fruit_to_lime 2.4.0 → 2.4.1

data/lib/fruit_to_lime/model/deal.rb

@@ -3,10 +3,9 @@ module FruitToLime
     class Deal
         include SerializeHelper, ModelHasCustomFields, ModelHasTags
 
-        attr_accessor :id, :integration_id, :name, :description, :probability, :value, :order_date,
-        :responsible_coworker, :customer_contact, :status
+        attr_accessor :id, :integration_id, :name, :description, :probability, :value, :order_date, :status
         # you add custom values by using {#set_custom_value}
-        attr_reader :custom_values, :customer
+        attr_reader :custom_values, :customer, :responsible_coworker, :customer_contact
 
         def serialize_variables
             [ :id, :integration_id, :name, :description, :probability, :value, :order_date ].map {
@@ -46,7 +45,19 @@ module FruitToLime
             error = String.new
 
             if @name.nil? || @name.empty?
-                error = "A name is required for deal.\n#{serialize()}"
+                error = "A name is required for deal.\n}"
+            end
+
+            if @customer.nil?
+                error = "#{error}\nA customer is required for deal."
+            end
+
+            if @responsible_coworker.nil?
+                error = "#{error}\nA responsible coworker is required for deal."
+            end
+
+            if error.length > 0
+                error = "#{error}\n#{serialize()}"
             end
 
             return error
@@ -60,5 +71,13 @@ module FruitToLime
         def customer=(customer)
             @customer = OrganizationReference.from_organization(customer)
         end
+
+        def responsible_coworker=(coworker)
+            @responsible_coworker = CoworkerReference.from_coworker(coworker)
+        end
+
+        def customer_contact=(person)
+            @customer_contact = PersonReference.from_person(person)
+        end
     end
 end

data/spec/coworker_spec.rb

@@ -33,36 +33,36 @@ describe "Coworker" do
             coworker.parse_name_to_firstname_lastname_se nil, 'a default'
 
             coworker.first_name.should eq 'a default'
-        end        
+        end
     end
 
-    describe "gues_email" do
-    	it "guesses kalle.nilsson@x.com for coworker with firstname 'Kalle', lastname 'Nilsson' and domain set to 'x.com" do
-    		coworker.first_name = 'Kalle'
-    		coworker.last_name = 'Nilsson'
+    describe "guess_email" do
+        it "guesses kalle.nilsson@x.com for coworker with firstname 'Kalle', lastname 'Nilsson' and domain set to 'x.com" do
+            coworker.first_name = 'Kalle'
+            coworker.last_name = 'Nilsson'
 
-    		guessed = coworker.guess_email 'x.com'
+            guessed = coworker.guess_email 'x.com'
 
-    		guessed.should eq 'kalle.nilsson@x.com'
-    	end
+            guessed.should eq 'kalle.nilsson@x.com'
+        end
 
-    	it "guesses '' when lastname is missing" do
-    		coworker.first_name = 'Kalle'
-    		coworker.last_name = ''
+        it "guesses '' when lastname is missing" do
+            coworker.first_name = 'Kalle'
+            coworker.last_name = ''
 
-    		guessed = coworker.guess_email 'x.com'
+            guessed = coworker.guess_email 'x.com'
 
-    		guessed.should eq ''
-    	end
+            guessed.should eq ''
+        end
 
-    	it "guesses '' when firstname is missing" do
-    		coworker.first_name = nil
-    		coworker.last_name = 'Nilsson'
+        it "guesses '' when firstname is missing" do
+            coworker.first_name = nil
+            coworker.last_name = 'Nilsson'
 
-    		guessed = coworker.guess_email 'x.com'
+            guessed = coworker.guess_email 'x.com'
 
-    		guessed.should eq ''
-    	end
+            guessed.should eq ''
+        end
 
         it "guesses åäöèé to be aaoee" do
             coworker.first_name = 'åäöèé'
@@ -80,7 +80,7 @@ describe "Coworker" do
             guessed = coworker.guess_email 'x.com'
 
             guessed.should eq 'sven-erik.nilsson@x.com'
-        end        
+        end
 
         it "guesses 'sven.nilsson-svensson@x.com' when lastnames has two names with ' ' between them" do
             coworker.first_name = 'Sven'
@@ -89,6 +89,6 @@ describe "Coworker" do
             guessed = coworker.guess_email 'x.com'
 
             guessed.should eq 'sven.nilsson-svensson@x.com'
-        end            
+        end
     end
 end

data/spec/deal_spec.rb

@@ -25,4 +25,37 @@ describe "Deal" do
         # then
         deal.customer.is_a?(FruitToLime::OrganizationReference).should eq true
     end
+
+    it "will auto convert coworker to coworker.ref during assignment" do
+        # given
+        coworker = FruitToLime::Coworker.new({:integration_id => "456", :first_name => "Billy", :last_name => "Bob"})
+
+        # when
+        deal.responsible_coworker = coworker
+
+        # then
+        deal.responsible_coworker.is_a?(FruitToLime::CoworkerReference).should eq true
+    end
+
+    it "will auto convert person to person.ref during assignment" do
+        # given
+        person = FruitToLime::Person.new({:integration_id => "123"})
+
+        # when
+        deal.customer_contact = person
+
+        # then
+        deal.customer_contact.is_a?(FruitToLime::PersonReference).should eq true
+    end
+
+    it "will fail on validation if name, responsible and customer is empty" do
+        # given, when
+        deal.name = "The big deal"
+        deal.customer = FruitToLime::Organization.new({:integration_id => "123", :name => "Lundalogik"})
+        deal.responsible_coworker =
+            FruitToLime::Coworker.new({ :integration_id => "456", :first_name => "Billy", :last_name => "Bob" })
+
+        # then
+        deal.validate.should eq ""
+    end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fruit_to_lime
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-15 00:00:00.000000000 Z
+date: 2014-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes