fruit_to_lime 2.3.1 → 2.3.2

data/spec/deal_spec.rb

@@ -2,17 +2,27 @@ require "spec_helper"
 require 'fruit_to_lime'
 
 describe "Deal" do
-	let(:deal){
-		FruitToLime::Deal.new
-	}
+    let(:deal){
+        FruitToLime::Deal.new
+    }
 
-	it "can attach a current status" do
-		deal.with_status do |status|
-			status.label = 'xyz'
-			status.id = '123'
-			status.date = DateTime.now
-			status.note = 'ho ho'
-		end
-	end
+    it "can attach a current status" do
+        deal.with_status do |status|
+            status.label = 'xyz'
+            status.id = '123'
+            status.date = DateTime.now
+            status.note = 'ho ho'
+        end
+    end
 
-end
+    it "will auto convert org to org.ref during assignment" do
+        # given
+        org = FruitToLime::Organization.new({:integration_id => "123", :name => "Lundalogik"})
+
+        # when
+        deal.customer = org
+
+        # then
+        deal.customer.is_a?(FruitToLime::OrganizationReference).should eq true
+    end
+end

data/spec/helpers/email_helper_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+require 'fruit_to_lime'
+
+describe FruitToLime::EmailHelper do
+    it "should validate a common email address" do
+        # given
+        import_email = "apl@lundalogik.se"
+
+        # when, then
+        FruitToLime::EmailHelper.is_valid?(import_email).should eq true
+    end
+
+    it "should validate an address with firstname.lastname" do
+        FruitToLime::EmailHelper.is_valid?("firstname.lastname@example.com").should eq true
+    end
+
+    it "should validate an address with lots of subdomains" do
+        FruitToLime::EmailHelper.is_valid?("firstname.lastname@sub1.sub2.example.com").should eq true
+    end
+
+    it "should validate an address with some special chars" do
+        FruitToLime::EmailHelper.is_valid?("firstname-lastname+=@sub1.sub2.example.com").should eq true
+    end
+
+    it "should validate an address with no top level domain" do
+        FruitToLime::EmailHelper.is_valid?("firstname@example").should eq true
+    end
+
+    it "should not validate an invalid address" do
+        FruitToLime::EmailHelper.is_valid?("hubbabubba").should eq false
+    end
+end

data/spec/helpers/phone_helper_spec.rb

@@ -0,0 +1,97 @@
+require 'spec_helper'
+require 'fruit_to_lime'
+
+describe FruitToLime::PhoneHelper do
+    before(:each) do
+        FruitToLime::PhoneHelper.set_country_code(:se)
+    end
+
+    it "should parse phonenumbers" do
+        # given, when
+        nice_number = FruitToLime::PhoneHelper.parse_numbers("0709-685226")
+
+        # then
+        nice_number.should eq "+46709685226"
+    end
+
+    it "should parse multiple numbers with default delimiter" do
+        # given
+        source = "046 - 270 48 00, 0709-685226"
+
+        # when
+        home, mobile = FruitToLime::PhoneHelper.parse_numbers(source)
+
+        # then
+        home.should eq "+46462704800"
+        mobile.should eq "+46709685226"
+    end
+
+    it "should parse multiple numbers with custom delimiter" do
+        # given
+        source = "046 - 270 48 00/ 0709-685226"
+
+        # when
+        home, mobile = FruitToLime::PhoneHelper.parse_numbers(source, '/')
+
+        # then
+        home.should eq "+46462704800"
+        mobile.should eq "+46709685226"
+    end
+
+    it "should parse numbers with different delimiters" do
+        # given
+        source1 = "046 - 270 48 00/ 0709-685226"
+        source2 = "08-562 776 00, 070-73 85 180"
+        source3 = "031-712 44 00\\\\ 0707 38 52 72/, 031 71 244 04"
+
+        # when
+        home1, mobile1 = FruitToLime::PhoneHelper.parse_numbers(source1, ['/', ',', "\\\\"])
+        home2, mobile2 = FruitToLime::PhoneHelper.parse_numbers(source2, ['/', ',', "\\\\"])
+        home3, mobile3, direct3 = FruitToLime::PhoneHelper.parse_numbers(source3, ['/', ',', "\\\\"])
+
+        # then
+        home1.should eq "+46462704800"
+        mobile1.should eq "+46709685226"
+
+        home2.should eq "+46856277600"
+        mobile2.should eq "+46707385180"
+
+        home3.should eq "+46317124400"
+        mobile3.should eq "+46707385272"
+        direct3.should eq "+46317124404"
+    end
+
+    it "should not mess with invalid numbers by default" do
+        # given
+        source = "im not a number"
+
+        # when
+        number = FruitToLime::PhoneHelper.parse_numbers(source)
+
+        # then
+        number.should eq "im not a number"
+    end
+
+    it "should not mess with invalid numbers unless strict mode" do
+        # given
+        source = "im not a number"
+
+        # when
+        number = FruitToLime::PhoneHelper.parse_numbers_strict(source)
+
+        # then
+        number.should eq ""
+    end
+
+    it "should parse foreign numbers" do
+        # given
+        source = "22 13 00 30"
+
+        # when
+        FruitToLime::PhoneHelper.set_country_code(:no)
+        number = FruitToLime::PhoneHelper.parse_numbers(source)
+
+        # then
+        number.should eq "+4722130030"
+    end
+end

data/spec/helpers/roo_helper_spec.rb

@@ -1,10 +1,10 @@
-require 'spec_helper'
-require 'fruit_to_lime'
-require 'roo'
-describe FruitToLime::RooHelper do
-	it "should handle sv chars" do
-		samplefile = File.join(File.dirname(__FILE__), '..', 'sample_data', 'excel.xlsx')
-		rows = FruitToLime::RooHelper.new(Roo::Excelx.new(samplefile)).rows
-		rows.should include({"Alpha"=>"L\u00E5s","Beta"=>"m\u00E4sk","\u00D6rjan"=>"l\u00E4sk","\u00C4skil"=>""})
-	end
-end
+require 'spec_helper'
+require 'fruit_to_lime'
+require 'roo'
+describe FruitToLime::RooHelper do
+	it "should handle sv chars" do
+		samplefile = File.join(File.dirname(__FILE__), '..', 'sample_data', 'excel.xlsx')
+		rows = FruitToLime::RooHelper.new(Roo::Excelx.new(samplefile)).rows
+		rows.should include({"Alpha"=>"L\u00E5s","Beta"=>"m\u00E4sk","\u00D6rjan"=>"l\u00E4sk","\u00C4skil"=>""})
+	end
+end

data/spec/note_spec.rb

@@ -0,0 +1,55 @@
+require "spec_helper"
+require 'fruit_to_lime'
+
+describe "Note" do
+    let("note") {
+        FruitToLime::Note.new
+    }
+
+    it "must have a text" do
+        note.validate.length > 0
+    end
+
+    it "is valid when it has text, created_by and organization" do
+        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        note.created_by = FruitToLime::CoworkerReference.new( { :integration_id => "123", :heading => "kalle anka" } )
+        note.organization = FruitToLime::OrganizationReference.new({ :integration_id => "456", :heading => "Lundalogik" })
+
+        note.validate.should eq ""
+    end
+
+    it "will auto convert org to org.ref during assignment" do
+        # given
+        org = FruitToLime::Organization.new({:integration_id => "123", :name => "Beagle Boys!"})
+
+        # when
+        note.organization = org
+
+        # then
+        note.organization.is_a?(FruitToLime::OrganizationReference).should eq true
+    end
+
+    it "will auto convert person to person.ref during assignment" do
+        # given
+        person = FruitToLime::Person.new({:integration_id => "123" })
+        person.parse_name_to_firstname_lastname_se "Billy Bob"
+
+        # when
+        note.person = person
+
+        # then
+        note.person.is_a?(FruitToLime::PersonReference).should eq true
+    end
+
+    it "will auto convert coworker to coworker.ref during assignment" do
+        # given
+        coworker = FruitToLime::Coworker.new({:integration_id => "123" })
+        coworker.parse_name_to_firstname_lastname_se "Billy Bob"
+
+        # when
+        note.created_by = coworker
+
+        # then
+        note.created_by.is_a?(FruitToLime::CoworkerReference).should eq true
+    end
+end

data/spec/organization_spec.rb

@@ -0,0 +1,57 @@
+require "spec_helper"
+require 'fruit_to_lime'
+
+describe "Organization" do
+    let(:organization) {
+        FruitToLime::Organization.new
+    }
+
+    it "must have a name" do
+        organization.name = "Lundalogik"
+
+        organization.validate.should eq ""
+    end
+
+    it "will fail on validation if no name is specified" do
+        organization.name = ""
+
+        organization.validate.length > 0
+    end
+end
+
+describe "OrganizationReference" do
+    it "can be created from an organization" do
+        # given
+        org = FruitToLime::Organization.new
+        org.name = "Lundalogik"
+        org.integration_id = "123"
+
+        # when
+        ref = FruitToLime::OrganizationReference.from_organization(org)
+
+        # then
+        ref.is_a?(FruitToLime::OrganizationReference).should eq true
+        ref.heading.should eq "Lundalogik"
+        ref.integration_id.should eq "123"
+    end
+
+    it "can be created from an organization_reference" do
+        # given
+        orgref = FruitToLime::OrganizationReference.new
+        orgref.heading = "Lundalogik"
+
+        # when
+        ref = FruitToLime::OrganizationReference.from_organization(orgref)
+
+        # then
+        ref.is_a?(FruitToLime::OrganizationReference).should eq true
+    end
+
+    it "is nil when created from nil" do
+        # given, when
+        ref = FruitToLime::OrganizationReference.from_organization(nil)
+
+        # then
+        ref.should eq nil
+    end
+end

data/spec/person_spec.rb

@@ -25,7 +25,7 @@ describe "Person" do
         value = person.custom_values[0]
         field = value.field
 
-        person.custom_values.length.should eq 1 
+        person.custom_values.length.should eq 1
         field.integration_id.should eq 'the key'
         value.value.should eq 'the value 2'
     end
@@ -39,7 +39,7 @@ describe "Person" do
         value = person.custom_values[0]
         field = value.field
 
-        person.custom_values.length.should eq 1 
+        person.custom_values.length.should eq 1
         field.id.should eq 'the id'
         value.value.should eq 'the value 2'
     end
@@ -51,16 +51,15 @@ describe "Person" do
         value = person.custom_values[0]
         field = value.field
 
-        person.custom_values.length.should eq 1 
+        person.custom_values.length.should eq 1
         field.integration_id.should eq 'the id'
         value.value.should eq 'the value 2'
     end
 
-
     it "will only set tag once" do
         person.set_tag('tag1')
         person.set_tag('tag1')
-        person.tags.length.should eq 1 
+        person.tags.length.should eq 1
         tag = person.tags[0]
         tag.value.should eq 'tag1'
     end
@@ -93,13 +92,23 @@ describe "Person" do
         error.should start_with("A firstname or lastname is required for person")
     end
 
+    it "should auto convert org to org.ref during assignment" do
+        # given
+        org = FruitToLime::Organization.new({:integration_id => "123", :name => "Lundalogik"})
+
+        # when
+        person.organization = org
+
+        # then
+        person.organization.is_a?(FruitToLime::OrganizationReference).should eq true
+    end
+
     describe "parse_name_to_firstname_lastname_se" do
         it "can parse 'Kalle Nilsson' into firstname 'Kalle' and lastname 'Nilsson'" do
             person.parse_name_to_firstname_lastname_se 'Kalle Nilsson'
 
             person.first_name.should eq 'Kalle'
             person.last_name.should eq 'Nilsson'
-
         end
 
         it "can parse 'Kalle Svensson Nilsson' into firstname 'Kalle' and lastname 'Svensson Nilsson'" do

data/spec/rootmodel_spec.rb

@@ -11,13 +11,12 @@ describe "RootModel" do
         rootmodel.coworkers.length.should eq 1
     end
 
-
     it "can add a coworker from a hash" do
         rootmodel.add_coworker({
-            :integration_id=>"123key",
-            :first_name=>"Kalle",
-            :last_name=>"Anka",
-            :email=>"kalle.anka@vonanka.com"
+            :integration_id => "123key",
+            :first_name => "Kalle",
+            :last_name => "Anka",
+            :email => "kalle.anka@vonanka.com"
         })
         rootmodel.find_coworker_by_integration_id("123key").first_name.should eq "Kalle"
         rootmodel.coworkers.length.should eq 2
@@ -54,6 +53,134 @@ describe "RootModel" do
         rootmodel.coworkers.length.should eq 2
     end
 
+    it "can add an organization from hash" do
+        rootmodel.add_organization({
+                                       :integration_id => "123key",
+                                       :name => "Beagle Boys"
+        })
+        rootmodel.find_organization_by_integration_id("123key").name.should eq "Beagle Boys"
+        rootmodel.organizations.length.should eq 1
+    end
+
+    it "can add an organization from a new organization" do
+        # given
+        organization = FruitToLime::Organization.new
+        organization.integration_id = "123key"
+        organization.name = "Beagle Boys"
+
+        # when
+        rootmodel.add_organization(organization)
+
+        # then
+        rootmodel.find_organization_by_integration_id("123key").name.should eq "Beagle Boys"
+        rootmodel.organizations.length.should eq 1
+    end
+
+    it "will not add a new organizations when the organizations is already added (same integration id)" do
+        # given
+        rootmodel.add_organization({
+            :integration_id => "123key",
+            :name => "Beagle Boys"
+        })
+        rootmodel.organizations.length.should eq 1
+        rootmodel.find_organization_by_integration_id("123key").name.should eq "Beagle Boys"
+
+        # when, then
+        expect {
+            rootmodel.add_organization({
+                :integration_id => "123key",
+                :name => "Beagle Boys 2"
+            })
+        }.to raise_error(FruitToLime::AlreadyAddedError)
+        rootmodel.find_organization_by_integration_id("123key").name.should eq "Beagle Boys"
+        rootmodel.organizations.length.should eq 1
+    end
+
+    it "can add a deal from hash" do
+        rootmodel.add_deal({
+                                       :integration_id => "123key",
+                                       :name => "Big deal"
+        })
+        rootmodel.find_deal_by_integration_id("123key").name.should eq "Big deal"
+        rootmodel.deals.length.should eq 1
+    end
+
+    it "can add a deal from a new deal" do
+        # given
+        deal = FruitToLime::Deal.new
+        deal.integration_id = "123key"
+        deal.name = "Big deal"
+
+        # when
+        rootmodel.add_deal(deal)
+
+        # then
+        rootmodel.find_deal_by_integration_id("123key").name.should eq "Big deal"
+        rootmodel.deals.length.should eq 1
+    end
+
+    it "will not add a new deal when the deal is already added (same integration id)" do
+        # given
+        rootmodel.add_deal({
+            :integration_id => "123key",
+            :name => "Big deal"
+        })
+        rootmodel.deals.length.should eq 1
+        rootmodel.find_deal_by_integration_id("123key").name.should eq "Big deal"
+
+        # when, then
+        expect {
+            rootmodel.add_deal({
+                :integration_id => "123key",
+                :name => "Bigger deal"
+            })
+        }.to raise_error(FruitToLime::AlreadyAddedError)
+        rootmodel.find_deal_by_integration_id("123key").name.should eq "Big deal"
+        rootmodel.deals.length.should eq 1
+    end
+
+    it "can add a note from hash" do
+        rootmodel.add_note({
+                               :integration_id => "123key",
+                               :text => "This is a note"
+        })
+        rootmodel.find_note_by_integration_id("123key").text.should eq "This is a note"
+        rootmodel.notes.length.should eq 1
+    end
+
+    it "can add a note from a new note" do
+        # given
+        note = FruitToLime::Note.new
+        note.integration_id = "123key"
+        note.text = "This is a note"
+
+        # when
+        rootmodel.add_note(note)
+
+        # then
+        rootmodel.find_note_by_integration_id("123key").text.should eq "This is a note"
+        rootmodel.notes.length.should eq 1
+    end
+
+    it "will not add a new organizations when the organizations is already added (same integration id)" do
+        # given
+        rootmodel.add_note({
+            :integration_id => "123key",
+            :text => "This is a note"
+        })
+        rootmodel.notes.length.should eq 1
+
+        # when, then
+        expect {
+            rootmodel.add_note({
+                :integration_id => "123key",
+                :text => "This is another note"
+            })
+        }.to raise_error(FruitToLime::AlreadyAddedError)
+        rootmodel.notes.length.should eq 1
+        rootmodel.find_note_by_integration_id("123key").text.should eq "This is a note"
+    end
+
     it "will ignore empty integration ids during sanity check" do
         org1 = FruitToLime::Organization.new
         org1.name = "company 1"
@@ -65,7 +192,7 @@ describe "RootModel" do
 
         rootmodel.sanity_check.should eq ""
     end
-    
+
     it "will report when the same integration id is used during sanity check" do
         org1 = FruitToLime::Organization.new
         org1.integration_id = "1"
@@ -99,6 +226,5 @@ describe "RootModel" do
         rootmodel.organizations.push org2
 
         rootmodel.sanity_check.should eq "Duplicate person integration_id: 1."
-
     end
 end

data/spec/spec_helper.rb

@@ -1,24 +1,24 @@
-# This file is copied to spec/ when you run 'rails generate rspec:install'
-#require File.expand_path("../../config/environment", __FILE__)
-require 'rspec/autorun'
-
-# Requires supporting ruby files with custom matchers and macros, etc,
-# in spec/support/ and its subdirectories.
-Dir[File.join(File.dirname(File.absolute_path(__FILE__)),"support/**/*.rb")].each { |f| require f }
-
-RSpec.configure do |config|
-  # ## Mock Framework
-  #
-  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
-  #
-  # config.mock_with :mocha
-  # config.mock_with :flexmock
-  # config.mock_with :rr
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = "random"
-end
-
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+#require File.expand_path("../../config/environment", __FILE__)
+require 'rspec/autorun'
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.join(File.dirname(File.absolute_path(__FILE__)),"support/**/*.rb")].each { |f| require f }
+
+RSpec.configure do |config|
+  # ## Mock Framework
+  #
+  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
+  #
+  # config.mock_with :mocha
+  # config.mock_with :flexmock
+  # config.mock_with :rr
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = "random"
+end
+

data/templates/csv/Gemfile

@@ -1,5 +1,5 @@
-source 'http://rubygems.org'
-
-gem 'thor'
-gem 'fruit_to_lime'
-gem 'rspec'
+source 'http://rubygems.org'
+
+gem 'thor'
+gem 'fruit_to_lime'
+gem 'rspec'

data/templates/csv/Rakefile.rb

@@ -1,7 +1,7 @@
-#!/usr/bin/env rake
-require 'rspec/core/rake_task'
-
-RSpec::Core::RakeTask.new(:spec)
-
-task :default => :spec
-task :test => :spec
+#!/usr/bin/env rake
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec
+task :test => :spec

data/templates/csv/convert.rb

@@ -1,3 +1,3 @@
-require "./lib/tomodel"
-
+require "./lib/tomodel"
+
 Cli.start(ARGV)

data/templates/csv/spec/spec_helper.rb

@@ -1,24 +1,24 @@
-# This file is copied to spec/ when you run 'rails generate rspec:install'
-#require File.expand_path("../../config/environment", __FILE__)
-#require 'rspec/rails'
-require 'rspec/autorun'
-
-# Requires supporting ruby files with custom matchers and macros, etc,
-# in spec/support/ and its subdirectories.
-#Dir[File.join(File.dirname(File.absolute_path(__FILE__)),"support/**/*.rb")].each { |f| require f }
-
-RSpec.configure do |config|
-  # ## Mock Framework
-  #
-  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
-  #
-  # config.mock_with :mocha
-  # config.mock_with :flexmock
-  # config.mock_with :rr
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = "random"
-end
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+#require File.expand_path("../../config/environment", __FILE__)
+#require 'rspec/rails'
+require 'rspec/autorun'
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+#Dir[File.join(File.dirname(File.absolute_path(__FILE__)),"support/**/*.rb")].each { |f| require f }
+
+RSpec.configure do |config|
+  # ## Mock Framework
+  #
+  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
+  #
+  # config.mock_with :mocha
+  # config.mock_with :flexmock
+  # config.mock_with :rr
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = "random"
+end

data/templates/excel/Gemfile

@@ -1,6 +1,6 @@
-source 'http://rubygems.org'
-
-gem 'rspec'
-gem 'roo'
-gem 'thor'
-gem 'fruit_to_lime'
+source 'http://rubygems.org'
+
+gem 'rspec'
+gem 'roo'
+gem 'thor'
+gem 'fruit_to_lime'