fruit_to_lime 2.3.0 → 2.3.1

data/lib/fruit_to_lime/model/class_settings.rb

@@ -43,28 +43,5 @@ module FruitToLime
             return field
         end
 
-        # Add custom field. If there is already an existing custom field, then an AlreadyAddedError will be raised.
-        def add_custom_field(obj)
-            @custom_fields = [] if @custom_fields==nil
-
-            if obj.is_a?(CustomField)
-                field = obj
-            else
-                field = CustomField.new(obj)
-            end
-
-            index = @custom_fields.find_index do |custom_field| 
-                custom_field.same_as?(field)
-            end
-
-            if index
-                raise AlreadyAddedError, "Already added a custom same as #{obj}"
-            end
-
-            @custom_fields.push field
-
-            return field
-        end
-
     end
 end

data/lib/fruit_to_lime/model_helpers.rb

@@ -1,10 +1,19 @@
 module FruitToLime
     module ModelHasCustomFields
         # @example
-        #     obj.set_custom_value(row['business_value_partner_info'], "partner_info")
-        def set_custom_value(value, field)
+        #     value = row['business_value_partner_info']
+        #     obj.set_custom_value("partner_info", value)
+        def set_custom_value(integration_id, value)
+            return set_custom_field({integration_id: integration_id, value: value})
+        end
+        # @example
+        #     value = row['business_value_partner_info']
+        #     obj.set_custom_field({:integration_id=>"partner_info", :value=>value})
+        def set_custom_field(obj)
             @custom_values = [] if @custom_values == nil
-            custom_value = CustomValue.new()
+            value = obj[:value]
+            field = CustomFieldReference.new(obj)
+            custom_value = CustomValue.new
             custom_value.value = value
             custom_value.field = field
             index = @custom_values.find_index do |custom_value|
@@ -17,12 +26,6 @@ module FruitToLime
             @custom_values.push custom_value
             return custom_value
         end
-        # Note that this method is obsolete and will be removed later on. Please use {#set_custom_value}
-        def set_custom_field(obj)
-            value = obj[:value]
-            ref = CustomFieldReference.new(obj)
-            return set_custom_value(value, ref)
-        end
     end
 
     module ModelWithIntegrationIdSameAs

data/spec/class_settings_spec.rb

@@ -13,14 +13,5 @@ describe "ClassSettings" do
         class_settings.custom_fields[0].title.should eq "Link to BI system 2" 
     end
 
-    it "can add custom field and if there is already an existing custom field, then an AlreadyAddedError will be raised (and nothing is added)." do
-        class_settings.add_custom_field({:integration_id=>"link_to_bi_system", :title=>"Link to BI system"})
-        expect { 
-            class_settings.add_custom_field({:integration_id=>"link_to_bi_system", :title=>"Link to BI system 2"})
-        }.to raise_error(FruitToLime::AlreadyAddedError)
-        class_settings.custom_fields.length.should eq 1
-        class_settings.custom_fields[0].title.should eq "Link to BI system" 
-    end
-
 end
 

data/spec/person_spec.rb

@@ -44,6 +44,19 @@ describe "Person" do
         value.value.should eq 'the value 2'
     end
 
+    it "will set custom field (using set_custom_value) with same integration_id to the last value" do
+        person.set_custom_value('the id','the value')
+
+        person.set_custom_value('the id','the value 2')
+        value = person.custom_values[0]
+        field = value.field
+
+        person.custom_values.length.should eq 1 
+        field.integration_id.should eq 'the id'
+        value.value.should eq 'the value 2'
+    end
+
+
     it "will only set tag once" do
         person.set_tag('tag1')
         person.set_tag('tag1')

data/templates/csv/lib/tomodel.rb

@@ -52,7 +52,7 @@ class Exporter
         # client will continue to use it can be useful to be
         # able to link from Go to the same record in the ERP
         # FOr instance Lime links
-        organization.set_custom_value("http://something.com?key=#{row['id']}", "external_url")
+        organization.set_custom_value("external_url", "http://something.com?key=#{row['id']}")
 
         return organization
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fruit_to_lime
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-06 00:00:00.000000000 Z
+date: 2014-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes
@@ -158,7 +158,6 @@ files:
 - lib/fruit_to_lime.rb
 - bin/fruit_to_lime
 - templates/csv/convert.rb
-- templates/csv/export.xml
 - templates/csv/Gemfile
 - templates/csv/lib/tomodel.rb
 - templates/csv/Rakefile.rb

data/templates/csv/export.xml

@@ -1,152 +0,0 @@
-<GoImport Version='v2_0'
-><Settings
-  ><Organization
-    ><CustomFields
-      ><CustomField
-        ><Title
-          >Link to external system</Title
-          ><Type
-          >Link</Type
-          ></CustomField
-        ></CustomFields
-      ></Organization
-    ></Settings
-  ><Coworkers
-  ><Coworker
-    ><IntegrationId
-      >import</IntegrationId
-      ><FirstName
-      >Import</FirstName
-      ></Coworker
-    ><Coworker
-    ><IntegrationId
-      >666</IntegrationId
-      ><FirstName
-      >Evil</FirstName
-      ><LastName
-      >Elvis</LastName
-      ><Email
-      >t@e.com</Email
-      ><DirectPhoneNumber
-      >+46121212</DirectPhoneNumber
-      ><MobilePhoneNumber
-      >+46324234</MobilePhoneNumber
-      ><HomePhoneNumber
-      >+46234234</HomePhoneNumber
-      ></Coworker
-    ></Coworkers
-  ><Organizations
-  ><Organization
-    ><IntegrationId
-      >6</IntegrationId
-      ><Name
-      >Alfs Mjukvaruutveckling</Name
-      ><OrganizationNumber
-      >a number</OrganizationNumber
-      ><PostalAddress
-      ><Street
-        >postal street</Street
-        ><ZipCode
-        >226 48</ZipCode
-        ><City
-        >LUND</City
-        ></PostalAddress
-      ><VisitAddress
-      ><Street
-        >visit street</Street
-        ><ZipCode
-        >visit zip</ZipCode
-        ><City
-        >visit city</City
-        ></VisitAddress
-      ><CentralPhoneNumber
-      >0000</CentralPhoneNumber
-      ><Email
-      >email to organizaiton, not the person</Email
-      ><WebSite
-      >www.whatever.com</WebSite
-      ><Employees
-      ><Person
-        ><IntegrationId
-          >123</IntegrationId
-          ><FirstName
-          >Rune</FirstName
-          ><LastName
-          >Rebellion</LastName
-          ><DirectPhoneNumber
-          >+4611111</DirectPhoneNumber
-          ><FaxPhoneNumber
-          >+4623234234234</FaxPhoneNumber
-          ><MobilePhoneNumber
-          >+462321212</MobilePhoneNumber
-          ><Email
-          >x@y.com</Email
-          ><AlternativeEmail
-          >y@x.com</AlternativeEmail
-          ><PostalAddress
-          ><Street
-            >postal street</Street
-            ><ZipCode
-            >226 48</ZipCode
-            ><City
-            >LUND</City
-            ></PostalAddress
-          ><CurrentlyEmployed
-          >true</CurrentlyEmployed
-          ></Person
-        ></Employees
-      ><CustomValues
-      ><CustomValue
-        ><Field
-          >external_url</Field
-          ><Value
-          >http://something.com?key=6</Value
-          ></CustomValue
-        ></CustomValues
-      ><Tags
-      ><Tag
-        >Imported</Tag
-        ></Tags
-      ><ResponsibleCoworker
-      ><Heading
-        >Evil Elvis</Heading
-        ><IntegrationId
-        >666</IntegrationId
-        ></ResponsibleCoworker
-      ></Organization
-    ></Organizations
-  ><Deals
-  ><Deal
-    ><IntegrationId
-      >333</IntegrationId
-      ><Name
-      >Feta affären</Name
-      ><Probability
-      >50</Probability
-      ><Value
-      >10000</Value
-      ><OfferDate
-      >2013-12-01</OfferDate
-      ><OrderDate
-      >2014-01-05</OrderDate
-      ><Customer
-      ><IntegrationId
-        >6</IntegrationId
-        ><Heading
-        >Alfs Mjukvaruutveckling</Heading
-        ></Customer
-      ><ResponsibleCoworker
-      ><Heading
-        >Evil Elvis</Heading
-        ><IntegrationId
-        >666</IntegrationId
-        ></ResponsibleCoworker
-      ><CustomerContact
-      ><IntegrationId
-        >123</IntegrationId
-        ></CustomerContact
-      ></Deal
-    ></Deals
-  ><Notes
-  /></GoImport
->