frozen_record 0.19.4 → 0.21.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2fe4a43299f20ff72c35ee4093ef5f6c8d49214aabc82cf67108da083980b28e
-  data.tar.gz: 7023b4b75d3eb733ef534ae85f1b25e0efb7aac3ba8548dd9e1a25bdbe1ec804
+  metadata.gz: 0a25a269067396d2e6054a57c514b1251e39dca90928e7bdd837bfbb9ef8d2cf
+  data.tar.gz: 77b55ee24e39590dd213c157b22e3707c8f551a051df34f516a1e9d061d4eb6a
 SHA512:
-  metadata.gz: 4031cf6cd49bec9dc97c246a0999736ed178d9f6b1e623ef6e60070da454e1141fb7ca25056d2d55f2f808d2812f0f1c14e856cecaf73b0dd403a2a047debf62
-  data.tar.gz: 823f999ec6e21c55b4b0cad6b39008c55377052d194a29af96edb0e85cc9a33227635246a9187fdc7207eac9ec515c352f54ac8c568a7ec7bd3589ef74dea0dd
+  metadata.gz: a1d23916d54278598ec3ba29e5c1000f4adb0f13566db9be7900e5344199e36fe02254539a531a26d8b2d211e62f3916438c98032e7166795fbbf1681a170b91
+  data.tar.gz: af66cb72d621f8d6008de238d7f0846bf576200437fbdead4cfcdd1d598af62ac4d29bd801efd14420bfddb4470301312eb992628e2c7185e21b8dbee0381f6e

data/.github/workflows/main.yml

@@ -0,0 +1,32 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.6', '2.7', '3.0' ]
+        minimal: [ false, true ]
+    name: Ruby ${{ matrix.ruby }} tests, minimal=${{ matrix.minimal }}
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - uses: actions/cache@v2
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-${{ matrix.ruby }}-gems-${{ hashFiles('Gemfile', 'frozen_record.gemspec') }}
+          restore-keys: |
+            ${{ runner.os }}-${{ matrix.ruby }}-gems-
+      - name: Bundle install
+        run: |
+          gem install bundler
+          bundle install --jobs 4 --retry 3 --path=vendor/bundle
+      - name: Run tests
+        env:
+          MINIMAL: ${{ matrix.minimal }}
+        run: bundle exec rake

data/frozen_record.gemspec

@@ -20,7 +20,8 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.5'
 
   spec.add_runtime_dependency 'activemodel'
-  spec.add_development_dependency 'bundler'
+  spec.add_runtime_dependency 'dedup'
+
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'pry'

data/lib/frozen_record.rb

@@ -1,29 +1,5 @@
 # frozen_string_literal: true
 
-require 'yaml'
-require 'set'
-require 'active_support/all'
-require 'active_model'
-
-require 'frozen_record/version'
-require 'frozen_record/scope'
-require 'frozen_record/index'
-require 'frozen_record/base'
-require 'frozen_record/compact'
-require 'frozen_record/deduplication'
-
-module FrozenRecord
-  RecordNotFound = Class.new(StandardError)
-
-  class << self
-    attr_accessor :deprecated_yaml_erb_backend
-
-    def eager_load!
-      Base.descendants.each(&:eager_load!)
-    end
-  end
-
-  self.deprecated_yaml_erb_backend = true
-end
-
+require 'frozen_record/minimal'
+require 'frozen_record/serialization'
 require 'frozen_record/railtie' if defined?(Rails)

data/lib/frozen_record/backends/empty.json

@@ -0,0 +1 @@
+true

data/lib/frozen_record/backends/json.rb

@@ -9,9 +9,26 @@ module FrozenRecord
         "#{model_name.underscore.pluralize}.json"
       end
 
-      def load(file_path)
-        json_data = File.read(file_path)
-        JSON.parse(json_data) || []
+      if JSON.respond_to?(:load_file)
+        supports_freeze = begin
+          JSON.load_file(File.expand_path('../empty.json', __FILE__), freeze: true)
+        rescue ArgumentError
+          false
+        end
+
+        if supports_freeze
+          def load(file_path)
+            JSON.load_file(file_path, freeze: true) || Dedup::EMPTY_ARRAY
+          end
+        else
+          def load(file_path)
+            Dedup.deep_intern!(JSON.load_file(file_path) || Dedup::EMPTY_ARRAY)
+          end
+        end
+      else
+        def load(file_path)
+          Dedup.deep_intern!(JSON.parse(File.read(file_path)) || Dedup::EMPTY_ARRAY)
+        end
       end
     end
   end

data/lib/frozen_record/backends/yaml.rb

@@ -34,15 +34,41 @@ module FrozenRecord
             end
           end
 
-          YAML.load(yml_data) || []
+          load_string(yml_data)
         else
           if file_path.end_with?('.erb')
-            YAML.load(ERB.new(File.read(file_path)).result) || []
+            load_string(ERB.new(File.read(file_path)).result)
           else
-            YAML.load_file(file_path) || []
+            load_file(file_path)
           end
         end
       end
+
+      private
+
+      supports_freeze = begin
+        YAML.load_file(File.expand_path('../empty.json', __FILE__), freeze: true)
+      rescue ArgumentError
+        false
+      end
+
+      if supports_freeze
+        def load_file(path)
+          YAML.load_file(path, freeze: true) || Dedup::EMPTY_ARRAY
+        end
+
+        def load_string(yaml)
+          YAML.load(yaml, freeze: true) || Dedup::EMPTY_ARRAY
+        end
+      else
+        def load_file(path)
+          Dedup.deep_intern!(YAML.load_file(path) || Dedup::EMPTY_ARRAY)
+        end
+
+        def load_string(yaml)
+          Dedup.deep_intern!(YAML.load(yaml) || Dedup::EMPTY_ARRAY)
+        end
+      end
     end
   end
 end

data/lib/frozen_record/base.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-require 'set'
 require 'active_support/descendants_tracker'
 require 'frozen_record/backends'
-require 'objspace'
 
 module FrozenRecord
   class Base
@@ -11,11 +9,6 @@ module FrozenRecord
     extend ActiveModel::Naming
     include ActiveModel::Conversion
     include ActiveModel::AttributeMethods
-    include ActiveModel::Serializers::JSON
-
-    if defined? ActiveModel::Serializers::Xml
-      include ActiveModel::Serializers::Xml
-    end
 
     FIND_BY_PATTERN = /\Afind_by_(\w+)(!?)/
     FALSY_VALUES = [false, nil, 0, -''].to_set
@@ -52,7 +45,7 @@ module FrozenRecord
       alias_method :set_default_attributes, :default_attributes=
       private :set_default_attributes
       def default_attributes=(default_attributes)
-        set_default_attributes(Deduplication.deep_deduplicate!(default_attributes.stringify_keys))
+        set_default_attributes(Dedup.deep_intern!(default_attributes.transform_keys(&:to_s)))
       end
 
       alias_method :set_primary_key, :primary_key=
@@ -146,8 +139,9 @@ module FrozenRecord
 
         @records ||= begin
           records = backend.load(file_path)
-          records.each { |r| assign_defaults!(r) }
-          records = Deduplication.deep_deduplicate!(records)
+          if default_attributes
+            records = records.map { |r| assign_defaults!(r.dup).freeze }.freeze
+          end
           @attributes = list_attributes(records).freeze
           define_attribute_methods(@attributes.to_a)
           records = records.map { |r| load(r) }.freeze
@@ -164,7 +158,7 @@ module FrozenRecord
       private :load
 
       def new(attrs = {})
-        load(assign_defaults!(attrs.stringify_keys))
+        load(assign_defaults!(attrs.transform_keys(&:to_s)))
       end
 
       private
@@ -245,7 +239,7 @@ module FrozenRecord
     private
 
     def attribute?(attribute_name)
-      FALSY_VALUES.exclude?(self[attribute_name]) && self[attribute_name].present?
+      !FALSY_VALUES.include?(self[attribute_name]) && self[attribute_name].present?
     end
 
     def attribute_method?(attribute_name)

data/lib/frozen_record/compact.rb

@@ -13,8 +13,9 @@ module FrozenRecord
 
         @records ||= begin
           records = backend.load(file_path)
-          records.each { |r| assign_defaults!(r) }
-          records = Deduplication.deep_deduplicate!(records)
+          if default_attributes
+            records = records.map { |r| assign_defaults!(r.dup).freeze }.freeze
+          end
           @attributes = list_attributes(records).freeze
           build_attributes_cache
           define_attribute_methods(@attributes.to_a)
@@ -67,13 +68,13 @@ module FrozenRecord
 
     def attributes=(attributes)
       self.class.attributes.each do |attr|
-        instance_variable_set(self.class._attributes_cache[attr], Deduplication.deep_deduplicate!(attributes[attr]))
+        instance_variable_set(self.class._attributes_cache[attr], Dedup.deep_intern!(attributes[attr]))
       end
     end
 
     def attribute?(attribute_name)
       val = self[attribute_name]
-      Base::FALSY_VALUES.exclude?(val) && val.present?
+      !Base::FALSY_VALUES.include?(val) && val.present?
     end
   end
 end

data/lib/frozen_record/minimal.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'yaml'
+require 'set'
+require 'active_model'
+
+require 'dedup'
+
+require 'frozen_record/version'
+require 'frozen_record/scope'
+require 'frozen_record/index'
+require 'frozen_record/base'
+require 'frozen_record/compact'
+
+module FrozenRecord
+  RecordNotFound = Class.new(StandardError)
+
+  class << self
+    attr_accessor :deprecated_yaml_erb_backend
+
+    def eager_load!
+      Base.descendants.each(&:eager_load!)
+    end
+  end
+
+  self.deprecated_yaml_erb_backend = true
+end

data/lib/frozen_record/scope.rb

@@ -2,7 +2,7 @@
 
 module FrozenRecord
   class Scope
-    BLACKLISTED_ARRAY_METHODS = [
+    DISALLOWED_ARRAY_METHODS = [
       :compact!, :flatten!, :reject!, :reverse!, :rotate!, :map!,
       :shuffle!, :slice!, :sort!, :sort_by!, :delete_if,
       :keep_if, :pop, :shift, :delete_at, :compact
@@ -227,13 +227,14 @@ module FrozenRecord
         super
       end
     end
+    ruby2_keywords :method_missing if respond_to?(:ruby2_keywords, true)
 
     def delegate_to_class(*args, &block)
       scoping { @klass.public_send(*args, &block) }
     end
 
     def array_delegable?(method)
-      Array.method_defined?(method) && BLACKLISTED_ARRAY_METHODS.exclude?(method)
+      Array.method_defined?(method) && !DISALLOWED_ARRAY_METHODS.include?(method)
     end
 
     def where!(criterias)

data/lib/frozen_record/serialization.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'frozen_record/base'
+
+module FrozenRecord
+  class Base
+    include ActiveModel::Serializers::JSON
+
+    if defined? ActiveModel::Serializers::Xml
+      include ActiveModel::Serializers::Xml
+    end
+  end
+end

data/lib/frozen_record/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FrozenRecord
-  VERSION = '0.19.4'
+  VERSION = '0.21.1'
 end

data/spec/scope_spec.rb

@@ -193,6 +193,11 @@ describe 'querying' do
       expect(countries.length).to be == 0
     end
 
+    it 'is chainable with methods of the form `def method(*args, **kargs)' do
+      countries = Country.republics.continent_and_capital('Europe', capital: 'Paris')
+      expect(countries.length).to be == 1
+    end
+
     it 'can be used with arrays' do
       countries = Country.where(id: [1,2])
       expect(countries.length).to be == 2
@@ -410,7 +415,7 @@ describe 'querying' do
 
   end
 
-  describe '.as_json' do
+  describe '.as_json', exclude_minimal: true do
 
     it 'serialize the results' do
       json = Country.all.as_json

data/spec/spec_helper.rb

@@ -1,6 +1,8 @@
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
+minimal = ENV['MINIMAL'] == 'true'
+
 require 'pry'
 require 'simplecov'
 require 'coveralls'
@@ -10,7 +12,14 @@ SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
 ]
 SimpleCov.start
 
-require 'frozen_record'
+require 'objspace'
+
+if minimal
+  require 'frozen_record/minimal'
+else
+  require 'frozen_record'
+end
+
 require 'frozen_record/test_helper'
 
 FrozenRecord::Base.base_path = File.join(File.dirname(__FILE__), 'fixtures')
@@ -22,6 +31,7 @@ FrozenRecord.eager_load!
 RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
+  config.filter_run_excluding :exclude_minimal if minimal
 
   config.order = 'random'
 

data/spec/support/country.rb

@@ -12,6 +12,10 @@ class Country < FrozenRecord::Base
     where(nato: true)
   end
 
+  def self.continent_and_capital(continent, capital:)
+    where(continent: continent, capital: capital)
+  end
+
   def reverse_name
     name.reverse
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: frozen_record
 version: !ruby/object:Gem::Version
-  version: 0.19.4
+  version: 0.21.1
 platform: ruby
 authors:
 - Jean Boussier
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-18 00:00:00.000000000 Z
+date: 2021-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -25,13 +25,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: dedup
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -101,9 +101,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -114,17 +114,18 @@ files:
 - frozen_record.gemspec
 - lib/frozen_record.rb
 - lib/frozen_record/backends.rb
+- lib/frozen_record/backends/empty.json
 - lib/frozen_record/backends/json.rb
 - lib/frozen_record/backends/yaml.rb
 - lib/frozen_record/base.rb
 - lib/frozen_record/compact.rb
-- lib/frozen_record/deduplication.rb
 - lib/frozen_record/index.rb
+- lib/frozen_record/minimal.rb
 - lib/frozen_record/railtie.rb
 - lib/frozen_record/scope.rb
+- lib/frozen_record/serialization.rb
 - lib/frozen_record/test_helper.rb
 - lib/frozen_record/version.rb
-- spec/deduplication_spec.rb
 - spec/fixtures/animals.json
 - spec/fixtures/cars.yml
 - spec/fixtures/countries.yml.erb
@@ -156,12 +157,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: ActiveRecord like interface to read only access and query static YAML files
 test_files:
-- spec/deduplication_spec.rb
 - spec/fixtures/animals.json
 - spec/fixtures/cars.yml
 - spec/fixtures/countries.yml.erb

data/.travis.yml

@@ -1,5 +0,0 @@
-sudo: false
-rvm:
-  - '2.5'
-  - '2.6'
-  - '2.7'

data/lib/frozen_record/deduplication.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-require 'active_support/core_ext/object/duplicable'
-
-module FrozenRecord
-  module Deduplication
-    extend self
-
-    # We deduplicate data in place because it is assumed it directly
-    # comes from the parser, and won't be held by anyone.
-    #
-    # Frozen Hashes and Arrays are ignored because they are likely
-    # the result of the use of YAML anchor. Meaning we already deduplicated
-    # them.
-    if RUBY_VERSION >= '2.7'
-      def deep_deduplicate!(data)
-        case data
-        when Hash
-          return data if data.frozen?
-          data.transform_keys! { |k| deep_deduplicate!(k) }
-          data.transform_values! { |v| deep_deduplicate!(v) }
-          data.freeze
-        when Array
-          return data if data.frozen?
-          data.map! { |d| deep_deduplicate!(d) }.freeze
-        when String
-          -data
-        else
-          data.duplicable? ? data.freeze : data
-        end
-      end
-    else
-      def deep_deduplicate!(data)
-        case data
-        when Hash
-          return data if data.frozen?
-          data.transform_keys! { |k| deep_deduplicate!(k) }
-          data.transform_values! { |v| deep_deduplicate!(v) }
-          data.freeze
-        when Array
-          return data if data.frozen?
-          data.map! { |d| deep_deduplicate!(d) }.freeze
-        when String
-          # String#-@ doesn't deduplicate the string if it's tainted.
-          # So in such case we need to untaint it first.
-          if data.tainted?
-            -(+data).untaint
-          else
-            -data
-          end
-        else
-          data.duplicable? ? data.freeze : data
-        end
-      end
-    end
-  end
-end

data/spec/deduplication_spec.rb

@@ -1,31 +0,0 @@
-require 'spec_helper'
-
-describe 'deduplication' do
-
-  it 'deduplicate string values' do
-    pending("Strings can't be deduplicated before Ruby 2.5") if RUBY_VERSION < '2.5'
-
-    records = [
-      { 'name' => 'George'.dup },
-    ]
-
-    expect(records[0]['name']).to_not equal 'George'.freeze
-    FrozenRecord::Deduplication.deep_deduplicate!(records)
-    expect(records[0]['name']).to equal 'George'.freeze
-  end
-
-  it 'handles duplicated references' do
-    # This simulates the YAML anchor behavior
-    tags = { 'foo' => 'bar' }
-    records = [
-      { 'name' => 'George', 'tags' => tags },
-      { 'name' => 'Peter', 'tags' => tags },
-    ]
-
-    expect(records[0]['tags']).to_not be_frozen
-    FrozenRecord::Deduplication.deep_deduplicate!(records)
-    expect(records[0]['tags']).to be_frozen
-    expect(records[0]['tags']).to equal records[1]['tags']
-  end
-
-end