front_end_builds 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73289473dbe8e87ac2027aa1bcac232568fe0e68
-  data.tar.gz: 8093059b4f3617b49ab28e7330060501076a47f1
+  metadata.gz: 6fd868520d0d5a610455acb3c99d0840899fc90d
+  data.tar.gz: 7440bdcf50f76bb1ea2b5d7fff954c6851cbbaf9
 SHA512:
-  metadata.gz: d75e87d5cb946ed4d5a86697d1ed983798c78748d3aaaa2f6275a7e612a54401d3da10a59f694d2857dd1b5560c1aba35702a29a762091b3234ce1bc1366da6d
-  data.tar.gz: e41ff6b3243e41ed75132b5a60de0f9208a5e3c01e6fe20fca113f9043b06f3dea1f617dc740e6e8bcb5faf3261da9d1063a1d9dda316e0a237d29001c743e07
+  metadata.gz: 61396b3ac76d1a6fcce0b06a07b92ffc1abe25bca323c8bd4332cd99dd6d27894e3887ffee7abd7dfcce960c767ffe02b8ffac508be8a5914c60f4b913ba4082
+  data.tar.gz: 812c52f64e604aecaef6d1db4b89b891f69fa9a93a6a43ac08f1e84eab17947cf8b31ec7c80bdc61ed5226ac53c46f2ad68d3551b4dd358b317e0feadc866114

data/app/controllers/front_end_builds/builds_controller.rb

@@ -2,6 +2,7 @@ require_dependency "front_end_builds/application_controller"
 
 module FrontEndBuilds
   class BuildsController < ApplicationController
+    before_filter :set_app!, only: :create
 
     def index
       front_end = FrontEndBuilds::Build.find_best(build_search_params)
@@ -14,23 +15,33 @@ module FrontEndBuilds
     end
 
     def create
-      app = find_app
+      build = @app.builds.new(build_create_params)
 
-      if app
-        build = app.builds.create(build_create_params)
-      end
-
-      if app && build
+      if build.save
         build.fetch!
         build.activate!
         head :ok
+
       else
-        head :unprocessable_entity
+        render(
+          text: 'Could not create the build: ' + build.errors.full_messages.to_s,
+          status: :unprocessable_entity
+        )
       end
     end
 
     private
 
+    def set_app!
+      @app = find_app
+      if @app.nil?
+        render(
+          text: 'That app name/API combination was not found.',
+          status: :unprocessable_entity
+        )
+      end
+    end
+
     def csrf_tag
       [
         "<meta name='csrf-param' content='#{request_forgery_protection_token}' />",
@@ -46,7 +57,8 @@ module FrontEndBuilds
       params.permit(
         :branch,
         :sha,
-        :job
+        :job,
+        :endpoint
       )
     end
 

data/app/models/front_end_builds/build.rb

@@ -7,8 +7,8 @@ module FrontEndBuilds
 
     validates :app, presence: true
     validates :sha, presence: true
-    validates :job, presence: true
     validates :branch, presence: true
+    validates :endpoint, presence: true
 
     def self.find_best(params = {})
       scope = self
@@ -54,8 +54,6 @@ module FrontEndBuilds
     def fetch!
       return if fetched?
 
-      # Store endpoint in app
-      endpoint = "http://ted.conferences.#{app.name}.s3-website-us-east-1.amazonaws.com/dist-#{job}-#{sha}/index.html"
       html = Net::HTTP.get(URI.parse(endpoint))
 
       update_attributes(

data/db/migrate/20141105222855_add_endpoint_to_front_end_builds_build.rb

@@ -0,0 +1,5 @@
+class AddEndpointToFrontEndBuildsBuild < ActiveRecord::Migration
+  def change
+    add_column :front_end_builds_builds, :endpoint, :string, limit: 2038
+  end
+end

data/lib/front_end_builds/ext/routes.rb

@@ -26,7 +26,7 @@ module ActionDispatch::Routing
         get(
           "/#{path}/(*path)" => "front_end_builds/builds#index",
           defaults: {
-            branch: :master,
+            branch: 'master',
             app_name: name
           }.merge(options)
         )

data/lib/front_end_builds/version.rb

@@ -1,3 +1,3 @@
 module FrontEndBuilds
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: front_end_builds
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Ryan Toronto
@@ -142,6 +142,7 @@ files:
 - config/routes.rb
 - db/migrate/20141010162405_create_front_end_builds_builds.rb
 - db/migrate/20141010165726_create_front_end_builds_apps.rb
+- db/migrate/20141105222855_add_endpoint_to_front_end_builds_build.rb
 - lib/front_end_builds.rb
 - lib/front_end_builds/engine.rb
 - lib/front_end_builds/ext/routes.rb