fron 0.1.4 → 0.2.0rc1

data/spec/dom/modules/classlist_spec.rb

@@ -1,72 +1,71 @@
-require 'fron/dom'
+require 'spec_helper'
 
 describe DOM::ClassList do
-
   let(:element) { DOM::Element.new 'div' }
   subject { element['class'] }
 
-  describe '#addClass' do
+  describe '#add_class' do
     it 'should add a class' do
-      element.addClass 'test'
+      element.add_class 'test'
       subject.should eq 'test'
     end
 
     it 'should add multiple classes' do
-      element.addClass 'test', 'help'
+      element.add_class 'test', 'help'
       subject.should eq 'test help'
     end
   end
 
-  describe '#removeClass' do
+  describe '#remove_class' do
     before do
       element['class'] = 'test help'
     end
 
     it 'should add a class' do
-      element.removeClass 'test'
+      element.remove_class 'test'
       subject.should eq 'help'
     end
 
     it 'should add multiple classes' do
-      element.removeClass 'test', 'help'
-      subject.should eq ''
+      element.remove_class 'test', 'help'
+      subject.should eq nil
     end
   end
 
-  describe '#hasClass' do
+  describe '#has_class' do
     it 'should return true if the element has given class' do
       element['class'] = 'test'
-      element.hasClass('test').should eq true
+      element.has_class('test').should eq true
     end
 
     it 'should return flase if the element does not have the given class' do
-      element.hasClass('test').should eq false
+      element.has_class('test').should eq false
     end
   end
 
-  describe '#toggleClass' do
+  describe '#toggle_class' do
     before do
       element['class'] = 'test'
     end
 
     it 'should remove class if the element has the given class' do
-      element.toggleClass 'test'
-      subject.should eq ''
+      element.toggle_class 'test'
+      subject.should eq nil
     end
 
     it 'should add class if the element does not have the given class' do
-      element.toggleClass 'help'
+      element.toggle_class 'help'
       subject.should eq 'test help'
     end
 
     it 'should add class if the second argument is true' do
-      element.toggleClass 'help', true
+      element.toggle_class 'help', true
       subject.should eq 'test help'
     end
 
     it 'should remove class if the second argument if false' do
-      element.toggleClass 'test', false
-      subject.should eq ''
+      element.toggle_class 'test', false
+      subject.should eq nil
     end
   end
 end

data/spec/dom/modules/dimensions_spec.rb

@@ -1,55 +1,120 @@
-require 'fron/dom'
+require 'spec_helper'
 
 describe DOM::Dimensions do
-
-  let(:element) { DOM::Element.new 'div' }
+  subject { DOM::Element.new 'div' }
 
   before do
-    element >> DOM::Document.body
-    element.style.position = 'absolute'
-    element.style.width = '100px'
-    element.style.top = '40px'
-    element.style.left = '60px'
-    element.style.height = '80px'
+    subject >> DOM::Document.body
+    subject.style.position = 'absolute'
+    subject.style.width = '100px'
+    subject.style.top = '40px'
+    subject.style.left = '60px'
+    subject.style.height = '80px'
   end
 
   after do
-    element.remove!
+    subject.remove!
+  end
+
+  describe '#scroll_top' do
+    it 'should return the scroll position' do
+      subject.scroll_top.should eq 0
+    end
+  end
+
+  describe '#scroll_left' do
+    it 'should return the scroll position' do
+      subject.scroll_left.should eq 0
+    end
+  end
+
+  describe '#cover?' do
+    let(:pos) { double x: 62, y: 82 }
+    it 'should return the true if it covers' do
+      subject.cover?(pos).should eq true
+    end
   end
 
   describe '#top' do
-    it 'should return the top position of the element' do
-      element.top.should eq 40
+    it 'should return the top position' do
+      subject.top.should eq 40
     end
   end
 
   describe '#left' do
-    it 'should return the left position of the element' do
-      element.left.should eq 60
+    it 'should return the left position' do
+      subject.left.should eq 60
     end
   end
 
   describe '#right' do
-    it 'should return the right position of the element' do
-      element.right.should eq 160
+    it 'should return the right position' do
+      subject.right.should eq 160
     end
   end
 
   describe '#bottom' do
-    it 'should return the bottom position of the element' do
-      element.bottom.should eq 120
+    it 'should return the bottom position' do
+      subject.bottom.should eq 120
     end
   end
 
   describe '#width' do
-    it 'should return the width of the element' do
-      element.width.should eq 100
+    it 'should return the width' do
+      subject.width.should eq 100
     end
   end
 
   describe '#height' do
-    it 'should return the height of the element' do
-      element.height.should eq 80
+    it 'should return the height' do
+      subject.height.should eq 80
+    end
+  end
+
+  describe '#visible?' do
+    context 'display: none' do
+      it 'should return false' do
+        expect {
+          subject.style.display = 'none'
+        }.to change { subject.visible? }.from(true).to(false)
+      end
+    end
+
+    context 'not in viewport' do
+      height, width = `window.innerHeight`, `window.innerWidth`
+      [
+        [-80, -100],     # Top Left
+        [-80, 0],        # Top
+        [0, -100],       # Left
+        [height, width], # Bottom Right
+        [height, 0],     # Bottom
+        [0, width]       # Right
+      ].each do |item|
+        it "should return false for #{item}" do
+          top, left = item
+          expect {
+            subject.style.top = "#{top}px"
+            subject.style.left = "#{left}px"
+          }.to change { subject.visible? }.from(true).to(false)
+        end
+      end
+    end
+
+    context '0 size' do
+      it 'should return false' do
+        expect {
+          subject.style.width = 0
+          subject.style.height = 0
+        }.to change { subject.visible? }.from(true).to(false)
+      end
+    end
+
+    context 'not in dom' do
+      it 'should return false' do
+        expect {
+          subject.remove!
+        }.to change { subject.visible? }.from(true).to(false)
+      end
     end
   end
 end

data/spec/dom/modules/events_spec.rb

@@ -1,13 +1,27 @@
-require 'fron/dom'
+require 'spec_helper'
 
 describe DOM::Events do
-
   let(:element) { DOM::Element.new 'div' }
-  subject { element.instance_variable_get("@listeners") }
+  subject { element.instance_variable_get '@listeners' }
 
   describe '#on' do
     async 'should register for event' do
-      listener = element.on 'click' do |event|
+      listener = element.on 'click' do
+        run_async do
+          subject.should_not be nil
+          subject[:click].should_not be nil
+          subject[:click].length.should eq 1
+          subject[:click].include?(listener).should eq true
+          element.off 'click'
+        end
+      end
+      element.trigger 'click'
+    end
+  end
+
+  describe '#on!' do
+    async 'should register for event' do
+      listener = element.on! 'click' do
         run_async do
           subject.should_not be nil
           subject[:click].should_not be nil
@@ -21,7 +35,7 @@ describe DOM::Events do
   end
 
   describe '#off' do
-    context "two arguments" do
+    context 'two arguments' do
       it 'should unregister for event' do
         listener = element.on 'click' do end
         subject[:click].include?(listener).should eq true
@@ -30,7 +44,7 @@ describe DOM::Events do
       end
     end
 
-    context "one argument" do
+    context 'one argument' do
       it 'should unregister all events for type' do
         listener = element.on 'click' do end
         subject[:click].include?(listener).should eq true
@@ -39,7 +53,7 @@ describe DOM::Events do
       end
     end
 
-    context "no argument" do
+    context 'no argument' do
       it 'should unregister all events' do
         listener = element.on 'click' do end
         subject[:click].include?(listener).should eq true
@@ -62,7 +76,7 @@ describe DOM::Events do
 
   describe '#trigger' do
     async 'should trigger the event' do
-      element.on 'click' do |event|
+      element.on 'click' do
         run_async do
           element.off 'click'
         end

data/spec/dom/node_spec.rb

@@ -1,11 +1,11 @@
-require 'fron/dom'
+require 'spec_helper'
 
+# Test Node
 class TestNode < DOM::NODE
   attr_reader :el
 end
 
 describe TestNode do
-
   let(:el)   { DOM::Element.new('div') }
   let(:body) { DOM::Document.body }
   subject    { described_class.new `document.createElement('div')` }
@@ -15,8 +15,7 @@ describe TestNode do
     el.remove!
   end
 
-  describe "#dup" do
-
+  describe '#dup' do
     let(:node) { subject.dup }
 
     it 'should clone the node' do
@@ -28,7 +27,7 @@ describe TestNode do
     end
   end
 
-  describe "#dup!" do
+  describe '#dup!' do
     it 'should clone with children' do
       subject << el
       subject.children.length.should eq 1
@@ -44,18 +43,27 @@ describe TestNode do
 
     it 'should return a new NODE' do
       subject >> body
-      subject.parent.class.should eq DOM::NODE
+      subject.parent.should be_a DOM::NODE
     end
   end
 
-  describe "#parentNode" do
+  describe '#parent_node' do
     it 'should return nil if there is no parent node' do
-      subject.parentNode.should eq nil
+      subject.parent_node.should eq nil
     end
 
     it 'should return a new NODE' do
       subject >> body
-      subject.parentNode.class.should eq DOM::NODE
+      subject.parent_node.should be_a DOM::NODE
+    end
+  end
+
+  describe '#empty' do
+    it 'should remove all children' do
+      subject << el
+      expect {
+        subject.empty
+      }.to change { el.parent }.from(subject).to nil
     end
   end
 
@@ -114,25 +122,25 @@ describe TestNode do
     end
   end
 
-  describe '#insertBefore' do
+  describe '#insert_before' do
     let(:otherEl) { DOM::Element.new 'div' }
 
     it 'should insert given node before the other given node' do
       subject << el
       subject << otherEl
-      el.should > otherEl
+      (el > otherEl).should eq true
       otherEl.should < el
     end
   end
 
-  describe "#text" do
+  describe '#text' do
     it 'should return the nodes textContent' do
       `#{subject.el}.textContent = 'Test'`
       subject.text.should eq 'Test'
     end
   end
 
-  describe "#text=" do
+  describe '#text=' do
     it 'should set the nodes textContent' do
       subject.text = 'Asd'
       `#{subject.el}.textContent`.should eq 'Asd'
@@ -160,7 +168,7 @@ describe TestNode do
     end
   end
 
-  describe "<=>" do
+  describe '<=>' do
     it 'should return 0 if nodes are the same' do
       subject >> el
       expect(el.children[0] <=> subject).to eq 0
@@ -168,20 +176,20 @@ describe TestNode do
 
     it 'should throw if the nodes are not in the same parent' do
       subject >> body
-      expect(Proc.new { el <=> subject } ).to raise_error
+      expect(proc { el <=> subject }).to raise_error
     end
 
     it 'should compare indexes if the nodes are in the same parent' do
       subject >> body
       el >> body
-      expect(el <=> subject).to eq -1
+      expect(el <=> subject).to eq(-1)
       expect(subject <=> el).to eq 1
     end
   end
 
   describe 'index' do
     it 'should return index (position) of the node' do
-      el << DOM::Text.new('Test')
+      el << DOM::Element.new('test')
       subject >> el
       subject.index.should eq 1
     end

data/spec/dom/nodelist_spec.rb

@@ -1,11 +1,10 @@
-require 'fron/dom'
+require 'spec_helper'
 
 describe DOM::NodeList do
-
   describe '#initialize' do
     it 'should map nodes to elements' do
       DOM::Document.body.children.each do |node|
-        node.class.should eq DOM::NODE
+        node.should be_a DOM::NODE
       end
     end
   end

data/spec/dom/style_spec.rb

@@ -1,9 +1,10 @@
-describe DOM::Style do
+require 'spec_helper'
 
+describe DOM::Style do
   subject { DOM::Element.new 'div' }
-  let(:el) { subject.instance_variable_get("@el") }
+  let(:el) { subject.instance_variable_get('@el') }
 
-  describe "method_missing" do
+  describe 'method_missing' do
     it 'should call []= if the methods ends with =' do
       expect(subject.style).to receive(:[]=).with 'display', 'none'
       subject.style.display = 'none'
@@ -15,14 +16,14 @@ describe DOM::Style do
     end
   end
 
-  describe "[]=" do
+  describe '[]=' do
     it 'should set the given style' do
       subject.style['display'] = 'none'
       `#{el}.style.display`.should eq 'none'
     end
   end
 
-  describe "[]" do
+  describe '[]'do
     it 'should return with the value of the given style' do
       `#{el}.style.display = 'block'`
       subject.style['display'].should eq 'block'