friends 0.52 → 0.53

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57f457698261d056ca29ea09b153b0917cfebc74dd1c6abf735342d4fa52aa76
-  data.tar.gz: 47435bd44eda4f24f31f61df3cd84a7d4930fa92def6cc68b2b1111f9322a998
+  metadata.gz: 1be607e71eb696b1ebf8c6e46b1b561f153288ecede0c429fc93facd82a4b392
+  data.tar.gz: 2ea6de005359014425d32386306c0654eaa8349be0ebf19c957da3582a8c33f2
 SHA512:
-  metadata.gz: 4c9500e8446cccad117a7110fb92f8f2871a7793f175e403100eae3455aeff473013c1fe0218481985d8a88b5949274501686187f05c0fac1aa4233b4175c1ad
-  data.tar.gz: 18ed3d0414a30c3d21350c8190bd6b56b7caec077592e8e32952abb6570aa9f3ea26b80d6c54d381aa8f7bdedbb10ec494166e8ed5c347fd1d19f875bcd384cf
+  metadata.gz: e946dd33cd26ee1fdbe288cc2a2be9f0eb3eaae6bede1e47096c8b42d2af5da753b7d151b29fd75aa3aac5958d717a7141cac7e108e949961cd000e6af5f3451
+  data.tar.gz: 3c8e1a84fec855f17d0177de3cadd52a31bdfe51255bf77dd70dd9188be59871eec15d734e6f0b269183e330e15734653679f821d322407c6a87ca8d3f1a3b8f

data/.github/CONTRIBUTING.md

@@ -55,7 +55,7 @@ promise I don't bite. 😊
 
 ## Code of Conduct
 
-Note that this project follows a [Code of Conduct](https://github.com/JacobEvelyn/friends/blob/master/CODE_OF_CONDUCT.md).
+Note that this project follows a [Code of Conduct](https://github.com/JacobEvelyn/friends/blob/main/CODE_OF_CONDUCT.md).
 If you're a polite, reasonable person you won't have any issues!
 
 ## Financial contributions

data/.travis.yml

@@ -19,6 +19,6 @@ matrix:
         - CODE_COVERAGE=true
 branches:
   only:
-    - master # Always run on the master branch
+    - main # Always run on the main branch
 notifications:
   email: false

data/CHANGELOG.md

@@ -4,6 +4,18 @@
 making a small donation (🙏) with the **Sponsor** button at the top of this page to
 show you appreciate its continued development.
 
+## [v0.53](https://github.com/JacobEvelyn/friends/tree/v0.53) (2020-07-06)
+
+[Full Changelog](https://github.com/JacobEvelyn/friends/compare/v0.52...v0.53)
+
+**Fixed bugs:**
+
+- undefined method error occurred when “add tag" or “add nickname” executed with no arguments [\#265](https://github.com/JacobEvelyn/friends/issues/265)
+
+**Merged pull requests:**
+
+- Fix for the case of add tag or add nickname args are nill [\#266](https://github.com/JacobEvelyn/friends/pull/266) ([m-t-a-n-a-k-a](https://github.com/m-t-a-n-a-k-a))
+
 ## [v0.52](https://github.com/JacobEvelyn/friends/tree/v0.52) (2020-06-03)
 
 [Full Changelog](https://github.com/JacobEvelyn/friends/compare/v0.51...v0.52)
@@ -92,7 +104,7 @@ show you appreciate its continued development.
 
 **Fixed bugs:**
 
-- Tests are failing in `master` [\#238](https://github.com/JacobEvelyn/friends/issues/238)
+- Tests are failing in `main` [\#238](https://github.com/JacobEvelyn/friends/issues/238)
 
 **Merged pull requests:**
 
@@ -645,7 +657,7 @@ show you appreciate its continued development.
 **Merged pull requests:**
 
 - Highlight multiple occurrences [\#70](https://github.com/JacobEvelyn/friends/pull/70) ([GuruKhalsa](https://github.com/GuruKhalsa))
-- Fix Travis badge \(master only\) [\#67](https://github.com/JacobEvelyn/friends/pull/67) ([JacobEvelyn](https://github.com/JacobEvelyn))
+- Fix Travis badge \(main only\) [\#67](https://github.com/JacobEvelyn/friends/pull/67) ([JacobEvelyn](https://github.com/JacobEvelyn))
 - Move activity prompt to bin/friends [\#64](https://github.com/JacobEvelyn/friends/pull/64) ([JacobEvelyn](https://github.com/JacobEvelyn))
 - Adds the --debug flag for printing backtraces on error [\#63](https://github.com/JacobEvelyn/friends/pull/63) ([JacobEvelyn](https://github.com/JacobEvelyn))
 - Move file writes to end of command actions [\#61](https://github.com/JacobEvelyn/friends/pull/61) ([JacobEvelyn](https://github.com/JacobEvelyn))

data/README.md

@@ -1,6 +1,6 @@
 [![Gem Version](https://badge.fury.io/rb/friends.svg)](https://badge.fury.io/rb/friends)
-[![Code Coverage](https://codecov.io/gh/JacobEvelyn/friends/branch/master/graph/badge.svg)](https://codecov.io/gh/JacobEvelyn/friends)
-[![Build Status](https://travis-ci.com/JacobEvelyn/friends.svg?branch=master)](https://travis-ci.com/JacobEvelyn/friends)
+[![Code Coverage](https://codecov.io/gh/JacobEvelyn/friends/branch/main/graph/badge.svg)](https://codecov.io/gh/JacobEvelyn/friends)
+[![Build Status](https://travis-ci.com/JacobEvelyn/friends.svg?branch=main)](https://travis-ci.com/JacobEvelyn/friends)
 [![Readme Score](http://readme-score-api.herokuapp.com/score.svg?url=JacobEvelyn/friends&bust=1)](http://clayallsopp.github.io/readme-score?url=JacobEvelyn/friends)
 [![Inline docs](http://inch-ci.org/github/JacobEvelyn/friends.png)](http://inch-ci.org/github/JacobEvelyn/friends)
 [![Gem](https://img.shields.io/gem/dt/friends.svg)](https://rubygems.org/gems/friends)
@@ -181,7 +181,7 @@ The `friends.md` Markdown file that stores all of your data contains:
 ```
 
 See the example
-[`friends.md`](https://github.com/JacobEvelyn/friends/blob/master/friends.md)
+[`friends.md`](https://github.com/JacobEvelyn/friends/blob/main/friends.md)
 file for more information.
 
 ### Global flags
@@ -956,7 +956,7 @@ If you have an idea,
 [make a GitHub issue](https://github.com/JacobEvelyn/friends/issues/new)!
 Suggestions are very very welcome, and usually are implemented very
 quickly. And if you'd like to do the implementing yourself, see the
-[contributing guide](https://github.com/JacobEvelyn/friends/blob/master/.github/CONTRIBUTING.md).
+[contributing guide](https://github.com/JacobEvelyn/friends/blob/main/.github/CONTRIBUTING.md).
 
 A big big thanks to all of this project's lovely
 [contributors](https://github.com/JacobEvelyn/friends/graphs/contributors):
@@ -988,10 +988,10 @@ Support this project by becoming a sponsor. Your logo will show up here with a l
 
 ## Code of Conduct
 
-Note that this project follows a [Code of Conduct](https://github.com/JacobEvelyn/friends/blob/master/CODE_OF_CONDUCT.md).
+Note that this project follows a [Code of Conduct](https://github.com/JacobEvelyn/friends/blob/main/CODE_OF_CONDUCT.md).
 If you're a polite, reasonable person you won't have any issues!
 
 ## License
 
 Friends is released under the
-[MIT License](https://github.com/JacobEvelyn/friends/blob/master/LICENSE.txt).
+[MIT License](https://github.com/JacobEvelyn/friends/blob/main/LICENSE.txt).

data/RELEASING.md

@@ -2,7 +2,7 @@
 
 These are steps for the maintainer to take to release a new version of this gem.
 
-1.  On the `master` branch, update the `VERSION` constant in
+1.  On the `main` branch, update the `VERSION` constant in
     `lib/friends/version.rb`.
 2.  Commit the change (`git add -A && git commit -m 'Bump to vX.X'`).
 3.  Add a tag (`git tag -am "vX.X" vX.X`).

data/lib/friends/commands/add.rb

@@ -35,7 +35,7 @@ command :add do |add|
   add.arg_name "NAME NICKNAME"
   add.command :nickname do |add_nickname|
     add_nickname.action do |_, _, args|
-      @introvert.add_nickname(name: args.first.strip, nickname: args[1].strip)
+      @introvert.add_nickname(name: args.first.to_s.strip, nickname: args[1].to_s.strip)
       @dirty = true # Mark the file for cleaning.
     end
   end
@@ -46,7 +46,7 @@ command :add do |add|
     add_tag.action do |_, _, args|
       @introvert.add_tag(
         name: args[0..-2].join(" "),
-        tag: Tag.convert_to_tag(args.last.strip)
+        tag: Tag.convert_to_tag(args.last.to_s.strip)
       )
       @dirty = true # Mark the file for cleaning.
     end

data/lib/friends/introvert.rb

@@ -203,6 +203,7 @@ module Friends
     # @param nickname [String] the nickname to add to the friend
     # @raise [FriendsError] if 0 or 2+ friends match the given name
     def add_nickname(name:, nickname:)
+      raise FriendsError, "Expected \"[Friend Name]\" \"[Nickname]\"" if name.empty?
       raise FriendsError, "Nickname cannot be blank" if nickname.empty?
 
       friend = thing_with_name_in(:friend, name)
@@ -216,6 +217,7 @@ module Friends
     # @param tag [String] the tag to add to the friend, of the form: "@tag"
     # @raise [FriendsError] if 0 or 2+ friends match the given name
     def add_tag(name:, tag:)
+      raise FriendsError, "Expected \"[Friend Name]\" \"[Tag]\"" if name.empty?
       raise FriendsError, "Tag cannot be blank" if tag == "@"
 
       friend = thing_with_name_in(:friend, name)

data/lib/friends/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Friends
-  VERSION = "0.52"
+  VERSION = "0.53"
 end

data/test/commands/add/nickname_spec.rb

@@ -7,6 +7,15 @@ clean_describe "add nickname" do
 
   let(:content) { CONTENT }
 
+  describe "when friend name and nickname are blank" do
+    let(:friend_name) { nil }
+    let(:nickname) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Friend Name]" "[Nickname]"'
+    end
+  end
+
   describe "when friend name has no matches" do
     let(:friend_name) { "Garbage" }
     let(:nickname) { "Georgie" }

data/test/commands/add/tag_spec.rb

@@ -7,6 +7,15 @@ clean_describe "add tag" do
 
   let(:content) { CONTENT }
 
+  describe "when friend name and tag are blank" do
+    let(:friend_name) { nil }
+    let(:tag) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Friend Name]" "[Tag]"'
+    end
+  end
+
   describe "when friend name has no matches" do
     let(:friend_name) { "Garbage" }
     let(:tag) { "school" }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: friends
 version: !ruby/object:Gem::Version
-  version: '0.52'
+  version: '0.53'
 platform: ruby
 authors:
 - Jacob Evelyn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-03 00:00:00.000000000 Z
+date: 2020-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chronic