friends 0.51 → 0.55

data/lib/friends/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Friends
-  VERSION = "0.51"
+  VERSION = "0.55"
 end

data/test/commands/add/alias_spec.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "add alias" do
+  subject { run_cmd("add alias #{location_name} #{nickname}") }
+
+  let(:content) { CONTENT }
+
+  describe "when location name and alias are blank" do
+    let(:location_name) { nil }
+    let(:nickname) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Location Name]" "[Alias]"'
+    end
+  end
+
+  describe "when location name has no matches" do
+    let(:location_name) { "Garbage" }
+    let(:nickname) { "Big Apple Pie" }
+
+    it "prints an error message" do
+      stderr_only 'Error: No location found for "Garbage"'
+    end
+  end
+
+  describe "when location alias has more than one match" do
+    let(:location_name) { "'New York City'" }
+    let(:nickname) { "'Big Apple'" }
+    before do
+      run_cmd("add location Manhattan")
+      run_cmd("add alias Manhattan 'Big Apple'")
+    end
+
+    it "prints an error message" do
+      stderr_only "Error: The location alias "\
+                  '"Big Apple" is already taken by "Manhattan (a.k.a. Big Apple)"'
+    end
+  end
+
+  describe "when location name has one match" do
+    let(:location_name) { "'New York City'" }
+
+    describe "when alias is blank" do
+      let(:nickname) { "' '" }
+
+      it "prints an error message" do
+        stderr_only "Error: Alias cannot be blank"
+      end
+    end
+
+    describe "when alias is nil" do
+      let(:nickname) { nil }
+
+      it "prints an error message" do
+        stderr_only "Error: Alias cannot be blank"
+      end
+    end
+
+    describe "when alias is not blank" do
+      let(:nickname) { "'Big Apple'" }
+
+      it "adds alias to location" do
+        line_changed "- New York City (a.k.a. NYC a.k.a. NY)",
+                     "- New York City (a.k.a. NYC a.k.a. NY a.k.a. Big Apple)"
+      end
+
+      it "prints an output message" do
+        stdout_only 'Alias added: "New York City (a.k.a. NYC a.k.a. NY a.k.a. Big Apple)"'
+      end
+    end
+  end
+end

data/test/commands/add/nickname_spec.rb

@@ -7,6 +7,15 @@ clean_describe "add nickname" do
 
   let(:content) { CONTENT }
 
+  describe "when friend name and nickname are blank" do
+    let(:friend_name) { nil }
+    let(:nickname) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Friend Name]" "[Nickname]"'
+    end
+  end
+
   describe "when friend name has no matches" do
     let(:friend_name) { "Garbage" }
     let(:nickname) { "Georgie" }

data/test/commands/add/tag_spec.rb

@@ -7,6 +7,15 @@ clean_describe "add tag" do
 
   let(:content) { CONTENT }
 
+  describe "when friend name and tag are blank" do
+    let(:friend_name) { nil }
+    let(:tag) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Friend Name]" "[Tag]"'
+    end
+  end
+
   describe "when friend name has no matches" do
     let(:friend_name) { "Garbage" }
     let(:tag) { "school" }

data/test/commands/edit_spec.rb

@@ -134,6 +134,7 @@ Not cleaning file: "#{filename}" ("exit 1 #" did not exit successfully)
 - Atlantis
 - Martha's Vineyard
 - Mysterious Mountains
+- New York City (a.k.a. NYC a.k.a. NY)
 - Paris
       EXPECTED_CONTENT
     end

data/test/commands/list/friends_spec.rb

@@ -26,26 +26,26 @@ clean_describe "list friends" do
     # only reads from the (usually-sorted) file.
     let(:content) { SCRAMBLED_CONTENT }
 
-    it "lists friends in file order" do
+    it "lists friends in alphabetical order" do
       stdout_only <<-OUTPUT
 George Washington Carver
-Marie Curie
 Grace Hopper
-Stanislav Petrov
+Marie Curie
 Norman Borlaug
+Stanislav Petrov
       OUTPUT
     end
 
     describe "--verbose" do
       subject { run_cmd("list friends --verbose") }
 
-      it "lists friends in file order with details" do
+      it "lists friends in sorted order with details" do
         stdout_only <<-OUTPUT
 George Washington Carver
-Marie Curie [Atlantis] @science
 Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Paris] @navy @science
-Stanislav Petrov (a.k.a. Stan) @doesnt-trust-computers @doesnt-trust-computers:military-uses
+Marie Curie [Atlantis] @science
 Norman Borlaug (a.k.a. Norm) @science @science:outdoors @science:outdoors:agronomy
+Stanislav Petrov (a.k.a. Stan) @doesnt-trust-computers @doesnt-trust-computers:military-uses
         OUTPUT
       end
     end
@@ -73,8 +73,8 @@ Norman Borlaug (a.k.a. Norm) @science @science:outdoors @science:outdoors:agrono
 
       it "matches tag case-insensitively" do
         stdout_only <<-OUTPUT
-Marie Curie
 Grace Hopper
+Marie Curie
 Norman Borlaug
         OUTPUT
       end
@@ -114,5 +114,99 @@ Stanislav Petrov
         end
       end
     end
+
+    describe "--sort" do
+      subject { run_cmd("list friends --sort #{sort} #{reverse}") }
+
+      let(:reverse) { nil }
+
+      # Use scrambled content to differentiate between output that is sorted and output that
+      # only reads from the (usually-sorted) file.
+      let(:content) { SCRAMBLED_CONTENT }
+
+      describe "alphabetical" do
+        let(:sort) { "alphabetical" }
+
+        it "lists friends in sorted order" do
+          stdout_only <<-OUTPUT
+George Washington Carver
+Grace Hopper
+Marie Curie
+Norman Borlaug
+Stanislav Petrov
+          OUTPUT
+        end
+
+        describe "--reverse" do
+          let(:reverse) { "--reverse" }
+
+          it "lists friends in reverse order" do
+            stdout_only <<-OUTPUT
+Stanislav Petrov
+Norman Borlaug
+Marie Curie
+Grace Hopper
+George Washington Carver
+            OUTPUT
+          end
+        end
+      end
+
+      describe "n-activities" do
+        let(:sort) { "n-activities" }
+
+        it "lists friends in sorted order" do
+          stdout_only <<-OUTPUT
+3 activities: George Washington Carver
+2 activities: Grace Hopper
+1 activity: Marie Curie
+1 activity: Norman Borlaug
+0 activities: Stanislav Petrov
+          OUTPUT
+        end
+
+        describe "--reverse" do
+          let(:reverse) { "--reverse" }
+
+          it "lists friends in reverse order" do
+            stdout_only <<-OUTPUT
+0 activities: Stanislav Petrov
+1 activity: Norman Borlaug
+1 activity: Marie Curie
+2 activities: Grace Hopper
+3 activities: George Washington Carver
+            OUTPUT
+          end
+        end
+      end
+
+      describe "recency" do
+        let(:sort) { "recency" }
+
+        it "lists friends in sorted order" do
+          stdout_only_regexes [
+            "N/A days ago: Stanislav Petrov",
+            /\d+ days ago: George Washington Carver/,
+            /\d+ days ago: Norman Borlaug/,
+            /\d+ days ago: Grace Hopper/,
+            /\d+ days ago: Marie Curie/
+          ]
+        end
+
+        describe "--reverse" do
+          let(:reverse) { "--reverse" }
+
+          it "lists friends in reverse order" do
+            stdout_only_regexes [
+              /\d+ days ago: Marie Curie/,
+              /\d+ days ago: Grace Hopper/,
+              /\d+ days ago: Norman Borlaug/,
+              /\d+ days ago: George Washington Carver/,
+              "N/A days ago: Stanislav Petrov"
+            ]
+          end
+        end
+      end
+    end
   end
 end

data/test/commands/list/locations_spec.rb

@@ -26,12 +26,114 @@ clean_describe "list locations" do
     # only reads from the (usually-sorted) file.
     let(:content) { SCRAMBLED_CONTENT }
 
-    it "lists locations in file order" do
+    it "lists locations in alphabetical" do
       stdout_only <<-OUTPUT
-Paris
 Atlantis
 Martha's Vineyard
+New York City
+Paris
       OUTPUT
     end
+
+    describe "--sort" do
+      subject { run_cmd("list locations --sort #{sort} #{reverse}") }
+
+      let(:reverse) { nil }
+
+      # Use scrambled content to differentiate between output that is sorted and output that
+      # only reads from the (usually-sorted) file.
+      let(:content) { SCRAMBLED_CONTENT }
+
+      describe "alphabetical" do
+        let(:sort) { "alphabetical" }
+
+        it "lists locations in sorted order" do
+          stdout_only <<-OUTPUT
+Atlantis
+Martha's Vineyard
+New York City
+Paris
+          OUTPUT
+        end
+
+        describe "--reverse" do
+          let(:reverse) { "--reverse" }
+
+          it "lists locations in reverse order" do
+            stdout_only <<-OUTPUT
+Paris
+New York City
+Martha's Vineyard
+Atlantis
+            OUTPUT
+          end
+        end
+      end
+
+      describe "n-activities" do
+        let(:sort) { "n-activities" }
+
+        it "lists locations in sorted order" do
+          stdout_only <<-OUTPUT
+1 activity: Paris
+1 activity: Atlantis
+1 activity: Martha's Vineyard
+0 activities: New York City
+          OUTPUT
+        end
+
+        describe "--reverse" do
+          let(:reverse) { "--reverse" }
+
+          it "lists locations in reverse order" do
+            stdout_only <<-OUTPUT
+0 activities: New York City
+1 activity: Martha's Vineyard
+1 activity: Atlantis
+1 activity: Paris
+            OUTPUT
+          end
+        end
+      end
+
+      describe "recency" do
+        let(:sort) { "recency" }
+
+        it "lists locations in sorted order" do
+          stdout_only_regexes [
+            "N/A days ago: New York City",
+            /\d+ days ago: Atlantis/,
+            /\d+ days ago: Martha's Vineyard/,
+            /\d+ days ago: Paris/
+          ]
+        end
+
+        describe "--reverse" do
+          let(:reverse) { "--reverse" }
+
+          it "lists locations in reverse order" do
+            stdout_only_regexes [
+              /\d+ days ago: Paris/,
+              /\d+ days ago: Martha's Vineyard/,
+              /\d+ days ago: Atlantis/,
+              "N/A days ago: New York City"
+            ]
+          end
+        end
+      end
+    end
+
+    describe "--verbose" do
+      subject { run_cmd("list locations --verbose") }
+
+      it "lists locations in alphabetical order with details" do
+        stdout_only <<-OUTPUT
+Atlantis
+Martha's Vineyard
+New York City (a.k.a. NYC a.k.a. NY)
+Paris
+        OUTPUT
+      end
+    end
   end
 end

data/test/commands/remove/alias_spec.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "remove alias" do
+  subject { run_cmd("remove alias #{location_name} #{nickname}") }
+
+  let(:content) { CONTENT }
+
+  describe "when location and nickname are nil" do
+    let(:location_name) { nil }
+    let(:nickname) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Location Name]" "[Alias]"'
+    end
+  end
+
+  describe "when location name has no matches" do
+    let(:location_name) { "Garbage" }
+    let(:nickname) { "'Big Apple Pie'" }
+
+    it "prints an error message" do
+      stderr_only 'Error: No location found for "Garbage"'
+    end
+  end
+
+  describe "when location name has one match" do
+    let(:location_name) { "'New York City'" }
+
+    describe "when alias is nil" do
+      let(:nickname) { nil }
+      it "prints an error message" do
+        stderr_only "Error: Alias cannot be blank"
+      end
+    end
+
+    describe "when alias is not present on location" do
+      let(:nickname) { "Gotham" }
+      it "prints an error message" do
+        stderr_only 'Error: Alias "Gotham" not found for "New York City"'
+      end
+    end
+
+    describe "when alias is present on location" do
+      let(:nickname) { "'NYC'" }
+
+      it "removes alias from location" do
+        line_changed(
+          "- New York City (a.k.a. NYC a.k.a. NY)",
+          "- New York City (a.k.a. NY)"
+        )
+      end
+
+      it "removes parenthetical from file when location has no more nicknames" do
+        run_cmd("remove alias #{location_name} 'NY'")
+        line_changed(
+          "- New York City (a.k.a. NYC)",
+          "- New York City"
+        )
+      end
+
+      it "prints an output message" do
+        stdout_only 'Alias removed: "New York City (a.k.a. NY)"'
+      end
+    end
+  end
+end