friends 0.49 → 0.54

data/test/commands/add/nickname_spec.rb

@@ -7,6 +7,15 @@ clean_describe "add nickname" do
 
   let(:content) { CONTENT }
 
+  describe "when friend name and nickname are blank" do
+    let(:friend_name) { nil }
+    let(:nickname) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Friend Name]" "[Nickname]"'
+    end
+  end
+
   describe "when friend name has no matches" do
     let(:friend_name) { "Garbage" }
     let(:nickname) { "Georgie" }

data/test/commands/add/tag_spec.rb

@@ -7,6 +7,15 @@ clean_describe "add tag" do
 
   let(:content) { CONTENT }
 
+  describe "when friend name and tag are blank" do
+    let(:friend_name) { nil }
+    let(:tag) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Friend Name]" "[Tag]"'
+    end
+  end
+
   describe "when friend name has no matches" do
     let(:friend_name) { "Garbage" }
     let(:tag) { "school" }

data/test/commands/edit_spec.rb

@@ -134,6 +134,7 @@ Not cleaning file: "#{filename}" ("exit 1 #" did not exit successfully)
 - Atlantis
 - Martha's Vineyard
 - Mysterious Mountains
+- New York City (a.k.a. NYC a.k.a. NY)
 - Paris
       EXPECTED_CONTENT
     end

data/test/commands/list/locations_spec.rb

@@ -31,7 +31,21 @@ clean_describe "list locations" do
 Paris
 Atlantis
 Martha's Vineyard
+New York City
       OUTPUT
     end
+
+    describe "--verbose" do
+      subject { run_cmd("list locations --verbose") }
+
+      it "lists locations in file order with details" do
+        stdout_only <<-OUTPUT
+Paris
+Atlantis
+Martha's Vineyard
+New York City (a.k.a. NYC a.k.a. NY)
+        OUTPUT
+      end
+    end
   end
 end

data/test/commands/remove/alias_spec.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "remove alias" do
+  subject { run_cmd("remove alias #{location_name} #{nickname}") }
+
+  let(:content) { CONTENT }
+
+  describe "when location and nickname are nil" do
+    let(:location_name) { nil }
+    let(:nickname) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: Expected "[Location Name]" "[Alias]"'
+    end
+  end
+
+  describe "when location name has no matches" do
+    let(:location_name) { "Garbage" }
+    let(:nickname) { "'Big Apple Pie'" }
+
+    it "prints an error message" do
+      stderr_only 'Error: No location found for "Garbage"'
+    end
+  end
+
+  describe "when location name has one match" do
+    let(:location_name) { "'New York City'" }
+
+    describe "when alias is nil" do
+      let(:nickname) { nil }
+      it "prints an error message" do
+        stderr_only "Error: Alias cannot be blank"
+      end
+    end
+
+    describe "when alias is not present on location" do
+      let(:nickname) { "Gotham" }
+      it "prints an error message" do
+        stderr_only 'Error: Alias "Gotham" not found for "New York City"'
+      end
+    end
+
+    describe "when alias is present on location" do
+      let(:nickname) { "'NYC'" }
+
+      it "removes alias from location" do
+        line_changed(
+          "- New York City (a.k.a. NYC a.k.a. NY)",
+          "- New York City (a.k.a. NY)"
+        )
+      end
+
+      it "removes parenthetical from file when location has no more nicknames" do
+        run_cmd("remove alias #{location_name} 'NY'")
+        line_changed(
+          "- New York City (a.k.a. NYC)",
+          "- New York City"
+        )
+      end
+
+      it "prints an output message" do
+        stdout_only 'Alias removed: "New York City (a.k.a. NY)"'
+      end
+    end
+  end
+end

data/test/commands/remove/tag_spec.rb

@@ -7,6 +7,15 @@ clean_describe "remove tag" do
 
   let(:content) { CONTENT }
 
+  describe "when friend name and tag are blank" do
+    let(:friend_name) { nil }
+    let(:tag) { nil }
+
+    it "prints an error message" do
+      stderr_only 'Error: No friend found for ""'
+    end
+  end
+
   describe "when friend name has no matches" do
     let(:friend_name) { "Garbage" }
     let(:tag) { "science" }

data/test/commands/stats_spec.rb

@@ -42,7 +42,7 @@ Total time elapsed: 0 days
       stdout_only <<-OUTPUT
 Total activities: 5
 Total friends: 5
-Total locations: 3
+Total locations: 4
 Total notes: 4
 Total tags: 10
 Total time elapsed: 1179 days

data/test/editor

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
 # This is an example "editor" used to test the `friends edit` command.
 # It inserts a new activity into the second line of the file, allowing
 # us to test that friends and locations added in an `edit` command are

data/test/helper.rb

@@ -24,7 +24,7 @@ require "securerandom"
 
 require "friends"
 
-CONTENT = <<-FILE.freeze
+CONTENT = <<-FILE
 ### Activities:
 - 2018-02-06: @science:indoors:agronomy-with-hydroponics: **Norman Borlaug** and **George Washington Carver** scored a tour of _Atlantis_' hydroponics gardens through wetplants@example.org and they took me along.
 - 2015-11-01: **Grace Hopper** and I went to _Martha's Vineyard_. George had to cancel at the last minute.
@@ -48,11 +48,12 @@ CONTENT = <<-FILE.freeze
 ### Locations:
 - Atlantis
 - Martha's Vineyard
+- New York City (a.k.a. NYC a.k.a. NY)
 - Paris
 FILE
 
 # This is CONTENT but with activities, friends, and locations unsorted.
-SCRAMBLED_CONTENT = <<-FILE.freeze
+SCRAMBLED_CONTENT = <<-FILE
 ### Activities:
 - 2015-01-04: Got lunch with **Grace Hopper** and **George Washington Carver**. @food
 - 2015-11-01: **Grace Hopper** and I went to _Martha's Vineyard_. George had to cancel at the last minute.
@@ -77,6 +78,7 @@ SCRAMBLED_CONTENT = <<-FILE.freeze
 - Paris
 - Atlantis
 - Martha's Vineyard
+- New York City (a.k.a. NYC a.k.a. NY)
 FILE
 
 # Define these methods so they can be referenced in the methods below. They'll be overridden in

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: friends
 version: !ruby/object:Gem::Version
-  version: '0.49'
+  version: '0.54'
 platform: ruby
 authors:
 - Jacob Evelyn
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-02 00:00:00.000000000 Z
+date: 2020-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chronic
@@ -52,26 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: semverse
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
 - !ruby/object:Gem::Dependency
   name: tty-pager
   requirement: !ruby/object:Gem::Requirement
@@ -120,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 description: Spend time with the people you care about. Introvert-tested. Extrovert-approved.
 email:
 - jacobevelyn@gmail.com
@@ -177,11 +157,13 @@ files:
 - lib/friends/note.rb
 - lib/friends/post_install_message.rb
 - lib/friends/regex_builder.rb
+- lib/friends/sem_ver_comparator.rb
 - lib/friends/serializable.rb
 - lib/friends/tag_regex.rb
 - lib/friends/version.rb
 - test/add_event_helper.rb
 - test/commands/add/activity_spec.rb
+- test/commands/add/alias_spec.rb
 - test/commands/add/friend_spec.rb
 - test/commands/add/location_spec.rb
 - test/commands/add/nickname_spec.rb
@@ -198,6 +180,7 @@ files:
 - test/commands/list/locations_spec.rb
 - test/commands/list/notes_spec.rb
 - test/commands/list/tags_spec.rb
+- test/commands/remove/alias_spec.rb
 - test/commands/remove/nickname_spec.rb
 - test/commands/remove/tag_spec.rb
 - test/commands/rename/friend_spec.rb
@@ -224,20 +207,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.1'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Spend time with the people you care about.
 test_files:
 - test/add_event_helper.rb
 - test/commands/add/activity_spec.rb
+- test/commands/add/alias_spec.rb
 - test/commands/add/friend_spec.rb
 - test/commands/add/location_spec.rb
 - test/commands/add/nickname_spec.rb
@@ -254,6 +238,7 @@ test_files:
 - test/commands/list/locations_spec.rb
 - test/commands/list/notes_spec.rb
 - test/commands/list/tags_spec.rb
+- test/commands/remove/alias_spec.rb
 - test/commands/remove/nickname_spec.rb
 - test/commands/remove/tag_spec.rb
 - test/commands/rename/friend_spec.rb