friends 0.39 → 0.40

data/lib/friends/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Friends
-  VERSION = "0.39".freeze
+  VERSION = "0.40".freeze
 end

data/test/commands/graph_spec.rb

@@ -48,19 +48,19 @@ clean_describe "graph" do
 
     it "graphs all activities" do
       stdout_only <<-OUTPUT
-Nov 2014 |█
-Dec 2014 |█
-Jan 2015 |████
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |█
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |████
+Dec 2014 |█
+Nov 2014 |█
       OUTPUT
     end
 
@@ -88,19 +88,19 @@ Nov 2015 |█
         let(:location_name) { "paris" }
         it "matches location case-insensitively" do
           stdout_only <<-OUTPUT
-Nov 2014 |∙|
-Dec 2014 |█
-Jan 2015 |███∙|
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |∙|
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |███∙|
+Dec 2014 |█
+Nov 2014 |∙|
           OUTPUT
         end
       end
@@ -130,19 +130,19 @@ Nov 2015 |∙|
 
         it "matches friend case-insensitively" do
           stdout_only <<-OUTPUT
-Nov 2014 |█
-Dec 2014 |∙|
-Jan 2015 |█∙∙∙|
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |∙|
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |█∙∙∙|
+Dec 2014 |∙|
+Nov 2014 |█
           OUTPUT
         end
       end
@@ -154,19 +154,19 @@ Nov 2015 |∙|
 
         it "matches all friends case-insensitively" do
           stdout_only <<-OUTPUT
-Nov 2014 |∙|
-Dec 2014 |∙|
-Jan 2015 |█∙∙∙|
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |∙|
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |█∙∙∙|
+Dec 2014 |∙|
+Nov 2014 |∙|
           OUTPUT
         end
       end
@@ -177,19 +177,19 @@ Nov 2015 |∙|
 
       it "matches tag case-sensitively" do
         stdout_only <<-OUTPUT
-Nov 2014 |∙|
-Dec 2014 |█
-Jan 2015 |█∙∙∙|
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |█
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |█∙∙∙|
+Dec 2014 |█
+Nov 2014 |∙|
         OUTPUT
       end
 
@@ -200,19 +200,19 @@ Nov 2015 |█
 
         it "matches all tags case-sensitively" do
           stdout_only <<-OUTPUT
-Nov 2014 |∙|
-Dec 2014 |█
-Jan 2015 |∙∙∙∙|
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |∙|
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |∙∙∙∙|
+Dec 2014 |█
+Nov 2014 |∙|
           OUTPUT
         end
       end
@@ -223,17 +223,17 @@ Nov 2015 |∙|
 
       it "graphs activities on and after the specified date" do
         stdout_only <<-OUTPUT
-Jan 2015 |███
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |█
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |███
         OUTPUT
       end
     end
@@ -243,9 +243,9 @@ Nov 2015 |█
 
       it "graphs activities before and on the specified date" do
         stdout_only <<-OUTPUT
-Nov 2014 |█
-Dec 2014 |█
 Jan 2015 |███
+Dec 2014 |█
+Nov 2014 |█
         OUTPUT
       end
     end
@@ -257,17 +257,17 @@ Jan 2015 |███
         # If we just rounded to the month, there would be three unfiltered activities in
         # January displayed (due to the one on 1/5/2015). Instead, we correctly display two.
         stdout_only <<-OUTPUT
-Jan 2015 |█∙∙|
-Feb 2015 |
-Mar 2015 |
-Apr 2015 |
-May 2015 |
-Jun 2015 |
-Jul 2015 |
-Aug 2015 |
-Sep 2015 |
-Oct 2015 |
 Nov 2015 |█
+Oct 2015 |
+Sep 2015 |
+Aug 2015 |
+Jul 2015 |
+Jun 2015 |
+May 2015 |
+Apr 2015 |
+Mar 2015 |
+Feb 2015 |
+Jan 2015 |█∙∙|
         OUTPUT
       end
     end

data/test/commands/list/activities_spec.rb

@@ -36,27 +36,6 @@ clean_describe "list activities" do
       OUTPUT
     end
 
-    describe "--limit" do
-      subject { run_cmd("list activities --limit #{limit}") }
-
-      describe "when limit is less than 1" do
-        let(:limit) { 0 }
-        it "prints an error message" do
-          stderr_only "Error: Limit must be positive"
-        end
-      end
-
-      describe "when limit is 1 or greater" do
-        let(:limit) { 2 }
-        it "limits output to the number specified" do
-          stdout_only <<-OUTPUT
-2015-01-04: Got lunch with Grace Hopper and George Washington Carver. @food
-2015-11-01: Grace Hopper and I went to Marie's Diner. George had to cancel at the last minute. @food
-          OUTPUT
-        end
-      end
-    end
-
     describe "--in" do
       subject { run_cmd("list activities --in #{location_name}") }
 

data/test/commands/list/favorite/friends_spec.rb

@@ -109,53 +109,5 @@ FILE
         lines.last.must_include "3. Friend"
       end
     end
-
-    describe "--limit" do
-      subject { run_cmd("list favorite friends --limit #{limit}") }
-
-      describe "when limit is less than 1" do
-        let(:limit) { 0 }
-        it "prints an error message" do
-          stderr_only "Error: Favorites limit must be positive"
-        end
-      end
-
-      describe "when limit is 1" do
-        let(:limit) { 1 }
-
-        it "uses correct friend pluralization" do
-          stdout_only "Your favorite friend is Grace Hopper (3 activities)"
-        end
-
-        describe "when favorite friend only has one activity" do
-          let(:content) do
-            <<-FILE
-### Activities:
-- 2017-01-01: Did some math with **Grace Hopper**.
-
-### Friends:
-- George Washington Carver
-- Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Paris] @navy @science
-- Marie Curie [Atlantis] @science
-FILE
-          end
-
-          it "uses correct activity pluralization" do
-            stdout_only "Your favorite friend is Grace Hopper (1 activity)"
-          end
-        end
-      end
-
-      describe "when limit is greater than 1" do
-        let(:limit) { 2 }
-        it "limits output to the number specified" do
-          stdout_only <<-OUTPUT
-Your favorite friends:
-1. Grace Hopper             (3 activities)
-2. George Washington Carver (2)
-          OUTPUT
-        end
-      end
-    end
   end
 end

data/test/commands/list/favorite/locations_spec.rb

@@ -114,58 +114,5 @@ FILE
         lines.last.must_include "3. Location"
       end
     end
-
-    describe "--limit" do
-      subject { run_cmd("list favorite locations --limit #{limit}") }
-
-      describe "when limit is less than 1" do
-        let(:limit) { 0 }
-        it "prints an error message" do
-          stderr_only "Error: Favorites limit must be positive"
-        end
-      end
-
-      describe "when limit is 1" do
-        let(:limit) { 1 }
-
-        it "uses correct location pluralization" do
-          stdout_only "Your favorite location is Marie's Diner (2 activities)"
-        end
-
-        describe "when favorite location only has one activity" do
-          let(:content) do
-            <<-FILE
-### Activities:
-- 2017-01-01: Did some math with **Grace Hopper** at _Marie's Diner_.
-
-### Friends:
-- George Washington Carver
-- Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Paris] @navy @science
-- Marie Curie [Atlantis] @science
-
-### Locations:
-- Atlantis
-- Marie's Diner
-- Paris
-FILE
-          end
-
-          it "uses correct activity pluralization" do
-            stdout_only "Your favorite location is Marie's Diner (1 activity)"
-          end
-        end
-      end
-
-      describe "when limit is greater than 1" do
-        let(:limit) { 2 }
-        it "limits output to the number specified" do
-          stdout_only <<-OUTPUT
-Your favorite locations:
-1. Marie's Diner (2 activities)
-2. Paris         (1)
-          OUTPUT
-        end
-      end
-    end
   end
 end

data/test/commands/list/notes_spec.rb

@@ -35,27 +35,6 @@ clean_describe "list notes" do
       OUTPUT
     end
 
-    describe "--limit" do
-      subject { run_cmd("list notes --limit #{limit}") }
-
-      describe "when limit is less than 1" do
-        let(:limit) { 0 }
-        it "prints an error message" do
-          stderr_only "Error: Limit must be positive"
-        end
-      end
-
-      describe "when limit is 1 or greater" do
-        let(:limit) { 2 }
-        it "limits output to the number specified" do
-          stdout_only <<-OUTPUT
-2015-01-04: Grace Hopper and George Washington Carver both won an award.
-2015-06-06: Marie Curie just got accepted into a PhD program in Paris. @school
-          OUTPUT
-        end
-      end
-    end
-
     describe "--in" do
       subject { run_cmd("list notes --in #{location_name}") }
 

data/test/paging_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "paging" do
+  subject { run_cmd("stats", env_vars: env_vars) }
+
+  let(:content) { nil }
+  let(:expected_output) do
+    <<-OUTPUT
+Total activities: 0
+Total friends: 0
+Total locations: 0
+Total notes: 0
+Total tags: 0
+Total time elapsed: 0 days
+    OUTPUT
+  end
+
+  describe "when using the default pager" do
+    let(:env_vars) { "" }
+    it { stdout_only expected_output }
+  end
+
+  describe "when using a custom pager" do
+    let(:env_vars) { "FRIENDS_PAGER='head -n 3 | tail -n 2'" }
+    it { stdout_only expected_output.split("\n").take(3).drop(1).join("\n") }
+  end
+
+  describe "when using a nonexistent pager" do
+    let(:env_vars) { "FRIENDS_PAGER=garbage" }
+    it { stdout_only expected_output }
+  end
+end