friends 0.28 → 0.29

data/test/commands/rename/friend_spec.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "rename friend" do
+  subject { run_cmd("rename friend #{old_name} #{new_name}") }
+
+  let(:content) { CONTENT }
+  let(:new_name) { "'George Washington'" }
+
+  describe "when friend name has no matches" do
+    let(:old_name) { "Garbage" }
+    it "prints an error message" do
+      stderr_only 'Error: No friend found for "Garbage"'
+    end
+  end
+
+  describe "when friend name has more than one match" do
+    let(:old_name) { "George" }
+    before { run_cmd("add friend George Harrison") }
+
+    it "prints an error message" do
+      stderr_only 'Error: More than one friend found for "George": '\
+                  "George Harrison, George Washington Carver"
+    end
+  end
+
+  describe "when friend name has one match" do
+    let(:old_name) { "George" }
+
+    it "renames friend" do
+      line_changed "- George Washington Carver", "- George Washington"
+    end
+
+    it "updates friend name in activities" do
+      run_cmd("list activities")[:stdout].must_equal <<-FILE
+2015-11-01: Grace Hopper and I went to Marie's Diner. George had to cancel at the last minute. @food
+2015-01-04: Got lunch with Grace Hopper and George Washington Carver. @food
+2014-12-31: Celebrated the new year in Paris with Marie Curie. @partying
+2014-11-15: Talked to George Washington Carver on the phone for an hour.
+      FILE
+      subject
+      run_cmd("list activities")[:stdout].must_equal <<-FILE
+2015-11-01: Grace Hopper and I went to Marie's Diner. George had to cancel at the last minute. @food
+2015-01-04: Got lunch with Grace Hopper and George Washington. @food
+2014-12-31: Celebrated the new year in Paris with Marie Curie. @partying
+2014-11-15: Talked to George Washington on the phone for an hour.
+      FILE
+    end
+
+    it "prints an output message" do
+      stdout_only 'Name changed: "George Washington"'
+    end
+  end
+end

data/test/commands/rename/location_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "rename location" do
+  subject { run_cmd("rename location #{old_name} #{new_name}") }
+
+  let(:content) { CONTENT }
+  let(:new_name) { "'Ville Lumière'" }
+
+  describe "when location name has no matches" do
+    let(:old_name) { "Garbage" }
+    it "prints an error message" do
+      stderr_only 'Error: No location found for "Garbage"'
+    end
+  end
+
+  describe "when location name has one match" do
+    let(:old_name) { "Paris" }
+
+    it "renames location" do
+      line_changed("- Paris", "- Ville Lumière")
+    end
+
+    it "updates location name in activities" do
+      line_changed(
+        "- 2014-12-31: Celebrated the new year in _Paris_ with **Marie Curie**. @partying",
+        "- 2014-12-31: Celebrated the new year in _Ville Lumière_ with **Marie Curie**. @partying"
+      )
+    end
+
+    it "updates location name for friends" do
+      line_changed(
+        "- Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Paris] @navy @science",
+        "- Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Ville Lumière] @navy @science"
+      )
+    end
+
+    it "prints an output message" do
+      stdout_only 'Location renamed: "Ville Lumière"'
+    end
+  end
+end

data/test/commands/set/location_spec.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "set location" do
+  subject { run_cmd("set location #{friend_name} #{location_name}") }
+  let(:content) { CONTENT }
+
+  describe "when friend does not exist" do
+    let(:friend_name) { "Garbage" }
+    let(:location_name) { "Paris" }
+
+    it "prints an error message" do
+      stderr_only 'Error: No friend found for "Garbage"'
+    end
+  end
+
+  describe "when location does not exist" do
+    let(:friend_name) { "Marie" }
+    let(:location_name) { "Garbage" }
+
+    it "prints an error message" do
+      stderr_only 'Error: No location found for "Garbage"'
+    end
+  end
+
+  describe "when friend and location exist" do
+    let(:location_name) { "Paris" }
+
+    describe "when friend already has a location" do
+      let(:friend_name) { "Marie" }
+
+      it "prints correct output" do
+        stdout_only "Marie Curie's location set to: Paris"
+      end
+
+      it "updates existing location" do
+        line_changed "- Marie Curie [Atlantis] @science", "- Marie Curie [Paris] @science"
+      end
+    end
+
+    describe "when friend has no location" do
+      let(:friend_name) { "George" }
+
+      it "prints correct output" do
+        stdout_only "George Washington Carver's location set to: Paris"
+      end
+
+      it "adds a location" do
+        line_changed "- George Washington Carver", "- George Washington Carver [Paris]"
+      end
+    end
+  end
+end

data/test/commands/stats_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "stats" do
+  subject { run_cmd("stats") }
+
+  describe "when file does not exist" do
+    it "returns the stats" do
+      stdout_only <<-FILE
+Total activities: 0
+Total friends: 0
+Total time elapsed: 0 days
+      FILE
+    end
+  end
+
+  describe "when the file is empty" do
+    let(:content) { "" }
+
+    it "returns the stats" do
+      stdout_only <<-FILE
+Total activities: 0
+Total friends: 0
+Total time elapsed: 0 days
+      FILE
+    end
+  end
+
+  describe "when file has stats" do
+    let(:content) { CONTENT }
+
+    it "returns the content" do
+      stdout_only <<-FILE
+Total activities: 4
+Total friends: 3
+Total time elapsed: 351 days
+      FILE
+    end
+  end
+end

data/test/commands/suggest_spec.rb

@@ -0,0 +1,86 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "suggest" do
+  subject { run_cmd("suggest") }
+
+  describe "when file does not exist" do
+    it "prints a no-data message" do
+      stdout_only <<-FILE
+Distant friend: None found
+Moderate friend: None found
+Close friend: None found
+      FILE
+    end
+  end
+
+  describe "when the file is empty" do
+    let(:content) { "" }
+
+    it "prints a no-data message" do
+      stdout_only <<-FILE
+Distant friend: None found
+Moderate friend: None found
+Close friend: None found
+      FILE
+    end
+  end
+
+  describe "when file has content" do
+    let(:content) do
+      <<-FILE
+### Activities:
+- 2017-03-01: Met up with **George Washington Carver**.
+- 2017-02-01: Met up with **George Washington Carver**.
+- 2017-01-01: Met up with **George Washington Carver**.
+- 2016-12-01: Met up with **Grace Hopper**.
+- 2016-11-01: Met up with **Grace Hopper**.
+- 2016-10-01: Met up with **Grace Hopper**.
+- 2016-09-01: Met up with **Grace Hopper**.
+- 2016-08-01: Met up with **Grace Hopper**.
+- 2016-07-01: Met up with **Grace Hopper**.
+- 2016-06-01: Met up with **Grace Hopper**.
+- 2016-05-01: Met up with **Grace Hopper**.
+- 2016-04-01: Met up with **Grace Hopper**.
+- 2016-03-01: Met up with **Grace Hopper**.
+- 2016-02-01: Met up with **Grace Hopper**.
+- 2016-01-01: Met up with **Grace Hopper**.
+- 2015-11-01: **Grace Hopper** and I went to _Marie's Diner_. George had to cancel at the last minute. @food
+- 2015-01-04: Got lunch with **Grace Hopper** and **George Washington Carver**. @food
+- 2014-12-31: Celebrated the new year in _Paris_ with **Marie Curie**. @partying
+- 2014-11-15: Talked to **George Washington Carver** on the phone for an hour.
+
+### Friends:
+- George Washington Carver
+- Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Paris] @navy @science
+- Marie Curie [Atlantis] @science
+
+### Locations:
+- Atlantis
+- Marie's Diner
+- Paris
+FILE
+    end
+
+    it "prints suggested friends" do
+      stdout_only <<-FILE
+Distant friend: Marie Curie
+Moderate friend: George Washington Carver
+Close friend: Grace Hopper
+      FILE
+    end
+
+    describe "--in" do
+      subject { run_cmd("suggest --in Paris") }
+
+      it "prints suggested friends" do
+        stdout_only <<-FILE
+Distant friend: None found
+Moderate friend: None found
+Close friend: Grace Hopper
+        FILE
+      end
+    end
+  end
+end

data/test/commands/update_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require "./test/helper"
+
+clean_describe "update" do
+  subject { run_cmd("update") }
+
+  it "prints a status message" do
+    subject[:stderr].must_equal ""
+    subject[:status].must_equal 0
+    [/Updated to friends/, /Already up-to-date/].one? { |m| subject[:stdout] =~ m }.must_equal true
+  end
+end

data/test/helper.rb

@@ -3,7 +3,121 @@
 require "codeclimate-test-reporter"
 CodeClimate::TestReporter.start
 
+ENV["MT_HELL"] = "1" # Forces tests to have at least one assertion to pass.
+
 require "minitest/autorun"
+require "minitest/parallel_fork"
 require "minitest/pride"
+require "minitest/hell"
+require "open3"
+require "securerandom"
 
 require "friends"
+
+CONTENT = <<-FILE
+### Activities:
+- 2015-11-01: **Grace Hopper** and I went to _Marie's Diner_. George had to cancel at the last minute. @food
+- 2015-01-04: Got lunch with **Grace Hopper** and **George Washington Carver**. @food
+- 2014-12-31: Celebrated the new year in _Paris_ with **Marie Curie**. @partying
+- 2014-11-15: Talked to **George Washington Carver** on the phone for an hour.
+
+### Friends:
+- George Washington Carver
+- Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Paris] @navy @science
+- Marie Curie [Atlantis] @science
+
+### Locations:
+- Atlantis
+- Marie's Diner
+- Paris
+FILE
+
+# This is CONTENT but with activities, friends, and locations unsorted.
+SCRAMBLED_CONTENT = <<-FILE
+### Activities:
+- 2015-01-04: Got lunch with **Grace Hopper** and **George Washington Carver**. @food
+- 2015-11-01: **Grace Hopper** and I went to _Marie's Diner_. George had to cancel at the last minute. @food
+- 2014-11-15: Talked to **George Washington Carver** on the phone for an hour.
+- 2014-12-31: Celebrated the new year in _Paris_ with **Marie Curie**. @partying
+
+### Friends:
+- George Washington Carver
+- Marie Curie [Atlantis] @science
+- Grace Hopper (a.k.a. The Admiral a.k.a. Amazing Grace) [Paris] @navy @science
+
+### Locations:
+- Paris
+- Atlantis
+- Marie's Diner
+FILE
+
+# Define these methods so they can be referenced in the methods below. They'll be overridden in
+# test files.
+def filename; end
+
+def subject; end
+
+def run_cmd(command, **args)
+  stdout, stderr, status = Open3.capture3(
+    "bundle exec bin/friends --colorless --filename #{filename} #{command}",
+    **args
+  )
+  {
+    stdout: stdout,
+    stderr: stderr,
+    status: status.exitstatus
+  }
+end
+
+# @param str [String] a string
+# @return [String] the input string with a newline appended to it if one was not already
+#   present, *unless* the string is empty
+def ensure_trailing_newline_unless_empty(str)
+  return "" if str.empty?
+
+  str.to_s[-1] == "\n" ? str.to_s : "#{str}\n"
+end
+
+def stdout_only(expected)
+  subject[:stdout].must_equal ensure_trailing_newline_unless_empty(expected)
+  subject[:stderr].must_equal ""
+  subject[:status].must_equal 0
+end
+
+def stderr_only(expected)
+  subject[:stdout].must_equal ""
+  subject[:stderr].must_equal ensure_trailing_newline_unless_empty(expected)
+  subject[:status].must_be :>, 0
+end
+
+def file_equals(expected)
+  subject
+  File.read(filename).must_equal expected
+end
+
+def line_changed(expected_old, expected_new)
+  index = File.read(filename).split("\n").index(expected_old)
+  index.must_be_kind_of Numeric # Not nil, so we know that `expected_old` was found.
+  subject
+  File.read(filename).split("\n")[index].must_equal expected_new
+end
+
+def line_added(expected)
+  n_initial_lines = File.read(filename).split("\n").size
+  subject
+  lines = File.read(filename).split("\n")
+  lines.index(expected).must_be_kind_of Numeric # Not nil, so we know that `expected` was found.
+  lines.size.must_equal(n_initial_lines + 1) # Line was added, not changed.
+end
+
+def clean_describe(desc, *additional_desc, &block)
+  describe desc, *additional_desc do
+    let(:filename) { "test/tmp/friends#{SecureRandom.uuid}.md" }
+    let(:content) { nil }
+
+    before { File.write(filename, content) unless content.nil? }
+    after { File.delete(filename) if File.exist?(filename) }
+
+    class_eval(&block)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: friends
 version: !ruby/object:Gem::Version
-  version: '0.28'
+  version: '0.29'
 platform: ruby
 authors:
 - Jacob Evelyn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-25 00:00:00.000000000 Z
+date: 2017-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chronic
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.15'
 - !ruby/object:Gem::Dependency
   name: paint
   requirement: !ruby/object:Gem::Requirement
@@ -122,6 +122,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.5'
+- !ruby/object:Gem::Dependency
+  name: minitest-parallel_fork
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: minitest-proveit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: overcommit
   requirement: !ruby/object:Gem::Requirement
@@ -191,6 +219,17 @@ files:
 - friends.md
 - lib/friends.rb
 - lib/friends/activity.rb
+- lib/friends/commands/add.rb
+- lib/friends/commands/clean.rb
+- lib/friends/commands/edit.rb
+- lib/friends/commands/graph.rb
+- lib/friends/commands/list.rb
+- lib/friends/commands/remove.rb
+- lib/friends/commands/rename.rb
+- lib/friends/commands/set.rb
+- lib/friends/commands/stats.rb
+- lib/friends/commands/suggest.rb
+- lib/friends/commands/update.rb
 - lib/friends/friend.rb
 - lib/friends/friends_error.rb
 - lib/friends/graph.rb
@@ -199,12 +238,29 @@ files:
 - lib/friends/regex_builder.rb
 - lib/friends/serializable.rb
 - lib/friends/version.rb
-- test/activity_spec.rb
-- test/friend_spec.rb
-- test/graph_spec.rb
+- test/commands/add/activity_spec.rb
+- test/commands/add/friend_spec.rb
+- test/commands/add/location_spec.rb
+- test/commands/add/nickname_spec.rb
+- test/commands/add/tag_spec.rb
+- test/commands/clean_spec.rb
+- test/commands/graph_spec.rb
+- test/commands/help_spec.rb
+- test/commands/list/activities_spec.rb
+- test/commands/list/favorite/friends_spec.rb
+- test/commands/list/favorite/locations_spec.rb
+- test/commands/list/friends_spec.rb
+- test/commands/list/locations_spec.rb
+- test/commands/list/tags_spec.rb
+- test/commands/remove/nickname_spec.rb
+- test/commands/remove/tag_spec.rb
+- test/commands/rename/friend_spec.rb
+- test/commands/rename/location_spec.rb
+- test/commands/set/location_spec.rb
+- test/commands/stats_spec.rb
+- test/commands/suggest_spec.rb
+- test/commands/update_spec.rb
 - test/helper.rb
-- test/introvert_spec.rb
-- test/location_spec.rb
 - test/tmp/.keep
 homepage: https://github.com/JacobEvelyn/friends
 licenses:
@@ -226,15 +282,33 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Spend time with the people you care about.
 test_files:
-- test/activity_spec.rb
-- test/friend_spec.rb
-- test/graph_spec.rb
+- test/commands/add/activity_spec.rb
+- test/commands/add/friend_spec.rb
+- test/commands/add/location_spec.rb
+- test/commands/add/nickname_spec.rb
+- test/commands/add/tag_spec.rb
+- test/commands/clean_spec.rb
+- test/commands/graph_spec.rb
+- test/commands/help_spec.rb
+- test/commands/list/activities_spec.rb
+- test/commands/list/favorite/friends_spec.rb
+- test/commands/list/favorite/locations_spec.rb
+- test/commands/list/friends_spec.rb
+- test/commands/list/locations_spec.rb
+- test/commands/list/tags_spec.rb
+- test/commands/remove/nickname_spec.rb
+- test/commands/remove/tag_spec.rb
+- test/commands/rename/friend_spec.rb
+- test/commands/rename/location_spec.rb
+- test/commands/set/location_spec.rb
+- test/commands/stats_spec.rb
+- test/commands/suggest_spec.rb
+- test/commands/update_spec.rb
 - test/helper.rb
-- test/introvert_spec.rb
-- test/location_spec.rb
 - test/tmp/.keep
+has_rdoc: