friendly_shipping 0.4.13 → 0.4.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1003d74ec50b026b72f4aee61e1c3ebfbdda0e99740ec0f766cb4c64a9333ad3
-  data.tar.gz: 72bb7de71cde4aae5d7b202fbf56dc2d8b2e31f04c2950d5bc17b8405d45139b
+  metadata.gz: d43e668240fd5d6edb702b48b28e7a886abf53843f3963feb44fcff17a7f498a
+  data.tar.gz: 84e4efa1108768940d25493ba816197879c5dd9ad51ce64d5c1f5be8d2f5c92f
 SHA512:
-  metadata.gz: 6a3feda8a0cc788d23318d61c9a90f9628ea1323f2e9a4208f23376f7efb768c6b732c9d6af462c18763a261ec22fc0ebe75bcdefe0656e7a9fbe38750a0ea92
-  data.tar.gz: 01042d8c994b18598ea9acfa4ce20a4c11190beeb43bf342a72d25d76040be65bddb2883a2e3d240c3502811cc89bfeb620ed397e681c05d7ab5efb89e3ce533
+  metadata.gz: d0f0c826feea1c9f9396785049f07c7635f7be2386619d3b3c217339da7f363e43842a2b3eceef2204556868be082b01f76cc96dc36b4849649cd09baa924a79
+  data.tar.gz: 0c56d00886b43ac1d4a272c36d7dd90b3eb791315dcedcd689fe95450a6f23e0c76fb9d1e7c2c26f7a146bb418e27296c5911bcee6e698de287b53427926c05c

data/CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.14] - 2020-01-21
+
+### Changed
+- Code Style: Move development dependencies to Gemspec (#76)
+- USPS Service: Fix documentation (#76)
+- USPS Service: Use "Acceptance Date" if "Effective Acceptance Date" invalid (#79)
+
 ## [0.4.13] - 2020-01-18
 
 ### Changed

data/Gemfile

@@ -6,12 +6,3 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in friendly_shipping.gemspec
 gemspec
-
-gem 'dotenv'
-gem 'factory_bot'
-gem 'pry'
-gem 'rspec_junit_formatter'
-gem 'rubocop'
-gem 'simplecov', require: false
-gem 'vcr'
-gem 'webmock'

data/friendly_shipping.gemspec

@@ -31,6 +31,14 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.4'
 
   spec.add_development_dependency "bundler"
+  spec.add_development_dependency "dotenv"
+  spec.add_development_dependency "factory_bot", "~> 5.0"
+  spec.add_development_dependency "pry"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rspec_junit_formatter", "~> 0.4"
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "vcr"
+  spec.add_development_dependency "webmock"
 end

data/lib/friendly_shipping/services/usps/parse_time_in_transit_response.rb

@@ -37,7 +37,11 @@ module FriendlyShipping
             return [] if expedited_commitment_nodes.empty?
 
             # All Expedited Commitments have the same acceptance date
-            effective_acceptance_date = Time.parse(expedited_commitment_nodes.at('EAD').text)
+            # However, sometimes that date is invalid.
+            effective_acceptance_date = [
+              Time.parse(expedited_commitment_nodes.at('EAD').text),
+              Time.parse(expedited_commitment_nodes.document.at('AcceptDate').text)
+            ].max
             expedited_commitment_nodes.xpath('Commitment').map do |commitment_node|
               shipping_method = SHIPPING_METHODS.detect do |potential_shipping_method|
                 potential_shipping_method.name == MAIL_CLASSES[commitment_node.at('MailClass').text]

data/lib/friendly_shipping/services/usps/serialize_rate_request.rb

@@ -10,10 +10,10 @@ module FriendlyShipping
 
         class << self
           # @param [Physical::Shipment] shipment The shipment we want to get rates for
-          #   shipment.packages[0].properties[:box_code] Can be :rectangular, :variable,
+          #   shipment.packages[0].properties[:box_name] Can be :rectangular, :variable,
           #     or a flat rate container defined in CONTAINERS.
           # @param [String] login The USPS login code
-          # @param [FriendlyShipping::ShippingMethod] service The shipping methods we want to get rates
+          # @param [FriendlyShipping::ShippingMethod] shipping_method The shipping method we want to get rates
           #   for. If empty, we get all of them
           # @return Array<[FriendlyShipping::Rate]> A set of Rates that this package may be sent with
           def call(shipment:, login:, shipping_method: nil)

data/lib/friendly_shipping/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FriendlyShipping
-  VERSION = "0.4.13"
+  VERSION = "0.4.14"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: friendly_shipping
 version: !ruby/object:Gem::Version
-  version: 0.4.13
+  version: 0.4.14
 platform: ruby
 authors:
 - Martin Meyerhoff
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-18 00:00:00.000000000 Z
+date: 2020-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: data_uri
@@ -108,6 +108,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: dotenv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +178,76 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Allows you to quote or ship a Physical::Shipment object
 email:
 - mamhoff@gmail.com