friendly_id4 4.0.0.beta1

data/test/history_test.rb

@@ -0,0 +1,46 @@
+require File.expand_path("../helper.rb", __FILE__)
+
+class Manual < ActiveRecord::Base
+  include FriendlyId::History
+  has_friendly_id :name
+end
+
+class HistoryTest < MiniTest::Unit::TestCase
+
+  include FriendlyId::Test
+  include FriendlyId::Test::Shared
+
+  def klass
+    Manual
+  end
+
+  test "should insert record in slugs table on create" do
+    with_instance_of(klass) {|record| assert !record.friendly_id_slugs.empty?}
+  end
+
+  test "should not create new slug record if friendly_id is not changed" do
+    with_instance_of(klass) do |record|
+      record.active = true
+      record.save!
+      assert_equal 1, FriendlyIdSlug.count
+    end
+  end
+
+  test "should create new slug record when friendly_id changes" do
+    with_instance_of(klass) do |record|
+      record.name = record.name + "b"
+      record.save!
+      assert_equal 2, FriendlyIdSlug.count
+    end
+  end
+
+  test "should be findable by old slugs" do
+    with_instance_of(klass) do |record|
+      old_friendly_id = record.friendly_id
+      record.name = record.name + "b"
+      record.save!
+      assert found = klass.find_by_friendly_id(old_friendly_id)
+      assert !found.readonly?
+    end
+  end
+end

data/test/object_utils_test.rb

@@ -0,0 +1,26 @@
+require File.expand_path("../helper.rb", __FILE__)
+
+
+class ObjectUtilsTest < MiniTest::Unit::TestCase
+
+  include FriendlyId::Test
+
+  test "strings with letters are friendly_ids" do
+    assert "a".friendly_id?
+  end
+
+  test "integers should be unfriendly ids" do
+    assert 1.unfriendly_id?
+  end
+
+  test "numeric strings are neither friendly nor unfriendly" do
+    assert_equal nil, "1".friendly_id?
+    assert_equal nil, "1".unfriendly_id?
+  end
+
+  test "ActiveRecord::Base instances should be unfriendly_ids" do
+    klass = Class.new(ActiveRecord::Base)
+    klass.table_name = "authors"
+    assert klass.new.unfriendly_id?
+  end
+end

data/test/schema.rb

@@ -0,0 +1,53 @@
+require "friendly_id/migration"
+
+module FriendlyId
+  module Test
+    class Schema < ActiveRecord::Migration
+      class << self
+        def down
+          CreateFriendlyIdSlugs.down
+          tables.each do |name|
+            drop_table name
+          end
+        end
+
+        def up
+          CreateFriendlyIdSlugs.up
+
+          tables.each do |table_name|
+            create_table table_name do |t|
+              t.string  :name
+              t.boolean :active
+            end
+          end
+
+          slugged_tables.each do |table_name|
+            add_column table_name, :slug, :string
+            add_index  table_name, :slug, :unique => true
+          end
+
+          # This will be used to test scopes
+          add_column :novels, :novelist_id, :integer
+          remove_index :novels, :slug
+
+          # This will be used to test column name quoting
+          add_column :journalists, "strange name", :string
+        end
+
+        private
+
+        def slugged_tables
+          ["journalists", "articles", "novelists", "novels", "manuals"]
+        end
+
+        def simple_tables
+          ["authors", "books"]
+        end
+
+        def tables
+          simple_tables + slugged_tables
+        end
+      end
+    end
+  end
+end

data/test/scoped_test.rb

@@ -0,0 +1,49 @@
+require File.expand_path("../helper", __FILE__)
+
+class Novelist < ActiveRecord::Base
+  include FriendlyId::Slugged
+  has_friendly_id :name
+end
+
+class Novel < ActiveRecord::Base
+  include FriendlyId::Scoped
+  belongs_to :novelist
+  has_friendly_id :name, :scope => :novelist
+end
+
+class ScopedTest < MiniTest::Unit::TestCase
+
+  include FriendlyId::Test
+  include FriendlyId::Test::Shared
+
+  def klass
+    Novel
+  end
+
+  test "should detect scope column from belongs_to relation" do
+    assert_equal "novelist_id", Novel.friendly_id_config.scope_column
+  end
+
+  test "should detect scope column from explicit column name" do
+    klass = Class.new(ActiveRecord::Base)
+    klass.has_friendly_id :empty, :scope => :dummy
+    assert_equal "dummy", klass.friendly_id_config.scope_column
+  end
+
+  test "should allow duplicate slugs outside scope" do
+    transaction do
+      novel1 = Novel.create! :name => "a", :novelist => Novelist.create!(:name => "a")
+      novel2 = Novel.create! :name => "a", :novelist => Novelist.create!(:name => "b")
+      assert_equal novel1.friendly_id, novel2.friendly_id
+    end
+  end
+
+  test "should not allow duplicate slugs inside scope" do
+    with_instance_of Novelist do |novelist|
+      novel1 = Novel.create! :name => "a", :novelist => novelist
+      novel2 = Novel.create! :name => "a", :novelist => novelist
+      assert novel1.friendly_id != novel2.friendly_id
+    end
+  end
+
+end

data/test/shared.rb

@@ -0,0 +1,76 @@
+module FriendlyId
+  module Test
+    module Shared
+
+      test "finds should respect conditions" do
+        with_instance_of(klass) do |record|
+          assert_raises(ActiveRecord::RecordNotFound) do
+            klass.where("1 = 2").find record.friendly_id
+          end
+        end
+      end
+
+      test "should be findable by friendly id" do
+        with_instance_of(klass) {|record| assert klass.find record.friendly_id}
+      end
+
+      test "should be findable by id as integer" do
+        with_instance_of(klass) {|record| assert klass.find record.id.to_i}
+      end
+
+      test "should be findable by id as string" do
+        with_instance_of(klass) {|record| assert klass.find record.id.to_s}
+      end
+
+      test "should be findable by numeric friendly_id" do
+        with_instance_of(klass, :name => "206") {|record| assert klass.find record.friendly_id}
+      end
+
+      test "to_param should return the friendly_id" do
+        with_instance_of(klass) {|record| assert_equal record.friendly_id, record.to_param}
+      end
+
+      test "should be findable by themselves" do
+        with_instance_of(klass) {|record| assert_equal record, klass.find(record)}
+      end
+
+      test "updating record's other values should not change the friendly_id" do
+        with_instance_of klass do |record|
+          old = record.friendly_id
+          record.update_attributes! :active => false
+          assert klass.find old
+        end
+      end
+
+      test "instances found by a single id should not be read-only" do
+        with_instance_of(klass) {|record| assert !klass.find(record.friendly_id).readonly?}
+      end
+
+      test "failing finds with unfriendly_id should raise errors normally" do
+        assert_raises(ActiveRecord::RecordNotFound) {klass.find 0}
+      end
+
+      test "should return numeric id if the friendly_id is nil" do
+        with_instance_of(klass) do |record|
+          record.expects(:friendly_id).returns(nil)
+          assert_equal record.id.to_s, record.to_param
+        end
+      end
+
+      test "should return numeric id if the friendly_id is an empty string" do
+        with_instance_of(klass) do |record|
+          record.expects(:friendly_id).returns("")
+          assert_equal record.id.to_s, record.to_param
+        end
+      end
+
+      test "should return numeric id if the friendly_id is blank" do
+        with_instance_of(klass) do |record|
+          record.expects(:friendly_id).returns("  ")
+          assert_equal record.id.to_s, record.to_param
+        end
+      end
+    end
+  end
+end
+

data/test/slugged_test.rb

@@ -0,0 +1,111 @@
+require File.expand_path("../helper.rb", __FILE__)
+
+Journalist, Article = 2.times.map do
+  Class.new(ActiveRecord::Base) do
+    include FriendlyId::Slugged
+    has_friendly_id :name
+  end
+end
+
+class SluggedTest < MiniTest::Unit::TestCase
+
+  include FriendlyId::Test
+  include FriendlyId::Test::Shared
+
+  def klass
+    Journalist
+  end
+
+  test "configuration should have a sequence_separator" do
+    assert !klass.friendly_id_config.sequence_separator.empty?
+  end
+
+  test "should make a new slug if the friendly_id method value has changed" do
+    with_instance_of klass do |record|
+      record.name = "Changed Value"
+      record.save!
+      assert_equal "changed-value", record.slug
+    end
+  end
+
+  test "should increment the slug sequence for duplicate friendly ids" do
+    with_instance_of klass do |record|
+      record2 = klass.create! :name => record.name
+      assert record2.friendly_id.match(/2\z/)
+    end
+  end
+
+  test "should not add slug sequence on update after other conflicting slugs were added" do
+    with_instance_of klass do |record|
+      old = record.friendly_id
+      record2 = klass.create! :name => record.name
+      record.save!
+      record.reload
+      assert_equal old, record.to_param
+    end
+  end
+end
+
+class SlugSequencerTest < MiniTest::Unit::TestCase
+
+  include FriendlyId::Test
+
+  test "should quote column names" do
+    klass            = Class.new(ActiveRecord::Base)
+    klass.table_name = "journalists"
+    klass.send :include, FriendlyId::Slugged
+    klass.has_friendly_id :name, :slug_column => "strange name"
+    begin
+      with_instance_of(klass) {|record| assert klass.find(record.friendly_id)}
+    rescue ActiveRecord::StatementInvalid
+      flunk "column name was not quoted"
+    end
+  end
+end
+
+class SlugSeparatorTest < MiniTest::Unit::TestCase
+
+  include FriendlyId::Test
+
+  class Journalist < ActiveRecord::Base
+    include FriendlyId::Slugged
+    has_friendly_id :name, :sequence_separator => ":"
+  end
+
+  def klass
+    Journalist
+  end
+
+  test "should increment sequence with configured sequence separator" do
+    with_instance_of klass do |record|
+      record2 = klass.create! :name => record.name
+      assert record2.friendly_id.match(/:2\z/)
+    end
+  end
+
+  test "should detect when a sequenced slug has changed" do
+    with_instance_of klass do |record|
+      record2 = klass.create! :name => record.name
+      assert !record2.slug_sequencer.slug_changed?
+      record2.name = "hello world"
+      assert record2.slug_sequencer.slug_changed?
+    end
+  end
+end
+
+class SluggedRegressionsTest < MiniTest::Unit::TestCase
+  include FriendlyId::Test
+
+  def klass
+    Journalist
+  end
+
+  test "should increment the slug sequence for duplicate friendly ids beyond 10" do
+    with_instance_of klass do |record|
+      (2..12).each do |i|
+        r = klass.create! :name => record.name
+        assert r.friendly_id.match(/#{i}\z/)
+      end
+    end
+  end
+end

metadata

@@ -0,0 +1,163 @@
+--- !ruby/object:Gem::Specification 
+name: friendly_id4
+version: !ruby/object:Gem::Version 
+  prerelease: 6
+  version: 4.0.0.beta1
+platform: ruby
+authors: 
+- Norman Clarke
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2011-07-14 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: activerecord
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: "3.0"
+  type: :development
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: sqlite3
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: "1.3"
+  type: :development
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: cutest
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 1.1.2
+  type: :development
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: ffaker
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: maruku
+  prerelease: false
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :development
+  version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: yard
+  prerelease: false
+  requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :development
+  version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: mocha
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :development
+  version_requirements: *id007
+description: "    FriendlyId is the \"Swiss Army bulldozer\" of slugging and permalink plugins\n    for Ruby on Rails. It allows you to create pretty URL's and work with\n    human-friendly strings as if they were numeric ids for ActiveRecord models.\n"
+email: 
+- norman@njclarke.com
+executables: []
+
+extensions: []
+
+extra_rdoc_files: []
+
+files: 
+- .gitignore
+- Gemfile
+- Guide.md
+- README.md
+- Rakefile
+- WhatsNew.md
+- bench.rb
+- friendly_id.gemspec
+- lib/friendly_id.rb
+- lib/friendly_id/base.rb
+- lib/friendly_id/configuration.rb
+- lib/friendly_id/finder_methods.rb
+- lib/friendly_id/history.rb
+- lib/friendly_id/migration.rb
+- lib/friendly_id/model.rb
+- lib/friendly_id/object_utils.rb
+- lib/friendly_id/scoped.rb
+- lib/friendly_id/slug.rb
+- lib/friendly_id/slug_sequencer.rb
+- lib/friendly_id/slugged.rb
+- lib/friendly_id/version.rb
+- lib/generators/friendly_id_generator.rb
+- test/config/mysql.yml
+- test/config/postgres.yml
+- test/config/sqlite3.yml
+- test/core_test.rb
+- test/helper.rb
+- test/history_test.rb
+- test/object_utils_test.rb
+- test/schema.rb
+- test/scoped_test.rb
+- test/shared.rb
+- test/slugged_test.rb
+homepage: http://norman.github.com/friendly_id
+licenses: []
+
+post_install_message: 
+rdoc_options: []
+
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">"
+    - !ruby/object:Gem::Version 
+      version: 1.3.1
+requirements: []
+
+rubyforge_project: friendly_id
+rubygems_version: 1.8.5
+signing_key: 
+specification_version: 3
+summary: A comprehensive slugging and pretty-URL plugin.
+test_files: []
+