friendly_id 5.4.0 → 5.5.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (65) hide show
  1. checksums.yaml +4 -4
  2. checksums.yaml.gz.sig +0 -0
  3. data/.github/FUNDING.yml +1 -0
  4. data/.github/dependabot.yml +6 -0
  5. data/.github/stale.yml +1 -1
  6. data/.github/workflows/test.yml +38 -36
  7. data/.yardopts +2 -0
  8. data/Changelog.md +19 -0
  9. data/Gemfile +9 -13
  10. data/README.md +31 -8
  11. data/Rakefile +24 -27
  12. data/bench.rb +30 -27
  13. data/certs/parndt.pem +25 -23
  14. data/friendly_id.gemspec +26 -29
  15. data/gemfiles/Gemfile.rails-5.2.rb +11 -16
  16. data/gemfiles/Gemfile.rails-6.0.rb +11 -16
  17. data/gemfiles/Gemfile.rails-6.1.rb +22 -0
  18. data/gemfiles/Gemfile.rails-7.0.rb +22 -0
  19. data/guide.rb +13 -6
  20. data/lib/friendly_id/base.rb +59 -60
  21. data/lib/friendly_id/candidates.rb +9 -11
  22. data/lib/friendly_id/configuration.rb +6 -7
  23. data/lib/friendly_id/finder_methods.rb +63 -15
  24. data/lib/friendly_id/finders.rb +66 -66
  25. data/lib/friendly_id/history.rb +62 -63
  26. data/lib/friendly_id/initializer.rb +4 -4
  27. data/lib/friendly_id/migration.rb +6 -6
  28. data/lib/friendly_id/object_utils.rb +2 -2
  29. data/lib/friendly_id/reserved.rb +30 -32
  30. data/lib/friendly_id/scoped.rb +99 -102
  31. data/lib/friendly_id/sequentially_slugged/calculator.rb +69 -0
  32. data/lib/friendly_id/sequentially_slugged.rb +17 -64
  33. data/lib/friendly_id/simple_i18n.rb +78 -69
  34. data/lib/friendly_id/slug.rb +1 -2
  35. data/lib/friendly_id/slug_generator.rb +1 -3
  36. data/lib/friendly_id/slugged.rb +238 -239
  37. data/lib/friendly_id/version.rb +1 -1
  38. data/lib/friendly_id.rb +47 -49
  39. data/lib/generators/friendly_id_generator.rb +9 -9
  40. data/test/base_test.rb +10 -13
  41. data/test/benchmarks/finders.rb +28 -26
  42. data/test/benchmarks/object_utils.rb +13 -13
  43. data/test/candidates_test.rb +17 -18
  44. data/test/configuration_test.rb +7 -11
  45. data/test/core_test.rb +1 -2
  46. data/test/databases.yml +4 -3
  47. data/test/finders_test.rb +36 -13
  48. data/test/generator_test.rb +16 -26
  49. data/test/helper.rb +31 -24
  50. data/test/history_test.rb +70 -74
  51. data/test/numeric_slug_test.rb +4 -4
  52. data/test/object_utils_test.rb +0 -2
  53. data/test/reserved_test.rb +9 -11
  54. data/test/schema.rb +5 -4
  55. data/test/scoped_test.rb +18 -20
  56. data/test/sequentially_slugged_test.rb +65 -50
  57. data/test/shared.rb +15 -16
  58. data/test/simple_i18n_test.rb +22 -12
  59. data/test/slugged_test.rb +125 -113
  60. data/test/sti_test.rb +19 -21
  61. data.tar.gz.sig +0 -0
  62. metadata +38 -34
  63. metadata.gz.sig +0 -0
  64. data/gemfiles/Gemfile.rails-5.0.rb +0 -28
  65. data/gemfiles/Gemfile.rails-5.1.rb +0 -27
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 6fa83b80901ae7c4930b4a0dea61544152f2cc4a7d94b828c2f52e807fb5d686
4
- data.tar.gz: b5db403619e2d9bc275d567dc9f567fb943316e1222bc9c6052e43a285b92116
3
+ metadata.gz: 5fd869be5d6d4518b4928f41284ec56c4eca0162a3d0683369ed6789b87206ed
4
+ data.tar.gz: b349d6f8cbb6d1289c768cf6d38c55ad864b472fc39f08e98baf2389af96e85d
5
5
  SHA512:
6
- metadata.gz: f8c8bef9ec1e0a42103fa813d40b087bcb84c1f3148f73d53d21fde568865b9a6dc0a2c83508431a2ffa2c2b09bf7f3d26e49b30ac09a758e39dd02323aff328
7
- data.tar.gz: 0f78de10e8d9597728e554dc53949318f23a5771adb8014b23172c204f550c48b5f2222f8df144a4368d5f34560f01051a5f42183fcac415f85ad9e1bfb262e4
6
+ metadata.gz: 07ca31c8fc194a8a3b336a8e2fdf63cb69f2ac84f1e8cb3781e35beabd392c8b8100495b9fc07e42a548d4e91d1bbf35aed2f9b51c5d5f65cf59d32cb4f25732
7
+ data.tar.gz: 776d4a15ae8c7144dbff2b9bc2b9d8f745f22858db397617a58af1bc61bacbdb9cc6e52477dfa7ee88e5457f9bda775a892292c3fe51b49060743e783b74e317
checksums.yaml.gz.sig CHANGED
Binary file
@@ -0,0 +1 @@
1
+ github: parndt
@@ -0,0 +1,6 @@
1
+ version: 2
2
+ updates:
3
+ - package-ecosystem: "github-actions"
4
+ directory: "/"
5
+ schedule:
6
+ interval: "weekly"
data/.github/stale.yml CHANGED
@@ -1,5 +1,5 @@
1
1
  # Number of days of inactivity before an issue becomes stale
2
- daysUntilStale: 42
2
+ daysUntilStale: 84
3
3
  # Number of days of inactivity before a stale issue is closed
4
4
  daysUntilClose: 7
5
5
  # Issues with these labels will never be considered stale
@@ -9,52 +9,54 @@ jobs:
9
9
  test:
10
10
  strategy:
11
11
  matrix:
12
- architecture: [ x64 ]
13
12
  database: [ mysql, postgresql ]
14
- gemfile: [ '6.0', '5.2', '5.1', '5.0' ]
15
- ruby: [ '2.6.x', '2.5.x' ]
13
+ gemfile: [ '7.0', '6.1', '6.0' ]
14
+ ruby: [ '2.6', '2.7', '3.0', '3.1', '3.2' ]
15
+ exclude:
16
+ - ruby: '2.6'
17
+ gemfile: '7.0'
18
+ - ruby: '3.2'
19
+ gemfile: '6.0'
20
+ - ruby: '3.2'
21
+ gemfile: '6.1'
16
22
  fail-fast: false
17
23
  runs-on: ubuntu-latest
18
- name: ${{ matrix.ruby }} ${{ matrix.database }} rails-${{ matrix.gemfile }}
19
- steps:
20
- - uses: actions/setup-ruby@v1.0.0
21
- with:
22
- architecture: ${{ matrix.architecture }}
23
- ruby-version: ${{ matrix.ruby }}
24
- version: ${{ matrix.ruby }}
25
- - uses: actions/checkout@v1
26
- - run: sudo apt-get update && sudo apt-get install libpq-dev postgresql-client libmysqlclient-dev mysql-client libsqlite3-dev -y
27
- - id: cache-bundler
28
- uses: actions/cache@v1
29
- with:
30
- path: vendor/bundle
31
- key: ${{ matrix.ruby }}-gem-${{ hashFiles(format('gemfiles/Gemfile.rails-{0}.rb', matrix.gemfile)) }}
32
- - run: gem install bundler
33
- - run: bundle install --path vendor/bundle
34
- - run: bundle exec rake db:create db:up
35
- - run: bundle exec rake test
36
24
 
37
25
  env:
38
- BUNDLE_JOBS: 4
39
26
  BUNDLE_GEMFILE: gemfiles/Gemfile.rails-${{ matrix.gemfile }}.rb
40
- BUNDLE_PATH: vendor/bundle
41
27
  CI: true
42
28
  COVERALLS: true
43
29
  DB: ${{ matrix.database }}
44
30
  MYSQL_PASSWORD: root
45
31
  PGHOST: localhost
46
- PGPORT: 5432
47
- PGUSER: postgres
32
+ PGPASSWORD: runner
33
+ PGUSER: runner
48
34
  RAILS_ENV: test
49
35
 
50
- services:
51
- postgres:
52
- image: postgres:11.5
53
- ports: ["5432:5432"]
54
- options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
55
- mysql:
56
- image: mysql:5.7
57
- ports: ["3306:3306"]
58
- options: --health-cmd "mysqladmin ping" --health-interval 10s --health-timeout 5s --health-retries 5
59
- env:
60
- MYSQL_ROOT_PASSWORD: root
36
+ name: ${{ matrix.ruby }} ${{ matrix.database }} rails-${{ matrix.gemfile }}
37
+ steps:
38
+ - uses: actions/checkout@v3
39
+
40
+ - run: sudo apt-get update && sudo apt-get install libsqlite3-dev -y
41
+
42
+ - name: "Set up MySQL using VM's server"
43
+ if: ${{ env.DB == 'mysql' }}
44
+ run: |
45
+ sudo apt-get install libmysqlclient-dev -y
46
+ sudo systemctl start mysql.service
47
+
48
+ - name: "Set up PostgreSQL using VM's server"
49
+ if: ${{ env.DB == 'postgresql' }}
50
+ run: |
51
+ sudo apt-get install libpq-dev -y
52
+ sudo systemctl start postgresql.service
53
+ sudo -u postgres psql -c "CREATE USER runner WITH SUPERUSER PASSWORD 'runner'"
54
+ sudo -u postgres createdb runner
55
+
56
+ - uses: ruby/setup-ruby@v1
57
+ with:
58
+ bundler-cache: true
59
+ ruby-version: ${{ matrix.ruby }}
60
+
61
+ - run: bundle exec rake db:{create,up}
62
+ - run: bundle exec rake test
data/.yardopts CHANGED
@@ -1,5 +1,7 @@
1
1
  -e guide.rb
2
2
  --files=Changelog.md,Guide.md
3
+ --tag guide
4
+ --hide-tag guide
3
5
  --private
4
6
  --protected
5
7
  --exclude lib/friendly_id/migration
data/Changelog.md CHANGED
@@ -5,6 +5,25 @@ suggestions, ideas and improvements to FriendlyId.
5
5
 
6
6
  ## Unreleased
7
7
 
8
+ ## 5.5.1 (2023-11-13)
9
+
10
+ * Fix YARD doc generation. ([#1006](https://github.com/norman/friendly_id/pull/1006))
11
+
12
+ ## 5.5.0 (2022-11-16)
13
+
14
+ * SimpleI18n: Handle regional locales ([#965](https://github.com/norman/friendly_id/pull/965))
15
+ * Fix: "unknown column" exception ([#943](https://github.com/norman/friendly_id/pull/943))
16
+ * Add: `allow_nil: true` to the Finder ([#995](https://github.com/norman/friendly_id/pull/995) and [#997](https://github.com/norman/friendly_id/pull/997))
17
+
18
+ ## 5.4.2 (2021-01-07)
19
+
20
+ * Fix: Set slug before save if needed ([#948](https://github.com/norman/friendly_id/pull/948))
21
+ * Revert "Make `first_by_friendly_id` case insensitive using `downcase`" ([#951](https://github.com/norman/friendly_id/pull/951))
22
+
23
+ ## 5.4.1 (2020-11-06)
24
+
25
+ * Fix unexpected `:slug` error on valid, unpersisted model ([#952](https://github.com/norman/friendly_id/pull/952))
26
+
8
27
  ## 5.4.0 (2020-08-14)
9
28
 
10
29
  * Fix Ruby 2.7 keyword params deprecation warning ([#939](https://github.com/norman/friendly_id/pull/939))
data/Gemfile CHANGED
@@ -1,27 +1,23 @@
1
- source 'https://rubygems.org'
1
+ source "https://rubygems.org"
2
2
 
3
3
  gemspec
4
4
 
5
- gem 'rake'
5
+ gem "standard"
6
+ gem "rake"
6
7
 
7
8
  group :development, :test do
8
9
  platforms :ruby do
9
- gem 'byebug'
10
- gem 'pry'
10
+ gem "byebug"
11
+ gem "pry"
11
12
  end
12
13
 
13
14
  platforms :jruby do
14
- gem 'activerecord-jdbcsqlite3-adapter', '>= 1.3.0.beta2'
15
- gem 'kramdown'
15
+ gem "activerecord-jdbcsqlite3-adapter", ">= 1.3.0.beta2"
16
+ gem "kramdown"
16
17
  end
17
18
 
18
19
  platforms :ruby, :rbx do
19
- gem 'sqlite3'
20
- gem 'redcarpet'
21
- end
22
-
23
- platforms :rbx do
24
- gem 'rubysl', '~> 2.0'
25
- gem 'rubinius-developer_tools'
20
+ gem "sqlite3"
21
+ gem "redcarpet"
26
22
  end
27
23
  end
data/README.md CHANGED
@@ -1,10 +1,10 @@
1
1
  [![Build Status](https://github.com/norman/friendly_id/workflows/CI/badge.svg)](https://github.com/norman/friendly_id/actions)
2
2
  [![Code Climate](https://codeclimate.com/github/norman/friendly_id.svg)](https://codeclimate.com/github/norman/friendly_id)
3
- [![Inline docs](http://inch-ci.org/github/norman/friendly_id.svg?branch=master)](http://inch-ci.org/github/norman/friendly_id)
3
+ [![Inline docs](https://inch-ci.org/github/norman/friendly_id.svg?branch=master)](https://inch-ci.org/github/norman/friendly_id)
4
4
 
5
5
  # FriendlyId
6
6
 
7
- **For the most complete, user-friendly documentation, see the [FriendlyId Guide](http://norman.github.io/friendly_id/file.Guide.html).**
7
+ **For the most complete, user-friendly documentation, see the [FriendlyId Guide](https://norman.github.io/friendly_id/file.Guide.html).**
8
8
 
9
9
  FriendlyId is the "Swiss Army bulldozer" of slugging and permalink plugins for
10
10
  Active Record. It lets you create pretty URLs and work with human-friendly
@@ -12,16 +12,16 @@ strings as if they were numeric ids.
12
12
 
13
13
  With FriendlyId, it's easy to make your application use URLs like:
14
14
 
15
- http://example.com/states/washington
15
+ https://example.com/states/washington
16
16
 
17
17
  instead of:
18
18
 
19
- http://example.com/states/4323454
19
+ https://example.com/states/4323454
20
20
 
21
21
 
22
22
  ## Getting Help
23
23
 
24
- Ask questions on [Stack Overflow](http://stackoverflow.com/questions/tagged/friendly-id)
24
+ Ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/friendly-id)
25
25
  using the "friendly-id" tag, and for bugs have a look at [the bug section](https://github.com/norman/friendly_id#bugs)
26
26
 
27
27
  ## FriendlyId Features
@@ -39,9 +39,11 @@ FriendlyId offers many advanced features, including:
39
39
  Add this line to your application's Gemfile:
40
40
 
41
41
  ```ruby
42
- gem 'friendly_id', '~> 5.2.4' # Note: You MUST use 5.0.0 or greater for Rails 4.0+
42
+ gem 'friendly_id', '~> 5.4.0'
43
43
  ```
44
44
 
45
+ Note: You MUST use 5.0.0 or greater for Rails 4.0+.
46
+
45
47
  And then execute:
46
48
 
47
49
  ```shell
@@ -102,10 +104,31 @@ existing users, do this from the console, runner, or add a Rake task:
102
104
  User.find_each(&:save)
103
105
  ```
104
106
 
107
+ ## Options
108
+
109
+ ### `:allow_nil`
110
+
111
+ You can pass `allow_nil: true` to the `friendly.find()` method if you're want to
112
+ avoid raising `ActiveRecord::RecordNotFound` and accept a `nil`.
113
+
114
+ #### Example
115
+
116
+ ```ruby
117
+ MyModel.friendly.find("bad-slug") # where bad-slug is not a valid slug
118
+ MyModel.friendly.find(123) # where 123 is not a valid primary key ID
119
+ MyModel.friendly.find(nil) # maybe you have a variable/param that's potentially nil
120
+ #=> raise ActiveRecord::RecordNotFound
121
+
122
+ MyModel.friendly.find("bad-slug", allow_nil: true)
123
+ MyModel.friendly.find(123, allow_nil: true)
124
+ MyModel.friendly.find(nil, allow_nil: true)
125
+ #=> nil
126
+ ```
127
+
105
128
  ## Bugs
106
129
 
107
130
  Please report them on the [Github issue
108
- tracker](http://github.com/norman/friendly_id/issues) for this project.
131
+ tracker](https://github.com/norman/friendly_id/issues) for this project.
109
132
 
110
133
  If you have a bug to report, please include the following information:
111
134
 
@@ -131,7 +154,7 @@ volunteers](https://github.com/norman/friendly_id/contributors).
131
154
 
132
155
  ## License
133
156
 
134
- Copyright (c) 2008-2016 Norman Clarke and contributors, released under the MIT
157
+ Copyright (c) 2008-2020 Norman Clarke and contributors, released under the MIT
135
158
  license.
136
159
 
137
160
  Permission is hereby granted, free of charge, to any person obtaining a copy of
data/Rakefile CHANGED
@@ -1,107 +1,104 @@
1
1
  require "rubygems"
2
2
  require "rake/testtask"
3
3
 
4
- task :default => :test
4
+ task default: :test
5
5
 
6
6
  task :load_path do
7
- %w(lib test).each do |path|
7
+ %w[lib test].each do |path|
8
8
  $LOAD_PATH.unshift(File.expand_path("../#{path}", __FILE__))
9
9
  end
10
10
  end
11
11
 
12
12
  Rake::TestTask.new do |t|
13
13
  t.libs << "test"
14
- t.test_files = FileList['test/*_test.rb']
14
+ t.test_files = FileList["test/*_test.rb"]
15
15
  t.verbose = true
16
16
  end
17
17
 
18
18
  desc "Remove temporary files"
19
19
  task :clean do
20
- %x{rm -rf *.gem doc pkg coverage}
21
- %x{rm -f `find . -name '*.rbc'`}
20
+ `rm -rf *.gem doc pkg coverage`
21
+ %x(rm -f `find . -name '*.rbc'`)
22
22
  end
23
23
 
24
24
  desc "Build the gem"
25
25
  task :gem do
26
- %x{gem build friendly_id.gemspec}
26
+ `gem build friendly_id.gemspec`
27
27
  end
28
28
 
29
29
  desc "Build YARD documentation"
30
30
  task :yard do
31
- puts %x{bundle exec yard}
31
+ puts `bundle exec yard`
32
32
  end
33
33
 
34
34
  desc "Run benchmarks"
35
- task :bench => :load_path do
35
+ task bench: :load_path do
36
36
  require File.expand_path("../bench", __FILE__)
37
37
  end
38
38
 
39
39
  desc "Run benchmarks on finders"
40
- task :bench_finders => :load_path do
40
+ task bench_finders: :load_path do
41
41
  require File.expand_path("../test/benchmarks/finders", __FILE__)
42
42
  end
43
43
 
44
44
  desc "Run benchmarks on ObjectUtils"
45
- task :bench_object_utils => :load_path do
45
+ task bench_object_utils: :load_path do
46
46
  require File.expand_path("../test/benchmarks/object_utils", __FILE__)
47
47
  end
48
48
 
49
49
  desc "Generate Guide.md"
50
50
  task :guide do
51
- load File.expand_path('../guide.rb', __FILE__)
51
+ load File.expand_path("../guide.rb", __FILE__)
52
52
  end
53
53
 
54
54
  namespace :test do
55
-
56
55
  desc "Run each test class in a separate process"
57
56
  task :isolated do
58
57
  dir = File.expand_path("../test", __FILE__)
59
58
  Dir["#{dir}/*_test.rb"].each do |test|
60
59
  puts "Running #{test}:"
61
- puts %x{ruby -Ilib -Itest #{test}}
60
+ puts `ruby -Ilib -Itest #{test}`
62
61
  end
63
62
  end
64
63
  end
65
64
 
66
65
  namespace :db do
67
-
68
66
  desc "Create the database"
69
- task :create => :load_path do
67
+ task create: :load_path do
70
68
  require "helper"
71
69
  driver = FriendlyId::Test::Database.driver
72
70
  config = FriendlyId::Test::Database.config[driver]
73
71
  commands = {
74
- "mysql" => "mysql -h #{config['host']} -P #{config['port']} -u #{config['username']} --password=#{config['password']} -e 'create database #{config["database"]};' >/dev/null",
75
- "postgres" => "psql -c 'create database #{config['database']};' -U #{config['username']} >/dev/null"
72
+ "mysql" => "mysql -h #{config["host"]} -P #{config["port"]} -u #{config["username"]} --password=#{config["password"]} -e 'create database #{config["database"]};' >/dev/null",
73
+ "postgres" => "psql -c 'create database #{config["database"]};' -U #{config["username"]} >/dev/null"
76
74
  }
77
- %x{#{commands[driver] || true}}
75
+ `#{commands[driver] || true}`
78
76
  end
79
77
 
80
78
  desc "Drop the database"
81
- task :drop => :load_path do
79
+ task drop: :load_path do
82
80
  require "helper"
83
81
  driver = FriendlyId::Test::Database.driver
84
82
  config = FriendlyId::Test::Database.config[driver]
85
83
  commands = {
86
- "mysql" => "mysql -h #{config['host']} -P #{config['port']} -u #{config['username']} --password=#{config['password']} -e 'drop database #{config["database"]};' >/dev/null",
87
- "postgres" => "psql -c 'drop database #{config['database']};' -U #{config['username']} >/dev/null"
84
+ "mysql" => "mysql -h #{config["host"]} -P #{config["port"]} -u #{config["username"]} --password=#{config["password"]} -e 'drop database #{config["database"]};' >/dev/null",
85
+ "postgres" => "psql -c 'drop database #{config["database"]};' -U #{config["username"]} >/dev/null"
88
86
  }
89
- %x{#{commands[driver] || true}}
87
+ `#{commands[driver] || true}`
90
88
  end
91
89
 
92
90
  desc "Set up the database schema"
93
- task :up => :load_path do
91
+ task up: :load_path do
94
92
  require "helper"
95
93
  FriendlyId::Test::Schema.up
96
94
  end
97
95
 
98
96
  desc "Drop and recreate the database schema"
99
- task :reset => [:drop, :create]
100
-
97
+ task reset: [:drop, :create]
101
98
  end
102
99
 
103
- task :doc => :yard
100
+ task doc: :yard
104
101
 
105
102
  task :docs do
106
- sh %{git checkout gh-pages && rake doc && git checkout @{-1}}
103
+ sh %(git checkout gh-pages && rake doc && git checkout @{-1})
107
104
  end
data/bench.rb CHANGED
@@ -4,7 +4,11 @@ require "ffaker"
4
4
  N = 10000
5
5
 
6
6
  def transaction
7
- ActiveRecord::Base.transaction { yield ; raise ActiveRecord::Rollback }
7
+ ActiveRecord::Base.transaction do
8
+ yield
9
+
10
+ raise ActiveRecord::Rollback
11
+ end
8
12
  end
9
13
 
10
14
  class Array
@@ -17,65 +21,64 @@ Book = Class.new ActiveRecord::Base
17
21
 
18
22
  class Journalist < ActiveRecord::Base
19
23
  extend FriendlyId
20
- friendly_id :name, :use => :slugged
24
+ friendly_id :name, use: :slugged
21
25
  end
22
26
 
23
27
  class Manual < ActiveRecord::Base
24
28
  extend FriendlyId
25
- friendly_id :name, :use => :history
29
+ friendly_id :name, use: :history
26
30
  end
27
31
 
28
32
  class Restaurant < ActiveRecord::Base
29
33
  extend FriendlyId
30
- friendly_id :name, :use => :finders
34
+ friendly_id :name, use: :finders
31
35
  end
32
36
 
33
-
34
- BOOKS = []
37
+ BOOKS = []
35
38
  JOURNALISTS = []
36
- MANUALS = []
39
+ MANUALS = []
37
40
  RESTAURANTS = []
38
41
 
39
42
  100.times do
40
43
  name = FFaker::Name.name
41
- BOOKS << (Book.create! :name => name).id
42
- JOURNALISTS << (Journalist.create! :name => name).friendly_id
43
- MANUALS << (Manual.create! :name => name).friendly_id
44
- RESTAURANTS << (Restaurant.create! :name => name).friendly_id
44
+ BOOKS << (Book.create! name: name).id
45
+ JOURNALISTS << (Journalist.create! name: name).friendly_id
46
+ MANUALS << (Manual.create! name: name).friendly_id
47
+ RESTAURANTS << (Restaurant.create! name: name).friendly_id
45
48
  end
46
49
 
47
50
  ActiveRecord::Base.connection.execute "UPDATE manuals SET slug = NULL"
48
51
 
49
52
  Benchmark.bmbm do |x|
50
- x.report 'find (without FriendlyId)' do
51
- N.times {Book.find BOOKS.rand}
53
+ x.report "find (without FriendlyId)" do
54
+ N.times { Book.find BOOKS.rand }
52
55
  end
53
56
 
54
- x.report 'find (in-table slug)' do
55
- N.times {Journalist.friendly.find JOURNALISTS.rand}
57
+ x.report "find (in-table slug)" do
58
+ N.times { Journalist.friendly.find JOURNALISTS.rand }
56
59
  end
57
60
 
58
- x.report 'find (in-table slug; using finders module)' do
59
- N.times {Restaurant.find RESTAURANTS.rand}
61
+ x.report "find (in-table slug; using finders module)" do
62
+ N.times { Restaurant.find RESTAURANTS.rand }
60
63
  end
61
64
 
62
- x.report 'find (external slug)' do
63
- N.times {Manual.friendly.find MANUALS.rand}
65
+ x.report "find (external slug)" do
66
+ N.times { Manual.friendly.find MANUALS.rand }
64
67
  end
65
68
 
66
- x.report 'insert (without FriendlyId)' do
67
- N.times {transaction {Book.create :name => FFaker::Name.name}}
69
+ x.report "insert (without FriendlyId)" do
70
+ N.times { transaction { Book.create name: FFaker::Name.name } }
68
71
  end
69
72
 
70
- x.report 'insert (in-table-slug)' do
71
- N.times {transaction {Journalist.create :name => FFaker::Name.name}}
73
+ x.report "insert (in-table-slug)" do
74
+ N.times { transaction { Journalist.create name: FFaker::Name.name } }
72
75
  end
73
76
 
74
- x.report 'insert (in-table-slug; using finders module)' do
75
- N.times {transaction {Restaurant.create :name => FFaker::Name.name}}
77
+ x.report "insert (in-table-slug; using finders module)" do
78
+ N.times { transaction { Restaurant.create name: FFaker::Name.name } }
76
79
  end
77
80
 
78
- x.report 'insert (external slug)' do
79
- N.times {transaction {Manual.create :name => FFaker::Name.name}}
81
+ x.report "insert (external slug)" do
82
+ N.times { transaction { Manual.create name: FFaker::Name.name } }
80
83
  end
81
84
  end
data/certs/parndt.pem CHANGED
@@ -1,25 +1,27 @@
1
1
  -----BEGIN CERTIFICATE-----
2
- MIIEMjCCApqgAwIBAgIBATANBgkqhkiG9w0BAQsFADAjMSEwHwYDVQQDDBhnZW1z
3
- L0RDPXAvREM9YXJuZHQvREM9aW8wHhcNMjAwNTEwMjIxOTQ2WhcNMjEwNTEwMjIx
4
- OTQ2WjAjMSEwHwYDVQQDDBhnZW1zL0RDPXAvREM9YXJuZHQvREM9aW8wggGiMA0G
5
- CSqGSIb3DQEBAQUAA4IBjwAwggGKAoIBgQDT+JzHYPGMYJt9ct2DCsbIymn1uJJp
6
- HnDkQESfsGe40jTC90oF2iVbVOkaacNc1N3CSWUZvZjuygUuS86P6/kpBILGdO2+
7
- bkXXKtfGC2YGGx9TdNLpCb4925vQHvdFeKXGpQDZdDw1SNC6zraZou47CvOE1cl2
8
- Bp+1QMZuGRZ4+5CzOEWDWurjqce3O1jUEbyBB7z5H0h/YEaxfXipxhL1Dhi0sgkH
9
- qP/e6SxzifdifdZCksJFQ06a1ji9hJY6eM23qbv/aaluVHAZSVBAQBS7rYniLo+N
10
- G4vpFhoubQO5u8UluUtCaPUpI/qOvVcSaZn3ZkzlMwC8b1RwAeXBQmtFE2wnrv2i
11
- ovTwoN7rHchwhgaHbkuFh4Wr92wGbrWL7J+X8rWKk1f8RF4kvtNE/NA6YrkxTpVh
12
- QMyDmekt7rTxvcq2NneLGroWIUVCx/JID+Jw492LKQ6Sl1/P2TRzdEDtqZAZL0gt
13
- xlWeMUfGG2D/gLnhs5qnaFaWQwGTmBnTgHcCAwEAAaNxMG8wCQYDVR0TBAIwADAL
14
- BgNVHQ8EBAMCBLAwHQYDVR0OBBYEFEqtAyQVxPgKsrgoTQ1YmaIu/fmvMBoGA1Ud
15
- EQQTMBGBD2dlbXNAcC5hcm5kdC5pbzAaBgNVHRIEEzARgQ9nZW1zQHAuYXJuZHQu
16
- aW8wDQYJKoZIhvcNAQELBQADggGBALu2HM50B8xqlAXkCwavJDvWWtV9pG1igFUg
17
- friZRWprUQ5nTaNmAd8p8qbJQwaIK2gt+DfYWfB9LtKnQTfbhLRBbmJ7zYw8LjKY
18
- PwCs4RWjDAiuyCO3ppfsz+1bsMUXPLgWlaUkXsUy3nr2NruEFTO9zu3wGYQQ93Tt
19
- vYSHOnP35UB4QjsjNrOO7FBaQfy6O909PP+GnVcJ62s9c26voJz63RSolwY7Jydw
20
- XUlG68jjJKSoDHRzVTmNB7sX8rs8P2kvYkpIUXPHyls3mWBWjBWbdEYWESZrxI2x
21
- dS7jY3AnfqhvsWra2pSREb2IDqPnJrHVOejnEI/zuuufUxLwDx3AC6SMdsyWkZ7V
22
- 9OmLt2rg75Sct6h2220lO5ySqYtqAXuOMBDGv5L0zLalx1g8LACA7uILTKVWh8B8
23
- Hsej0MQ3drCB1eA4c9OXdCUQJnY2aLTq3uNvTbZvoTgWK55eq3KLBJ4zzoKZ4tBX
24
- /HIFI/fEwYlI1Ji3oikUrHkc4rWgaQ==
2
+ MIIEljCCAv6gAwIBAgIBATANBgkqhkiG9w0BAQsFADBRMREwDwYDVQQDDAhydWJ5
3
+ Z2VtczERMA8GCgmSJomT8ixkARkWAXAxFTATBgoJkiaJk/IsZAEZFgVhcm5kdDES
4
+ MBAGCgmSJomT8ixkARkWAmlvMB4XDTIyMTExNTIyMjQzMFoXDTIzMTExNTIyMjQz
5
+ MFowUTERMA8GA1UEAwwIcnVieWdlbXMxETAPBgoJkiaJk/IsZAEZFgFwMRUwEwYK
6
+ CZImiZPyLGQBGRYFYXJuZHQxEjAQBgoJkiaJk/IsZAEZFgJpbzCCAaIwDQYJKoZI
7
+ hvcNAQEBBQADggGPADCCAYoCggGBAMPq2bIEO+BmmBeuidSySK7xlL/LWBHzyDxw
8
+ EMgWsHqJMDZYCZI4WoWbSTSSLrp5zPXLWN0hB23u3dxFp4RVygTTZkc8k05mteab
9
+ fdREGgdcP+mY8/ASQSvb1VW6IM51Srgjy1SK0S5Qf3HAiQafFvRsxRkY0SWyth24
10
+ ne/7HG667vHQ1+t0VFl8twupJE9S8p2zgX3eZBl2yRNm/kE5reUsOLvmS58Iri/X
11
+ 9tnz0SGkzrKkim9OIByq7XkFLL3oaIyfbBVgOWilM5pvxj/xNuRH7EIM6aE3q0UZ
12
+ xo7o9u9Iz2zApDEjejByPjxWAhLuP3v3bJyinRFE1rO47lEM/s6KM/6YooxvgYIN
13
+ miYYFRtTj9nmKEMv6+h1mZ1/ZwqStTTRh/T90T65dcgsoqRd0JNvpNRjFrYH5cuj
14
+ QZWMl/FE6AADm0GXa34ZiTQx3Wx2ctqJLFak8+imPwes90nCpiYmgaZpwBI+shjU
15
+ AddbPDNq+EoxPMWTh0Er3w76fywOWQIDAQABo3kwdzAJBgNVHRMEAjAAMAsGA1Ud
16
+ DwQEAwIEsDAdBgNVHQ4EFgQUxRJaTQZmtkN8FKUWVHKc2riND18wHgYDVR0RBBcw
17
+ FYETcnVieWdlbXNAcC5hcm5kdC5pbzAeBgNVHRIEFzAVgRNydWJ5Z2Vtc0BwLmFy
18
+ bmR0LmlvMA0GCSqGSIb3DQEBCwUAA4IBgQBSRGMkZ2dvJ0LSjFz+rIt3G3AZMbKD
19
+ tjaaQRuC9rOkrl3Rml6h9j7cHYiM0wkTjXneFNySc8jWmM/jKnxiiUfUK9r1XL4n
20
+ 71tz39+MD2lIpLVVEQ69MIoUseppNUTCg0mNghSDYNwISMD/hoWwbJudBi56DbhE
21
+ xkulLbw8qtcEE+iilIKibe+eJF4platKScsOA7d1AuilR1/S245UzeqwwyI52/xK
22
+ dfoP928X9Tb/48+83lWUgAgCQOd6WdfCpgQ5H6R90lc8L7OfuDR/vgcmSOTsNVgG
23
+ 1TC3b2FISS0p0qfZsiS7BXh+ARoBKLXsV1a7WR36X0dUpajvk+zzBGrFCdbW43Gx
24
+ wmJzIksYnf9Ktg8Ux+FLcRBGw4qEIyWvqmS0obB1Hke68rTg0uNTFcKXsNw33XF5
25
+ fw1cbj95g7OPe0feGK8+afXh/L38vx/hIIOGlUEZ+HaWL2Dki/7vRGvda8dfOpG5
26
+ bJfaoyKbVsrK+gGKFJv860zsO8lg6BGLsUw=
25
27
  -----END CERTIFICATE-----
data/friendly_id.gemspec CHANGED
@@ -1,39 +1,36 @@
1
- # encoding: utf-8
2
1
  require File.expand_path("../lib/friendly_id/version", __FILE__)
3
2
 
4
3
  Gem::Specification.new do |s|
5
- s.name = "friendly_id"
6
- s.version = FriendlyId::VERSION
7
- s.authors = ["Norman Clarke", "Philip Arndt"]
8
- s.email = ["norman@njclarke.com", "p@arndt.io"]
9
- s.homepage = "https://github.com/norman/friendly_id"
10
- s.summary = "A comprehensive slugging and pretty-URL plugin."
11
- s.files = `git ls-files`.split("\n")
12
- s.test_files = `git ls-files -- {test}/*`.split("\n")
13
- s.require_paths = ["lib"]
14
- s.license = 'MIT'
4
+ s.name = "friendly_id"
5
+ s.version = FriendlyId::VERSION
6
+ s.authors = ["Norman Clarke", "Philip Arndt"]
7
+ s.email = ["norman@njclarke.com", "p@arndt.io"]
8
+ s.homepage = "https://github.com/norman/friendly_id"
9
+ s.summary = "A comprehensive slugging and pretty-URL plugin."
10
+ s.files = `git ls-files`.split("\n")
11
+ s.test_files = `git ls-files -- {test}/*`.split("\n")
12
+ s.require_paths = ["lib"]
13
+ s.license = "MIT"
15
14
 
16
- s.required_ruby_version = '>= 2.1.0'
15
+ s.required_ruby_version = ">= 2.1.0"
17
16
 
18
- s.add_dependency 'activerecord', '>= 4.0.0'
17
+ s.add_dependency "activerecord", ">= 4.0.0"
19
18
 
20
- s.add_development_dependency 'coveralls'
21
- s.add_development_dependency 'railties', '>= 4.0'
22
- s.add_development_dependency 'minitest', '~> 5.3'
23
- s.add_development_dependency 'mocha', '~> 1.1'
24
- s.add_development_dependency 'yard'
25
- s.add_development_dependency 'i18n'
26
- s.add_development_dependency 'ffaker'
27
- s.add_development_dependency 'simplecov'
19
+ s.add_development_dependency "coveralls"
20
+ s.add_development_dependency "railties", ">= 4.0"
21
+ s.add_development_dependency "minitest", "~> 5.3"
22
+ s.add_development_dependency "mocha", "~> 2.1"
23
+ s.add_development_dependency "yard"
24
+ s.add_development_dependency "i18n"
25
+ s.add_development_dependency "ffaker"
26
+ s.add_development_dependency "simplecov"
28
27
 
29
- s.description = <<-EOM
30
- FriendlyId is the "Swiss Army bulldozer" of slugging and permalink plugins for
31
- Active Record. It lets you create pretty URLs and work with human-friendly
32
- strings as if they were numeric ids.
33
- EOM
28
+ s.description = "FriendlyId is the \"Swiss Army bulldozer\" of slugging " \
29
+ "and permalink plugins for Active Record. It lets you create pretty URLs " \
30
+ "and work with human-friendly strings as if they were numeric ids."
34
31
 
35
- s.cert_chain = [File.expand_path('certs/parndt.pem', __dir__)]
36
- if $PROGRAM_NAME =~ /gem\z/ && ARGV.include?('build') && ARGV.include?(__FILE__)
37
- s.signing_key = File.expand_path('~/.ssh/gem-private_key.pem')
32
+ s.cert_chain = [File.expand_path("certs/parndt.pem", __dir__)]
33
+ if $PROGRAM_NAME.end_with?("gem") && ARGV.include?("build") && ARGV.include?(__FILE__)
34
+ s.signing_key = File.expand_path("~/.ssh/gem-private_key.pem")
38
35
  end
39
36
  end