friendly_id 2.2.7 → 2.3.0

data/test/active_record2/simple_test.rb

@@ -0,0 +1,59 @@
+require File.dirname(__FILE__) + '/test_helper'
+
+module FriendlyId
+  module Test
+    module ActiveRecord2
+      module Simple
+
+        module SimpleTest
+          def klass
+            @klass ||= User
+          end
+
+          def instance
+            @instance ||= User.create! :name => "hello world"
+          end
+
+          def other_class
+            Author
+          end
+        end
+
+        class StatusTest < ::Test::Unit::TestCase
+
+          include SimpleTest
+
+          test "should default to not friendly" do
+            assert !status.friendly?
+          end
+
+          test "should default to numeric" do
+            assert status.numeric?
+          end
+
+          test "should be friendly if name is set" do
+            status.name = "name"
+            assert status.friendly?
+          end
+
+          test "should be best if it is numeric, but record has no friendly_id" do
+            instance.send("#{klass.friendly_id_config.column}=", nil)
+            assert status.best?
+          end
+
+          def status
+            @status ||= instance.friendly_id_status
+          end
+
+        end
+
+        class BasicTest < ::Test::Unit::TestCase
+          include Core
+          include SimpleTest
+        end
+
+      end
+    end
+  end
+end
+

data/test/active_record2/slug_test.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+require File.dirname(__FILE__) + '/test_helper'
+
+module FriendlyId
+  module Test
+
+    class SlugTest < ::Test::Unit::TestCase
+
+      def teardown
+        Slug.delete_all
+        Post.delete_all
+      end
+
+      test "should indicate if it is the most recent slug" do
+        post = Post.create!(:name => "test title")
+        post.name = "a new title"
+        post.save!
+        assert post.slugs.first.current?
+        assert !post.slugs.last.current?
+      end
+
+      test "should include the sequence if the sequence is greater than 1" do
+        slug = Slug.new(:name => "test", :sluggable => Post.new, :sequence => 2)
+        assert_equal "test--2", slug.to_friendly_id
+      end
+
+      test "should not include the sequence if the sequence is 1" do
+        slug = Slug.new(:name => "test",  :sluggable => Post.new, :sequence => 1)
+        assert_equal "test", slug.to_friendly_id
+      end
+
+    end
+  end
+end

data/test/active_record2/slugged.rb

@@ -0,0 +1,30 @@
+require File.dirname(__FILE__) + '/test_helper'
+
+module FriendlyId
+  module Test
+    module ActiveRecord2
+      module Slugged
+
+        test "should allow eager loading of slugs" do
+          assert_nothing_raised do
+            klass.find(instance.friendly_id, :include => :slugs)
+          end
+        end
+
+        def klass
+          Post
+        end
+
+        def other_class
+          District
+        end
+
+        def instance
+          @instance ||= klass.create! :name => "hello world"
+        end
+
+      end
+    end
+  end
+end
+

data/test/active_record2/slugged_status_test.rb

@@ -0,0 +1,61 @@
+require File.dirname(__FILE__) + '/test_helper'
+
+
+module FriendlyId
+  module Test
+    module ActiveRecord2
+
+      class StatusTest < ::Test::Unit::TestCase
+
+        test "should default to not friendly" do
+          assert !status.friendly?
+        end
+
+        test "should default to numeric" do
+          assert status.numeric?
+        end
+
+        test "should be friendly if slug is set" do
+          status.slug = Slug.new
+          assert status.friendly?
+        end
+
+        test "should be friendly if name is set" do
+          status.name = "name"
+          assert status.friendly?
+        end
+
+        test "should be current if current slug is set" do
+          status.slug = instance.slug
+          assert status.current?
+        end
+
+        test "should not be current if non-current slug is set" do
+          status.slug = Slug.new(:sluggable => instance)
+          assert !status.current?
+        end
+
+        test "should be best if it is current" do
+          status.slug = instance.slug
+          assert status.best?
+        end
+
+        test "should be best if it is numeric, but record has not slug" do
+          instance.slugs = []
+          instance.slug = nil
+          assert status.best?
+        end
+
+        def instance
+          @instance ||= Post.create! :name => "hello world"
+        end
+
+        def status
+          @status ||= instance.friendly_id_status
+        end
+
+      end
+    end
+  end
+end
+

data/test/active_record2/sti_test.rb

@@ -0,0 +1,22 @@
+require File.dirname(__FILE__) + '/test_helper'
+
+module FriendlyId
+  module Test
+    module ActiveRecord2
+
+      class StiTest < ::Test::Unit::TestCase
+
+        include FriendlyId::Test::Generic
+        include FriendlyId::Test::Slugged
+        include FriendlyId::Test::ActiveRecord2::Slugged
+        include FriendlyId::Test::ActiveRecord2::Core
+
+        def klass
+          Novel
+        end
+
+      end
+
+    end
+  end
+end

data/test/active_record2/support/database.mysql.yml

@@ -0,0 +1,4 @@
+adapter: mysql
+database: friendly_id_test
+username: root
+hostname: 127.0.0.1

data/test/{support → active_record2/support}/models.rb

@@ -1,42 +1,70 @@
 class CreateSupportModels < ActiveRecord::Migration
   def self.up
+
+    create_table :authors do |t|
+      t.string :name
+    end
+
     create_table :books do |t|
       t.string :name
       t.string :type
+      t.string :note
     end
+
     create_table :cities do |t|
       t.string :name
       t.string :my_slug
       t.integer :population
+      t.index :my_slug, :unique => true
     end
+
     create_table :countries do |t|
       t.string :name
     end
+
     create_table :districts do |t|
       t.string :name
+      t.string :note
       t.string :cached_slug
+      t.index :cached_slug, :unique => true
     end
+
     create_table :events do |t|
       t.string :name
       t.datetime :event_date
     end
+
+    create_table :houses do |t|
+      t.string :name
+      t.integer :user_id
+    end
+
     create_table :legacy_table do |t|
       t.string :name
+      t.string :note
     end
+
     create_table :people do |t|
       t.string :name
+      t.string :note
     end
+
     create_table :posts do |t|
       t.string :name
       t.boolean :published
+      t.string :note
     end
+
     create_table :residents do |t|
       t.string :name
       t.integer :country_id
     end
+
     create_table :users do |t|
       t.string :name
+      t.index :name, :unique => true
     end
+
   end
 
   def self.down

data/test/active_record2/tasks_test.rb

@@ -0,0 +1,82 @@
+require(File.dirname(__FILE__) + '/test_helper')
+require File.dirname(__FILE__) + '/../../lib/friendly_id/active_record2/tasks'
+
+class TasksTest < Test::Unit::TestCase
+
+  def teardown
+    ENV["MODEL"] = nil
+    [City, District, Post, Slug].map(&:delete_all)
+  end
+
+  test "should make slugs" do
+    City.create! :name => "Nairobi"
+    City.create! :name => "Buenos Aires"
+    Slug.delete_all
+    ENV["MODEL"] = "City"
+    FriendlyId::TaskRunner.new.make_slugs
+    assert_equal 2, Slug.count
+  end
+
+  test "should admit lower case, plural model names" do
+    ENV["MODEL"] = "cities"
+    assert_equal City, FriendlyId::TaskRunner.new.klass
+  end
+
+  test "make_slugs should raise error if no model given" do
+    assert_raise(RuntimeError) { FriendlyId::TaskRunner.new.make_slugs }
+  end
+
+  test "make_slugs should raise error if class doesn't use FriendlyId" do
+    ENV["MODEL"] = "String"
+    assert_raise(RuntimeError) { FriendlyId::TaskRunner.new.make_slugs }
+  end
+
+  test"delete_slugs delete only slugs for the specified model" do
+    Post.create! :name => "Slugs Considered Harmful"
+    City.create! :name => "Buenos Aires"
+    ENV["MODEL"] = "city"
+    FriendlyId::TaskRunner.new.delete_slugs
+    assert_equal 1, Slug.count
+  end
+
+  test "delete_slugs should set the cached_slug column to NULL" do
+    ENV["MODEL"] = "district"
+    District.create! :name => "Garment"
+    FriendlyId::TaskRunner.new.delete_slugs
+    assert_nil District.first.cached_slug
+  end
+
+
+  test "delete_old_slugs should delete slugs older than 45 days by default" do
+    set_up_old_slugs
+    FriendlyId::TaskRunner.new.delete_old_slugs
+    assert_equal 2, Slug.count
+  end
+
+  test "delete_old_slugs should respect the days argument" do
+    set_up_old_slugs
+    ENV["DAYS"] = "100"
+    FriendlyId::TaskRunner.new.delete_old_slugs
+    assert_equal 3, Slug.count
+  end
+
+  test "delete_old_slugs should respect the class argument" do
+    set_up_old_slugs
+    ENV["MODEL"] = "post"
+    FriendlyId::TaskRunner.new.delete_old_slugs
+    assert_equal 3, Slug.count
+  end
+
+  private
+
+  def set_up_old_slugs
+    Post.create! :name => "Slugs Considered Harmful"
+    city = City.create! :name => "Buenos Aires"
+    City.connection.execute "UPDATE slugs SET created_at = '%s' WHERE id = %d" % [
+      45.days.ago.strftime("%Y-%m-%d"), city.slug.id
+    ]
+    city.update_attributes :name => "Ciudad de Buenos Aires"
+    assert_equal 3, Slug.count
+  end
+
+end

data/test/active_record2/test_helper.rb

@@ -0,0 +1,107 @@
+require File.dirname(__FILE__) + "/../test_helper"
+
+require "active_record"
+require "active_support"
+require File.dirname(__FILE__) + "/../../lib/friendly_id/active_record2.rb"
+require File.dirname(__FILE__) + "/../../generators/friendly_id/templates/create_slugs"
+require File.dirname(__FILE__) + "/support/models"
+require File.dirname(__FILE__) + '/core'
+require File.dirname(__FILE__) + '/slugged'
+
+local_db_settings = File.dirname(__FILE__) + "/support/database.yml"
+default_db_settings = File.dirname(__FILE__) + "/support/database.sqlite3.yml"
+db_settings = File.exists?(local_db_settings) ? local_db_settings : default_db_settings
+ActiveRecord::Base.establish_connection(YAML::load(File.open(db_settings)))
+
+class ActiveRecord::Base
+  def log_protected_attribute_removal(*args) end
+end
+
+ActiveRecord::Base.connection.tables.each do |table|
+  ActiveRecord::Base.connection.drop_table(table)
+end
+ActiveRecord::Migration.verbose = false
+CreateSlugs.up
+CreateSupportModels.up
+
+# A model that uses the automagically configured "cached_slug" column
+class District < ActiveRecord::Base
+  has_friendly_id :name, :use_slug => true
+end
+
+# A model that specifies a custom cached slug column
+class City < ActiveRecord::Base
+  attr_accessible :name
+  has_friendly_id :name, :use_slug => true, :cache_column => "my_slug"
+end
+
+# A model with a custom slug text normalizer
+class Person < ActiveRecord::Base
+  has_friendly_id :name, :use_slug => true
+
+  def normalize_friendly_id(string)
+    string.upcase
+  end
+
+end
+
+# A slugged model that uses a scope
+class Resident < ActiveRecord::Base
+  belongs_to :country
+  has_friendly_id :name, :use_slug => true, :scope => :country
+end
+
+# A slugged model used as a scope
+class Country < ActiveRecord::Base
+  has_many :people
+  has_many :residents
+  has_friendly_id :name, :use_slug => true
+end
+
+# A model that doesn"t use slugs
+class User < ActiveRecord::Base
+  has_friendly_id :name
+  has_many :houses
+end
+
+# Another model that doesn"t use slugs
+class Author < ActiveRecord::Base
+  has_friendly_id :name
+end
+
+
+# A model that uses a non-slugged model for its scope
+class House < ActiveRecord::Base
+  belongs_to :user
+  has_friendly_id :name, :use_slug => true, :scope => :user
+end
+
+# A model that uses default slug settings and has a named scope
+class Post < ActiveRecord::Base
+  has_friendly_id :name, :use_slug => true
+  named_scope :published, :conditions => { :published => true }
+end
+
+# Model that uses a custom table name
+class Place < ActiveRecord::Base
+  self.table_name = "legacy_table"
+  has_friendly_id :name, :use_slug => true
+end
+
+# A model that uses a datetime field for its friendly_id
+class Event < ActiveRecord::Base
+  has_friendly_id :event_date, :use_slug => true
+end
+
+# A base model for single table inheritence
+class Book < ActiveRecord::Base ; end
+
+# A model that uses STI
+class Novel < ::Book
+  has_friendly_id :name, :use_slug => true
+end
+
+# A model with no table
+class Question < ActiveRecord::Base
+  has_friendly_id :name, :use_slug => true
+end