freshdesk_apiclient 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 187b3d6e3fdfb1db8a9a9402bbfefe81ed114850
-  data.tar.gz: 4fe413daf9829aaafd834d6e1b6f36a97a78d664
+  metadata.gz: c67b2ccd83449bf610df65a9654726d8f34937aa
+  data.tar.gz: e3a070ed3e73a4c4938df9b29976201e3901d0ab
 SHA512:
-  metadata.gz: 631b8a2ca96c31748eeeeefd40ffd2fb68ccbf11550b31b0485c7c6e934b9983bc12737199628f8f62e14bae916ba71c42d856a68fff27d6a5a4540d4d26fe36
-  data.tar.gz: 5e455c86ca9f317c170d3bbf7c977136915c8d2ffb937290dc29baceaf2db96ea60ae55d17821eebec4696e54ae777dc2a1a6abf9433bb7d772734963165ad8c
+  metadata.gz: 4cfa44771737bb759ee954b6cd307b71e519df5e2f4caa8f793a7fbb40875b9c4423ff1cefc504043534ad9536caec3babafbd085c6ef23595c73f1dbae2ebbb
+  data.tar.gz: 9244b995840da35dfce94cde37379cc3f8ebf4f6e24d30423e6279bb8dc40a1c474fdbcfe65affdda30e7dcb5275185d3b791cd382790d63bbefb4cc941bb132

data/lib/freshdesk_apiclient.rb

@@ -7,3 +7,29 @@ require 'freshdesk_apiclient/utils/camelizable'
 require 'freshdesk_apiclient/rest/resources'
 require 'freshdesk_apiclient/rest/tickets'
 require 'freshdesk_apiclient/rest/client'
+
+module FreshdeskApiclient
+  def self.domain
+    @domain
+  end
+
+  def self.domain=(domain)
+    @domain = domain
+  end
+
+  def self.username_or_api_key
+    @username_or_api_key
+  end
+
+  def self.username_or_api_key=(username_or_api_key)
+    @username_or_api_key = username_or_api_key
+  end
+
+  def self.password
+    @password ||= 'X'
+  end
+
+  def self.password=(password)
+    @password = password
+  end
+end

data/lib/freshdesk_apiclient/rest/client.rb

@@ -11,7 +11,10 @@ module FreshdeskApiclient
       # @param [String] username_or_api_key
       # @param [String] password
       # @param [Logger] logger
-      def initialize(domain, username_or_api_key, password='X', logger=nil)
+      def initialize(domain: FreshdeskApiclient.domain,
+                     username_or_api_key: FreshdeskApiclient.username_or_api_key,
+                     password: FreshdeskApiclient.password,
+                     logger: nil)
         @base_url = "https://#{domain}.freshdesk.com/api/v2/"
         @credentials = {username: username_or_api_key, password: password}
         @logger = logger

data/lib/freshdesk_apiclient/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FreshdeskApiclient
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/freshdesk_apiclient_spec.rb

@@ -2,7 +2,19 @@
 require 'spec_helper'
 
 RSpec.describe FreshdeskApiclient do
-  it 'has a version number' do
-    expect(FreshdeskApiclient::VERSION).not_to be nil
+  it('has a version number') { expect(FreshdeskApiclient::VERSION).not_to be nil }
+
+  before { FreshdeskApiclient.domain = :domain }
+  it('allows to set domain') { expect(FreshdeskApiclient.domain).to eq(:domain) }
+
+  before { FreshdeskApiclient.username_or_api_key = :u }
+  it('allows to set username_or_api_key') { expect(FreshdeskApiclient.username_or_api_key).to eq(:u) }
+
+  before { FreshdeskApiclient.password = :p }
+  it('allows to set password') { expect(FreshdeskApiclient.password).to eq(:p) }
+
+  context 'when password was not set' do
+    before { FreshdeskApiclient.password = nil }
+    it('has a default password') { expect(FreshdeskApiclient.password).to eq('X') }
   end
 end

data/spec/rest/client_spec.rb

@@ -9,14 +9,19 @@ require_relative '../../lib/freshdesk_apiclient/rest/tickets' unless defined?(Fr
 require_relative '../../lib/freshdesk_apiclient/rest/resources' unless defined?(FreshdeskApiclient::REST::Resources)
 
 describe FreshdeskApiclient::REST::Client do
-  subject { FreshdeskApiclient::REST::Client.new(:domain, :api_key) }
+  before do
+    FreshdeskApiclient.domain = :domain
+    FreshdeskApiclient.username_or_api_key = :api_key
+  end
+  subject { FreshdeskApiclient::REST::Client.new }
   describe '#new' do
     it 'sets the base_url for the given domain' do
       expect(subject.instance_variable_get(:@base_url)).to eql("https://#{:domain}.freshdesk.com/api/v2/")
     end
 
     context 'when password is provided' do
-      subject { FreshdeskApiclient::REST::Client.new(:domain, :api_key, :password) }
+      before { FreshdeskApiclient.password = :password }
+      subject { FreshdeskApiclient::REST::Client.new }
       it 'sets the credentials for the given parameters' do
         expect(subject.instance_variable_get(:@credentials)[:username]).to eq(:api_key)
         expect(subject.instance_variable_get(:@credentials)[:password]).to eq(:password)
@@ -24,6 +29,7 @@ describe FreshdeskApiclient::REST::Client do
     end
 
     context 'when password is not provided' do
+      before { FreshdeskApiclient.password = nil }
       it 'sets the credentials for the given api_key and default password' do
         expect(subject.instance_variable_get(:@credentials)[:username]).to eq(:api_key)
         expect(subject.instance_variable_get(:@credentials)[:password]).to eq('X')
@@ -35,7 +41,7 @@ describe FreshdeskApiclient::REST::Client do
     end
 
     context 'when a logger option is provided' do
-      subject { FreshdeskApiclient::REST::Client.new(:domain, :api_key, nil, Logger.new(STDOUT)) }
+      subject { FreshdeskApiclient::REST::Client.new(logger: Logger.new(STDOUT)) }
       it('sets the logger') { expect(subject.instance_variable_get(:@logger)).to be_a(Logger) }
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: freshdesk_apiclient
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-02 00:00:00.000000000 Z
+date: 2017-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client