frenetic 0.0.3 → 0.0.4

data/Gemfile

@@ -3,5 +3,5 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in frenetic.gemspec
 gemspec
 
-gem "awesome_print"
-gem "fakefs",         '~> 0.4.0', :require => false
+gem 'awesome_print'
+gem 'fakefs',         '~> 0.4.0', require: false

data/frenetic.gemspec

@@ -18,13 +18,12 @@ Gem::Specification.new do |gem|
   gem.add_dependency             'faraday',             '~> 0.8.1'
   gem.add_dependency             'faraday_middleware',  '~> 0.8.7'
   gem.add_dependency             'rack-cache',          '~> 1.1'
-  gem.add_dependency             'addressable',         '~> 2.2.8'
+  gem.add_dependency             'addressable',         '~> 2.3.0'
   gem.add_dependency             'patron',              '~> 0.4.18'
 
-  gem.add_development_dependency 'guard-spork',         '~> 0.7.1'
-  gem.add_development_dependency 'guard-rspec',         '~> 1.0.1'
+  gem.add_development_dependency 'guard-spork',         '~> 1.2.0'
+  gem.add_development_dependency 'guard-rspec',         '~> 1.2.1'
   gem.add_development_dependency 'rspec',               '~> 2.11.0'
-  gem.add_development_dependency 'bourne',              '~> 1.1.2'
-  gem.add_development_dependency 'webmock',             '~> 1.8.7'
-  gem.add_development_dependency 'vcr',                 '~> 2.2.2'
+  gem.add_development_dependency 'webmock',             '~> 1.8.10'
+  gem.add_development_dependency 'vcr',                 '~> 2.2.5'
 end

data/lib/frenetic/hal_json.rb

@@ -5,8 +5,8 @@ require 'frenetic/hal_json/response_wrapper'
 class Frenetic
 
   class HalJson < Faraday::Middleware
-    def call( env )
-      @app.call(env).on_complete { |env| on_complete(env) }
+    def call( environment )
+      @app.call(environment).on_complete { |env| on_complete(env) }
     end
 
     def on_complete( env )

data/lib/frenetic/resource.rb

@@ -7,7 +7,7 @@ class Frenetic
       if attributes.is_a? Hash
         load attributes.keys, attributes
 
-        @links = []
+        @links = {}
       else
         load self.class.schema, attributes
 

data/lib/frenetic/version.rb

@@ -1,3 +1,3 @@
 class Frenetic
-  VERSION = "0.0.3"
+  VERSION = '0.0.4'
 end

data/spec/lib/frenetic/configuration_spec.rb

@@ -81,7 +81,7 @@ describe Frenetic::Configuration do
         end
 
         context "which includes incorrect cache settings" do
-          before { Frenetic::Configuration.any_instance.stubs(:configure_cache).returns(nil) }
+          before { Frenetic::Configuration.any_instance.stub(:configure_cache).and_return nil }
 
           it "should raise a configuration error for a missing :metastore" do
             expect {

data/spec/lib/frenetic/hal_json_spec.rb

@@ -1,31 +1,29 @@
 describe Frenetic::HalJson do
-  let(:hal_json) { Frenetic::HalJson.new }
+  let(:hal_json) { described_class.new }
+
   let(:app_callbacks_stub) do
-    stub('FaradayCallbackStubs').tap do |cb_stub|
-      cb_stub.stubs('on_complete').yields env
+    double('FaradayCallbackStubs').tap do |cb|
+      cb.stub(:on_complete).and_yield env
     end
   end
+
   let(:app_stub) do
-    stub('FaradayAppStub').tap do |app_stub|
-      app_stub.stubs(call: app_callbacks_stub)
+    double('FaradayAppStub').tap do |app|
+      app.stub(:call).and_return app_callbacks_stub
     end
   end
 
-  before { hal_json.instance_variable_set("@app", app_stub) }
+  before { hal_json.instance_variable_set '@app', app_stub }
 
   subject { hal_json }
 
   describe "#call" do
-    let(:env) { Hash.new(:status => 200) }
-
-    before do
-      hal_json.stubs(:on_complete)
-
-      hal_json.call(env)
-    end
+    let(:env) { { status:200 } }
 
     it "should execute the on_complete callback" do
-      hal_json.should have_received(:on_complete).with(env)
+      hal_json.should_receive( :on_complete ).with env
+
+      hal_json.call env
     end
   end
 

data/spec/lib/frenetic/resource_spec.rb

@@ -1,8 +1,9 @@
 describe Frenetic::Resource do
 
-  @client = Frenetic.new('url' => 'http://example.org')
+  let(:client) { Frenetic.new('url' => 'http://example.org') }
+
+  let(:resource) { described_class.new }
 
-  let(:resource) { Frenetic::Resource.new }
   let(:description_stub) do
     Frenetic::HalJson::ResponseWrapper.new('resources' => { 'schema' => { 'resource' =>
       { 'properties' => { 'foo' => 2 } }
@@ -12,9 +13,10 @@ describe Frenetic::Resource do
   subject { resource }
 
   context "created from a Hash" do
-    let(:resource) { Frenetic::Resource.new( foo: 'bar' ) }
+    let(:resource) { described_class.new( foo: 'bar' ) }
 
     it { should respond_to(:foo) }
+    its(:links) { should be_a Hash }
     its(:links) { should be_empty }
   end
 
@@ -31,15 +33,15 @@ describe Frenetic::Resource do
     let(:wrapped_response) do
       Frenetic::HalJson::ResponseWrapper.new(api_response)
     end
-    let(:resource_a) { Frenetic::Resource.new( wrapped_response ) }
-    let(:resource_b) { Frenetic::Resource.new }
+    let(:resource_a) { described_class.new( wrapped_response ) }
+    let(:resource_b) { described_class.new }
 
     before do
-      @client.stubs(:description).returns( description_stub )
+      client.stub(:description).and_return description_stub
 
-      Frenetic::Resource.stubs(:api).returns( @client )
+      described_class.stub(:api).and_return client
 
-      resource_a and resource_b
+      resource_a && resource_b
     end
 
     context "initialized with data" do
@@ -49,6 +51,7 @@ describe Frenetic::Resource do
       it { should_not respond_to(:bar) }
       its(:links) { should_not be_empty }
     end
+
     context "intiailized in sequence without data" do
       subject { resource_b }
 
@@ -56,6 +59,7 @@ describe Frenetic::Resource do
       it { should_not respond_to(:bar) }
       its(:links) { should be_empty }
     end
+
     context "with embedded resources" do
       let(:api_response) do
         {
@@ -77,18 +81,18 @@ describe Frenetic::Resource do
 
   describe ".api_client" do
     context "with a block" do
-      before { resource.class.api_client { @client } }
+      before { resource.class.api_client { client } }
 
       it "should reference the defined API client" do
-        subject.class.api.should == @client
+        subject.class.api.should == client
       end
     end
 
     context "with an argument" do
-      before { resource.class.api_client @client }
+      before { resource.class.api_client client }
 
       it "should reference the defined API client" do
-        subject.class.api.should == @client
+        subject.class.api.should == client
       end
     end
   end
@@ -98,9 +102,9 @@ describe Frenetic::Resource do
 
     context "with a defined API Client" do
       before do
-        @client.stubs(:description).returns( description_stub )
+        client.stub(:description).and_return description_stub
 
-        resource.class.api_client @client
+        resource.class.api_client client
       end
 
       it "should return the schema for the specific resource" do
@@ -109,7 +113,7 @@ describe Frenetic::Resource do
     end
 
     context "without a defined API Client" do
-      before { Frenetic::Resource.stubs(:respond_to?).with(:api).returns( false ) }
+      before { described_class.stub(:respond_to?).with(:api).and_return false }
 
       it "should raise an error" do
         expect { subject }.to raise_error(Frenetic::MissingAPIReference)

data/spec/lib/frenetic_spec.rb

@@ -8,7 +8,7 @@ describe Frenetic do
     response: {}
   } }
 
-  before { Frenetic::Configuration.stubs(:new).returns(config) }
+  before { Frenetic::Configuration.stub(:new).and_return config }
 
   subject { client }
 
@@ -36,14 +36,11 @@ describe Frenetic do
     it { should be_a Faraday::Connection }
 
     it "should be created" do
-      faraday_stub = Faraday.new
-      Faraday.stubs(:new).returns( faraday_stub )
+      Faraday.should_receive( :new ).with do |cfg|
+        cfg.has_key? :url
+      end
 
       client
-
-      Faraday.should have_received(:new).with() { |config|
-        config.has_key? :url
-      }
     end
 
     describe 'logger configuration' do

data/spec/spec_helper.rb

@@ -9,14 +9,12 @@ Spork.prefork do
   require 'rspec'
   require 'fakefs/spec_helpers'
   require 'awesome_print'
-  require 'bourne'
   require 'vcr'
 
   RSpec.configure do |config|
-    config.filter_run :focus => true
+    config.filter_run focus:true
     config.run_all_when_everything_filtered = true
     config.treat_symbols_as_metadata_keys_with_true_values = true
-    config.mock_with :mocha
   end
 
   VCR.configure do |c|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: frenetic
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-21 00:00:00.000000000 Z
+date: 2012-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2164705080 !ruby/object:Gem::Requirement
+  requirement: &2152993480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2164705080
+  version_requirements: *2152993480
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
-  requirement: &2164719480 !ruby/object:Gem::Requirement
+  requirement: &2152992980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.8.7
   type: :runtime
   prerelease: false
-  version_requirements: *2164719480
+  version_requirements: *2152992980
 - !ruby/object:Gem::Dependency
   name: rack-cache
-  requirement: &2164717740 !ruby/object:Gem::Requirement
+  requirement: &2152992520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,21 +43,21 @@ dependencies:
         version: '1.1'
   type: :runtime
   prerelease: false
-  version_requirements: *2164717740
+  version_requirements: *2152992520
 - !ruby/object:Gem::Dependency
   name: addressable
-  requirement: &2164716900 !ruby/object:Gem::Requirement
+  requirement: &2152992060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.2.8
+        version: 2.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *2164716900
+  version_requirements: *2152992060
 - !ruby/object:Gem::Dependency
   name: patron
-  requirement: &2164716220 !ruby/object:Gem::Requirement
+  requirement: &2152991560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,32 +65,32 @@ dependencies:
         version: 0.4.18
   type: :runtime
   prerelease: false
-  version_requirements: *2164716220
+  version_requirements: *2152991560
 - !ruby/object:Gem::Dependency
   name: guard-spork
-  requirement: &2164715380 !ruby/object:Gem::Requirement
+  requirement: &2153009100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 1.2.0
   type: :development
   prerelease: false
-  version_requirements: *2164715380
+  version_requirements: *2153009100
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2164714260 !ruby/object:Gem::Requirement
+  requirement: &2153008360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: 1.2.1
   type: :development
   prerelease: false
-  version_requirements: *2164714260
+  version_requirements: *2153008360
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2164725920 !ruby/object:Gem::Requirement
+  requirement: &2153007440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,40 +98,29 @@ dependencies:
         version: 2.11.0
   type: :development
   prerelease: false
-  version_requirements: *2164725920
-- !ruby/object:Gem::Dependency
-  name: bourne
-  requirement: &2164724580 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.2
-  type: :development
-  prerelease: false
-  version_requirements: *2164724580
+  version_requirements: *2153007440
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2164722520 !ruby/object:Gem::Requirement
+  requirement: &2153006720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.7
+        version: 1.8.10
   type: :development
   prerelease: false
-  version_requirements: *2164722520
+  version_requirements: *2153006720
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2164736740 !ruby/object:Gem::Requirement
+  requirement: &2153005480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.2.2
+        version: 2.2.5
   type: :development
   prerelease: false
-  version_requirements: *2164736740
+  version_requirements: *2153005480
 description: An opinionated Ruby-based Hypermedia API client.
 email:
 - dlindahl@customink.com