freight_kit 0.1.17 → 0.1.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 44ddf6522da07b3f38b6fa21e2209126e5b247b3ad874c406e5b856160f7a994
-  data.tar.gz: 35f7b97346b38dfe7dba144504797e08df4a21da0ad42c05c356dd2b6bf609b3
+  metadata.gz: a388e3b699bfd3954ee2505e18db4d202af11dfba48c1c64643c0331f52a4a63
+  data.tar.gz: db547dada7eb6f6f65980ea8004b18210cae4e90e27022d194a513c3184c56b0
 SHA512:
-  metadata.gz: ab133a86dbe534e1c3c142d8ae800e8b94ad9e7cc6942a6d1c0f94d2425cb09082ff50d7d7e9a3b8500ae9aded131d6448f69b7bb9b586e0dd2118420208019a
-  data.tar.gz: 82391670cf07c687dfec3abaecbbdf1c5b22c44ba96b6d0fbc0af22448c1416139ad08f3cf76b99a603a88c0a1d40cb122b0f927578bac9fab59f83d79984fde
+  metadata.gz: 76be478d726587dda86efd0aa86cf758daee9537f16f65dafd3227ecc128bf3915dbc1bc5eeb403b21099247629d43f5962fc35b2ced934a7f98837ac8500941
+  data.tar.gz: 689dbeed18ddd0929e360a9ec232cea1916dcb47575e2567092ef141b9ff67cc069d1ba28c6969692cb293e7a2932bf75f1b364feb188f9b4d1aa5de9f2ade98

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    freight_kit (0.1.15)
+    freight_kit (0.1.17)
       active_utils (>= 3.3.1, < 3.7.0)
       activemodel (>= 7.1, < 8.1.4)
       activesupport (>= 7.1, < 8.1.4)
@@ -39,21 +39,20 @@ GEM
       mutex_m
       securerandom (>= 0.3)
       tzinfo (~> 2.0)
-    addressable (2.9.0)
-      public_suffix (>= 2.0.2, < 8.0)
-    akami (1.3.3)
-      base64
+    addressable (2.8.5)
+      public_suffix (>= 2.0.2, < 6.0)
+    akami (1.3.1)
       gyoku (>= 0.4.0)
       nokogiri
-    ast (2.4.2)
+    ast (2.4.3)
     base64 (0.3.0)
     benchmark (0.5.0)
-    bigdecimal (3.3.1)
-    builder (3.3.0)
+    bigdecimal (4.1.2)
+    builder (3.2.4)
     business_time (0.13.0)
       activesupport (>= 3.2.0)
       tzinfo
-    concurrent-ruby (1.3.6)
+    concurrent-ruby (1.2.2)
     connection_pool (3.0.2)
     csv (3.3.5)
     date (3.5.1)
@@ -61,7 +60,7 @@ GEM
     drb (2.2.3)
     faker (3.8.0)
       i18n (>= 1.8.11, < 2)
-    faraday (2.14.2)
+    faraday (2.14.3)
       faraday-net_http (>= 2.0, < 3.5)
       json
       logger
@@ -78,12 +77,12 @@ GEM
       mutex_m
       nkf
       rack (>= 2.0, < 4)
-    i18n (1.14.8)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    json (2.7.2)
-    language_server-protocol (3.17.0.3)
+    json (2.21.1)
+    language_server-protocol (3.17.0.6)
     logger (1.7.0)
-    mail (2.9.0)
+    mail (2.9.1)
       logger
       mini_mime (>= 0.1.1)
       net-imap
@@ -95,15 +94,13 @@ GEM
       nokogiri (~> 1)
       rake
     mini_mime (1.1.5)
-    minitest (6.0.6)
-      drb (~> 2.0)
-      prism (~> 1.5)
-    multi_xml (0.7.1)
-      bigdecimal (~> 3.1)
+    mini_portile2 (2.8.4)
+    minitest (5.15.0)
+    multi_xml (0.6.0)
     mutex_m (0.3.0)
     net-http (0.9.1)
       uri (>= 0.11.1)
-    net-imap (0.6.4)
+    net-imap (0.6.4.1)
       date
       net-protocol
     net-pop (0.1.2)
@@ -112,14 +109,14 @@ GEM
       timeout
     net-smtp (0.5.1)
       net-protocol
-    nkf (0.2.0)
-    nokogiri (1.19.3-arm64-darwin)
+    nkf (0.3.0)
+    nokogiri (1.13.10)
+      mini_portile2 (~> 2.8.0)
       racc (~> 1.4)
-    nori (2.7.1)
-      bigdecimal
+    nori (2.6.0)
     observer (0.1.2)
-    parallel (1.25.1)
-    parser (3.3.2.0)
+    parallel (1.28.0)
+    parser (3.3.12.0)
       ast (~> 2.4.1)
       racc
     pkg-config (1.6.5)
@@ -127,15 +124,15 @@ GEM
       activesupport (>= 7.1, < 8.1.4)
       csv (~> 3.3)
     prism (1.9.0)
-    public_suffix (7.0.5)
-    racc (1.8.1)
-    rack (3.2.6)
+    public_suffix (5.0.3)
+    racc (1.7.1)
+    rack (3.0.8)
     rainbow (3.1.1)
     rake (13.4.2)
     redcarpet (3.6.0)
-    regexp_parser (2.9.0)
-    rexml (3.4.4)
-    rmagick (7.0.3)
+    regexp_parser (2.8.1)
+    rexml (3.2.6)
+    rmagick (7.0.5)
       observer (~> 0.1)
       pkg-config (~> 1.4)
     rspec (3.12.0)
@@ -162,10 +159,11 @@ GEM
       rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.3)
-      parser (>= 3.3.1.0)
-    rubocop-graphql (1.5.2)
-      rubocop (>= 0.90, < 2)
+    rubocop-ast (1.50.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-graphql (1.5.4)
+      rubocop (>= 1.50, < 2)
     rubocop-next (1.0.7)
       rubocop (>= 1.56, < 1.65)
       rubocop-graphql (>= 1.4, < 1.6)
@@ -173,14 +171,14 @@ GEM
       rubocop-rake (~> 0.6.0)
       rubocop-rspec (>= 2.23.2, < 3.1.0)
       rubocop-shopify (>= 2.14, < 2.16)
-    rubocop-rails (2.25.0)
+    rubocop-rails (2.25.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (3.0.1)
+    rubocop-rspec (3.0.5)
       rubocop (~> 1.61)
     rubocop-shopify (2.15.1)
       rubocop (~> 1.51)
@@ -196,32 +194,30 @@ GEM
       nori (~> 2.4)
       wasabi (>= 5.1.0, < 6)
     securerandom (0.4.1)
-    selenium-webdriver (4.16.0)
+    selenium-webdriver (4.12.0)
       rexml (~> 3.2, >= 3.2.5)
       rubyzip (>= 1.2.2, < 3.0)
       websocket (~> 1.0)
     timeout (0.6.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    tzinfo-data (1.2023.3)
+    tzinfo-data (1.2023.4)
       tzinfo (>= 1.0.0)
-    unicode-display_width (2.5.0)
+    unicode-display_width (2.6.0)
     uri (1.1.1)
     wasabi (5.1.0)
       addressable
       faraday (>= 1.9, < 3)
       nokogiri (>= 1.13.9)
-    watir (7.3.0)
+    watir (7.1.0)
       regexp_parser (>= 1.2, < 3)
-      selenium-webdriver (~> 4.2)
-    websocket (1.2.10)
+      selenium-webdriver (~> 4.0)
+    websocket (1.2.9)
     yard (0.9.34)
-    zeitwerk (2.6.11)
+    zeitwerk (2.8.2)
 
 PLATFORMS
   arm64-darwin-22
-  arm64-darwin-23
-  arm64-darwin-24
   arm64-darwin-25
 
 DEPENDENCIES

data/VERSION

@@ -1 +1 @@
-0.1.17
+0.1.18

data/lib/freight_kit/carrier.rb

@@ -353,21 +353,44 @@ module FreightKit
       raise NotImplementedError, "#valid_pro is not supported by #{self.class.name}."
     end
 
-    def overlength_fee(tarrif, package)
-      max_dimension_inches = [package.length(:inches), package.width(:inches)].max
+    # The package's longest horizontal dimension (length or width), as a
+    # Measured::Length so comparisons stay unit-agnostic.
+    #
+    # @param package [FreightKit::Package]
+    # @return [Measured::Length]
+    def longest_dimension(package)
+      [
+        Measured::Length.new(package.length(:inches), :inches),
+        Measured::Length.new(package.width(:inches), :inches),
+      ].max
+    end
 
-      return 0 if max_dimension_inches < self.class.minimum_length_for_overlength_fees.convert_to(:inches).value
+    # @param package [FreightKit::Package]
+    # @return [Boolean] whether the package is long enough to incur overlength fees.
+    def overlength?(package) = longest_dimension(package) >= self.class.minimum_length_for_overlength_fees
 
-      tarrif.overlength_rules.each do |overlength_rule|
-        next if max_dimension_inches < overlength_rule[:min_length].convert_to(:inches).value
+    def overlength_fee(tariff, package)
+      overlength_rule = overlength_rule_for(tariff, package)
+      return 0 if overlength_rule.nil?
 
-        if overlength_rule[:max_length].blank? ||
-           max_dimension_inches <= overlength_rule[:max_length].convert_to(:inches).value
-          return (package.quantity * overlength_rule[:fee_cents])
-        end
-      end
+      package.quantity * overlength_rule.fee_cents
+    end
+
+    # Returns the overlength rule from +tariff+ that applies to +package+, or
+    # +nil+ when the package is not overlength, or no configured rule covers it.
+    #
+    # This is the single source of truth for "does a rule cover this package?"
+    # shared by {#overlength_fee} and {#validate_packages} so the two can never
+    # disagree (e.g. a package quoting $0 overlength while also being treated as
+    # serviceable).
+    #
+    # @param tariff [FreightKit::Tariff, nil]
+    # @param package [FreightKit::Package]
+    # @return [FreightKit::Tariff::OverlengthRule, nil]
+    def overlength_rule_for(tariff, package)
+      return unless tariff.is_a?(FreightKit::Tariff) && overlength?(package)
 
-      0
+      tariff.overlength_rules.find { |overlength_rule| overlength_rule.cover?(longest_dimension(package)) }
     end
 
     # Determine whether the carrier will accept the packages based on credentials and/or tariff.
@@ -389,19 +412,30 @@ module FreightKit
         message << "items must weigh #{max_weight_pounds.to_f} lbs or less"
       end
 
-      if self.class.overlength_fees_require_tariff? && (tariff.blank? || !tariff.is_a?(FreightKit::Tariff))
-        missing_dimensions = packages.map do |p|
-          [p.height(:inches), p.length(:inches), p.width(:inches)].any?(&:zero?)
-        end.any?(true)
+      # Carriers that don't quote overlength fees via their API rely on the
+      # tariff to price them. Fail closed rather than silently under-quoting: a
+      # missing, empty, or non-covering tariff for an overlength package must
+      # make the carrier unserviceable. We key off rule *coverage* (via
+      # #overlength_rule_for) rather than the tariff object's mere presence,
+      # because a present-but-empty FreightKit::Tariff is not `blank?` and would
+      # otherwise slip past this check.
+      if self.class.overlength_fees_require_tariff?
+        missing_dimensions = packages.any? do |package|
+          [
+            package.height(:inches),
+            package.length(:inches),
+            package.width(:inches),
+          ].any?(&:zero?)
+        end
+
+        uncovered_overlength = packages.any? do |package|
+          overlength?(package) && overlength_rule_for(tariff, package).nil?
+        end
 
         if missing_dimensions
           message << 'item dimensions are required'
-        else
-          max_length_inches = self.class.minimum_length_for_overlength_fees.convert_to(:inches).value
-
-          if packages.map { |p| [p.width(:inches), p.length(:inches)].max }.max >= max_length_inches
-            message << 'tariff must be defined to calculate overlength fees'
-          end
+        elsif uncovered_overlength
+          message << 'tariff must be defined to calculate overlength fees'
         end
       end
 

data/lib/freight_kit/tariff/overlength_rule.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module FreightKit
+  class Tariff
+    class OverlengthRule
+      attr_reader :fee_cents, :max_length, :min_length
+
+      def initialize(fee_cents:, max_length:, min_length:)
+        raise ArgumentError, 'overlength_rule[:fee_cents] must be an Integer' unless fee_cents.is_a?(Integer)
+
+        if max_length && !max_length.is_a?(Measured::Length)
+          raise ArgumentError, 'overlength_rule[:max_length] must be one of Measured::Length, NilClass'
+        end
+
+        unless min_length.is_a?(Measured::Length)
+          raise ArgumentError, 'overlength_rule[:min_length] must be a Measured::Length'
+        end
+
+        @fee_cents = fee_cents
+        @max_length = max_length
+        @min_length = min_length
+      end
+
+      # @param length [Measured::Length] a package's longest dimension.
+      # @return [Boolean] whether this rule's length band covers the dimension.
+      def cover?(length)
+        return false if length < min_length
+
+        max_length.nil? || length <= max_length
+      end
+    end
+  end
+end

data/lib/freight_kit/tariff.rb

@@ -8,22 +8,12 @@ module FreightKit
       options.symbolize_keys!
       @options = options
 
-      @options[:overlength_rules] = (@options[:overlength_rules].presence || [])
-      raise ArgumentError, 'overlength_rules must be an Array' unless @options[:overlength_rules].is_a?(Array)
+      overlength_rules = options[:overlength_rules].presence || []
+      raise ArgumentError, 'overlength_rules must be an Array' unless overlength_rules.is_a?(Array)
 
-      @options[:overlength_rules].each do |overlength_rule|
-        if !overlength_rule[:min_length].is_a?(Measured::Length)
-          raise ArgumentError, 'overlength_rule[:min_length] must be a Measured::Length'
-        elsif ![Measured::Length, NilClass].include?(overlength_rule[:max_length].class)
-          raise ArgumentError, 'overlength_rule[:max_length] must be one of Measured::Length, NilClass'
-        end
-
-        unless overlength_rule[:fee_cents].is_a?(Integer)
-          raise ArgumentError, 'overlength_rule[:fee_cents] must be an Integer'
-        end
+      @overlength_rules = overlength_rules.map do |overlength_rule|
+        overlength_rule.is_a?(OverlengthRule) ? overlength_rule : OverlengthRule.new(**overlength_rule)
       end
-
-      @overlength_rules = @options[:overlength_rules]
     end
   end
 end

metadata

@@ -1,16 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: freight_kit
 version: !ruby/object:Gem::Version
-  version: 0.1.17
+  version: 0.1.18
 platform: ruby
 authors:
 - Third Party Transportation Systems LLC
 - Brody Hoskins
 - Sub Pop Records
 - Shopify
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faker
@@ -477,11 +478,13 @@ files:
 - lib/freight_kit/platforms/the_great_information_factory.rb
 - lib/freight_kit/shipment_packer.rb
 - lib/freight_kit/tariff.rb
+- lib/freight_kit/tariff/overlength_rule.rb
 - service_type_symbols.txt
 - shipment_event_symbols.txt
 homepage: https://github.com/next-tms/freight_kit
 licenses: []
 metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -496,7 +499,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Freight carrier API and website abstraction library for transportation management
   systems (TMS)