freelancing-god-thinking-sphinx 1.1.12 → 1.1.14

data/spec/unit/thinking_sphinx/field_spec.rb

@@ -1,23 +1,28 @@
 require 'spec/spec_helper'
 
 describe ThinkingSphinx::Field do
+  before :each do
+    @index     = ThinkingSphinx::Index.new(Alpha)
+    @source    = ThinkingSphinx::Source.new(@index)
+  end
+  
   describe '#initialize' do
     it 'raises if no columns are provided so that configuration errors are easier to track down' do
       lambda {
-        ThinkingSphinx::Field.new([])
+        ThinkingSphinx::Field.new(@source, [])
       }.should raise_error(RuntimeError)
     end
 
     it 'raises if an element of the columns param is an integer - as happens when you use id instead of :id - so that configuration errors are easier to track down' do
       lambda {
-        ThinkingSphinx::Field.new([1234])
+        ThinkingSphinx::Field.new(@source, [1234])
       }.should raise_error(RuntimeError)
     end
   end
   
   describe "unique_name method" do
     before :each do
-      @field = ThinkingSphinx::Field.new [
+      @field = ThinkingSphinx::Field.new @source, [
         Object.stub_instance(:__stack => [], :__name => "col_name")
       ]
     end
@@ -42,13 +47,15 @@ describe ThinkingSphinx::Field do
 
   describe "prefixes method" do
     it "should default to false" do
-      @field = ThinkingSphinx::Field.new([Object.stub_instance(:__stack => [])])
+      @field = ThinkingSphinx::Field.new(
+        @source, [Object.stub_instance(:__stack => [])]
+      )
       @field.prefixes.should be_false
     end
     
     it "should be true if the corresponding option is set" do
       @field = ThinkingSphinx::Field.new(
-        [Object.stub_instance(:__stack => [])], :prefixes => true
+        @source, [Object.stub_instance(:__stack => [])], :prefixes => true
       )
       @field.prefixes.should be_true
     end
@@ -56,13 +63,15 @@ describe ThinkingSphinx::Field do
   
   describe "infixes method" do
     it "should default to false" do
-      @field = ThinkingSphinx::Field.new([Object.stub_instance(:__stack => [])])
+      @field = ThinkingSphinx::Field.new(
+        @source, [Object.stub_instance(:__stack => [])]
+      )
       @field.infixes.should be_false
     end
     
     it "should be true if the corresponding option is set" do
       @field = ThinkingSphinx::Field.new(
-        [Object.stub_instance(:__stack => [])], :infixes => true
+        @source, [Object.stub_instance(:__stack => [])], :infixes => true
       )
       @field.infixes.should be_true
     end
@@ -70,7 +79,7 @@ describe ThinkingSphinx::Field do
   
   describe "column_with_prefix method" do
     before :each do
-      @field = ThinkingSphinx::Field.new [
+      @field = ThinkingSphinx::Field.new @source, [
         ThinkingSphinx::Index::FauxColumn.new(:col_name)
       ]
       @field.columns.each { |col| @field.associations[col] = [] }
@@ -116,7 +125,7 @@ describe ThinkingSphinx::Field do
       @assoc_c = Object.stub_instance(:is_many? => true)
       
       @field = ThinkingSphinx::Field.new(
-        [ThinkingSphinx::Index::FauxColumn.new(:col_name)]
+        @source, [ThinkingSphinx::Index::FauxColumn.new(:col_name)]
       )
       @field.associations = {
         :a => @assoc_a, :b => @assoc_b, :c => @assoc_c

data/spec/unit/thinking_sphinx/index/builder_spec.rb

@@ -1,5 +1,351 @@
 require 'spec/spec_helper'
 
 describe ThinkingSphinx::Index::Builder do
-  #
+  describe ".generate without source scope" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name, last_name
+        has birthday
+        has id, :as => :internal_id
+        
+        set_property :sql_range_step => 1000
+        
+        where "birthday <= NOW()"
+        group_by "first_name"
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    it "should return an index" do
+      @index.should be_a_kind_of(ThinkingSphinx::Index)
+    end
+    
+    it "should have one source for the index" do
+      @index.sources.length.should == 1
+    end
+    
+    it "should have two fields" do
+      @source.fields.length.should == 2
+      @source.fields[0].unique_name.should == :first_name
+      @source.fields[1].unique_name.should == :last_name
+    end
+    
+    it "should have two attributes alongside the four internal ones" do
+      @source.attributes.length.should == 6
+      @source.attributes[4].unique_name.should == :birthday
+      @source.attributes[5].unique_name.should == :internal_id
+    end
+    
+    it "should have one condition" do
+      @source.conditions.length.should == 1
+      @source.conditions.first.should == "birthday <= NOW()"
+    end
+    
+    it "should have one grouping" do
+      @source.groupings.length.should == 1
+      @source.groupings.first.should == "first_name"
+    end
+    
+    it "should have one option" do
+      @source.options.length.should == 1
+      @source.options[:sql_range_step].should == 1000
+    end
+  end
+  
+  describe "sortable field" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name, :sortable => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    it "should have one field" do
+      @source.fields.length.should == 1
+    end
+    
+    it "should have one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+    
+    it "should set the attribute name to have the _sort suffix" do
+      @source.attributes.last.unique_name.should == :first_name_sort
+    end
+    
+    it "should set the attribute column to be the same as the field" do
+      @source.attributes.last.columns.length.should == 1
+      @source.attributes.last.columns.first.__name.should == :first_name
+    end
+  end
+  
+  describe "faceted field" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Person.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have one field" do
+      @source.fields.length.should == 1
+    end
+    
+    it "should have one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+    
+    it "should set the attribute name to have the _facet suffix" do
+      @source.attributes.last.unique_name.should == :first_name_facet
+    end
+    
+    it "should set the attribute type to integer" do
+      @source.attributes.last.type.should == :integer
+    end
+    
+    it "should set the attribute column to be the same as the field" do
+      @source.attributes.last.columns.length.should == 1
+      @source.attributes.last.columns.first.__name.should == :first_name
+    end
+  end
+  
+  describe "faceted integer attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Alpha) do
+        indexes :name
+        has value, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Alpha.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted timestamp attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        has birthday, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Person.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted boolean attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Beta) do
+        indexes :name
+        has delta, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Beta.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted float attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Alpha) do
+        indexes :name
+        has cost, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Alpha.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have just one attribute alongside the four internal ones" do
+      @source.attributes.length.should == 5
+    end
+  end
+  
+  describe "faceted string attribute" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        has last_name, :facet => true
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    after :each do
+      Person.sphinx_facets.delete_at(-1)
+    end
+    
+    it "should have two attributes alongside the four internal ones" do
+      @source.attributes.length.should == 6
+    end
+    
+    it "should set the facet attribute name to have the _facet suffix" do
+      @source.attributes.last.unique_name.should == :last_name_facet
+    end
+    
+    it "should set the attribute type to integer" do
+      @source.attributes.last.type.should == :integer
+    end
+    
+    it "should set the attribute column to be the same as the field" do
+      @source.attributes.last.columns.length.should == 1
+      @source.attributes.last.columns.first.__name.should == :last_name
+    end
+  end
+  
+  describe "no fields" do
+    it "should raise an exception" do
+      lambda {
+        ThinkingSphinx::Index::Builder.generate(Person) do
+          #
+        end
+      }.should raise_error
+    end
+  end
+  
+  describe "explicit source" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        define_source do
+          indexes first_name, last_name
+          has birthday
+          has id, :as => :internal_id
+        
+          set_property :delta => true
+        
+          where "birthday <= NOW()"
+          group_by "first_name"
+        end
+      end
+      
+      @source = @index.sources.first
+    end
+    
+    it "should return an index" do
+      @index.should be_a_kind_of(ThinkingSphinx::Index)
+    end
+    
+    it "should have one source for the index" do
+      @index.sources.length.should == 1
+    end
+    
+    it "should have two fields" do
+      @source.fields.length.should == 2
+      @source.fields[0].unique_name.should == :first_name
+      @source.fields[1].unique_name.should == :last_name
+    end
+    
+    it "should have two attributes alongside the four internal ones" do
+      @source.attributes.length.should == 6
+      @source.attributes[4].unique_name.should == :birthday
+      @source.attributes[5].unique_name.should == :internal_id
+    end
+  end
+  
+  describe "multiple sources" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        define_source do
+          indexes first_name
+          has birthday
+        end
+        
+        define_source do
+          indexes last_name
+          has :id, :as => :internal_id
+        end
+      end
+    end
+    
+    it "should have two sources" do
+      @index.sources.length.should == 2
+    end
+    
+    it "should have two fields" do
+      @index.fields.length.should == 2
+    end
+    
+    it "should have one field in each source" do
+      @index.sources.each do |source|
+        source.fields.length.should == 1
+      end
+    end
+    
+    it "should have two attributes alongside the eight internal ones" do
+      @index.attributes.length.should == 10
+    end
+    
+    it "should have one attribute in each source alongside the four internal ones" do
+      @index.sources.each do |source|
+        source.attributes.length.should == 5
+      end
+    end
+  end
+  
+  describe "index options" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        
+        set_property :charset_type => "utf16"
+      end
+    end
+    
+    it "should store the setting for the index" do
+      @index.local_options.length.should == 1
+      @index.local_options[:charset_type].should == "utf16"
+    end
+  end
+  
+  describe "delta options" do
+    before :each do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
+        
+        set_property :delta => true
+      end
+    end
+    
+    it "should not keep the delta setting in source options" do
+      @index.sources.first.options.should be_empty
+    end
+    
+    it "should not keep the delta setting in index options" do
+      @index.local_options.should be_empty
+    end
+    
+    it "should set the index delta object set" do
+      @index.delta_object.should be_a_kind_of(ThinkingSphinx::Deltas::DefaultDelta)
+    end
+  end
 end

data/spec/unit/thinking_sphinx/index_spec.rb

@@ -1,15 +1,6 @@
 require 'spec/spec_helper'
 
 describe ThinkingSphinx::Index do
-  describe "generated sql_query" do
-    it "should include explicit groupings if requested" do
-      @index = ThinkingSphinx::Index.new(Person)
-      
-      @index.groupings << "custom_sql"
-      @index.to_riddle_for_core(0, 0).sql_query.should match(/GROUP BY.+custom_sql/)
-    end
-  end
-  
   describe "prefix_fields method" do
     before :each do
       @index = ThinkingSphinx::Index.new(Person)
@@ -18,7 +9,7 @@ describe ThinkingSphinx::Index do
       @field_b = ThinkingSphinx::Field.stub_instance(:prefixes => false)
       @field_c = ThinkingSphinx::Field.stub_instance(:prefixes => true)
       
-      @index.fields = [@field_a, @field_b, @field_c]
+      @index.stub_method(:fields => [@field_a, @field_b, @field_c])
     end
     
     it "should return fields that are flagged as prefixed" do
@@ -39,7 +30,7 @@ describe ThinkingSphinx::Index do
       @field_b = ThinkingSphinx::Field.stub_instance(:infixes => false)
       @field_c = ThinkingSphinx::Field.stub_instance(:infixes => true)
       
-      @index.fields = [@field_a, @field_b, @field_c]
+      @index.stub_method(:fields => [@field_a, @field_b, @field_c])
     end
     
     it "should return fields that are flagged as infixed" do
@@ -54,12 +45,12 @@ describe ThinkingSphinx::Index do
   
   describe "multi-value attribute as ranged-query with has-many association" do
     before :each do 
-      @index = ThinkingSphinx::Index.new(Person) do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
         has tags(:id), :as => :tag_ids, :source => :ranged_query
       end
-      @index.link!
       
-      @sql = @index.to_riddle_for_core(0, 0).sql_query
+      @sql = @index.sources.first.to_riddle_for_core(0, 0).sql_query
     end
     
     it "should not include attribute in select-clause sql_query" do
@@ -72,8 +63,8 @@ describe ThinkingSphinx::Index do
     end
     
     it "should include sql_attr_multi as ranged-query" do
-      attribute = @index.send(:attributes).first
-      attribute.send(:type_to_config).to_s.should == "sql_attr_multi"
+      attribute = @index.attributes.detect { |attrib| attrib.unique_name == :tag_ids }
+      attribute.type_to_config.should == :sql_attr_multi
       
       declaration, query, range_query = attribute.send(:config_value).split('; ')
       declaration.should == "uint tag_ids from ranged-query"
@@ -84,12 +75,12 @@ describe ThinkingSphinx::Index do
   
   describe "multi-value attribute as ranged-query with has-many-through association" do
     before :each do
-      @index = ThinkingSphinx::Index.new(Person) do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
         has football_teams(:id), :as => :football_teams_ids, :source => :ranged_query
       end
-      @index.link!
       
-      @sql = @index.to_riddle_for_core(0, 0).sql_query
+      @sql = @index.sources.first.to_riddle_for_core(0, 0).sql_query
     end
     
     it "should not include attribute in select-clause sql_query" do
@@ -102,8 +93,10 @@ describe ThinkingSphinx::Index do
     end
     
     it "should include sql_attr_multi as ranged-query" do
-      attribute = @index.send(:attributes).first
-      attribute.send(:type_to_config).to_s.should == "sql_attr_multi"
+      attribute = @index.attributes.detect { |attrib|
+        attrib.unique_name == :football_teams_ids
+      }
+      attribute.type_to_config.should == :sql_attr_multi
       
       declaration, query, range_query = attribute.send(:config_value).split('; ')
       declaration.should == "uint football_teams_ids from ranged-query"
@@ -114,12 +107,12 @@ describe ThinkingSphinx::Index do
   
   describe "multi-value attribute as ranged-query with has-many-through association and foreign_key" do
     before :each do
-      @index = ThinkingSphinx::Index.new(Person) do
+      @index = ThinkingSphinx::Index::Builder.generate(Person) do
+        indexes first_name
         has friends(:id), :as => :friend_ids, :source => :ranged_query
       end
-      @index.link!
       
-      @sql = @index.to_riddle_for_core(0, 0).sql_query
+      @sql = @index.sources.first.to_riddle_for_core(0, 0).sql_query
     end
     
     it "should not include attribute in select-clause sql_query" do
@@ -132,8 +125,10 @@ describe ThinkingSphinx::Index do
     end
     
     it "should include sql_attr_multi as ranged-query" do
-      attribute = @index.send(:attributes).first
-      attribute.send(:type_to_config).to_s.should == "sql_attr_multi"
+      attribute = @index.attributes.detect { |attrib|
+        attrib.unique_name == :friend_ids
+      }
+      attribute.type_to_config.should == :sql_attr_multi
       
       declaration, query, range_query = attribute.send(:config_value).split('; ')
       declaration.should == "uint friend_ids from ranged-query"
@@ -141,4 +136,4 @@ describe ThinkingSphinx::Index do
       range_query.should == "SELECT MIN(`friendships`.`person_id`), MAX(`friendships`.`person_id`) FROM `friendships`"
     end
   end
-end
+end