freeagent 0.1.0 → 0.2.0

data/spec/fixtures/timeslips/all.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<timeslips type="array">
+  <timeslip>
+    <id type="integer">5903024</id>
+    <dated-on type="datetime">2011-04-12T00:00:00+00:00</dated-on>
+    <hours type="decimal">1.0</hours>
+    <comment>I did something.</comment>
+    <user-id type="integer">82948</user-id>
+    <project-id type="integer">116526</project-id>
+    <task-id type="integer">186247</task-id>
+    <updated-at type="integer">Tue Apr 12 20:48:43 UTC 2011</updated-at>
+    <status></status>
+  </timeslip>
+  <timeslip>
+    <id type="integer">5903025</id>
+    <dated-on type="datetime">2011-04-12T00:00:00+00:00</dated-on>
+    <hours type="decimal">3.0</hours>
+    <comment>It was a very difficult task!</comment>
+    <user-id type="integer">82948</user-id>
+    <project-id type="integer">116526</project-id>
+    <task-id type="integer">186247</task-id>
+    <updated-at type="integer">Tue Apr 12 20:49:21 UTC 2011</updated-at>
+    <status></status>
+  </timeslip>
+</timeslips>

data/spec/fixtures/timeslips/single.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<timeslip>
+  <id type="integer">5903024</id>
+  <dated-on type="datetime">2011-04-12T00:00:00+00:00</dated-on>
+  <hours type="decimal">1.0</hours>
+  <comment>I did something.</comment>
+  <user-id type="integer">82948</user-id>
+  <project-id type="integer">116526</project-id>
+  <task-id type="integer">186247</task-id>
+  <updated-at type="integer">Tue Apr 12 20:48:43 UTC 2011</updated-at>
+  <status></status>
+</timeslip>

data/spec/spec_helper.rb

@@ -19,7 +19,7 @@ end
 Dir[File.join(SPEC_ROOT, "support/**/*.rb")].each { |f| require f }
 
 RSpec.configure do |config|
-  # config.mock_with :rr
+  config.mock_with :rr
 
   config.before(:each) do
     FreeAgent.configure do |config|

data/spec/support/helper.rb

@@ -7,12 +7,12 @@ module Helper
     described_class
   end
 
-  def fixture(*name)
-    File.join(SPEC_ROOT, "fixtures", *name)
-  end
-
 end
 
 RSpec.configure do |config|
   config.include Helper
 end
+
+def fixture(*path)
+  File.read(File.join(SPEC_ROOT, 'fixtures', *path))
+end

data/spec/support/mimic.rb

@@ -1,9 +1,5 @@
 require 'mimic'
 
-def fixture(*path)
-  File.read(File.join(SPEC_ROOT, 'fixtures', *path))
-end
-
 Mimic.mimic do
 
   use Rack::Auth::Basic do |username, password|
@@ -14,9 +10,9 @@ Mimic.mimic do
   get('/attachments/1.xml').returning     "", 404
   get('/attachments/2.xml').returning     fixture('attachments/single.xml')
 
-  get('/bank_accounts.xml').returning     fixture('bank_accounts/all.xml')
-  get('/bank_accounts/1.xml').returning   "", 404
-  get('/bank_accounts/2.xml').returning   fixture('bank_accounts/single.xml')
+  get('/bank_accounts.xml').returning         fixture('bank_accounts/all.xml')
+  get('/bank_accounts/1.xml').returning       "", 404
+  get('/bank_accounts/84192.xml').returning   fixture('bank_accounts/single.xml')
 
   get('/bills.xml') do
     return [400, {}, []] unless params[:period]
@@ -26,22 +22,41 @@ Mimic.mimic do
   get('/bills/1.xml').returning           "", 404
   get('/bills/2.xml').returning           fixture('bills/single.xml')
 
-  get('/contacts.xml').returning          fixture('contacts/all.xml')
-  get('/contacts/1.xml').returning        "", 404
-  get('/contacts/2.xml').returning        fixture('contacts/single.xml')
-
-  get('/invoices.xml').returning          fixture('invoices/all.xml')
-  get('/invoices/1.xml').returning        "", 404
-  get('/invoices/2.xml').returning        fixture('invoices/single.xml')
-
-  get('/invoices/1/*') do
-    [404, {}, []]
-  end
-  get('/invoices/2/invoice_items.xml').returning      fixture('invoice_items/all.xml')
-  get('/invoices/2/invoice_items/1.xml').returning    "", 404
-  get('/invoices/2/invoice_items/2.xml').returning    fixture('invoice_items/single.xml')
-
-  get('/projects.xml').returning          fixture('projects/all.xml')
-  get('/projects/1.xml').returning        "", 404
-  get('/projects/2.xml').returning        fixture('projects/single.xml')
+  get('/contacts.xml').returning fixture('contacts/all.xml')
+  get('/contacts/1.xml').returning "", 404
+  get('/contacts/447693.xml').returning fixture('contacts/single.xml')
+  get('/contacts/1/invoices.xml').returning "", 404
+  get('/contacts/469012/invoices.xml').returning fixture('contacts/invoices.xml')
+
+  get('/invoices.xml').
+      returning fixture('invoices/all.xml')
+  get('/invoices/1.xml').
+      returning "", 404
+  get('/invoices/1/*').
+      returning "", 404
+  get('/invoices/2715138.xml').
+      returning fixture('invoices/single.xml')
+
+  get('/invoices/2/invoice_items.xml').
+      returning fixture('invoice_items/all.xml')
+  get('/invoices/2/invoice_items/1.xml').
+      returning "", 404
+  get('/invoices/2/invoice_items/2.xml').
+      returning fixture('invoice_items/single.xml')
+
+  put('/invoices/2715138/mark_as_draft.xml').
+      returning "", 200
+  put('/invoices/2715138/mark_as_sent.xml').
+      returning "", 200
+  put('/invoices/2715138/mark_as_cancelled.xml').
+      returning "", 200
+
+  get('/projects.xml').returning                      fixture('projects/all.xml')
+  get('/projects/1.xml').returning                    "", 404
+  get('/projects/1/*').returning                      "", 404
+  get('/projects/2.xml').returning                    fixture('projects/single.xml')
+  get('/projects/2/invoices.xml').returning           fixture('projects/invoices.xml')
+  get('/projects/2/tasks.xml').returning              fixture('projects/tasks.xml')
+  get('/projects/2/tasks/1.xml').returning            "", 404
+  get('/projects/2/tasks/2.xml').returning            fixture('tasks/single.xml')
 end

data/spec/unit/bank_account_spec.rb

@@ -36,7 +36,7 @@ describe FreeAgent::BankAccount do
   describe ".find(id)" do
     context "when the record exists" do
       before(:each) do
-        @bank_account = FreeAgent::BankAccount.find(2)
+        @bank_account = FreeAgent::BankAccount.find(84192)
       end
 
       it "returns a bank account" do

data/spec/unit/base_spec.rb

@@ -6,4 +6,117 @@ describe FreeAgent::Base do
     klass.superclass.should == ActiveResource::Base
   end
 
+
+  describe "DynamicFinderMatch" do
+
+    class Record < FreeAgent::Base
+    end
+
+    before(:each) do
+      @records = [
+        Record.new(:username => "alpha", :email => "alpha@example.org", :locale => "en"),
+        Record.new(:username => "beta", :email => "beta@example.org", :locale => "en"),
+        Record.new(:username => "charlie", :email => "charlie@example.org", :locale => "jp"),
+        Record.new(:username => "delta", :email => "delta@example.org", :locale => "en"),
+        Record.new(:username => "beta", :email => "beta@example.org", :locale => "jp"),
+      ]
+      stub(Record).all { @records }
+    end
+
+    describe "#find_by_" do
+      it "fetches .all records" do
+        mock(Record).all { @records }
+        Record.find_by_username('test')
+      end
+
+      it "searches and returns the first item matching criteria" do
+        Record.find_by_locale('en').should == @records[0]
+      end
+
+      it "supports multiple criteria" do
+        Record.find_by_email_and_username('beta@example.org', 'beta').should == @records[1]
+        Record.find_by_username_and_email('beta', 'beta@example.org').should == @records[1]
+      end
+    end
+
+    describe "#find_or_initialize_by_" do
+      it "fetches .all records" do
+        mock(Record).all { @records }
+        Record.find_or_initialize_by_username('test')
+      end
+
+      it "searches and returns the first item matching criteria" do
+        Record.find_or_initialize_by_username('en').should == @records[0]
+      end
+
+      it "supports multiple criteria" do
+        Record.find_or_initialize_by_email_and_username('beta@example.org', 'beta').should == @records[1]
+        Record.find_or_initialize_by_username_and_email('beta', 'beta@example.org').should == @records[1]
+      end
+
+      it "initializes the record if not available" do
+        record = Record.find_or_initialize_by_email('hello@example.org', 'hello')
+        record.email.should == 'hello@example.org'
+
+        record = Record.find_or_initialize_by_username_and_email('hello', 'hello@example.org')
+        record.username.should == 'hello'
+        record.email.should == 'hello@example.org'
+      end
+    end
+
+    describe "#find_all_by_" do
+      it "fetches .all records" do
+        mock(Record).all { @records }
+        Record.find_all_by_username('test')
+      end
+
+      it "searches and returns all items matching criteria" do
+        Record.find_all_by_locale('en').should == [@records[0], @records[1], @records[3]]
+      end
+
+      it "supports multiple criteria" do
+        Record.find_all_by_email_and_username('beta@example.org', 'beta').should == [@records[1], @records[4]]
+        Record.find_all_by_username_and_email('beta', 'beta@example.org').should == [@records[1], @records[4]]
+      end
+    end
+
+    describe "#find_last_by_" do
+      it "fetches .all records" do
+        mock(Record).all { @records }
+        Record.find_last_by_username('test')
+      end
+
+      it "searches and returns the last item matching criteria" do
+        Record.find_last_by_locale('en').should == @records[3]
+      end
+
+      it "supports multiple criteria" do
+        Record.find_last_by_email_and_username('beta@example.org', 'beta').should == @records[4]
+        Record.find_last_by_username_and_email('beta', 'beta@example.org').should == @records[4]
+      end
+    end
+
+    describe "#respond_to?" do
+      it "responds to find_by_*" do
+        Record.new.should respond_to(:find_by_name)
+        Record.new.should respond_to(:find_by_name_and_email)
+      end
+
+      it "responds to find_or_initialize_by_*" do
+        Record.new.should respond_to(:find_or_initialize_by_name)
+        Record.new.should respond_to(:find_or_initialize_by_name_and_email)
+      end
+
+      it "responds to find_all_by_*" do
+        Record.new.should respond_to(:find_all_by_name)
+        Record.new.should respond_to(:find_all_by_name_and_email)
+      end
+
+      it "responds to find_last_by_*" do
+        Record.new.should respond_to(:find_last_by_name)
+        Record.new.should respond_to(:find_last_by_name_and_email)
+      end
+    end
+  end
+
 end

data/spec/unit/contact_spec.rb

@@ -18,6 +18,35 @@ describe FreeAgent::Contact do
   end
 
 
+  describe "validations" do
+    it "requires either name or organisation_name" do
+      c = klass.new
+      c.should_not be_valid
+      c.errors[:first_name].should_not be_nil
+      c.errors[:last_name].should_not be_nil
+      c.errors[:organisation_name].should_not be_nil
+
+      c = klass.new(:last_name => "Carletti")
+      c.should_not be_valid
+      c.errors[:first_name].should_not be_nil
+
+      c = klass.new(:first_name => "Simone")
+      c.should_not be_valid
+      c.errors[:last_name].should_not be_nil
+    end
+
+    it "is valid with name" do
+      c = klass.new(:first_name => "Simone", :last_name => "Carletti")
+      c.should be_valid
+    end
+
+    it "is valid with organisation_name" do
+      c = klass.new(:organisation_name => "Company")
+      c.should be_valid
+    end
+  end
+
+
   describe ".all" do
     before(:each) do
       @contacts = FreeAgent::Contact.all
@@ -36,7 +65,7 @@ describe FreeAgent::Contact do
   describe ".find(id)" do
     context "when the record exists" do
       before(:each) do
-        @contacts = FreeAgent::Contact.find(2)
+        @contacts = FreeAgent::Contact.find(447693)
       end
 
       it "returns a contact" do
@@ -53,4 +82,61 @@ describe FreeAgent::Contact do
     end
   end
 
+
+  describe "#name" do
+    it "returns nil when no first_name and last_name" do
+      klass.new.name.should be_nil
+    end
+
+    it "returns the first_name when first_name" do
+      klass.new(:last_name => "Carletti").
+          name.should == "Carletti"
+    end
+
+    it "returns the first_name when first_name" do
+      klass.new(:first_name => "Simone").
+          name.should == "Simone"
+    end
+
+    it "returns first_name and last name" do
+      klass.new(:first_name => "Simone", :last_name => "Carletti").
+          name.should == "Simone Carletti"
+    end
+  end
+
+  describe "#invoices" do
+    it "merges the finder options" do
+      mock(FreeAgent::Invoice).all(:from => '/contacts/0/invoices.xml')
+      FreeAgent::Contact.new(:id => 0).invoices
+
+      mock(FreeAgent::Invoice).all(:from => '/contacts/0/invoices.xml', :params => { :foo => 'bar' })
+      FreeAgent::Contact.new(:id => 0).invoices(:params => { :foo => 'bar' })
+    end
+
+    context "when the contact exists" do
+      before(:each) do
+        @invoices = FreeAgent::Contact.new(:id => 469012).invoices
+      end
+
+      it "returns an array" do
+        @invoices.should be_a(Array)
+      end
+
+      it "returns the invoices" do
+        @invoices.should have(2).records
+        @invoices.first.should be_a(FreeAgent::Invoice)
+        @invoices.first.id.should == 2715138
+      end
+    end
+
+    context "when the contact does not exist" do
+      it "raises a ResourceNotFound error" do
+        pending 'ActiveResource rescues the error and returns nil'
+        lambda do
+          FreeAgent::Contact.new(:id => 1).invoices
+        end.should raise_error(ActiveResource::ResourceNotFound)
+      end
+    end
+  end
+
 end

data/spec/unit/invoice_item_spec.rb

@@ -58,7 +58,7 @@ describe FreeAgent::InvoiceItem do
   context "when the invoice does not exist" do
     describe ".all" do
       it "raises a ResourceNotFound error" do
-        pending 'ActiveResource returns nil'
+        pending 'ActiveResource rescues the error and returns nil'
         lambda do
           FreeAgent::InvoiceItem.all(:params => { :invoice_id => 1 })
         end.should raise_error(ActiveResource::ResourceNotFound)

data/spec/unit/invoice_spec.rb

@@ -17,6 +17,16 @@ describe FreeAgent::Invoice do
     end
   end
 
+  describe "initialization" do
+    context "from XML" do
+      it "parses the #invoice_items attribute into an array of InvoiceItem" do
+        @invoice = FreeAgent::Invoice.find(2715138)
+        @invoice.invoice_items.should be_a(Array)
+        @invoice.invoice_items.first.should be_a(FreeAgent::InvoiceItem)
+      end
+    end
+  end
+
 
   describe ".all" do
     before(:each) do
@@ -28,7 +38,7 @@ describe FreeAgent::Invoice do
     end
 
     it "returns the invoices" do
-      @invoices.should have(2).records
+      @invoices.should have(3).records
       @invoices.first.should be_a(FreeAgent::Invoice)
     end
   end
@@ -36,7 +46,7 @@ describe FreeAgent::Invoice do
   describe ".find(id)" do
     context "when the record exists" do
       before(:each) do
-        @invoice = FreeAgent::Invoice.find(2)
+        @invoice = FreeAgent::Invoice.find(2715138)
       end
 
       it "returns an invoice" do
@@ -53,4 +63,40 @@ describe FreeAgent::Invoice do
     end
   end
 
+  describe "#mark_as_draft" do
+    before(:each) do
+      @invoice = FreeAgent::Invoice.find(2715138)
+    end
+
+    it "does not complain on success" do
+      @invoice.mark_as_draft.should be_true
+    end
+
+    it "reloads the attributes"
+  end
+
+  describe "#mark_as_sent" do
+    before(:each) do
+      @invoice = FreeAgent::Invoice.find(2715138)
+    end
+
+    it "does not complain on success" do
+      @invoice.mark_as_sent.should be_true
+    end
+
+    it "reloads the attributes"
+  end
+
+  describe "#mark_as_cancelled" do
+    before(:each) do
+      @invoice = FreeAgent::Invoice.find(2715138)
+    end
+
+    it "does not complain on success" do
+      @invoice.mark_as_cancelled.should be_true
+    end
+
+    it "reloads the attributes"
+  end
+
 end