fragment_client 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47ec5a52e5b81e40693ac35fd5e34c1dbd1975ee
-  data.tar.gz: 60dfeb981985a908b134f452ae2d29d38f9d6518
+  metadata.gz: f1c1d458d625afad36e7931d2bda171aa6064d3d
+  data.tar.gz: 81c9be211e144ddb2a07d520de834a9bac7964d1
 SHA512:
-  metadata.gz: 02b2c42311ead392b53abbefc0d3528a6da8bdb1cb53c167683a8bd537b9cc55c6bba9a24e0bde80b724c0c31e74db60376edb42605350958ef5c77bd162d416
-  data.tar.gz: 3ecb2fad3cdced22a5060d1cd9baa7d8cab21f005f3f0b3fd5d38ca8b8863a421bcbf6a633ff47eecd586d55808cac71e985cc523048d8b67a0e60a40ee2d837
+  metadata.gz: 64835b4471eeaf7c32871b8ee4ab40801114f7215fd2c707cc18fe54754c3a2e2c0e16da0f6b68627f884c5dab01264ee99df7d97f8cd4f14d2c6aa6f17a596c
+  data.tar.gz: 8cdb8051c830a46a872c19fef5ade1d72b22d00acfe1b63ec458cf2f5ee49c3c65331b9c5de253f4da0d09ccab90c52cc6228e5db3e29e977dbe597651e7d799

data/lib/fragment_client.rb

@@ -1,21 +1,36 @@
 require 'json'
 require 'memory_cache'
+require 'net/http'
 
 class FragmentClient
-  attr_accessor :fragment_server_url, :option_params, :cache
+  attr_accessor :fragment_server_url, :option_params, :cache, :logger
   DEFAULT_URL = 'http://test-eva-fragment-server.herokuapp.com/fragments/full.json?'
 
-  def initialize(fragment_server_url=DEFAULT_URL, cache=MemoryCache.new)
+  def initialize(fragment_server_url=DEFAULT_URL, cache=MemoryCache.new, logger=default_logger)
     self.fragment_server_url = fragment_server_url
     self.cache               = cache
+    self.logger              = logger
   end
 
   def fetch(section, options={})
     set_params(options)
-    cache.fetch(section + option_params, expires_in: ENV["FRAGMENT_CLIENT_CACHE_TIME"] || 1.hour) { request[section] }
+    log(section)
+
+    cache.fetch(section.to_s + option_params, expires_in: ENV["FRAGMENT_CLIENT_CACHE_TIME"].to_i || 1.hour) do
+      request[section]
+    end
   end
 
   private
+  def default_logger
+    Rails.try(:logger) || Logger.new(STDOUT)
+  end
+
+  def log(section)
+    cache_hit = cache.read(section).present? ? 'CacheHit' : 'CacheMiss'
+    logger.info "FragmentClient:{Cache:#{cache.class}, Section:#{section}, #{cache_hit}}"
+    logger.info "FragmentClient:{requesting:#{uri}}" if cache_hit == 'CacheMiss'
+  end
 
   def set_params(options={})
     self.option_params = URI.encode_www_form(default_options.merge(options).sort)

data/lib/memory_cache.rb

@@ -10,6 +10,7 @@ class MemoryCache
   end
 
   def read(key)
+    return nil unless cache[key]
     cache[key]['entry']
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fragment_client
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Anthony Atkinson
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-11 00:00:00.000000000 Z
+date: 2015-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails-timeago