fpm 0.4.29 → 0.4.30

data/CHANGELIST

@@ -1,3 +1,21 @@
+0.4.30 (March 21, 2013)
+  - Solaris: --solaris-user and --solaris-group flags to specify
+    the owner of files in a package. (#342, patch by Derek Olsen)
+  - rpm: (bug fix) epoch of 0 is permitted now (#343, patch by Ben Hughes)
+  - pear: add flags --pear-bin-dir --pear-php-bin --pear-php-dir (#358, patch
+    by Zsolt Takács)
+  - New 'source' type: empty. Allows you to create packages without any files
+    in them (sometimes called 'meta packages'). Useful when you want to have
+    one package be simply dependencies or when you want to spoof a package
+    you don't want installed, etc. (#359, 349; patch by Pranay Kanwar)
+  - solaris: Add --solaris-user and --solaris-group flags (#342, Patch by Derek
+    Olsen)
+  - gem: new flag --env-shebang; default true (disable with --no-env-shebang).
+    Lets you disable #! (shebang) mangling done by gem installation. (#363,
+    patch by Grier Johnson)
+  - deb: fix bug on changelog handling (#376, patch by mbakke)
+  - rpm: fix --rpm-rpmbuild-define (#383, patch by Eric Merritt)
+
 0.4.29 (January 22, 2013)
   - Copy links literally, not what they point at (#337, patch by Dane Knecht)
 

data/lib/fpm/command.rb

@@ -364,6 +364,7 @@ class FPM::Command < Clamp::Command
     input.config_files += config_files
     input.directories += directories
     
+    script_errors = []
     setscript = proc do |scriptname|
       # 'self.send(scriptname) == self.before_install == --before-install
       # Gets the path to the script
@@ -373,7 +374,7 @@ class FPM::Command < Clamp::Command
 
       if !File.exists?(path)
         @logger.error("No such file (for #{scriptname.to_s}): #{path.inspect}")
-        return 1
+        script_errors << path
       end
 
       # Load the script into memory.
@@ -385,6 +386,10 @@ class FPM::Command < Clamp::Command
     setscript.call(:before_remove)
     setscript.call(:after_remove)
 
+    # Bail if any setscript calls had errors. We don't need to log
+    # anything because we've already logged the error(s) above.
+    return 1 if script_errors.any?
+
     # Validate the package
     if input.name.nil? or input.name.empty?
       @logger.fatal("No name given for this package (set name with, " \
@@ -424,6 +429,9 @@ class FPM::Command < Clamp::Command
   rescue FPM::Package::InvalidArgument => e
     @logger.error("Invalid package argument: #{e}")
     return 1
+  rescue FPM::Util::ProcessFailed => e
+    @logger.error("Process failed: #{e}")
+    return 1
   ensure
     input.cleanup unless input.nil?
     output.cleanup unless output.nil?
@@ -488,7 +496,7 @@ class FPM::Command < Clamp::Command
         mandatory(@command.input_type == "dir", "--inputs is only valid with -s dir")
       end
 
-      mandatory(@command.args.any? || @command.inputs,
+      mandatory(@command.args.any? || @command.inputs || @command.input_type == 'empty',
                 "No parameters given. You need to pass additional command " \
                 "arguments so that I know what you want to build packages " \
                 "from. For example, for '-s dir' you would pass a list of " \

data/lib/fpm/package.rb

@@ -337,7 +337,13 @@ class FPM::Package
   def edit_file(path)
     editor = ENV['FPM_EDITOR'] || ENV['EDITOR'] || 'vi'
     @logger.info("Launching editor", :file => path)
+    command = "#{editor} #{Shellwords.escape(path)}"
     system("#{editor} #{Shellwords.escape(path)}")
+    if !$?.success?
+      raise ProcessFailed.new("'#{editor}' failed (exit code " \
+                              "#{$?.exitstatus}) Full command was: "\
+                              "#{command}");
+    end
 
     if File.size(path) == 0
       raise "Empty file after editing: #{path.inspect}"

data/lib/fpm/package/deb.rb

@@ -301,8 +301,8 @@ class FPM::Package::Deb < FPM::Package
       dest_changelog = File.join(staging_path, "usr/share/doc/#{attributes[:name]}/changelog.Debian")
       FileUtils.mkdir_p(File.dirname(dest_changelog))
       FileUtils.cp attributes[:deb_changelog], dest_changelog
-      safesystem("gzip", dest_changelog)
       File.chmod(0644, dest_changelog)
+      safesystem("gzip", dest_changelog)
     end
 
     args = [ tar_cmd, "-C", staging_path, compression ] + tar_flags + [ "-cf", datatar, "." ]
@@ -349,13 +349,13 @@ class FPM::Package::Deb < FPM::Package
     if name =~ /[A-Z]/
       @logger.warn("Downcasing dependency '#{name}' because deb packages " \
                    " don't work so good with uppercase names")
-      dep.gsub!(name_re) { |n| n.downcase }
+      dep = dep.gsub(name_re) { |n| n.downcase }
     end
 
     if dep.include?("_")
       @logger.warn("Replacing underscores with dashes in '#{dep}' because " \
                    "debs don't like underscores")
-      dep.gsub!("_", "-")
+      dep = dep.gsub("_", "-")
     end
 
     # Convert gem ~> X.Y.Z to '>= X.Y.Z' and << X.Y+1.0

data/lib/fpm/package/empty.rb

@@ -0,0 +1,7 @@
+require "fpm/package"
+require "backports"
+
+# Empty Package type. For strict/meta/virtual package creation
+
+class FPM::Package::Empty < FPM::Package
+end

data/lib/fpm/package/gem.rb

@@ -35,6 +35,8 @@ class FPM::Package::Gem < FPM::Package
     :default => true
   option "--fix-dependencies", :flag, "Should the package dependencies be " \
     "prefixed?", :default => true
+  option "--env-shebang", :flag, "Should the target package have the " \
+    "shebang rewritten to use env?", :default => true
 
   def input(gem)
     # 'arg'  is the name of the rubygem we should unpack.
@@ -170,7 +172,10 @@ class FPM::Package::Gem < FPM::Package
     ::FileUtils.mkdir_p(installdir)
     # TODO(sissel): Allow setting gem tool path
     args = [attributes[:gem_gem], "install", "--quiet", "--no-ri", "--no-rdoc",
-       "--install-dir", installdir, "--ignore-dependencies", "-E"]
+       "--install-dir", installdir, "--ignore-dependencies"]
+    if attributes[:gem_env_shebang?]
+      args += ["-E"]
+    end
     if attributes[:gem_bin_path]
       bin_path = File.join(staging_path, attributes[:gem_bin_path])
       args += ["--bindir", bin_path]

data/lib/fpm/package/pear.rb

@@ -13,16 +13,25 @@ class FPM::Package::PEAR < FPM::Package
   option "--channel", "CHANNEL_URL",
     "The pear channel url to use instead of the default."
 
-  option "--channel-update", :flag, 
+  option "--channel-update", :flag,
     "call 'pear channel-update' prior to installation"
 
+  option "--bin-dir", "BIN_DIR",
+    "Directory to put binaries in"
+
+  option "--php-bin", "PHP_BIN",
+    "Specify php executable path if differs from the os used for packaging"
+
+  option "--php-dir", "PHP_DIR",
+    "Specify php dir relative to prefix if differs from pear default (pear/php)"
+
   # Input a PEAR package.
   #
   # The parameter is a PHP PEAR package name.
   #
   # Attributes that affect behavior here:
   # * :prefix - changes the install root, default is /usr/share
-  # * :pear_package_name_prefix - changes the 
+  # * :pear_package_name_prefix - changes the
   def input(input_package)
     if !program_in_path?("pear")
       raise ExecutableNotFound.new("pear")
@@ -34,10 +43,22 @@ class FPM::Package::PEAR < FPM::Package
     installroot = attributes[:prefix] || "/usr/share"
     safesystem("pear", "config-create", staging_path(installroot), config)
 
+    if attributes[:pear_php_dir]
+      @logger.info("Setting php_dir", :php_dir => attributes[:pear_php_dir])
+      safesystem("pear", "-c", config, "config-set", "php_dir", "#{staging_path(installroot)}/#{attributes[:pear_php_dir]}")
+    end
+
+    bin_dir = attributes[:pear_bin_dir] || "usr/bin"
+    @logger.info("Setting bin_dir", :bin_dir => bin_dir)
+    safesystem("pear", "-c", config, "config-set", "bin_dir", bin_dir)
+
+    php_bin = attributes[:pear_php_bin] || "/usr/bin/php"
+    @logger.info("Setting php_bin", :php_bin => php_bin)
+    safesystem("pear", "-c", config, "config-set", "php_bin", php_bin)
+
     # try channel-discover
     if !attributes[:pear_channel].nil?
       @logger.info("Custom channel specified", :channel => attributes[:pear_channel])
-      p ["pear", "-c", config, "channel-discover", attributes[:pear_channel]]
       safesystem("pear", "-c", config, "channel-discover", attributes[:pear_channel])
       input_package = "#{attributes[:pear_channel]}/#{input_package}"
       @logger.info("Prefixing package name with channel", :package => input_package)
@@ -50,25 +71,32 @@ class FPM::Package::PEAR < FPM::Package
       safesystem("pear", "-c", config, "channel-update", channel)
     end
 
+    @logger.info("Installing pear package", :package => input_package,
+                  :directory => staging_path)
+    ::Dir.chdir(staging_path) do
+      safesystem("pear", "-c", config, "install", "-n", "-f", input_package)
+    end
+
     pear_cmd = "pear -c #{config} remote-info #{input_package}"
     @logger.info("Fetching package information", :package => input_package, :command => pear_cmd)
     name = %x{#{pear_cmd} | sed -ne '/^Package\s*/s/^Package\s*//p'}.chomp
     self.name = "#{attributes[:pear_package_name_prefix]}-#{name}"
-    self.version = %x{#{pear_cmd} | sed -ne '/^Latest\s*/s/^Latest\s*//p'}.chomp
+    self.version = %x{#{pear_cmd} | sed -ne '/^Installed\s*/s/^Installed\s*//p'}.chomp
     self.description  = %x{#{pear_cmd} | sed -ne '/^Summary\s*/s/^Summary\s*//p'}.chomp
     @logger.debug("Package info", :name => self.name, :version => self.version,
                   :description => self.description)
 
-    @logger.info("Installing pear package", :package => input_package,
-                  :directory => staging_path)
-    ::Dir.chdir(staging_path) do
-      safesystem("pear", "-c", config, "install", "-n", "-f", input_package)
-    end
- 
     # Remove the stuff we don't want
-    delete_these = [".depdb", ".depdblock", ".filemap", ".lock", ".channel"]
+    delete_these = [".depdb", ".depdblock", ".filemap", ".lock", ".channel", "cache", "temp", "download", ".channels", ".registry"]
     Find.find(staging_path) do |path|
+      if File.file?(path) && File.executable?(path)
+        @logger.info("replacing pear_dir in binary", :binary => path)
+        staging_path_re = Regexp.new("^" + Regexp.escape(staging_path))
+        content = File.read(path).gsub(staging_path_re, "")
+        File.write(path, content)
+      end
       FileUtils.rm_r(path) if delete_these.include?(File.basename(path))
     end
+
   end # def input
 end # class FPM::Package::PEAR

data/lib/fpm/package/python.rb

@@ -58,6 +58,8 @@ class FPM::Package::Python < FPM::Package
   option "--install-data", "DATA_PATH", "The path to where data should be." \
     "installed to. This is equivalent to 'python setup.py --install-data " \
     "DATA_PATH"
+  option "--dependencies", :flag, "Include requirements defined in setup.py" \
+    " as dependencies.", :default => true
 
   private
 
@@ -196,23 +198,25 @@ class FPM::Package::Python < FPM::Package
         .map(&:strip)
     end
 
-    self.dependencies += metadata["dependencies"].collect do |dep|
-      dep_re = /^([^<>!= ]+)\s*(?:([<>!=]{1,2})\s*(.*))?$/
-      match = dep_re.match(dep)
-      if match.nil?
-        @logger.error("Unable to parse dependency", :dependency => dep)
-        raise FPM::InvalidPackageConfiguration, "Invalid dependency '#{dep}'"
-      end
-      name, cmp, version = match.captures
-      # dependency name prefixing is optional, if enabled, a name 'foo' will
-      # become 'python-foo' (depending on what the python_package_name_prefix
-      # is)
-      name = fix_name(name) if attributes[:python_fix_dependencies?]
+    if attributes[:python_dependencies?]
+      self.dependencies += metadata["dependencies"].collect do |dep|
+        dep_re = /^([^<>!= ]+)\s*(?:([<>!=]{1,2})\s*(.*))?$/
+        match = dep_re.match(dep)
+        if match.nil?
+          @logger.error("Unable to parse dependency", :dependency => dep)
+          raise FPM::InvalidPackageConfiguration, "Invalid dependency '#{dep}'"
+        end
+        name, cmp, version = match.captures
+        # dependency name prefixing is optional, if enabled, a name 'foo' will
+        # become 'python-foo' (depending on what the python_package_name_prefix
+        # is)
+        name = fix_name(name) if attributes[:python_fix_dependencies?]
 
-      # convert dependencies from python-Foo to python-foo
-      name = name.downcase if attributes[:python_downcase_dependencies?]
-      "#{name} #{cmp} #{version}"
-    end
+        # convert dependencies from python-Foo to python-foo
+        name = name.downcase if attributes[:python_downcase_dependencies?]
+        "#{name} #{cmp} #{version}"
+      end
+    end # if attributes[:python_dependencies?]
   end # def load_package_info
 
   # Sanitize package name.
@@ -243,13 +247,29 @@ class FPM::Package::Python < FPM::Package
       flags = [ "--root", staging_path ]
       if !attributes[:python_install_lib].nil?
         flags += [ "--install-lib", File.join(prefix, attributes[:python_install_lib]) ]
+      elsif !attributes[:prefix].nil?
+        # setup.py install --prefix PREFIX still installs libs to
+        # PREFIX/lib64/python2.7/site-packages/
+        # but we really want something saner.
+        #
+        # since prefix is given, but not python_install_lib, assume PREFIX/lib
+        flags += [ "--install-lib", File.join(prefix, "lib") ]
       end
+
       if !attributes[:python_install_data].nil?
         flags += [ "--install-data", File.join(prefix, attributes[:python_install_data]) ]
+      elsif !attributes[:prefix].nil?
+        # prefix given, but not python_install_data, assume PREFIX/data
+        flags += [ "--install-data", File.join(prefix, "data") ]
       end
+
       if !attributes[:python_install_bin].nil?
         flags += [ "--install-scripts", File.join(prefix, attributes[:python_install_bin]) ]
+      elsif !attributes[:prefix].nil?
+        # prefix given, but not python_install_bin, assume PREFIX/bin
+        flags += [ "--install-scripts", File.join(prefix, "bin") ]
       end
+
       safesystem(attributes[:python_bin], "setup.py", "install", *flags)
     end
   end # def install_to_staging

data/lib/fpm/package/rpm.rb

@@ -40,10 +40,11 @@ class FPM::Package::RPM < FPM::Package
       value
   end
 
+  rpmbuild_define = []
   option "--rpmbuild-define", "DEFINITION",
     "Pass a --define argument to rpmbuild." do |define|
-    attributes[:rpm_rpmbuild_define] ||= []
-    attributes[:rpm_rpmbuild_define] << define
+    rpmbuild_define << define
+    next rpmbuild_define
   end
 
   option "--digest", DIGEST_ALGORITHM_MAP.keys.join("|"),
@@ -271,6 +272,7 @@ class FPM::Package::RPM < FPM::Package
   # with fpm 0.4.3 and older)
   def epoch
     return 1 if @epoch.nil?
+    return @epoch if @epoch.is_a?(Numeric)
     return nil if @epoch.empty?
     return @epoch
   end # def epoch

data/lib/fpm/package/solaris.rb

@@ -7,6 +7,15 @@ require "fpm/util"
 # TODO(sissel): Add dependency checking support.
 # IIRC this has to be done as a 'checkinstall' step.
 class FPM::Package::Solaris < FPM::Package
+
+  option "--user", "USER",
+    "Set the user to USER in the prototype files.",
+    :default => 'root'
+
+  option "--group", "GROUP",
+    "Set the group to GROUP in the prototype file.",
+    :default => 'root'
+
   def architecture
     case @architecture
     when nil, "native"
@@ -48,7 +57,6 @@ class FPM::Package::Solaris < FPM::Package
     end
 
     # Generate the package 'Prototype' file
-    # TODO(sissel): allow setting default file owner.
     File.open("#{build_path}/Prototype", "w") do |prototype|
       prototype.puts("i pkginfo")
       prototype.puts("i preinstall") if self.scripts["pre-install"]
@@ -58,11 +66,8 @@ class FPM::Package::Solaris < FPM::Package
       # strip @prefix, since BASEDIR will set prefix via the pkginfo file
       IO.popen("pkgproto #{staging_path}/#{@prefix}=").each_line do |line|
         type, klass, path, mode, user, group = line.split
-        # Override stuff in pkgproto
-        # TODO(sissel): Make this tunable?
-        user = "root"
-        group = "root"
-        prototype.puts([type, klass, path, mode, user, group].join(" "))
+
+        prototype.puts([type, klass, path, mode, attributes[:solaris_user], attributes[:solaris_group]].join(" "))
       end # popen "pkgproto ..."
     end # File prototype
 

data/lib/fpm/version.rb

@@ -1,3 +1,3 @@
 module FPM
-  VERSION = "0.4.29"
+  VERSION = "0.4.30"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fpm
 version: !ruby/object:Gem::Version
-  version: 0.4.29
+  version: 0.4.30
   prerelease: 
 platform: ruby
 authors:
@@ -9,24 +9,24 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-22 00:00:00.000000000 Z
+date: 2013-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.6
+        version: 1.7.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - '='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.6
+        version: 1.7.7
 - !ruby/object:Gem::Dependency
   name: cabin
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +66,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: 0.0.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -74,7 +74,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: 0.0.8
 - !ruby/object:Gem::Dependency
   name: clamp
   requirement: !ruby/object:Gem::Requirement
@@ -161,40 +161,39 @@ description: Convert directories, rpms, python eggs, rubygems, and more to rpms,
 email: jls@semicomplete.com
 executables:
 - fpm
-- fpm-npm
 extensions: []
 extra_rdoc_files: []
 files:
 - lib/fpm.rb
-- lib/fpm/command.rb
 - lib/fpm/errors.rb
 - lib/fpm/namespace.rb
-- lib/fpm/package.rb
-- lib/fpm/package/deb.rb
-- lib/fpm/package/gem.rb
 - lib/fpm/package/npm.rb
 - lib/fpm/package/osxpkg.rb
-- lib/fpm/package/pear.rb
 - lib/fpm/package/puppet.rb
 - lib/fpm/package/pyfpm/__init__.py
-- lib/fpm/package/pyfpm/get_metadata.py
 - lib/fpm/package/pyfpm/__init__.pyc
+- lib/fpm/package/pyfpm/get_metadata.py
 - lib/fpm/package/pyfpm/get_metadata.pyc
-- lib/fpm/package/python.rb
-- lib/fpm/package/rpm.rb
-- lib/fpm/package/solaris.rb
 - lib/fpm/package/tar.rb
 - lib/fpm/package/dir.rb
+- lib/fpm/package/pear.rb
+- lib/fpm/package/empty.rb
+- lib/fpm/package/solaris.rb
+- lib/fpm/package/python.rb
+- lib/fpm/package/deb.rb
+- lib/fpm/package/gem.rb
+- lib/fpm/package/rpm.rb
 - lib/fpm/util.rb
+- lib/fpm/package.rb
+- lib/fpm/command.rb
 - lib/fpm/version.rb
 - bin/fpm
-- bin/fpm-npm
 - templates/deb.erb
 - templates/osxpkg.erb
 - templates/puppet/package.pp.erb
 - templates/puppet/package/remove.pp.erb
-- templates/rpm.erb
 - templates/solaris.erb
+- templates/rpm.erb
 - LICENSE
 - CONTRIBUTORS
 - CHANGELIST
@@ -224,3 +223,4 @@ signing_key:
 specification_version: 3
 summary: fpm - package building and mangling
 test_files: []
+has_rdoc: 

data/bin/fpm-npm

@@ -1,104 +0,0 @@
-#!/usr/bin/env ruby
-
-require "optparse"
-require "ostruct"
-require "json"
-
-settings = OpenStruct.new
-opts = OptionParser.new do |opts|
-  opts.on("-n PACKAGENAME", "--name PACKAGENAME",
-          "What name to give to the package") do |name|
-    settings.name = name
-  end
-
-  opts.on("-v VERSION", "--version VERSION",
-          "version to give the package") do |version|
-    settings.version = version
-  end
-
-  opts.on("-t OUTPUTTYPE", "--type OUTPUTTYPE",
-          "what kind of package you want as output (deb, etc)") do |packagetype|
-    settings.packagetype = packagetype
-  end
-end
-
-args = opts.parse(ARGV)
-
-if !["deb"].include?(settings.packagetype)
-  $stderr.puts "Unsupported output package type '#{settings.packagetype}'." \
-               "Only supports 'deb' right now."
-  exit 1
-end
-
-if !settings.name
-  $stderr.puts "No npm package name given (missing -n?)"
-  exit 1
-end
-
-builddir="#{Dir.pwd}/npm2pkg"
-# Prefix package names with 'nodejs-'
-PACKAGEPREFIX = "nodejs-"
-
-Dir.mkdir(builddir) if !File.exists?(builddir)
-File.open("#{builddir}/.npmrc", "w") do |file|
-  file.puts "root = #{builddir}/usr/lib/node"
-  file.puts "binroot = #{builddir}/usr/lib/node/bin"
-  file.puts "manroot = #{builddir}/usr/share/man"
-end
-
-## Trick npm into using a custom .npmrc
-system("env - PATH=$PATH HOME=#{builddir} npm install #{settings.name} #{settings.version}")
-
-# Find all installed npms in builddir, make packages.
-Dir.glob("#{builddir}/usr/lib/node/.npm/*/*") do |path|
-  next if File.symlink?(path)
-  puts path
-
-  # Load the package.json and glean any information from it, then invoke pkg.rb
-  package = JSON.parse(File.new("#{path}/package/package.json").read())
-
-  # TODO(sissel): Ideally we want to say any version with the same 'release' number, like
-  # So we'll specify deps of {v}-1 <= x <= {v}-999999....
-  depends = Dir.glob("#{path}/dependson/*@*") \
-    .collect { |p| PACKAGEPREFIX + File.basename(p) } \
-    .collect { |p| n,v = p.split("@");
-      ["#{n} (>= #{v}-1)", "#{n} (<= #{v}-99999999999999)"]
-  }.flatten
-
-  if package["author"]
-    maintainer = package["author"]
-  else
-    m = package["maintainers"][0] \
-      rescue { "name" => "missing upstream author", "email" => ENV["USER"] }
-    maintainer = "#{m["name"]} <#{m["email"]}>"
-  end
-
-  pkgcmd = [ "fpm",
-    "-n", "#{PACKAGEPREFIX}#{package["name"]}",
-    "-v", package["version"],
-    "-m", maintainer,
-    "-a", "all",
-  ]
-
-  depends.each do |dep|
-    pkgcmd += ["-d", dep]
-  end
-
-  pkgcmd += ["-p", "#{PACKAGEPREFIX}#{package["name"]}-VERSION_ARCH.deb"]
-  pkgcmd += ["-C", builddir]
-  pkgcmd << "usr/lib/node/.npm/#{package["name"]}/active"
-  pkgcmd << "usr/lib/node/.npm/#{package["name"]}/#{package["version"]}"
-  pkgcmd << "usr/lib/node/#{package["name"]}"
-  pkgcmd << "usr/lib/node/#{package["name"]}@#{package["version"]}"
-
-  # Include bin files, install to usr/lib/node/bin
-  (package["bin"] or []).each do |bin, script|
-    pkgcmd << "usr/lib/node/bin/#{bin}"
-    pkgcmd << "usr/lib/node/bin/#{bin}@#{package["version"]}"
-  end
-
-  # TODO(sissel): We could include manpages and docs, but I don't care right
-  # now. If you want it, I accept patches! :)
-
-  system *pkgcmd
-end