fpm-cookery 0.36.0 → 0.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d635234a7161b1b47ba35bf07f4a3c58209482d57ead1d2e7d42e59ead4090f
-  data.tar.gz: 15c95843c18e2b098236b68fa4249fad32387dfae68b92ae734087379179d337
+  metadata.gz: b95014d3c9e85da55e6ba1e46ff1d8b6fddd05ff100afff7d3f26c1440c56845
+  data.tar.gz: e2c6c2e73c6816ba2f34e20fa9ad9d25c9a255caf0b2c6fe9b5ba37cc2cd6308
 SHA512:
-  metadata.gz: b9c9ef894547aa17415134b1de01ba2cf4b594429f4d7a93fe24166bf0a1eed82961d1cdf155f16edb96907f4a9f36bc3517bae12e384c60fbd126daad953753
-  data.tar.gz: 79b01c1bb917e0ae2ab6e90c64a521d930d8e3d80512345b6df98ca82ce1ece074229eaff0044c39a8a451c79954b2b84966a9d440b827bbd978f771ae548c70
+  metadata.gz: 0c0eaf01306f288ac13a2c0766c1366a6dd79ec3eb5ada9928dbef287232d0f7b5108a0bdd1ff9005b53e1320100c9b70224126e3cebe1ae9dc7d3775de04324
+  data.tar.gz: ca59959ebd72f3b8eedbbba3b341a951f0ce816ccf5b383ab3b6013541befccf1da5e8d35f0cdda9bae5c86a8b1434cd4bd336fe8eec2692235ef37d69f0ee25

data/.github/workflows/ruby.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: ["2.4", "2.5", "2.6", "2.7", "3.0", "3.1"]
+        ruby: ["2.7", "3.0", "3.1", "3.2"]
 
     steps:
     - uses: actions/checkout@v1
@@ -19,6 +19,8 @@ jobs:
         bundler-cache: true
     - name: Build and test with Rake
       run: |
+        sudo apt-get update -qq
+        sudo apt-get install -yqq python3-sphinx
         gem install bundler
         bundle install --jobs 4 --retry 3
         bundle exec rake

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# v0.37.0 (2023-04-04)
+* Add `osfamily` fact and choose package target based on it. (FooBarQuaxx / #216)
+* Install Sphinx toolchain for GitHub Action workflow. (FooBarQuaxx / #217)
+* Add support for Ruby 3.2. (FooBarQuaxx / #218, bernd / #219)
+
 # v0.36.0 (2022-07-13)
 * Add Dockerfile for Ubuntu 18.04.
 * Allow newer versions of Puppet (gmathes / #211)

data/lib/fpm/cookery/chain_packager.rb

@@ -20,7 +20,7 @@ module FPM
         DependencyInspector.verify!([], recipe.build_depends)
         recipe.chain_recipes.each do |name|
           recipe_file = build_recipe_file_path(name)
-          unless File.exists?(recipe_file)
+          unless File.exist?(recipe_file)
             error_message = "Cannot find a recipe for #{name} at #{recipe_file}"
             Log.fatal error_message
             raise Error::ExecutionFailure, error_message
@@ -49,7 +49,7 @@ module FPM
         recipe.chain_recipes.each do |name|
           recipe_file = build_recipe_file_path(name)
 
-          unless File.exists?(recipe_file)
+          unless File.exist?(recipe_file)
             Log.fatal "Cannot find a recipe for #{name} at #{recipe_file}"
             exit 1
           end

data/lib/fpm/cookery/cli.rb

@@ -60,7 +60,7 @@ module FPM
           file = File.expand_path(recipe)
 
           # Allow giving the directory containing a recipe.rb
-          if File.directory?(file) && File.exists?(File.join(file, 'recipe.rb'))
+          if File.directory?(file) && File.exist?(File.join(file, 'recipe.rb'))
             file = File.join(file, 'recipe.rb')
           end
 
@@ -68,7 +68,7 @@ module FPM
         end
 
         def validate
-          unless File.exists?(recipe_file)
+          unless File.exist?(recipe_file)
             Log.error 'No recipe.rb found in the current directory, abort.'
             exit 1
           end

data/lib/fpm/cookery/facts.rb

@@ -28,13 +28,20 @@ module FPM
           @osmajorrelease ||= value(:operatingsystemmajrelease, false)
         end
 
+        def osfamily
+          @osfamily ||= value(:osfamily)
+        end
+
+        def osfamily=(value)
+          @osfamily = value.downcase.to_sym
+        end
+
         def target
-          @target ||= case platform
-                      when :centos, :redhat, :fedora, :amazon,
-                           :scientific, :oraclelinux, :sles    then :rpm
-                      when :debian, :ubuntu                    then :deb
-                      when :darwin                             then :osxpkg
-                      when :alpine                             then :apk
+          @target ||= case osfamily
+                      when :redhat, :suse then :rpm
+                      when :debian        then :deb
+                      when :darwin        then :osxpkg
+                      when :alpine        then :apk
                       end
         end
 

data/lib/fpm/cookery/hiera.rb

@@ -27,9 +27,6 @@ module FPM
         # Provides a default scope, and attempts to look up the key both as a
         # string and as a symbol.
         def lookup(key, default = nil, scope = self.scope, *rest)
-          
-          (Gem::Version.new(::Hiera.version) < Gem::Version.new('2.0.0') &&
-               super(key.to_sym, default, scope, *rest)) ||
             super(key.to_s, default, scope, *rest)
         end
         alias_method :[], :lookup

data/lib/fpm/cookery/omnibus_packager.rb

@@ -21,7 +21,7 @@ module FPM
         _recipe.omnibus_recipes.each do |name|
           recipe_file = build_recipe_file_path(name)
           Log.info "Loading dependency recipe #{name} from #{recipe_file}"
-          unless File.exists?(recipe_file)
+          unless File.exist?(recipe_file)
             error_message = "Cannot find a recipe for #{name} at #{recipe_file}"
             Log.fatal error_message
             raise Error::ExecutionFailure, error_message

data/lib/fpm/cookery/packager.rb

@@ -119,7 +119,7 @@ module FPM
 
             # Do not extract source again because it might destroy changes
             # that have been made to the source. (like patches)
-            if File.exists?(extract_cookie)
+            if File.exist?(extract_cookie)
               extracted_source = File.read(extract_cookie).chomp
               Log.debug "Extract cookie exists, using existing source directory: #{extracted_source}"
             else
@@ -149,7 +149,7 @@ module FPM
 
               build_cookie = build_cookie_name(package_name)
 
-              if File.exists?(build_cookie)
+              if File.exist?(build_cookie)
                 Log.warn "Skipping build of #{recipe.name} because build cookie found (#{build_cookie})," \
                          " use \"fpm-cook clean\" to rebuild!"
               else
@@ -161,7 +161,7 @@ module FPM
               end
 
               FileUtils.rm_rf(recipe.destdir) unless keep_destdir?
-              recipe.destdir.mkdir unless File.exists?(recipe.destdir)
+              recipe.destdir.mkdir unless File.exist?(recipe.destdir)
 
               begin
                 recipe.installing = true
@@ -243,7 +243,7 @@ module FPM
               script_file = File.expand_path("../#{script_file.to_s}", recipe.filename)
             end
 
-            if File.exists?(script_file)
+            if File.exist?(script_file)
               input.add_script(script, File.read(script_file.to_s))
             else
               Log.error "#{script} script '#{script_file}' is missing"

data/lib/fpm/cookery/version.rb

@@ -1,5 +1,5 @@
 module FPM
   module Cookery
-    VERSION = '0.36.0'
+    VERSION = '0.37.0'
   end
 end

data/spec/facts_spec.rb

@@ -69,81 +69,59 @@ describe "Facts" do
     end
   end
 
-  describe "target" do
-
-    describe "with platform Scientific" do
-      it "returns rpm" do
-        FPM::Cookery::Facts.platform = 'Scientific'
-        expect(FPM::Cookery::Facts.target).to eq(:rpm)
-      end
-    end
+  describe "osfamily" do
+    include_context "mock facts", { :osfamily => 'RedHat' }
 
-    describe "with platform CentOS" do
-      it "returns rpm" do
-        FPM::Cookery::Facts.platform = 'CentOS'
-        expect(FPM::Cookery::Facts.target).to eq(:rpm)
-      end
+    it "is using Facter to autodetect the osfamily" do
+      expect(FPM::Cookery::Facts.osfamily).to eq(:redhat)
     end
 
-    describe "with platform RedHat" do
-      it "returns rpm" do
-        FPM::Cookery::Facts.platform = 'RedHat'
-        expect(FPM::Cookery::Facts.target).to eq(:rpm)
-      end
+    it "can be set" do
+      FPM::Cookery::Facts.platform = 'RedHat'
+      expect(FPM::Cookery::Facts.osfamily).to eq(:redhat)
     end
+  end
 
-    describe "with platform Fedora" do
-      it "returns rpm" do
-        FPM::Cookery::Facts.platform = 'Fedora'
-        expect(FPM::Cookery::Facts.target).to eq(:rpm)
-      end
-    end
+  describe "target" do
 
-    describe "with platform Amazon" do
+    describe "with os family RedHat" do
       it "returns rpm" do
-        FPM::Cookery::Facts.platform = 'Amazon'
+        FPM::Cookery::Facts.osfamily = 'RedHat'
         expect(FPM::Cookery::Facts.target).to eq(:rpm)
       end
     end
 
-    describe "with platform OracleLinux" do
+    describe "with os family Suse" do
       it "returns rpm" do
-        FPM::Cookery::Facts.platform = 'OracleLinux'
+        FPM::Cookery::Facts.osfamily = 'Suse'
         expect(FPM::Cookery::Facts.target).to eq(:rpm)
       end
     end
 
-    describe "with platform Debian" do
-      it "returns deb" do
-        FPM::Cookery::Facts.platform = 'Debian'
-        expect(FPM::Cookery::Facts.target).to eq(:deb)
-      end
-    end
-
-    describe "with platform Ubuntu" do
+    describe "with os family Debian" do
       it "returns deb" do
-        FPM::Cookery::Facts.platform = 'Ubuntu'
+        FPM::Cookery::Facts.osfamily = 'Debian'
         expect(FPM::Cookery::Facts.target).to eq(:deb)
       end
     end
 
-    describe "with platform Darwin" do
+    describe "with os family Darwin" do
       it "returns osxpkg" do
-        FPM::Cookery::Facts.platform = 'Darwin'
+        FPM::Cookery::Facts.osfamily = 'Darwin'
         expect(FPM::Cookery::Facts.target).to eq(:osxpkg)
       end
     end
 
-    describe "with platform Alpine" do
+    describe "with os family Alpine" do
       it "returns apk" do
-        FPM::Cookery::Facts.platform = 'Alpine'
+        FPM::Cookery::Facts.osfamily = 'Alpine'
         expect(FPM::Cookery::Facts.target).to eq(:apk)
       end
     end
 
-    describe "with an unknown platform" do
+    describe "with an unknown os family" do
       it "returns nil" do
-        FPM::Cookery::Facts.platform = '___X___'
+        FPM::Cookery::Facts.osfamily = '___X___'
         expect(FPM::Cookery::Facts.target).to eq(nil)
       end
     end

data/spec/path_spec.rb

@@ -91,10 +91,10 @@ describe "Path" do
     it "creates the directory" do
       dir = Dir.mktmpdir
       FileUtils.rm_rf(dir)
-      expect(File.exists?(dir)).to eq(false)
+      expect(File.exist?(dir)).to eq(false)
 
       FPM::Cookery::Path.new(dir).mkdir
-      expect(File.exists?(dir)).to eq(true)
+      expect(File.exist?(dir)).to eq(true)
 
       FileUtils.rm_rf(dir)
     end
@@ -102,7 +102,7 @@ describe "Path" do
     describe "directory exists" do
       it "does not throw an error" do
         dir = Dir.mktmpdir
-        expect(File.exists?(dir)).to eq(true)
+        expect(File.exist?(dir)).to eq(true)
 
         expect(FPM::Cookery::Path.new(dir).mkdir).to eq([dir])
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fpm-cookery
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.37.0
 platform: ruby
 authors:
 - Bernd Ahlers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-13 00:00:00.000000000 Z
+date: 2023-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec