fourchette 0.1.2 → 0.1.3

data/spec/lib/fourchette/logger_spec.rb

@@ -19,4 +19,4 @@ describe Fourchette::Logger do
       expect(subject.logger).to be(logger)
     end
   end
-end
+end

data/spec/lib/fourchette/pull_request_spec.rb

@@ -2,42 +2,67 @@ require 'spec_helper'
 
 describe Fourchette::PullRequest do
   describe '#perform' do
-    let!(:fork) { double('fork') }
+    let(:fork) { double('fork') }
     subject { described_class.new }
 
     after do
-      Fourchette::Fork.stub(:new).and_return(fork)
+      allow(Fourchette::Fork).to receive(:new).and_return(fork)
       subject.perform(params)
     end
 
     context 'action == synchronize' do
-      let!(:params) { { 'action' => 'synchronize', 'pull_request' => { 'title' => 'Test Me' } } }
+      let(:params) do
+        {
+          'action' => 'synchronize',
+          'pull_request' => { 'title' => 'Test Me' }
+        }
+      end
 
-      it { fork.should_receive(:update) }
+      it { expect(fork).to receive(:update) }
     end
 
     context 'action == closed' do
-      let!(:params) { { 'action' => 'closed', 'pull_request' => { 'title' => 'Test Me' } } }
+      let(:params) do
+        {
+          'action' => 'closed',
+          'pull_request' => { 'title' => 'Test Me' }
+        }
+      end
 
-      it { fork.should_receive(:delete) }
+      it { expect(fork).to receive(:delete) }
     end
 
     context 'action == reopened' do
-      let!(:params) { { 'action' => 'reopened', 'pull_request' => { 'title' => 'Test Me' } } }
+      let(:params) do
+        {
+          'action' => 'reopened',
+          'pull_request' => { 'title' => 'Test Me' }
+        }
+      end
 
-      it { fork.should_receive(:create) }
+      it { expect(fork).to receive(:create) }
     end
 
     context 'action == opened' do
-      let!(:params) { { 'action' => 'opened', 'pull_request' => { 'title' => 'Test Me' } } }
+      let(:params) do
+        {
+          'action' => 'opened',
+          'pull_request' => { 'title' => 'Test Me' }
+        }
+      end
 
-      it { fork.should_receive(:create) }
+      it { expect(fork).to receive(:create) }
     end
 
     context 'title includes [qa skip]' do
-      let!(:params) { { 'action' => 'opened', 'pull_request' => { 'title' => 'Skip Me [QA Skip]' } } }
+      let(:params) do
+        {
+          'action' => 'opened',
+          'pull_request' => { 'title' => 'Skip Me [QA Skip]' }
+        }
+      end
 
-      it { fork.should_not_receive(:create) }
+      it { expect(fork).not_to receive(:create) }
     end
   end
 end

data/spec/lib/fourchette/tarball_spec.rb

@@ -9,36 +9,42 @@ describe Fourchette::Tarball do
     let(:branch_name) { 'feature/something-new' }
 
     before do
-      subject.stub(:expiration_timestamp).and_return('123')
-      subject.stub(:clone)
-      subject.stub(:tar).and_return('tmp/1234567/123.tar.gz')
-      subject.stub(:system)
-      stub_const('ENV', {'FOURCHETTE_APP_URL' => 'http://example.com'})
-      SecureRandom.stub(:uuid).and_return('1234567')
+      allow(subject).to receive(:expiration_timestamp).and_return('123')
+      allow(subject).to receive(:clone)
+      allow(subject).to receive(:tar).and_return('tmp/1234567/123.tar.gz')
+      allow(subject).to receive(:system)
+      stub_const('ENV', 'FOURCHETTE_APP_URL' => 'http://example.com')
+      allow(SecureRandom).to receive(:uuid).and_return('1234567')
     end
 
-    it {
-        expect(
-            subject.url(git_repo_url, branch_name, github_repo)
-          ).to eq "http://example.com/jipiboily/fourchette/1234567/123"
-        }
+    it do
+      expect(
+          subject.url(git_repo_url, branch_name, github_repo)
+        ).to eq 'http://example.com/jipiboily/fourchette/1234567/123'
+    end
 
     it 'clones the repo and checkout the branch' do
-      subject.unstub(:clone)
+      allow(subject).to receive(:clone).and_call_original
       git_instance = double
-      Git.should_receive(:clone).with(git_repo_url, "tmp/1234567", recursive: true).and_return(git_instance)
-      git_instance.should_receive(:checkout).with(branch_name)
+      expect(Git).to receive(:clone).with(
+        git_repo_url, 'tmp/1234567', recursive: true
+      ).and_return(git_instance)
+      expect(git_instance).to receive(:checkout).with(branch_name)
       subject.url(git_repo_url, branch_name, github_repo)
     end
 
     it 'creates the tarball' do
-      subject.unstub(:tar)
-      subject.should_receive(:system).with 'tar -zcf tmp/1234567/123.tar.gz -C tmp/1234567 .'
+      allow(subject).to receive(:tar).and_call_original
+      expect(subject).to receive(:system).with(
+        'tar -zcf tmp/1234567/123.tar.gz -C tmp/1234567 .'
+      )
       subject.url(git_repo_url, branch_name, github_repo)
     end
   end
 
   describe '#filepath' do
-    it { expect(subject.filepath('1234567', '123')).to eq 'tmp/1234567/123.tar.gz' }
+    it 'should return the correct filepath' do
+      expect(subject.filepath('1234567', '123')).to eq 'tmp/1234567/123.tar.gz'
+    end
   end
-end
+end

data/spec/lib/web/hooks_spec.rb

@@ -1,16 +1,16 @@
-require "spec_helper"
-require "support/sinatra_helper"
-require "sucker_punch/testing/inline"
+require 'spec_helper'
+require 'support/sinatra_helper'
+require 'sucker_punch/testing/inline'
 
-describe "GitHub web hooks receiver" do
-  it "kicks an async job doing all the work" do
-    expected_param = { "something" => "ok" }
-    Fourchette::PullRequest.any_instance
-      .should_receive(:perform)
+describe 'GitHub web hooks receiver' do
+  it 'kicks an async job doing all the work' do
+    expected_param = { 'something' => 'ok' }
+    expect_any_instance_of(Fourchette::PullRequest)
+      .to receive(:perform)
       .with(expected_param)
 
-    post "/hooks",
+    post '/hooks',
          expected_param.to_json,
-         "CONTENT_TYPE" => "application/json"
+         'CONTENT_TYPE' => 'application/json'
   end
 end

data/spec/lib/web/tarball_spec.rb

@@ -1,29 +1,28 @@
-require "spec_helper"
-require "support/sinatra_helper"
+require 'spec_helper'
+require 'support/sinatra_helper'
 
-describe "web tarball serving" do
-  context "valid and not expired URL" do
-    it "returns the file" do
+describe 'web tarball serving' do
+  context 'valid and not expired URL' do
+    it 'returns the file' do
       expire_in_2_secs = Time.now.to_i + 2
-      Fourchette::Tarball.any_instance
-        .should_receive(:filepath)
-        .with("1234567", expire_in_2_secs.to_s)
-        .and_return { "#{Dir.pwd}/spec/factories/fake_file" }
+      expect_any_instance_of(Fourchette::Tarball)
+        .to receive(:filepath)
+        .with('1234567', expire_in_2_secs.to_s) { "#{Dir.pwd}/spec/factories/fake_file" }
 
       get "/jipiboily/fourchette/1234567/#{expire_in_2_secs}"
-      expect(last_response.headers["Content-Type"]).to eq "application/x-tgz"
-      expect(last_response.body).to eq "some content..."
+      expect(last_response.headers['Content-Type']).to eq 'application/x-tgz'
+      expect(last_response.body).to eq 'some content...'
     end
   end
 
-  context "expired URL" do
-    it "does NOT returns the file if it is expired" do
+  context 'expired URL' do
+    it 'does NOT returns the file if it is expired' do
       expired_one_sec_ago = Time.now.to_i - 1
       get "/jipiboily/fourchette/1234567/#{expired_one_sec_ago}"
       expect(last_response).not_to be_ok
-      expect(last_response.body).not_to eq("Hello World")
+      expect(last_response.body).not_to eq('Hello World')
       expect(last_response.status).to eq(404)
-      subject.should_not_receive(:send_file)
+      expect(subject).not_to receive(:send_file)
     end
   end
 end

data/spec/spec_helper.rb

@@ -6,4 +6,4 @@ Coveralls.wear!
 require_relative '../lib/fourchette'
 
 support_include_path = "#{Dir.pwd}/spec/support/**/*.rb"
-Dir[support_include_path].each {|f| require f}
+Dir[support_include_path].each { |f| require f }

data/spec/support/silent-logger.rb

@@ -1,4 +1,4 @@
 Logger.class_eval do
-  def info(*args)
+  def info(*_args)
   end
-end
+end

data/spec/support/sinatra_helper.rb

@@ -1,4 +1,4 @@
-require "rack/test"
+require 'rack/test'
 include Rack::Test::Methods
 
 def app

data/templates/Gemfile

@@ -1,4 +1,4 @@
 source 'http://rubygems.org'
 
 gem 'puma'
-gem 'fourchette'
+gem 'fourchette'

data/templates/Rakefile

@@ -1 +1 @@
-require 'fourchette/rake_tasks'
+require 'fourchette/rake_tasks'

data/templates/callbacks.rb

@@ -1,9 +1,9 @@
-# This is a sample file to see how the really, really basic callback system works.
-# See the README for me or just dive in.
+# This is a sample file to see how the really, really basic callback system
+# works. See the README for me or just dive in.
 class Fourchette::Callbacks
   include Fourchette::Logger
 
-  def initialize params
+  def initialize(params)
     @params = params
   end
 
@@ -14,4 +14,4 @@ class Fourchette::Callbacks
   def after_all
     logger.info 'Placeholder for after steps... (see callbacks.rb to override)'
   end
-end
+end

data/templates/config/puma.rb

@@ -5,4 +5,4 @@ preload_app!
 
 rackup      DefaultRackup
 port        ENV['PORT']     || 9292
-environment ENV['RACK_ENV'] || 'development'
+environment ENV['RACK_ENV'] || 'development'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fourchette
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Jean-Philippe Boily
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-29 00:00:00.000000000 Z
+date: 2015-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -184,14 +184,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -309,7 +309,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Your new best friend for isolated testing environments on Heroku.