fortnox-api 1.0.0.rc2 → 1.0.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 355563e337538c18df2917f19aee3e0d91a1f7763fbb3a01bad441bd3956f496
-  data.tar.gz: 4898bf90e631edd152c4c44b1fda68c2284cc2f24e38cd712a8a0057e27a6c40
+  metadata.gz: 2297de9b35ce0c8d7f3f0e3b84f0a44a443062d257f843876657a6d26a4da160
+  data.tar.gz: b328a297acaa35278c2b943b10bc2dc04b7e8dfbf2dd65642346f35c572bb950
 SHA512:
-  metadata.gz: 5acaea5d925b3c8f60f817ff39d167f0e078e5ec32f7f86568cf853935ac4955431dd037c81b561ec2be081e09d46b1dbae9b3c3d204bbfbcfd2615bc4d19d50
-  data.tar.gz: 14ddc8dbdc2da42f8c09d6bb5ee11c47ceb6fa8faba6cd51da7c97d1fc4bbf4c3adcba67e2bbc831c2783a2841d4f292b3f358d608e31d84cae8e25222fa711b
+  metadata.gz: a73b124f68428feaaccbfea406a025bb24995b7dce7e88959dee7aca21ab449e4c92cbae11808b33c50cf8f8e498d6039399157cdcc5e68c3bcb6cfce5a35b30
+  data.tar.gz: aa5b472af7edc87d4f808581ae99545e1b99f33d7319890843d442d9f2c7d1afe7db6fb04d509a5524d5b7f405337e0b6043d8155be1e5b3ebf2b8e83d3e75e9

data/CHANGELOG.md

@@ -6,6 +6,29 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to
 [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.0.0.rc3] - 2026-05-08
+
+### Changed
+
+- `Fortnox::RequestError#message` now includes the API's
+  `ErrorInformation.Message` and code from the response body when present,
+  normalising Fortnox's inconsistent key casing (PascalCase vs lowercase)
+  across endpoints. Previously the message was only `"Request failed: <status>"`,
+  hiding the cause from logs and uncaught backtraces.
+- `Article#commodity_code`, `Customer#phone`, `Invoice#accounting_method`,
+  `Invoice#invoice_period_reference`, `Invoice#invoice_reference`,
+  `Document#time_basis_reference`, `Document#total_to_pay`, and
+  `Document#warehouse_ready` are now flagged read-only to match the Fortnox
+  API. Values set on these attributes are silently excluded from save
+  requests; previously they were sent and rejected by the API.
+
+### Fixed
+
+- `Order` and `Invoice` rows now serialise the VAT field as `VAT` instead of
+  `Vat`. Saving rows with a `vat` value previously failed with Fortnox
+  rejecting the request as `"Felaktigt fältnamn"`. This bug was introduced in the 1.0.0.rc1,
+  it did not exist in 0.x.
+
 ## [1.0.0.rc2] - 2026-05-05
 
 ### Added
@@ -22,16 +45,22 @@ and this project adheres to
   prescriptive default that didn't reflect the actual resource set. Other
   Fortnox scopes (`salary`, `bookkeeping`, etc.) can still be entered
   manually.
-- `TermsOfPayment.code` is now `Sized::String[25]` and required, matching
-  Fortnox API documentation. The rest-easy rewrite for rc1 briefly lost
-  the required flag.
-- `Unit.code` is now `Sized::String[20]` and required, matching Fortnox
-  API documentation. The rest-easy rewrite for rc1 briefly lost the
-  required flag.
+- `TermsOfPayment.code` now has a 25-character limit, matching Fortnox
+  API documentation.
+- `Unit.code` now has a 20-character limit, matching Fortnox API
+  documentation.
 - `Unit.description` is now `Sized::String[100]` and required, matching
   Fortnox API documentation. In 0.x and rc1 this was nullable client-side,
   but the Fortnox API rejected unset descriptions anyway.
 
+### Fixed
+
+- `TermsOfPayment.code` is required again, matching Fortnox API
+  documentation. The rest-easy rewrite for rc1 briefly lost the required
+  flag.
+- `Unit.code` is required again, matching Fortnox API documentation. The
+  rest-easy rewrite for rc1 briefly lost the required flag.
+
 ## [1.0.0.rc1] - 2026-05-04
 
 Version 1.0 is a complete rewrite of the gem and is **not** a drop-in
@@ -139,5 +168,6 @@ for the full list of breaking changes.
 For changes prior to the 1.0 rewrite, see the
 [0.x changelog](https://github.com/accodeing/fortnox-api/blob/v0.9.2/CHANGELOG.md).
 
+[1.0.0.rc3]: https://github.com/accodeing/fortnox-api/compare/v1.0.0.rc2...v1.0.0.rc3
 [1.0.0.rc2]: https://github.com/accodeing/fortnox-api/compare/v1.0.0.rc1...v1.0.0.rc2
 [1.0.0.rc1]: https://github.com/accodeing/fortnox-api/releases/tag/v1.0.0.rc1

data/README.md

@@ -16,7 +16,7 @@ Adding more resources is quick and easy, see the
 ## Status
 
 Version 1.0 is a complete rewrite, currently in release candidate
-(`1.0.0.rc2`). It is built on
+(`1.0.0.rc3`). It is built on
 [rest-easy](https://github.com/accodeing/rest-easy), replacing the old
 HTTParty + Data Mapper architecture with a single resource class per entity.
 Authorization uses the Fortnox client credentials flow.
@@ -68,8 +68,10 @@ The gem raises the following exceptions:
 
 - `Fortnox::Error` — base class for everything below. Rescue this to catch
   any error raised by the gem.
-- `Fortnox::RequestError` — 4xx/5xx responses from the Fortnox API. Carries
-  the response object as `.response`.
+- `Fortnox::RequestError` — 4xx/5xx responses from the Fortnox API. The
+  exception message includes the API's `ErrorInformation.Message` and code
+  when present (Fortnox is inconsistent about the key casing — the gem
+  normalises both). The full response is on `.response`.
 - `Fortnox::AttributeError` — base for attribute validation failures.
   - `Fortnox::ConstraintError` — an attribute value violates a type
     constraint (max size, format, etc.). Carries `.attribute_name` and

data/lib/fortnox/mappers/document_row.rb

@@ -6,7 +6,8 @@ module Fortnox
       struct    Structs::DocumentRow
       overrides housework: 'HouseWork',
                 housework_hours_to_report: 'HouseWorkHoursToReport',
-                housework_type: 'HouseWorkType'
+                housework_type: 'HouseWorkType',
+                vat: 'VAT'
     end
   end
 end

data/lib/fortnox/resources/article.rb

@@ -155,6 +155,6 @@ module Fortnox
     attr :default_stock_location, Coercible::String.optional
 
     # CommodityCode Commodity code of the article.
-    attr :commodity_code, Coercible::String.optional
+    attr :commodity_code, Coercible::String.optional, :read_only
   end
 end

data/lib/fortnox/resources/customer.rb

@@ -131,6 +131,9 @@ module Fortnox
     # Our reference
     attr :our_reference, Sized::String[50]
 
+    # Phone number of the customer. Only present in collection responses.
+    attr :phone, Coercible::String.optional, :read_only
+
     # First phone number of the customer
     attr :phone1, Sized::String[1024]
 
@@ -191,9 +194,6 @@ module Fortnox
     # Active If the customer is active.
     attr :active, Bool.optional, Boolean
 
-    # Phone number of the customer. Only present in collection responses.
-    attr :phone, Coercible::String.optional
-
     # External reference
     attr :external_reference, Sized::String[1024]
 

data/lib/fortnox/resources/document.rb

@@ -191,12 +191,12 @@ module Fortnox
     attr :outbound_date, Date.optional, Mappers::Date
 
     # TimeBasisReference Reference to time basis.
-    attr :time_basis_reference, Coercible::Integer.optional
+    attr :time_basis_reference, Coercible::Integer.optional, :read_only
 
     # TotalToPay Total amount to pay.
-    attr :total_to_pay, Coercible::Float.optional
+    attr :total_to_pay, Coercible::Float.optional, :read_only
 
     # WarehouseReady If the document is warehouse ready.
-    attr :warehouse_ready, Bool.optional, Boolean
+    attr :warehouse_ready, Bool.optional, :read_only, Boolean
   end
 end

data/lib/fortnox/resources/invoice.rb

@@ -12,7 +12,7 @@ module Fortnox
     end
 
     # AccountingMethod Accounting Method.
-    attr :accounting_method, AccountingMethods
+    attr :accounting_method, AccountingMethods, :read_only
 
     # Balance Balance of the invoice.
     attr :balance, Coercible::Float.optional, :read_only
@@ -51,10 +51,10 @@ module Fortnox
     attr :invoice_period_end, Date.optional, :read_only, Mappers::Date
 
     # InvoicePeriodReference Reference to the invoice period.
-    attr :invoice_period_reference, Coercible::String.optional
+    attr :invoice_period_reference, Coercible::String.optional, :read_only
 
     # InvoiceReference Reference to another invoice.
-    attr :invoice_reference, Coercible::String.optional
+    attr :invoice_reference, Coercible::String.optional, :read_only
 
     # InvoiceRows Separate object
     attr :invoice_rows, Strict::Array.of(Structs::InvoiceRow), Mappers::StructArray.for(Mappers::InvoiceRow)

data/lib/fortnox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Fortnox
-  VERSION = '1.0.0.rc2'
+  VERSION = '1.0.0.rc3'
 end

data/lib/fortnox.rb

@@ -23,11 +23,49 @@ module Fortnox
     def initialize(arg = nil)
       if arg.respond_to?(:status)
         @response = arg
-        super("Request failed: #{arg.status}")
+        super("Request failed: #{arg.status}#{format_body(arg.body)}")
       else
         super
       end
     end
+
+    BODY_FALLBACK_LIMIT = 500
+    private_constant :BODY_FALLBACK_LIMIT
+
+    private
+
+    def format_body(body)
+      return '' if body.nil? || body.empty?
+
+      " - #{error_details(body) || truncate(body.to_s)}"
+    end
+
+    # Fortnox have at least in the past sometimes returned HTML responses on error,
+    # for instance 503 Service Temporarily Unavailable.
+    # In that case, the body might be long and useful for debugging,
+    # so let's truncate it to a reasonable length if we end up here.
+    def truncate(string)
+      string.length > BODY_FALLBACK_LIMIT ? "#{string[0, BODY_FALLBACK_LIMIT]}…" : string
+    end
+
+    def error_details(body)
+      info = error_information(body)
+      message = info && info['message']
+      return nil unless message
+
+      code = info['code']
+      code ? "#{message} (#{code})" : message
+    end
+
+    def error_information(body)
+      parsed = body.is_a?(String) ? JSON.parse(body) : body
+      info = parsed['ErrorInformation'] if parsed.is_a?(Hash)
+      # Fortnox responds with inconsistently-cased error keys (see tests),
+      # so let's normalise to lowercase before reading.
+      info.is_a?(Hash) ? info.transform_keys(&:downcase) : nil
+    rescue JSON::ParserError
+      nil
+    end
   end
 
   class AttributeError < Error; end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fortnox-api
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc2
+  version: 1.0.0.rc3
 platform: ruby
 authors:
 - Jonas Schubert Erlandsson
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-05 00:00:00.000000000 Z
+date: 2026-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: countries