fortnox-api 0.8.2 → 0.9.0

data/spec/fortnox/api/models/base_spec.rb

@@ -24,19 +24,19 @@ describe Fortnox::API::Model::Base do
     end
 
     context 'without required attribute' do
-      subject { -> { entity_class.new({}) } }
-
-      it { is_expected.to raise_error Fortnox::API::Exception }
-      it { is_expected.to raise_error Fortnox::API::MissingAttributeError }
-      it { is_expected.to raise_error Fortnox::API::MissingAttributeError, /Missing attribute :string/ }
+      it do
+        expect do
+          entity_class.new({})
+        end.to raise_error Fortnox::API::MissingAttributeError, /Missing attribute :string/
+      end
     end
 
     context 'with invalid attribute value' do
-      subject { -> { entity_class.new(string: 'Test', account: 13_337) } }
-
-      it { is_expected.to raise_error Fortnox::API::Exception }
-      it { is_expected.to raise_error Fortnox::API::AttributeError }
-      it { is_expected.to raise_error Fortnox::API::AttributeError, /invalid type for :account/ }
+      it do
+        expect do
+          entity_class.new(string: 'Test', account: 13_337)
+        end.to raise_error Fortnox::API::AttributeError, /invalid type for :account/
+      end
     end
   end
 
@@ -44,15 +44,13 @@ describe Fortnox::API::Model::Base do
     let(:original) { entity_class.new(string: 'Test') }
 
     context 'with new, simple value' do
-      subject { updated_model }
-
-      let(:updated_model) { original.update(string: 'Variant') }
+      subject(:updated_model) { original.update(string: 'Variant') }
 
       it { is_expected.to be_new }
       it { is_expected.not_to be_saved }
 
       it 'returns a new object' do
-        is_expected.not_to eql(original)
+        expect(updated_model).not_to eql(original)
       end
 
       describe 'updated attribute' do
@@ -72,7 +70,7 @@ describe Fortnox::API::Model::Base do
       subject(:updated_model) { original.update(string: 'Test') }
 
       it 'returns the same object' do
-        is_expected.to eql(original)
+        expect(updated_model).to eql(original)
       end
 
       it 'returns a object with the same value' do
@@ -83,7 +81,7 @@ describe Fortnox::API::Model::Base do
       it { is_expected.not_to be_saved }
     end
 
-    context 'when updating' do
+    context 'when updating a saved entity' do
       let(:updated_entity) do
         saved_entity = entity_class.new(string: 'Saved', new: false, unsaved: false)
         saved_entity.update(string: 'Updated')
@@ -102,5 +100,18 @@ describe Fortnox::API::Model::Base do
         it { is_expected.to eq('Updated') }
       end
     end
+
+    context 'when updating a saved entity with nil values' do
+      subject(:updated_entity) { original.update(number: nil) }
+
+      let(:original) { entity_class.new(string: 'Saved', new: false, unsaved: false) }
+
+      it 'returns the same object' do
+        expect(updated_entity).to eql(original)
+      end
+
+      it { is_expected.not_to be_new }
+      it { is_expected.to be_saved }
+    end
   end
 end

data/spec/fortnox/api/models/unit_spec.rb

@@ -9,9 +9,11 @@ module Fortnox
     module Model
       describe Unit, type: :model do
         context 'when created from empty hash' do
-          subject { -> { described_class.new } }
-
-          it { is_expected.to raise_error(Fortnox::API::MissingAttributeError, /Missing attribute.*:code/) }
+          it {
+            expect do
+              described_class.new
+            end.to raise_error(Fortnox::API::MissingAttributeError, /Missing attribute.*:code/)
+          }
         end
 
         context 'when created from stub' do

data/spec/fortnox/api/repositories/article_spec.rb

@@ -10,13 +10,16 @@ require 'fortnox/api/repositories/examples/save'
 require 'fortnox/api/repositories/examples/save_with_specially_named_attribute'
 require 'fortnox/api/repositories/examples/search'
 
-describe Fortnox::API::Repository::Article, order: :defined, integration: true do
+describe Fortnox::API::Repository::Article, integration: true, order: :defined do
   include Helpers::Configuration
-
-  before { set_api_test_configuration }
+  include Helpers::Repositories
 
   subject(:repository) { described_class.new }
 
+  before { set_api_test_configuration }
+
+  # VCR: Requires a Financial Year in Fortnox, otherwise the sales account is not be available.
+  # VCR: Update requires that default accounts exists in the chart of accounts
   include_examples '.save',
                    :description,
                    additional_attrs: { sales_account: 1250 }
@@ -26,18 +29,20 @@ describe Fortnox::API::Repository::Article, order: :defined, integration: true d
                    :ean,
                    '5901234123457'
 
-  # When recording new VCR cassettes, expected matches must be increased
-  include_examples '.all', 33
+  # VCR: expected matches must be increased
+  include_examples '.all', 6
 
-  # When recording new VCR cassettes, expected matches must be increased
+  # VCR: Expected matches must be increased
+  # VCR: Create the searched Articles manually in Fortnox
   include_examples '.find', '1' do
     let(:find_by_hash_failure) { { description: 'Not Found' } }
-    let(:single_param_find_by_hash) { { find_hash: { articlenumber: 1 }, matches: 14 } }
+    let(:single_param_find_by_hash) { { find_hash: { articlenumber: 101 }, matches: 1 } }
 
     let(:multi_param_find_by_hash) do
-      { find_hash: { articlenumber: 1, description: 'Cykelpump' }, matches: 1 }
+      { find_hash: { articlenumber: 101, description: 'Hammer' }, matches: 1 }
     end
   end
 
-  include_examples '.search', :description, 'Testartikel', 2
+  # VCR: Expected mathes must be updated
+  include_examples '.search', :description, 'Test article', 3
 end

data/spec/fortnox/api/repositories/authentication_spec.rb

@@ -0,0 +1,103 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api'
+require 'fortnox/api/repositories/authentication'
+
+describe Fortnox::API::Repository::Authentication, integration: true do
+  include Helpers::Configuration
+
+  subject(:repository) { described_class.new }
+
+  before { set_api_test_configuration }
+
+  let(:vcr_dir) { 'authentication' }
+
+  let(:valid_response) do
+    VCR.use_cassette("#{vcr_dir}/valid_request") do
+      repository.renew_tokens(
+        refresh_token: ENV.fetch('FORTNOX_API_REFRESH_TOKEN'),
+        client_id: ENV.fetch('FORTNOX_API_CLIENT_ID'),
+        client_secret: ENV.fetch('FORTNOX_API_CLIENT_SECRET')
+      )
+    end
+  end
+
+  describe '#renew_tokens' do
+    context 'with invalid authorization' do
+      let(:request_with_nonsense_credentials) do
+        VCR.use_cassette("#{vcr_dir}/invalid_authorization") do
+          repository.renew_tokens(
+            refresh_token: ENV.fetch('FORTNOX_API_REFRESH_TOKEN'),
+            client_id: 'nonsense_id',
+            client_secret: 'nonsense_secret'
+          )
+        end
+      end
+
+      it 'raises an error' do
+        expect { request_with_nonsense_credentials }.to(
+          raise_error(Fortnox::API::RemoteServerError, /Unauthorized request(.)*Error:(.)*invalid_client/)
+        )
+      end
+    end
+
+    context 'with invalid refresh token' do
+      let(:request_with_invalid_refresh_token) do
+        VCR.use_cassette("#{vcr_dir}/invalid_refresh_token") do
+          repository.renew_tokens(
+            refresh_token: 'invalid_refresh_token',
+            client_id: ENV.fetch('FORTNOX_API_CLIENT_ID'),
+            client_secret: ENV.fetch('FORTNOX_API_CLIENT_SECRET')
+          )
+        end
+      end
+
+      it 'raises an error' do
+        expect { request_with_invalid_refresh_token }.to(
+          raise_error(Fortnox::API::RemoteServerError, /Bad request(.)*Error:(.)*Invalid refresh token/)
+        )
+      end
+    end
+
+    describe 'returned hash' do
+      subject { valid_response }
+
+      it { is_expected.to include(:access_token, :refresh_token, :expires_in, :token_type, :scope) }
+    end
+
+    describe 'access_token' do
+      subject { valid_response[:access_token] }
+
+      it { is_expected.to be_a(String) }
+      it { is_expected.not_to be_empty }
+    end
+
+    describe 'refresh_token' do
+      subject { valid_response[:refresh_token] }
+
+      it { is_expected.to be_a(String) }
+      it { is_expected.not_to be_empty }
+    end
+
+    describe 'expires_in' do
+      subject { valid_response[:expires_in] }
+
+      it { is_expected.to be_a(Integer) }
+    end
+
+    describe 'token_type' do
+      subject { valid_response[:token_type] }
+
+      it { is_expected.to be_a(String) }
+      it { is_expected.not_to be_empty }
+    end
+
+    describe 'scope' do
+      subject { valid_response[:scope] }
+
+      it { is_expected.to be_a(String) }
+      it { is_expected.not_to be_empty }
+    end
+  end
+end