fortnox-api 0.7.2 → 0.9.0

data/spec/fortnox/api/types/housework_types_spec.rb

@@ -7,62 +7,143 @@ require 'fortnox/api/repositories/order'
 require 'fortnox/api/models/order'
 require 'fortnox/api/types/order_row'
 
-# rubocop:disable RSpec/DescribeClass
 describe 'HouseworkTypes', integration: true do
   include Helpers::Configuration
+  include Helpers::Repositories
 
-  before { set_api_test_configuration }
+  before do
+    set_api_test_configuration
+    stub_const('TYPE_ROT', Fortnox::API::Types::TaxReductionTypes['rot'])
+    stub_const('TYPE_RUT', Fortnox::API::Types::TaxReductionTypes['rut'])
+  end
 
   let(:repository) { Fortnox::API::Repository::Order.new }
-  let(:valid_model) do
-    Fortnox::API::Model::Order.new(customer_number: '1', order_rows: [order_row])
-  end
-  let(:order_row) do
-    Fortnox::API::Types::OrderRow.new(ordered_quantity: 1,
-                                      article_number: '0000',
-                                      housework_type: housework_type)
-  end
 
-  shared_examples_for 'housework type' do |type, legacy: false|
-    subject do
-      lambda do
-        VCR.use_cassette("orders/housework_type_#{type.downcase}") do
-          repository.save(valid_model)
-        end
-      end
+  shared_examples_for 'housework type' do |type, tax_reduction_type, legacy: false, housework: true|
+    let(:document) do
+      Fortnox::API::Model::Order.new(
+        customer_number: '1',
+        tax_reduction_type: Object.const_get(tax_reduction_type),
+        order_rows: [
+          Fortnox::API::Types::OrderRow.new(
+            ordered_quantity: 1,
+            article_number: '101',
+            housework_type: Fortnox::API::Types::HouseworkTypes[type],
+            housework: housework
+          )
+        ]
+      )
+    end
+    let(:save) do
+      -> { VCR.use_cassette("orders/housework_type_#{type.downcase}") { repository.save(document) } }
     end
-
-    let(:error_message) { 'Skattereduktion för den valda typen av husarbete har upphört.' }
-    let(:housework_type) { Fortnox::API::Types::HouseworkTypes[type] }
 
     context "when creating an OrderRow with housework_type set to #{type}" do
       if legacy
-        it 'raises an error' do
-          is_expected.to raise_error(Fortnox::API::RemoteServerError, error_message)
-        end
+        let(:error_message) { /Skattereduktion för den valda typen av husarbete har upphört/ }
+
+        specify { expect { save.call }.to raise_error(Fortnox::API::RemoteServerError, error_message) }
       else
-        it { is_expected.not_to raise_error }
+        specify { expect { save.call }.not_to raise_error }
       end
     end
   end
 
-  it_behaves_like 'housework type', 'CONSTRUCTION'
-  it_behaves_like 'housework type', 'ELECTRICITY'
-  it_behaves_like 'housework type', 'GLASSMETALWORK'
-  it_behaves_like 'housework type', 'GROUNDDRAINAGEWORK'
-  it_behaves_like 'housework type', 'MASONRY'
-  it_behaves_like 'housework type', 'PAINTINGWALLPAPERING'
-  it_behaves_like 'housework type', 'HVAC'
-  it_behaves_like 'housework type', 'CLEANING'
-  it_behaves_like 'housework type', 'TEXTILECLOTHING'
-  it_behaves_like 'housework type', 'CLEANING'
-  it_behaves_like 'housework type', 'SNOWPLOWING'
-  it_behaves_like 'housework type', 'GARDENING'
-  it_behaves_like 'housework type', 'BABYSITTING'
-  it_behaves_like 'housework type', 'OTHERCARE'
-  it_behaves_like 'housework type', 'OTHERCOSTS'
-
-  it_behaves_like 'housework type', 'COOKING', legacy: true
-  it_behaves_like 'housework type', 'TUTORING', legacy: true
+  it_behaves_like 'housework type', 'CONSTRUCTION', 'TYPE_ROT'
+  it_behaves_like 'housework type', 'ELECTRICITY', 'TYPE_ROT'
+  it_behaves_like 'housework type', 'GLASSMETALWORK', 'TYPE_ROT'
+  it_behaves_like 'housework type', 'GROUNDDRAINAGEWORK', 'TYPE_ROT'
+  it_behaves_like 'housework type', 'MASONRY', 'TYPE_ROT'
+  it_behaves_like 'housework type', 'PAINTINGWALLPAPERING', 'TYPE_ROT'
+  it_behaves_like 'housework type', 'HVAC', 'TYPE_ROT'
+  it_behaves_like 'housework type', 'OTHERCOSTS', 'TYPE_ROT', housework: false
+
+  it_behaves_like 'housework type', 'MAJORAPPLIANCEREPAIR', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'MOVINGSERVICES', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'ITSERVICES', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'CLEANING', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'TEXTILECLOTHING', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'SNOWPLOWING', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'GARDENING', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'BABYSITTING', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'OTHERCARE', 'TYPE_RUT'
+  it_behaves_like 'housework type', 'OTHERCOSTS', 'TYPE_RUT', housework: false
+
+  # rubocop:disable RSpec/RepeatedExample
+  # rubocop:disable RSpec/RepeatedDescription
+  it 'will soon be added' do
+    pending 'todo'
+    raise StandardError, 'Will be supported 2021-01-01'
+    # it_behaves_like 'housework type', 'HOMEMAINTENANCE', TYPE_RUT
+    # it_behaves_like 'housework type', 'FURNISHING', TYPE_RUT
+    # it_behaves_like 'housework type', 'TRANSPORTATIONSERVICES', TYPE_RUT
+    # it_behaves_like 'housework type', 'WASHINGANDCAREOFCLOTHING', TYPE_RUT
+  end
+
+  it 'will soon be added' do
+    pending 'todo'
+    raise StandardError, 'Will be supported 2021-01-01'
+    # it_behaves_like 'housework type', 'SOLARCELLS', TYPE_GREEN
+    # it_behaves_like 'housework type', 'STORAGESELFPRODUCEDELECTRICTY', TYPE_GREEN
+    # it_behaves_like 'housework type', 'CHARGINGSTATIONELECTRICVEHICLE', TYPE_GREEN
+    # it_behaves_like 'housework type', 'OTHERCOSTS', TYPE_GREEN
+  end
+  # rubocop:enable RSpec/RepeatedExample
+  # rubocop:enable RSpec/RepeatedDescription
+
+  it_behaves_like 'housework type', 'COOKING', 'TYPE_RUT', legacy: true
+  it_behaves_like 'housework type', 'TUTORING', 'TYPE_RUT', legacy: true
+
+  describe 'with OTHERCOSTS' do
+    let(:document) do
+      Fortnox::API::Model::Order.new(
+        customer_number: '1',
+        tax_reduction_type: TYPE_ROT,
+        order_rows: [
+          Fortnox::API::Types::OrderRow.new(
+            ordered_quantity: 1,
+            article_number: '101',
+            housework_type: Fortnox::API::Types::HouseworkTypes['OTHERCOSTS'],
+            housework: true
+          )
+        ]
+      )
+    end
+
+    let(:error_message) { /Kan inte sätta typen övrig kostnad på en rad markerad som husarbete/ }
+
+    it "can't have housework set to true" do
+      expect do
+        VCR.use_cassette('orders/housework_othercoses_invalid') { repository.save(document) }
+      end.to raise_error(Fortnox::API::RemoteServerError, error_message)
+    end
+  end
+
+  describe 'with wrong tax reduction type' do
+    let(:type) { 'CONSTRUCTION' }
+    let(:document) do
+      Fortnox::API::Model::Order.new(
+        customer_number: '1',
+        tax_reduction_type: TYPE_RUT,
+        order_rows: [
+          Fortnox::API::Types::OrderRow.new(
+            ordered_quantity: 1,
+            article_number: '101',
+            housework_type: Fortnox::API::Types::HouseworkTypes[type],
+            housework: true
+          )
+        ]
+      )
+    end
+
+    let(:error_message) do
+      /Dokument med skattereduktionstypen '#{TYPE_RUT}' får inte innehålla rader med husarbetestypen '#{type}'/
+    end
+
+    it 'raises an error' do
+      expect do
+        VCR.use_cassette('orders/housework_invalid_tax_reduction_type') { repository.save(document) }
+      end.to raise_error(Fortnox::API::RemoteServerError, error_message)
+    end
+  end
 end
-# rubocop:enable RSpec/DescribeClass

data/spec/fortnox/api/types/model_spec.rb

@@ -6,22 +6,18 @@ require 'fortnox/api/types/model'
 
 RSpec.describe Fortnox::API::Types::Model do
   shared_examples_for 'raises error' do |error|
-    using_test_classes do
-      module Types
-        include Dry::Types.module
+    before do
+      stub_const('Types::Age', Dry::Types['strict.integer'].constrained(gt: 18).is(:required))
 
-        Age = Int.constrained(gt: 18).is(:required)
-      end
-
-      class TypesModelUser < Fortnox::API::Types::Model
+      types_model_user_class = Class.new(Fortnox::API::Types::Model) do
         attribute :age, Types::Age
       end
+
+      stub_const('TypesModelUser', types_model_user_class)
     end
 
     describe "User inheriting from #{described_class}" do
-      subject { -> { TypesModelUser.new(args) } }
-
-      it { is_expected.to raise_error(error) }
+      specify { expect { TypesModelUser.new(args) }.to raise_error(error) }
     end
   end
 
@@ -32,28 +28,22 @@ RSpec.describe Fortnox::API::Types::Model do
   end
 
   context 'when omitting optional keys' do
-    using_test_class do
-      module Types
-        include Dry::Types.module
+    before do
+      stub_const('Types::Nullable::String', Dry::Types['strict.string'].optional)
 
-        module Nullable
-          String = Types::Strict::String.optional
-        end
-      end
-
-      class User < Fortnox::API::Types::Model
+      user_class = Class.new(Fortnox::API::Types::Model) do
         attribute :optional_string, Types::Nullable::String
       end
-    end
 
-    subject { -> { User.new } }
+      stub_const('User', user_class)
+    end
 
-    it { is_expected.not_to raise_error }
+    specify { expect { User.new }.not_to raise_error }
 
     describe 'optional attribute' do
       subject { User.new.optional_string }
 
-      it { is_expected.to be nil }
+      it { is_expected.to be_nil }
     end
   end
 end

data/spec/fortnox/api/types/nullable_spec.rb

@@ -8,52 +8,72 @@ describe Fortnox::API::Types::Nullable, type: :type do
   subject { TestStruct }
 
   describe 'String' do
-    using_test_class do
-      class TestStruct < Dry::Struct
+    before do
+      test_struct_class = Class.new(Dry::Struct) do
         attribute :string, Fortnox::API::Types::Nullable::String
       end
+
+      stub_const('TestStruct', test_struct_class)
     end
 
     it { is_expected.to have_nullable(:string, 'A simple message', 0, '0') }
   end
 
   describe 'Float' do
-    using_test_class do
-      class TestStruct < Dry::Struct
+    before do
+      test_struct_class = Class.new(Dry::Struct) do
         attribute :float, Fortnox::API::Types::Nullable::Float
       end
+
+      stub_const('TestStruct', test_struct_class)
     end
 
     it { is_expected.to have_nullable(:float, 14.0, 'Not a Float!', 0.0) }
   end
 
   describe 'Integer' do
-    using_test_class do
-      class TestStruct < Dry::Struct
+    before do
+      test_struct_class = Class.new(Dry::Struct) do
         attribute :integer, Fortnox::API::Types::Nullable::Integer
       end
+
+      stub_const('TestStruct', test_struct_class)
     end
 
     it { is_expected.to have_nullable(:integer, 14, 14.0, 14) }
   end
 
   describe 'Boolean' do
-    using_test_class do
-      class TestStruct < Dry::Struct
+    before do
+      test_struct_class = Class.new(Dry::Struct) do
         attribute :boolean, Fortnox::API::Types::Nullable::Boolean
       end
+
+      stub_const('TestStruct', test_struct_class)
     end
 
     it { is_expected.to have_nullable(:boolean, true, 'Not a Boolean!', false) }
   end
 
   describe 'Date' do
-    using_test_class do
-      class TestStruct < Dry::Struct
+    before do
+      test_struct_class = Class.new(Dry::Struct) do
         attribute :date, Fortnox::API::Types::Nullable::Date
       end
+
+      stub_const('TestStruct', test_struct_class)
     end
 
     it { is_expected.to have_nullable_date(:date, Date.new(2016, 1, 1), 'Not a Date!') }
+
+    context 'with empty string' do
+      subject { TestStruct.new(date: '').date }
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'with invalid date' do
+      it { expect { TestStruct.new(date: 'Not a Date!') }.to raise_error(Fortnox::API::AttributeError, /invalid date/) }
+    end
   end
 end

data/spec/fortnox/api/types/order_row_spec.rb

@@ -5,10 +5,10 @@ require 'fortnox/api/types/order_row'
 require 'fortnox/api/types/examples/document_row'
 
 RSpec.describe Fortnox::API::Types::OrderRow, type: :type do
-  valid_hash = { ordered_quantity: 10.5 }
-
   subject { described_class }
 
+  valid_hash = { ordered_quantity: 10.5 }
+
   it { is_expected.to require_attribute(:ordered_quantity, valid_hash) }
 
   it_behaves_like 'DocumentRow', valid_hash

data/spec/fortnox/api/types/required_spec.rb

@@ -5,28 +5,19 @@ require 'fortnox/api/types'
 require 'fortnox/api/types/required'
 
 describe Fortnox::API::Types::Required, type: :type do
-  using_test_class do
-    class TestClass < Dry::Struct
-    end
-  end
+  before { stub_const('TestClass', Class.new(Dry::Struct)) }
 
   shared_examples_for 'required attribute' do |_type|
-    subject { -> { TestClass.new({}) } }
-
-    let(:error_message) do
-      "[#{TestClass}.new] #{:required_attribute.inspect} is missing in Hash input"
-    end
-
-    it 'raises an error' do
-      is_expected.to raise_error(Dry::Struct::Error, error_message)
-    end
+    let(:error_message) { "[#{TestClass}.new] #{:required_attribute.inspect} is missing in Hash input" }
+    specify { expect { TestClass.new({}) }.to raise_error(Dry::Struct::Error, error_message) }
   end
 
   describe 'String' do
     before do
-      class TestClass
+      test_class = Class.new(TestClass) do
         attribute :required_attribute, Fortnox::API::Types::Required::String
       end
+      stub_const('TestClass', test_class)
     end
 
     include_examples 'required attribute', String
@@ -34,9 +25,10 @@ describe Fortnox::API::Types::Required, type: :type do
 
   describe 'Float' do
     before do
-      class TestClass
+      test_class = Class.new(TestClass) do
         attribute :required_attribute, Fortnox::API::Types::Required::Float
       end
+      stub_const('TestClass', test_class)
     end
 
     include_examples 'required attribute', Float

data/spec/fortnox/api/types/sales_account_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api/types'
+require 'fortnox/api/types/examples/types'
+
+describe Fortnox::API::Types do
+  let(:klass) { Fortnox::API::Types::SalesAccount }
+
+  describe 'SalesAccount' do
+    context 'when created with nil' do
+      subject { klass[nil] }
+
+      it { is_expected.to be_nil }
+    end
+
+    context 'when created with empty string' do
+      subject { klass[''] }
+
+      it { is_expected.to be_nil }
+    end
+
+    [-12_345, -1_234, -123, -1, 0, 1, 12, 123, 1_234.0, 12_345].each do |invalid_number|
+      context "with #{invalid_number}" do
+        it 'raises ConstraintError' do
+          expect { klass[invalid_number] }.to raise_error(Dry::Types::ConstraintError)
+        end
+      end
+    end
+
+    context 'with 4 digits' do
+      subject { klass[1_234] }
+
+      it { is_expected.to eq('1234') }
+    end
+
+    context 'when created with valid string' do
+      include_examples 'equals input', '1234'
+    end
+
+    context 'when created with a too many digits' do
+      include_examples 'raises ConstraintError', '12345'
+    end
+
+    context 'when created with too few digits' do
+      include_examples 'raises ConstraintError', '123'
+    end
+
+    context 'when created with a negative number' do
+      include_examples 'raises ConstraintError', '-1234'
+    end
+
+    context 'when created with characters' do
+      include_examples 'raises ConstraintError', 'abcd'
+    end
+  end
+end

data/spec/fortnox/api_spec.rb

@@ -4,14 +4,7 @@ require 'spec_helper'
 require 'fortnox/api'
 
 describe Fortnox::API do
-  before do
-    module Fortnox
-      module API
-        class TestBase
-        end
-      end
-    end
-  end
+  before { stub_const('Fortnox::API::TestBase', Class.new) }
 
   describe 'configuration defaults' do
     subject(:config_value) { described_class.config[config_key] }
@@ -21,37 +14,13 @@ describe Fortnox::API do
     describe 'base_url' do
       let(:config_key) { :base_url }
 
-      it { is_expected.to eql 'https://api.fortnox.se/3/' }
-    end
-
-    describe 'client_secret' do
-      let(:config_key) { :client_secret }
-
-      it { is_expected.to be_nil }
-    end
-
-    describe 'access_token' do
-      let(:config_key) { :access_token }
-
-      it { is_expected.to be_nil }
-    end
-
-    describe 'access_tokens' do
-      let(:config_key) { :access_tokens }
-
-      it { is_expected.to be_nil }
+      it { is_expected.to eq 'https://api.fortnox.se/3/' }
     end
 
-    describe 'token_store' do
-      let(:config_key) { :token_store }
-
-      it { is_expected.to eql({}) }
-    end
-
-    describe 'debugging' do
-      let(:config_key) { :debugging }
+    describe 'token_url' do
+      let(:config_key) { :token_url }
 
-      it { is_expected.to be false }
+      it { is_expected.to eq 'https://apps.fortnox.se/oauth-v1/token' }
     end
 
     describe 'logger' do
@@ -67,104 +36,30 @@ describe Fortnox::API do
     end
   end
 
-  describe 'access_token' do
-    context 'when set to a String' do
-      subject { described_class.config.access_token }
-
-      before { described_class.configure { |config| config.access_token = value } }
-      let(:value) { '12345' }
-
-      it { is_expected.to eql value }
-    end
-
-    shared_examples_for 'invalid argument' do
-      subject { -> { described_class.configure { |config| config.access_token = value } } }
-
-      it { is_expected.to raise_error(ArgumentError, /expected a String/) }
-    end
-
-    context 'when set to a Hash' do
-      include_examples 'invalid argument' do
-        let(:value) { { a: '123' } }
-      end
-    end
-
-    context 'when set to an Array' do
-      include_examples 'invalid argument' do
-        let(:value) { %w[123 456] }
-      end
-    end
-  end
-
-  describe 'access_tokens' do
-    context 'when set to a String' do
-      subject { -> { described_class.configure { |config| config.access_tokens = '12345' } } }
-
-      it { is_expected.to raise_error(ArgumentError, /expected a Hash or an Array/) }
-    end
-
-    shared_examples_for 'valid argument' do
-      subject { described_class.config.access_tokens }
-
-      before { described_class.configure { |config| config.access_tokens = value } }
-
-      it { is_expected.to eql(value) }
-    end
-
-    context 'when set to a Hash' do
-      include_examples 'valid argument' do
-        let(:value) { { a: '123', b: '456' } }
-      end
-    end
-
-    context 'when set to an Array' do
-      include_examples 'valid argument' do
-        let(:value) { %w[123 456] }
-      end
-    end
-  end
-
-  describe 'token_store' do
-    subject { described_class.config[:token_store] }
-
-    context 'when access_token set' do
-      before { described_class.configure { |config| config.access_token = access_token } }
-      let(:access_token) { '12345' }
-
-      it { is_expected.to eql(default: access_token) }
-    end
-
-    context 'when access_tokens is' do
-      before { described_class.configure { |config| config.access_tokens = access_tokens } }
-
-      describe 'a Hash' do
-        let(:access_tokens) { { a: '123', b: '456' } }
-
-        it { is_expected.to eql(access_tokens) }
-      end
-
-      describe 'an Array' do
-        let(:access_tokens) { %w[123 456] }
-
-        it { is_expected.to eql(default: access_tokens) }
-      end
-    end
-  end
-
   describe 'readers for' do
     describe 'debugging' do
-      subject { described_class.debugging }
+      subject(:debugging) { described_class.debugging }
 
       it 'is available' do
-        is_expected.to be false
+        expect(debugging).to be false
       end
     end
 
     describe 'logger' do
-      subject { described_class.logger }
+      subject(:logger) { described_class.logger }
 
       it 'is available' do
-        is_expected.to be_a Logger
+        expect(logger).to be_a Logger
+      end
+    end
+  end
+
+  describe '#access_token' do
+    context 'when token is set' do
+      before { described_class.access_token = 'an_access_token' }
+
+      it 'returns the token' do
+        expect(described_class.access_token).to eq('an_access_token')
       end
     end
   end

data/spec/spec_helper.rb

@@ -20,26 +20,12 @@ RSpec.configure do |config|
   config.extend Helpers # Allow access to helpers in describe and context blocks
   config.include Helpers # Allow access to helpers in it and let blocks
 
-  config.include Helpers::Repositories, integration: true
   config.include Matchers::Type, type: :type
 
   config.order = 'random'
 
   WebMock.disable_net_connect!(allow: 'codeclimate.com')
 
-  config.before do
-    module Test
-      def self.remove_constants
-        constants.each { |const| remove_const(const) }
-        self
-      end
-    end
-  end
-
-  config.after do
-    Object.send(:remove_const, Test.remove_constants.name)
-  end
-
   # Reset configuration after each test run
   config.after do
     Fortnox::API::DEFAULT_CONFIGURATION.each do |key, value|