fortnox-api 0.6.2 → 0.8.0

data/spec/fortnox/api/mappers/contexts/json_conversion.rb

@@ -40,7 +40,7 @@ shared_context 'with JSON conversion' do
         attribute :url, 'strict.string'
         attribute :name, 'strict.string'
         attribute :vat, 'strict.float'
-        attribute :categories, Dry::Types['coercible.array'].member(Test::Category)
+        attribute :categories, Dry::Types['coercible.array'].of(Test::Category)
         attribute :designer, Test::ProductDesigner
       end
     end

data/spec/fortnox/api/repositories/article_spec.rb

@@ -26,11 +26,13 @@ describe Fortnox::API::Repository::Article, order: :defined, integration: true d
                    :ean,
                    '5901234123457'
 
-  include_examples '.all', 12
+  # When recording new VCR cassettes, expected matches must be increased
+  include_examples '.all', 29
 
+  # When recording new VCR cassettes, expected matches must be increased
   include_examples '.find', '1' do
     let(:find_by_hash_failure) { { description: 'Not Found' } }
-    let(:single_param_find_by_hash) { { find_hash: { articlenumber: 1 }, matches: 3 } }
+    let(:single_param_find_by_hash) { { find_hash: { articlenumber: 1 }, matches: 13 } }
 
     let(:multi_param_find_by_hash) do
       { find_hash: { articlenumber: 1, description: 'Cykelpump' }, matches: 1 }

data/spec/fortnox/api/repositories/base_spec.rb

@@ -6,18 +6,25 @@ require 'fortnox/api'
 describe Fortnox::API::Repository::Base do
   using_test_class do
     module Model
-      class Test
+      class RepositoryBaseTest
       end
     end
     module Repository
       class Test < Fortnox::API::Repository::Base
-        MODEL = Model::Test
+        MODEL = Model::RepositoryBaseTest
       end
     end
+  end
+
+  before do
+    Fortnox::API::Registry.register(:repositorybasetest, Model::RepositoryBaseTest)
+  end
 
-    require 'dry/container/stub'
-    Fortnox::API::Registry.enable_stubs!
-    Fortnox::API::Registry.stub(:test, Model::Test)
+  after do
+    # HACK: Currently, there is no way to remove keys from the Dry::Container#register.
+    # We could move the register call to a before(:all) hook, but that registered key
+    # would then leak into other tests. Instead, we can simply delete it with this little hack :)
+    Fortnox::API::Registry._container.delete('repositorybasetest')
   end
 
   let(:access_token) { '3f08d038-f380-4893-94a0-a08f6e60e67a' }
@@ -36,7 +43,7 @@ describe Fortnox::API::Repository::Base do
 
   describe 'creation' do
     shared_examples_for 'missing configuration' do
-      subject { -> { repository } }
+      subject { -> { Repository::Test.new(token_store: :store1).get('nonsense') } }
 
       let(:error) { Fortnox::API::MissingConfiguration }
 
@@ -45,14 +52,27 @@ describe Fortnox::API::Repository::Base do
 
     context 'without base url' do
       include_examples 'missing configuration' do
-        before { Fortnox::API.configure { |conf| conf.base_url = nil } }
+        before do
+          Fortnox::API.configure do |config|
+            config.base_url = nil
+            config.client_secret = client_secret
+            config.access_tokens = { store1: access_token }
+          end
+        end
+
         let(:message) { 'have to provide a base url' }
       end
     end
 
     context 'without client secret' do
       include_examples 'missing configuration' do
-        before { Fortnox::API.configure { |conf| conf.client_secret = nil } }
+        before do
+          Fortnox::API.configure do |config|
+            config.client_secret = nil
+            config.access_tokens = { store1: access_token }
+          end
+        end
+
         let(:message) { 'have to provide your client secret' }
       end
     end

data/spec/fortnox/api/repositories/customer_spec.rb

@@ -38,5 +38,33 @@ describe Fortnox::API::Repository::Customer, order: :defined, integration: true
     end
   end
 
-  include_examples '.search', :name, 'Test', 23
+  # When recording new VCR casettes, expected matches must be increased
+  include_examples '.search', :name, 'Test', 31
+
+  describe 'country reference' do
+    describe 'with valid country code \'SE\'' do
+      subject(:customer) do
+        VCR.use_cassette("#{vcr_dir}/save_new_with_country_code_SE") do
+          repository.save(
+            described_class::MODEL.new(
+              name: 'Customer with Swedish country code',
+              country_code: 'SE'
+            )
+          )
+        end
+      end
+
+      describe 'country code' do
+        subject { customer.country_code }
+
+        it { is_expected.to eq('SE') }
+      end
+
+      describe 'country' do
+        subject { customer.country }
+
+        it { is_expected.to eq('Sverige') }
+      end
+    end
+  end
 end

data/spec/fortnox/api/repositories/invoice_spec.rb

@@ -37,7 +37,7 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
 
   # It is not possible to delete Invoces. Therefore, expected nr of Orders
   # when running .all will continue to increase (until 100, which is max by default).
-  include_examples '.all', 60
+  include_examples '.all', 100
 
   include_examples '.find', 1 do
     let(:find_by_hash_failure) { { yourreference: 'Not found' } }
@@ -51,7 +51,151 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
     end
   end
 
-  include_examples '.search', :customername, 'Test', 3
+  include_examples '.search', :customername, 'Test', 7
 
-  include_examples '.only', :fullypaid, 1
+  include_examples '.only', :fullypaid, 4
+
+  describe 'country attribute' do
+    def new_invoice(country:)
+      described_class::MODEL.new(customer_number: 1, country: country)
+    end
+
+    context 'with valid country' do
+      def save_invoice(country:, vcr_cassette: country)
+        VCR.use_cassette("#{vcr_dir}/save_new_with_country_#{vcr_cassette}") do
+          repository.save(new_invoice(country: country))
+        end
+      end
+
+      it 'accepts English country names' do
+        expect(save_invoice(country: 'Norway').country).to eq('NO')
+      end
+
+      it 'translates Swedish country names to English' do
+        expect(save_invoice(country: 'Norge').country).to eq('NO')
+      end
+
+      it 'skips nil values' do
+        expect(save_invoice(country: nil, vcr_cassette: 'nil').country).to eq('')
+      end
+
+      it 'skips empty string values' do
+        expect(save_invoice(country: '', vcr_cassette: 'empty_string').country).to eq('')
+      end
+
+      describe 'GB' do
+        subject { save_invoice(country: 'GB').country }
+
+        it { is_expected.to eq('GB') }
+      end
+
+      describe 'KR' do
+        subject { save_invoice(country: 'KR').country }
+
+        it { is_expected.to eq('KR') }
+      end
+
+      describe 'VA' do
+        subject { save_invoice(country: 'VA').country }
+
+        it { is_expected.to eq('VA') }
+      end
+
+      describe 'VI' do
+        subject { save_invoice(country: 'VI').country }
+
+        it { is_expected.to eq('VI') }
+      end
+
+      describe 'special cases Sverige' do
+        subject { save_invoice(country: 'Sverige').country }
+
+        it { is_expected.to eq('SE') }
+      end
+    end
+  end
+
+  describe 'resetting values in Fortnox' do
+    context 'with String values' do
+      def new_invoice(comments:)
+        described_class::MODEL.new(customer_number: 1, comments: comments)
+      end
+
+      let(:persisted_invoice) do
+        VCR.use_cassette("#{vcr_dir}/save_new_with_comments") do
+          repository.save(new_invoice(comments: 'A comment to be reset'))
+        end
+      end
+
+      before { persisted_invoice }
+
+      context 'when setting value to nil' do
+        subject { updated_persisted_invoice.comments }
+
+        let(:updated_persisted_invoice) do
+          VCR.use_cassette("#{vcr_dir}/save_old_with_nil_comments") do
+            repository.save(persisted_invoice.update(comments: nil))
+          end
+        end
+
+        pending { is_expected.to eq(nil) }
+      end
+
+      context 'when setting value to empty string' do
+        subject { updated_persisted_invoice.comments }
+
+        let(:updated_persisted_invoice) do
+          VCR.use_cassette("#{vcr_dir}/save_old_with_empty_comments") do
+            repository.save(persisted_invoice.update(comments: ''))
+          end
+        end
+
+        it 'does not reset the value' do
+          is_expected.to eq('A comment to be reset')
+        end
+      end
+    end
+
+    context 'with other values' do
+      def new_invoice(country:)
+        described_class::MODEL.new(customer_number: 1, country: country)
+      end
+
+      let(:persisted_invoice) do
+        VCR.use_cassette("#{vcr_dir}/save_new_with_country") do
+          repository.save(new_invoice(country: 'Sverige'))
+        end
+      end
+
+      before { persisted_invoice }
+
+      context 'when setting value to nil' do
+        subject { updated_persisted_invoice.country }
+
+        let(:updated_persisted_invoice) do
+          # TODO: This VCR cassette needs to be re-recorded again
+          # when the we fix #172.
+          VCR.use_cassette("#{vcr_dir}/save_old_with_nil_country") do
+            repository.save(persisted_invoice.update(country: nil))
+          end
+        end
+
+        pending { is_expected.to eq(nil) }
+      end
+
+      context 'when setting value to empty string' do
+        subject { updated_persisted_invoice.country }
+
+        let(:updated_persisted_invoice) do
+          VCR.use_cassette("#{vcr_dir}/save_old_with_empty_country") do
+            repository.save(persisted_invoice.update(country: ''))
+          end
+        end
+
+        it 'does not reset the country' do
+          is_expected.to eq('SE')
+        end
+      end
+    end
+  end
 end

data/spec/fortnox/api/repositories/order_spec.rb

@@ -45,7 +45,7 @@ describe Fortnox::API::Repository::Order, order: :defined, integration: true do
     end
   end
 
-  include_examples '.search', :customername, 'A customer', 2
+  include_examples '.search', :customername, 'A customer', 3
 
-  include_examples '.only', :cancelled, 3
+  include_examples '.only', :cancelled, 6
 end

data/spec/fortnox/api/repositories/project_spec.rb

@@ -22,7 +22,7 @@ describe Fortnox::API::Repository::Project, order: :defined, integration: true d
   # It is not yet possible to delete Projects. Therefore, expected nr of
   # Projects when running .all will continue to increase
   # (until 100, which is max by default).
-  include_examples '.all', 8
+  include_examples '.all', 33
 
   include_examples '.find', '1' do
     let(:find_by_hash_failure) { { offset: 10_000 } }

data/spec/fortnox/api/repositories/terms_of_payment_spec.rb

@@ -17,11 +17,13 @@ describe Fortnox::API::Repository::TermsOfPayment, order: :defined, integration:
 
   before { set_api_test_configuration }
 
-  required_hash = { code: '15DAYS' }
+  # When recording new VCR cassettes, code must be changed to a new unique one
+  required_hash = { code: '19DAYS' }
 
   include_examples '.save', :description, additional_attrs: required_hash
 
-  include_examples '.all', 9
+  # When recording new VCR cassettes, expected matches needs to be increased
+  include_examples '.all', 13
 
   include_examples '.find', '15DAYS', find_by_hash: false do
     let(:find_by_hash_failure) { { code: '15days' } }

data/spec/fortnox/api/repositories/unit_spec.rb

@@ -16,16 +16,19 @@ describe Fortnox::API::Repository::Unit, order: :defined, integration: true do
 
   subject(:repository) { described_class.new }
 
+  # When recording new VCR cassettes, code needs to be changed to a unique value
   include_examples '.save',
                    :description,
-                   additional_attrs: { code: 'blarg' }
+                   additional_attrs: { code: 'blarg5' }
 
+  # When recording new VCR cassettes, code needs to be changed to a unique value
   include_examples '.save with specially named attribute',
                    { description: 'Happy clouds' },
                    :code,
-                   'woooh'
+                   'woooh5'
 
-  include_examples '.all', 6
+  # When recording new VCR cassettes, expected number must be updated
+  include_examples '.all', 14
 
   include_examples '.find', 'blarg', find_by_hash: false do
     let(:find_by_hash_failure) { { code: 'notfound' } }

data/spec/fortnox/api/types/account_number_spec.rb

@@ -7,25 +7,29 @@ require 'fortnox/api/types/examples/types'
 describe Fortnox::API::Types do
   let(:klass) { Fortnox::API::Types::AccountNumber }
 
-  context 'when AccountNumber created with nil' do
-    subject { klass[nil] }
+  describe 'AccountNumber' do
+    context 'when created with nil' do
+      subject { klass[nil] }
 
-    it { is_expected.to be_nil }
-  end
+      it { is_expected.to be_nil }
+    end
 
-  context 'when AccountNumber created with empty string' do
-    include_examples 'raises ConstraintError', ''
-  end
+    context 'when created with empty string' do
+      subject { klass[''] }
 
-  context 'when AccountNumber created with valid number' do
-    include_examples 'equals input', 1234
-  end
+      it { is_expected.to be_nil }
+    end
 
-  context 'when AccountNumber created with a too large number' do
-    include_examples 'raises ConstraintError', 10_000
-  end
+    context 'when created with valid number' do
+      include_examples 'equals input', 1234
+    end
+
+    context 'when created with a too large number' do
+      include_examples 'raises ConstraintError', 10_000
+    end
 
-  context 'when AccountNumber created with a negative number' do
-    include_examples 'raises ConstraintError', -1
+    context 'when created with a negative number' do
+      include_examples 'raises ConstraintError', -1
+    end
   end
 end

data/spec/fortnox/api/types/country_code_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api/types'
+
+describe Fortnox::API::Types::CountryCode do
+  context 'with nil' do
+    subject { described_class[nil] }
+
+    it { is_expected.to be_nil }
+  end
+
+  context 'with empty string' do
+    subject { described_class[''] }
+
+    it { is_expected.to eq('') }
+  end
+
+  context 'with valid input' do
+    it 'accepts country codes' do
+      expect(described_class['NO']).to eq 'NO'
+    end
+  end
+
+  context 'with invalid input' do
+    describe 'valid country name' do
+      it do
+        expect do
+          described_class['Norway']
+        end.to raise_error(Dry::Types::ConstraintError)
+      end
+    end
+
+    describe 'invalid country code' do
+      it do
+        expect do
+          described_class['XX']
+        end.to raise_error(Dry::Types::ConstraintError)
+      end
+    end
+  end
+end

data/spec/fortnox/api/types/country_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api/types'
+
+describe Fortnox::API::Types::Country do
+  context 'with nil' do
+    subject { described_class[nil] }
+
+    it { is_expected.to be_nil }
+  end
+
+  context 'with empty string' do
+    subject { described_class[''] }
+
+    it { is_expected.to eq('') }
+  end
+
+  context 'with valid input' do
+    it 'accepts country codes' do
+      expect(described_class['NO']).to eq 'NO'
+    end
+
+    it 'translates English country names to country code' do
+      expect(described_class['Norway']).to eq 'NO'
+    end
+
+    it 'translates Swedish country names to country code' do
+      expect(described_class['Norge']).to eq 'NO'
+    end
+
+    describe 'special cases' do
+      valid_sweden_inputs = [
+        'SE', 'se', 'Sweden', 'sweden', 'Sverige', 'sverige',
+        :SE, :se, :Sweden, :sweden, :Sverige, :sverige
+      ].freeze
+
+      valid_sweden_inputs.each do |sweden_input|
+        it "converts \"#{sweden_input}\" to \"SE\"" do
+          expect(described_class[sweden_input]).to eq 'SE'
+        end
+      end
+
+      it 'accepts country code for El Salvador' do
+        expect(described_class['SV']).to eq 'SV'
+      end
+
+      it 'translated Switzerland to ' do
+        expect(described_class['Switzerland']).to eq 'CH'
+      end
+    end
+  end
+
+  context 'with invalid input' do
+    invalid_inputs = [
+      'SEA', 'S', 'nonsense', :s
+    ].freeze
+
+    invalid_inputs.each do |invalid_input|
+      it "#{invalid_input} raises Dry::Types::ConstraintError" do
+        expect do
+          described_class[invalid_input]
+        end.to raise_error(Dry::Types::ConstraintError)
+      end
+    end
+  end
+end