fortnox-api 0.4.0 → 0.5.0

data/spec/fortnox/api/repositories/customer_spec.rb

@@ -9,6 +9,10 @@ require 'fortnox/api/repositories/examples/save_with_specially_named_attribute'
 require 'fortnox/api/repositories/examples/search'
 
 describe Fortnox::API::Repository::Customer, order: :defined, integration: true do
+  include Helpers::Configuration
+
+  before{ set_api_test_configuration }
+
   subject(:repository){ described_class.new }
 
   include_examples '.save', :name

data/spec/fortnox/api/repositories/invoice_spec.rb

@@ -11,6 +11,10 @@ require 'fortnox/api/repositories/examples/save_with_specially_named_attribute'
 require 'fortnox/api/repositories/examples/only'
 
 describe Fortnox::API::Repository::Invoice, order: :defined, integration: true do
+  include Helpers::Configuration
+
+  before{ set_api_test_configuration }
+
   subject(:repository){ described_class.new }
 
   required_hash = { customer_number: '1' }

data/spec/fortnox/api/repositories/order_spec.rb

@@ -10,6 +10,10 @@ require 'fortnox/api/repositories/examples/save_with_nested_model'
 require 'fortnox/api/repositories/examples/search'
 
 describe Fortnox::API::Repository::Order, order: :defined, integration: true do
+  include Helpers::Configuration
+
+  before{ set_api_test_configuration }
+
   subject(:repository){ described_class.new }
 
   required_hash = { customer_number: '1' }

data/spec/fortnox/api/repositories/project_spec.rb

@@ -7,6 +7,10 @@ require 'fortnox/api/repositories/examples/find'
 require 'fortnox/api/repositories/examples/save'
 
 describe Fortnox::API::Repository::Project, order: :defined, integration: true do
+  include Helpers::Configuration
+
+  before{ set_api_test_configuration }
+
   subject( :repository ){ described_class.new }
 
   include_examples '.save',

data/spec/fortnox/api/types/examples/document_row.rb

@@ -4,8 +4,8 @@ shared_examples_for 'DocumentRow' do |valid_hash|
   it{ is_expected.to have_sized_string( :article_number, 50, valid_hash ) }
   it{ is_expected.to have_sized_string( :description, 50, valid_hash ) }
 
-  it{ is_expected.to have_sized_float( :delivered_quantity, 0.0, 9_999_999_999_999.0, valid_hash ) }
-  it{ is_expected.to have_sized_float( :price, 0.0, 99_999_999_999.0, valid_hash ) }
+  it{ is_expected.to have_sized_float( :delivered_quantity, 0.0, 9_999_999_999_999.9, valid_hash ) }
+  it{ is_expected.to have_sized_float( :price, 0.0, 99_999_999_999.9, valid_hash ) }
 
   it{ is_expected.to have_discount_type( :discount_type, valid_hash ) }
 

data/spec/fortnox/api/types/house_work_types_spec.rb

@@ -7,6 +7,10 @@ require 'fortnox/api/types/order_row'
 
 # rubocop:disable RSpec/DescribeClass
 describe 'HouseWorkTypes', integration: true do
+  include Helpers::Configuration
+
+  before{ set_api_test_configuration }
+
   let(:repository){ Fortnox::API::Repository::Order.new }
   let(:valid_model) do
     Fortnox::API::Model::Order.new(customer_number: '1', order_rows: [order_row])

data/spec/fortnox/api_spec.rb

@@ -2,36 +2,166 @@ require 'spec_helper'
 require 'fortnox/api'
 
 describe Fortnox::API do
-  include Helpers::Environment
-
-  context 'get access token' do
-    before do
-      stub_environment(
-        'FORTNOX_API_BASE_URL' => 'http://api.fortnox.se/3/',
-        'FORTNOX_API_CLIENT_SECRET' => 'P5K5vE3Kun',
-        'FORTNOX_API_ACCESS_TOKEN' => '3f08d038-f380-4893-94a0-a08f6e60e67a',
-        'FORTNOX_API_AUTHORIZATION_CODE' => 'ea3862b0-189c-464b-8e23-1b9702365ea1'
-      )
-
-      stub_request(
-        :get,
-        'http://api.fortnox.se/3/',
-      ).with(
-        headers: {
-          'Authorization-Code' => 'ea3862b0-189c-464b-8e23-1b9702365ea1',
-          'Client-Secret' => 'P5K5vE3Kun',
-          'Accept' => 'application/json',
-        }
-        ).to_return(
-          status: 200,
-          body: { 'Authorisation' => { 'AccessToken' => '3f08d038-f380-4893-94a0-a08f6e60e67a' } }.to_json,
-          headers: { 'Content-Type' => 'application/json' },
-        )
-    end
-
-
-    subject{ described_class.get_access_token }
-
-    it{ is_expected.to eql( "3f08d038-f380-4893-94a0-a08f6e60e67a" ) }
+  before do
+    module Fortnox
+      module API
+        class TestBase
+        end
+      end
+    end
+  end
+
+  describe 'configuration defaults' do
+    subject(:config_value){ described_class.config[config_key] }
+
+    before{ Fortnox::API::TestBase.new }
+
+    describe 'base_url' do
+      let( :config_key ){ :base_url }
+
+      it{ is_expected.to eql 'https://api.fortnox.se/3/' }
+    end
+
+    describe 'client_secret' do
+      let( :config_key ){ :client_secret }
+
+      it{ is_expected.to be_nil }
+    end
+
+    describe 'access_token' do
+      let( :config_key ){ :access_token }
+
+      it{ is_expected.to be_nil }
+    end
+
+    describe 'access_tokens' do
+      let( :config_key ){ :access_tokens }
+
+      it{ is_expected.to be_nil }
+    end
+
+    describe 'token_store' do
+      let( :config_key ){ :token_store }
+
+      it{ is_expected.to eql( {} ) }
+    end
+
+    describe 'debugging' do
+      let( :config_key ){ :debugging }
+
+      it{ is_expected.to be false }
+    end
+
+    describe 'logger' do
+      let( :config_key ){ :logger }
+
+      it{ is_expected.to be_a Logger }
+
+      describe 'level' do
+        subject{ config_value.level }
+
+        it{ is_expected.to be Logger::WARN }
+      end
+    end
+  end
+
+  describe 'access_token' do
+    context 'when set to a String' do
+      subject{ described_class.config.access_token }
+
+      before{ described_class.configure{ |config| config.access_token = value } }
+      let( :value ){ '12345' }
+
+      it{ is_expected.to eql value }
+    end
+
+    shared_examples_for 'invalid argument' do
+      subject{ ->{ described_class.configure{ |config| config.access_token = value } } }
+
+      it{ is_expected.to raise_error(ArgumentError, /expected a String/) }
+    end
+
+    context 'when set to a Hash' do
+      include_examples 'invalid argument' do
+        let( :value ){ { a: '123' } }
+      end
+    end
+
+    context 'when set to an Array' do
+      include_examples 'invalid argument' do
+        let( :value ){ ['123', '456'] }
+      end
+    end
+  end
+
+  describe 'access_tokens' do
+    context 'when set to a String' do
+      subject{ ->{ described_class.configure{ |config| config.access_tokens = '12345' } } }
+
+      it{ is_expected.to raise_error(ArgumentError, /expected a Hash or an Array/) }
+    end
+
+    shared_examples_for 'valid argument' do
+      subject{ described_class.configure{ |config| config.access_tokens = value } }
+
+      it{ is_expected.to eql( value ) }
+    end
+
+    context 'when set to a Hash' do
+      include_examples 'valid argument' do
+        let( :value ){ { a: '123', b: '456' } }
+      end
+    end
+
+    context 'when set to an Array' do
+      include_examples 'valid argument' do
+        let( :value ){ ['123', '456'] }
+      end
+    end
+  end
+
+  describe 'token_store' do
+    subject{ described_class.config[:token_store] }
+
+    context 'when access_token set' do
+      before{ described_class.configure{ |config| config.access_token = access_token } }
+      let( :access_token ){ '12345' }
+
+      it{ is_expected.to eql(default: access_token) }
+    end
+
+    context 'when access_tokens is' do
+      before{ described_class.configure{ |config| config.access_tokens = access_tokens } }
+
+      describe 'a Hash' do
+        let( :access_tokens ){ { a: '123', b: '456' } }
+
+        it{ is_expected.to eql( access_tokens ) }
+      end
+
+      describe 'an Array' do
+        let( :access_tokens ){ ['123', '456'] }
+
+        it{ is_expected.to eql( default: access_tokens ) }
+      end
+    end
+  end
+
+  describe 'readers for' do
+    describe 'debugging' do
+      subject{ described_class.debugging }
+
+      it 'is available' do
+        is_expected.to be false
+      end
+    end
+
+    describe 'logger' do
+      subject{ described_class.logger }
+
+      it 'is available' do
+        is_expected.to be_a Logger
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -7,10 +7,8 @@ require "codeclimate-test-reporter"
 require 'support/matchers'
 require 'support/helpers'
 require 'support/vcr_setup'
-require 'dotenv'
 
 CodeClimate::TestReporter.start
-Dotenv.load('.env.test')
 
 RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
@@ -38,4 +36,11 @@ RSpec.configure do |config|
   config.after do
     Object.send(:remove_const, Test.remove_constants.name)
   end
+
+  # Reset configuration after each test run
+  config.after do
+    Fortnox::API::DEFAULT_CONFIGURATION.each do |key, value|
+      Fortnox::API.config.send("#{ key }=", value)
+    end
+  end
 end

data/spec/support/helpers/configuration_helper.rb

@@ -0,0 +1,10 @@
+module Helpers
+  module Configuration
+    def set_api_test_configuration
+      Fortnox::API.configure do |config|
+        config.client_secret = '9aBA8ZgsvR'
+        config.access_tokens = ['ccaef817-d5d8-4b1c-a316-54f3e55c5c54']
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fortnox-api
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Jonas Schubert Erlandsson
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2017-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -26,20 +26,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.14.0
-- !ruby/object:Gem::Dependency
-  name: dotenv
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: dry-struct
   requirement: !ruby/object:Gem::Requirement
@@ -243,7 +229,8 @@ description: This gem uses the HTTParty library to abstract away the REST calls.
   method.
 email:
 - jonas.schubert.erlandsson@my-codeworks.com
-executables: []
+executables:
+- console
 extensions: []
 extra_rdoc_files: []
 files:
@@ -259,15 +246,14 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/console
 - docs/account.rb
 - docs/extraction_script.js
 - docs/generation_script.rb
 - docs/json/account.json
 - fortnox-api.gemspec
 - lib/fortnox/api.rb
-- lib/fortnox/api/base.rb
-- lib/fortnox/api/class_methods.rb
-- lib/fortnox/api/environment_validation.rb
+- lib/fortnox/api/circular_queue.rb
 - lib/fortnox/api/mappers.rb
 - lib/fortnox/api/mappers/article.rb
 - lib/fortnox/api/mappers/base.rb
@@ -317,7 +303,6 @@ files:
 - lib/fortnox/api/types/required.rb
 - lib/fortnox/api/types/sized.rb
 - lib/fortnox/api/version.rb
-- spec/fortnox/api/base_spec.rb
 - spec/fortnox/api/mappers/article_spec.rb
 - spec/fortnox/api/mappers/base/from_json_spec.rb
 - spec/fortnox/api/mappers/base/to_json_spec.rb
@@ -342,6 +327,7 @@ files:
 - spec/fortnox/api/models/order_spec.rb
 - spec/fortnox/api/models/project_spec.rb
 - spec/fortnox/api/repositories/article_spec.rb
+- spec/fortnox/api/repositories/base_spec.rb
 - spec/fortnox/api/repositories/customer_spec.rb
 - spec/fortnox/api/repositories/examples/all.rb
 - spec/fortnox/api/repositories/examples/find.rb
@@ -372,8 +358,8 @@ files:
 - spec/fortnox/api_spec.rb
 - spec/spec_helper.rb
 - spec/support/helpers.rb
+- spec/support/helpers/configuration_helper.rb
 - spec/support/helpers/dummy_class_helper.rb
-- spec/support/helpers/environment_helper.rb
 - spec/support/helpers/repository_helper.rb
 - spec/support/helpers/when_performing_helper.rb
 - spec/support/matchers.rb
@@ -494,9 +480,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ">"
     - !ruby/object:Gem::Version
       version: '2.2'
-  - - "<"
-    - !ruby/object:Gem::Version
-      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -509,7 +492,6 @@ signing_key:
 specification_version: 4
 summary: Gem to use Fortnox REST API in Ruby.
 test_files:
-- spec/fortnox/api/base_spec.rb
 - spec/fortnox/api/mappers/article_spec.rb
 - spec/fortnox/api/mappers/base/from_json_spec.rb
 - spec/fortnox/api/mappers/base/to_json_spec.rb
@@ -534,6 +516,7 @@ test_files:
 - spec/fortnox/api/models/order_spec.rb
 - spec/fortnox/api/models/project_spec.rb
 - spec/fortnox/api/repositories/article_spec.rb
+- spec/fortnox/api/repositories/base_spec.rb
 - spec/fortnox/api/repositories/customer_spec.rb
 - spec/fortnox/api/repositories/examples/all.rb
 - spec/fortnox/api/repositories/examples/find.rb
@@ -564,8 +547,8 @@ test_files:
 - spec/fortnox/api_spec.rb
 - spec/spec_helper.rb
 - spec/support/helpers.rb
+- spec/support/helpers/configuration_helper.rb
 - spec/support/helpers/dummy_class_helper.rb
-- spec/support/helpers/environment_helper.rb
 - spec/support/helpers/repository_helper.rb
 - spec/support/helpers/when_performing_helper.rb
 - spec/support/matchers.rb

data/lib/fortnox/api/base.rb

@@ -1,47 +0,0 @@
-require 'fortnox/api/class_methods'
-require 'fortnox/api/environment_validation'
-require 'fortnox/api/request_handling'
-require 'httparty'
-
-module Fortnox
-  module API
-    class Base
-
-      include HTTParty
-      extend Fortnox::API::ClassMethods
-      include Fortnox::API::EnvironmentValidation
-      include Fortnox::API::RequestHandling
-
-      HTTParty::Parser::SupportedFormats[ "text/html" ] = :json
-
-      DEFAULT_HEADERS = {
-        'Content-Type' => 'application/json',
-        'Accept' => 'application/json',
-      }.freeze
-
-      HTTP_METHODS = [ :get, :put, :post, :delete ].freeze
-
-      attr_accessor :headers
-
-      def initialize
-        self.class.base_uri( get_base_url )
-
-        self.headers = DEFAULT_HEADERS.merge({
-          'Client-Secret' => get_client_secret,
-        })
-
-        check_access_tokens!
-      end
-
-      HTTP_METHODS.each do |method|
-        define_method method do |*args|
-          self.headers['Access-Token'] = get_access_token
-          execute do |remote|
-            remote.send( method, *args )
-          end
-        end
-      end
-
-    end
-  end
-end