fortitude 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 979ec914d2f256b806b70ad35fc10046423c6ebf
-  data.tar.gz: 6d12dd12a458019abce25cb3d6d1fa7b8cdbabde
+  metadata.gz: 11cc27b7da627f35c70cfd102e2fcdfec18d0869
+  data.tar.gz: 05da4419831b8159503bf9da7f9e30074688774a
 SHA512:
-  metadata.gz: c82032c67ec5e95e238b5914bc6b1fc8b6e14dc71aa90d81d47fd560e21e231059e097a0412e952acbc08142f5bdb05ae48655e6b3f8f8bc4223ce27ad5761e6
-  data.tar.gz: 4b1af326ecd906612c06e4fe528f14135e4a845d87dec9c72308d5a061a78dd3bbf41226cee8a10a5e55ac04d45f2bd08920c298de21c0f7d8c7cfcb1d2790fb
+  metadata.gz: ab7eac05ec3e3fb020489fd7698c52dc77807c5a2078041439835cff4f5d44824fe2fa988a9ec7bfdbd1e730c20a60c392aaf8f6581fb19277f7f1d8fb1ca177
+  data.tar.gz: c51b8b6bb5e4f8208f27c254f0d039cc0dff46b2dfd3e35ca7ec674ccee6042b00921cf70416d539d0f1aaa5faf316651583777116a4cf375a7c4a706de061ca

data/CHANGES.md

@@ -1,5 +1,15 @@
 # Fortitude Releases
 
+## 0.9.3, 2 February 2015
+
+* Fixed a memory leak when using `render :inline`, or certain other cases triggered by a user. (Fortitude widget
+  classes know about all their subclasses, in order to enable proper propagation of configuration changes.
+  If you created a subclass of a Fortitude widget that was intended to be single-use or otherwise temporary, it would
+  not get garbage-collected, since its superclass would still maintain a reference to it. Fortitude now uses the
+  [ref](https://github.com/ruby-concurrency/ref) gem in order to make this a weak reference, hence allowing it to
+  be garbage-collected. `render :inline` creates a temporary subclass of a Fortitude widget, thus triggering exactly
+  this issue.)
+
 ## 0.9.2, 22 January 2015
 
 * Began writing lots of documentation for Fortitude, beginning with the reasons why you should use it.

data/CONTRIBUTORS.md

@@ -32,6 +32,9 @@ Fortitude is written by [Andrew Geweke](https://github.com/ageweke), with contri
   * Reporting a bug where doing something like `div(nil, :class => 'foo')` would produce just `<div></div>` instead of
     the desired `<div class="foo"></div>`.
   * Reporting an issue where `return`ing from inside a block passed to a tag method would not render the closing tags.
+  * Reporting, and helping verify, an issue where creating anonymous subclasses of a Fortitude widget class (like
+    those used by `render :inline`) would cause those anonymous subclasses to never be garbage collected, causing
+    a memory leak.
 * [Adam Becker](https://github.com/ajb) for:
   * Discussion and details around exactly what `:attribute => true`, `:attribute => false`, and so on should render
     from Fortitude.

data/fortitude.gemspec

@@ -32,6 +32,7 @@ Gem::Specification.new do |s|
   end
 
   s.add_dependency "activesupport", *activesupport_spec
+  s.add_dependency "ref", ">= 1.0.5"
 
   s.add_development_dependency "bundler", "~> 1.5"
   s.add_development_dependency "rake"

data/lib/fortitude/version.rb

@@ -1,3 +1,3 @@
 module Fortitude
-  VERSION = "0.9.2"
+  VERSION = "0.9.3"
 end

data/lib/fortitude/widget/modules_and_subclasses.rb

@@ -1,6 +1,8 @@
 require 'active_support'
 require 'active_support/concern'
 
+require 'ref'
+
 require 'fortitude/tags/tags_module'
 
 module Fortitude
@@ -28,14 +30,17 @@ module Fortitude
 
         # INTERNAL USE ONLY
         def direct_subclasses
-          @direct_subclasses || [ ]
+          @direct_subclasses ||= [ ]
+          @direct_subclasses.delete_if { |ref| (! ref.object) }
+          @direct_subclasses.map { |ref| ref.object }
         end
         private :direct_subclasses
 
         # INTERNAL USE ONLY -- RUBY CALLBACK
         def inherited(subclass)
-          @direct_subclasses ||= [ ]
-          @direct_subclasses |= [ subclass ]
+          unless direct_subclasses.detect { |sc| sc.equal?(subclass) }
+            @direct_subclasses << ::Ref::WeakReference.new(subclass)
+          end
         end
 
         # INTERNAL USE ONLY

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fortitude
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Andrew Geweke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-22 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: ref
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement