fortitude 0.9.2-java → 0.9.3-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c93f8669e21ad6c24b05ee70f6495a89c8f2b3d8
-  data.tar.gz: 92acd8a7745f0dcd24af14b2e631b9786ee01142
+  metadata.gz: 467436a25faae7e85366ea30823ff7347b3db824
+  data.tar.gz: ab92630c1074a321afd13e52d525b065cf964df2
 SHA512:
-  metadata.gz: b517772661194a742cfd5e3a76220e5fee17e5abf41a0642f9c7afacdc7cf6c4dea0c6986895d76fa0b35ca3de8304c51a1072b36ccdc34c5014e0a5b0f96194
-  data.tar.gz: 9065a12094ce4249747a119bf57e51ddf3294d2e96427052afe252349a1ed7ad5e22f8746ba8c38816081d5c6354b780393c0fcef9d579105e15633729b7822b
+  metadata.gz: b36a5556e62012835d1b0c283cdb6457eb2d292137ae153e3c0da268df71334a64082fa29698742f2973e702ea9c305ef70ed888a8ca777865dc1929deb25e6f
+  data.tar.gz: e7eb439ae801b5defebc88d85fa5c2a02fe67f5c7f2e06098e6819f524abd462629a30a878a246c40bd59862de14b7f6d9cc62a56c8a26d7677c9cffbd488686

data/CHANGES.md

@@ -1,5 +1,15 @@
 # Fortitude Releases
 
+## 0.9.3, 2 February 2015
+
+* Fixed a memory leak when using `render :inline`, or certain other cases triggered by a user. (Fortitude widget
+  classes know about all their subclasses, in order to enable proper propagation of configuration changes.
+  If you created a subclass of a Fortitude widget that was intended to be single-use or otherwise temporary, it would
+  not get garbage-collected, since its superclass would still maintain a reference to it. Fortitude now uses the
+  [ref](https://github.com/ruby-concurrency/ref) gem in order to make this a weak reference, hence allowing it to
+  be garbage-collected. `render :inline` creates a temporary subclass of a Fortitude widget, thus triggering exactly
+  this issue.)
+
 ## 0.9.2, 22 January 2015
 
 * Began writing lots of documentation for Fortitude, beginning with the reasons why you should use it.

data/CONTRIBUTORS.md

@@ -32,6 +32,9 @@ Fortitude is written by [Andrew Geweke](https://github.com/ageweke), with contri
   * Reporting a bug where doing something like `div(nil, :class => 'foo')` would produce just `<div></div>` instead of
     the desired `<div class="foo"></div>`.
   * Reporting an issue where `return`ing from inside a block passed to a tag method would not render the closing tags.
+  * Reporting, and helping verify, an issue where creating anonymous subclasses of a Fortitude widget class (like
+    those used by `render :inline`) would cause those anonymous subclasses to never be garbage collected, causing
+    a memory leak.
 * [Adam Becker](https://github.com/ajb) for:
   * Discussion and details around exactly what `:attribute => true`, `:attribute => false`, and so on should render
     from Fortitude.

data/fortitude.gemspec

@@ -32,6 +32,7 @@ Gem::Specification.new do |s|
   end
 
   s.add_dependency "activesupport", *activesupport_spec
+  s.add_dependency "ref", ">= 1.0.5"
 
   s.add_development_dependency "bundler", "~> 1.5"
   s.add_development_dependency "rake"

data/lib/fortitude/version.rb

@@ -1,3 +1,3 @@
 module Fortitude
-  VERSION = "0.9.2"
+  VERSION = "0.9.3"
 end

data/lib/fortitude/widget/modules_and_subclasses.rb

@@ -1,6 +1,8 @@
 require 'active_support'
 require 'active_support/concern'
 
+require 'ref'
+
 require 'fortitude/tags/tags_module'
 
 module Fortitude
@@ -28,14 +30,17 @@ module Fortitude
 
         # INTERNAL USE ONLY
         def direct_subclasses
-          @direct_subclasses || [ ]
+          @direct_subclasses ||= [ ]
+          @direct_subclasses.delete_if { |ref| (! ref.object) }
+          @direct_subclasses.map { |ref| ref.object }
         end
         private :direct_subclasses
 
         # INTERNAL USE ONLY -- RUBY CALLBACK
         def inherited(subclass)
-          @direct_subclasses ||= [ ]
-          @direct_subclasses |= [ subclass ]
+          unless direct_subclasses.detect { |sc| sc.equal?(subclass) }
+            @direct_subclasses << ::Ref::WeakReference.new(subclass)
+          end
         end
 
         # INTERNAL USE ONLY

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fortitude
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: java
 authors:
 - Andrew Geweke
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-01-22 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -24,6 +24,20 @@ dependencies:
         version: '3.0'
   prerelease: false
   type: :runtime
+- !ruby/object:Gem::Dependency
+  name: ref
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.5
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.5
+  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency
   name: bundler
   version_requirements: !ruby/object:Gem::Requirement