fortitude 0.0.7 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eabd6ee415b258a82856f5c76df532a3ce71cb3e
-  data.tar.gz: 78b96f3f86e1a688e87de8d3ff772c9bdd67100b
+  metadata.gz: 56d217c0aa43c323a12d346c118f6156801ffddd
+  data.tar.gz: 2563fd9c7a8bff377f9974875a4b7891c97c5af0
 SHA512:
-  metadata.gz: 6bbe8a1b13135a561d29d48bf3072a80e10dcbcffb9e7fc06197071b9f47f32261606330d52651e31ba9d490258e67e9e3f8af5aa6f0d089e557f717f0753fa3
-  data.tar.gz: 4adba77413cfd61b38ce7f1b145063c27bf0df79ccae299de55ae0ba744b3ca0babf81756de52c5cf7a25ecf773b6c0eeb4f6dcbd58de69fa1bec7a42a8c85a5
+  metadata.gz: 96ed9cce589f63ad49c3853a3e90cfe1a10c41a0893864f27761a47fc6616f2a13db3676c518ff97a7fb840c836b63d8df930d36d23b008eaef5e8e14a0f4f31
+  data.tar.gz: 3b8222c8ef3b6f6877f57abd83b898972dc39427a87977e4edc0b95ffaeddb6ede1ae3d067e045570369b31b71ffbee3adc2621102305f48e26d738a6a435e12

data/CHANGES.md

@@ -1,5 +1,78 @@
 # Fortitude Releases
 
+## 0.0.9, 20 November 2014
+
+* Fortitude now supports passing blocks to widgets (above and beyond support for Rails' standard layouts and their
+  usage using `yield`). You can now do the following:
+
+```ruby
+class Views::Foo < Views::Base
+  def content
+    p "something here"
+    widget Views::Bar, :name => 'Yoko' { text "hello" }
+    p "something else"
+  end
+end
+
+class Views::Bar < Views::Base
+  def content
+    p "more content"
+    yield
+    p "even more content"
+  end
+end
+```
+
+  This will do as expected and cause `Views::Bar`'s `yield` call to call the block passed to it. Furthermore, because
+  it's often very useful to break a widget down into methods, and you might not want to explicitly pass the block all
+  over, you can call `yield_from_widget` from _any_ widget method and it will behave correctly. (This has actually
+  always been true in Fortitude for yielding to layouts; it just now will also yield to blocks passed into the widget
+  directly, too).
+
+  Fortitude first prefers a block passed in to `#widget`; it then looks for a block passed to the constructor of a
+  widget, and, finally, it will delegate to the layout (if any) if no other block is found. If there isn't even a
+  layout, you will receive an error.
+
+  Unlike Erector, Fortitude passes any arguments you give `yield` through to the widget, whether using `yield` or
+  `yield_from_widget`; it also passes, as the first argument, the widget instance being yielded from, too. This allows
+  a more elegant solution to the fact that the block is evaluated in the scope of the caller, not the wiget, and thus
+  may not have access to Fortitude methods (like `p`, `text`, and so on) if the caller is not itself a widget; you can
+  simply call those methods on the passed-in widget instance.
+
+  Thank you to [Leaf](https://github.com/leafo) for bringing up this issue!
+
+* The exact interpretation of attribute values has changed. Along with
+  [considerable discussion](https://github.com/ageweke/fortitude/issues/12), it became clear that the most desirable
+  behavior was the following: attributes with a value of `false` or `nil` simply are not output at all (thus making
+  behavior like `input(:type => :checkbox, :checked => some_boolean_variable)` work properly); attributes with a
+  value of `true` are output as the key only (so the previous example becomes `<input type="checkbox" checked>` if
+  `some_boolean_variable` is `true`) &mdash; except in XHTML document types, where that would be illegal, so they
+  become (_e.g._) `<input type="checkbox" checked="checked">`; and attributes mapped to the empty string are output
+  with a value of the empty string. Many thanks to [Leaf](https://github.com/leafo) and
+  [Adam Becker](https://github.com/ajb) for all the discussion and validation around this!
+
+* Multiple huge performance increases in Fortitude's class-loading time for widgets. Fortitude internally uses
+  dynamic compilation of many methods to achieve the very highest runtime performance; however, the system that did
+  this compilation could cause slow startup times if you had a very large number of widgets. Fortitude now lazy-
+  compiles some methods and caches its own internal trivial template language in order to make startup much faster
+  without slowing down critical runtime performance. Many thanks to [Leaf](https://github.com/leafo) for reporting this
+  issue and testing a number of fixes for it as they were made!
+
+* Fixed a number of bugs in Fortitude's support for `render :widget => ...`, including use of helpers, coexistence
+  with Erector, and being able to pass a widget class rather than an already-instantiated widget. Many thanks to
+  [Leaf](https://github.com/leafo) for the detailed bug report, suggestions for fixes, and pointers to new methods that
+  made the implementation much more robust.
+
+## 0.0.8, 13 November 2014
+
+* Fixed an issue where repeated reloading of a view in development mode in Rails could cause an error of the form
+  `superclass mismatch for class MyView`. (The issue was that Fortitude was calling `require_dependency` on the view
+  `.rb` file in the template handler, which caused it to get loaded outside of the scope where Rails is watching for
+  loaded constants, so that it can unload them before the next request. This caused view classes to hang around
+  forever, but not necessarily their superclasses, causing a very confusing `superclass mismatch` error.) Many thanks
+  again to [Jacob Maine](https://github.com/mainej) for the very detailed bug report and collaboration to fix the
+  issue.
+
 ## 0.0.7, 11 November 2014
 
 * Fortitude 0.0.6 introduced a regression, where referring to an autoloaded view class by partially-qualified namespace

data/CONTRIBUTORS.md

@@ -6,3 +6,20 @@ Fortitude is written by [Andrew Geweke](https://github.com/ageweke), with contri
   `gem install fortitude` works properly no matter which platform you're on.
 * [Roman Heinrich](https://github.com/mindreframer): reporting a bug where trying to use Fortitude as a Tilt
   engine to render would fail if the locals passed in were `nil`.
+* [Jacob Maine](https://github.com/mainej):
+  * Reporting the lack of `ActionMailer` support for Fortitude, and offering a patch to add it;
+  * Reporting a bug where view classes ending in `.html.rb` would encounter classloading issues
+    (resulting in `uninitialized constant` or `superclass mismatch` errors) in development mode.
+* [Leaf](https://github.com/leafo) for:
+  * Reporting slow widget classloading in very large systems due to eager, not lazy, complication of `needs`-related
+    methods, and significant work helping determine that widget localization support was a major source of slowness
+    here.
+  * Reporting the need for support for passing blocks to `widget`, and thus being able to `yield` from one widget
+    to another.
+  * Discussion and details around exactly what `:attribute => true`, `:attribute => false`, and so on should render
+    from Fortitude.
+  * Reporting multiple bugs in support for `render :widget => ...`, and many useful pointers to possible fixes and
+    additional methods to make the implementation a lot more robust.
+* [Adam Becker](https://github.com/ajb) for:
+  * Discussion and details around exactly what `:attribute => true`, `:attribute => false`, and so on should render
+    from Fortitude.

data/ext/com/fortituderuby/ext/fortitude/FortitudeNativeLibrary.java

@@ -3,6 +3,7 @@ package com.fortituderuby.ext.fortitude;
 import java.io.IOException;
 import org.jruby.Ruby;
 import org.jruby.RubyBasicObject;
+import org.jruby.RubyBoolean;
 import org.jruby.RubyArray;
 import org.jruby.RubyClass;
 import org.jruby.RubyFixnum;
@@ -159,13 +160,15 @@ public class FortitudeNativeLibrary implements Library {
             public final ThreadContext threadContext;
             public final RubyString prefix;
             public final RubyString output;
+            public final RubyBoolean allowsBareAttributes;
 
             public static final byte[] EQUALS_QUOTE = new byte[] { (byte) '=', (byte) '"' };
 
-            public AppendKeyAndValueVisitor(ThreadContext threadContext, RubyString prefix, RubyString output) {
+            public AppendKeyAndValueVisitor(ThreadContext threadContext, RubyString prefix, RubyString output, RubyBoolean allowsBareAttributes) {
                 this.threadContext = threadContext;
                 this.prefix = prefix;
                 this.output = output;
+                this.allowsBareAttributes = allowsBareAttributes;
             }
 
             public void visit(IRubyObject key, IRubyObject value) {
@@ -181,7 +184,9 @@ public class FortitudeNativeLibrary implements Library {
                     }
 
                     newPrefix.cat('-');
-                    fortitude_append_as_attributes(threadContext, value, output, newPrefix);
+                    fortitude_append_as_attributes(threadContext, value, output, newPrefix, this.allowsBareAttributes);
+                } else if ((value instanceof RubyNil) || ((value instanceof RubyBoolean) && (! value.isTrue()))) {
+                    // nothing here
                 } else {
                     output.cat(' ');
 
@@ -192,15 +197,26 @@ public class FortitudeNativeLibrary implements Library {
                     }
 
                     fortitude_append_to(key, output);
-                    output.cat(EQUALS_QUOTE);
-                    fortitude_append_to(value, output);
-                    output.cat('"');
+
+                    if ((value instanceof RubyBoolean) && (value.isTrue())) {
+                        if (this.allowsBareAttributes.isTrue()) {
+                            // ok, nothing here
+                        } else {
+                            output.cat(EQUALS_QUOTE);
+                            fortitude_append_to(key, output);
+                            output.cat('"');
+                        }
+                    } else {
+                        output.cat(EQUALS_QUOTE);
+                        fortitude_append_to(value, output);
+                        output.cat('"');
+                    }
                 }
             }
         }
 
         @JRubyMethod(name = "fortitude_append_as_attributes")
-        public static IRubyObject fortitude_append_as_attributes(ThreadContext context, IRubyObject self, IRubyObject output, IRubyObject prefix) {
+        public static IRubyObject fortitude_append_as_attributes(ThreadContext context, IRubyObject self, IRubyObject output, IRubyObject prefix, IRubyObject allowsBareAttributes) {
             if (! (output instanceof RubyString)) {
                 RaiseException exception = runtime.newArgumentError("You can only append to a String (this is a native (Java) method)");
                 throw exception;
@@ -213,7 +229,7 @@ public class FortitudeNativeLibrary implements Library {
                 throw exception;
             }
 
-            AppendKeyAndValueVisitor visitor = new AppendKeyAndValueVisitor(context, (RubyString) prefix, (RubyString) output);
+            AppendKeyAndValueVisitor visitor = new AppendKeyAndValueVisitor(context, (RubyString) prefix, (RubyString) output, (RubyBoolean) allowsBareAttributes);
 
             ((RubyHash) self).visitAll(visitor);
 

data/ext/fortitude_native_ext/fortitude_native_ext.c

@@ -3,7 +3,7 @@
 void Init_fortitude_native_ext();
 
 VALUE method_append_escaped_string(VALUE self, VALUE rb_output);
-VALUE method_append_as_attributes(VALUE self, VALUE rb_output, VALUE prefix);
+VALUE method_append_as_attributes(VALUE self, VALUE rb_output, VALUE prefix, VALUE allows_bare_attributes);
 
 void Init_fortitude_native_ext() {
     VALUE string_class, hash_class;
@@ -12,7 +12,7 @@ void Init_fortitude_native_ext() {
     rb_define_method(string_class, "fortitude_append_escaped_string", method_append_escaped_string, 1);
 
     hash_class = rb_const_get(rb_cObject, rb_intern("Hash"));
-    rb_define_method(hash_class, "fortitude_append_as_attributes", method_append_as_attributes, 2);
+    rb_define_method(hash_class, "fortitude_append_as_attributes", method_append_as_attributes, 3);
 }
 
 #define BUF_SIZE 256
@@ -145,85 +145,122 @@ void fortitude_append_to(VALUE object, VALUE rb_output) {
     }
 }
 
-struct fortitude_prefix_and_output {
+struct fortitude_append_key_and_value_data {
     VALUE prefix;
     VALUE rb_output;
+    VALUE allows_bare_attributes;
 };
 
-int fortitude_append_key_and_value(VALUE key, VALUE value, VALUE prefix_and_output_value) {
-    struct fortitude_prefix_and_output * prefix_and_output = (struct fortitude_prefix_and_output *)prefix_and_output_value;
+int fortitude_append_key_and_value(VALUE key, VALUE value, VALUE key_and_value_data_param) {
+    struct fortitude_append_key_and_value_data * key_and_value_data = (struct fortitude_append_key_and_value_data *)key_and_value_data_param;
 
-    VALUE prefix = prefix_and_output->prefix;
-    VALUE rb_output = prefix_and_output->rb_output;
+    VALUE prefix = key_and_value_data->prefix;
+    VALUE rb_output = key_and_value_data->rb_output;
+    VALUE allows_bare_attributes = key_and_value_data->allows_bare_attributes;
 
-    if (TYPE(value) == T_HASH) {
-        VALUE new_prefix_as_string;
-        ID dup;
-        ID to_s;
+    VALUE new_prefix_as_string;
+    ID dup;
+    ID to_s;
 
-#ifdef CONST_ID
-        CONST_ID(dup, "dup");
-        CONST_ID(to_s, "to_s");
-#else
-        dup = rb_intern("dup");
-        to_s = rb_intern("to_s");
-#endif
+    switch(TYPE(value)) {
+        case T_HASH:
+            #ifdef CONST_ID
+                CONST_ID(dup, "dup");
+                CONST_ID(to_s, "to_s");
+            #else
+                dup = rb_intern("dup");
+                to_s = rb_intern("to_s");
+            #endif
+
+            switch (TYPE(prefix)) {
+                case T_STRING:
+                    new_prefix_as_string = rb_funcall(prefix, dup, 0);
+                    fortitude_append_to(key, new_prefix_as_string);
+                    break;
+
+                case T_NIL:
+                    new_prefix_as_string = rb_str_new("", 0);
+                    fortitude_append_to(key, new_prefix_as_string);
+                    break;
+
+                default:
+                    rb_raise(rb_eArgError, "You can only use a String as a prefix (this is a native (C) method)");
+                    break;
+            }
 
-        switch (TYPE(prefix)) {
-            case T_STRING:
-                new_prefix_as_string = rb_funcall(prefix, dup, 0);
-                fortitude_append_to(key, new_prefix_as_string);
-                break;
+            rb_str_cat2(new_prefix_as_string, "-");
+            method_append_as_attributes(value, rb_output, new_prefix_as_string, allows_bare_attributes);
+            break;
 
-            case T_NIL:
-                new_prefix_as_string = rb_str_new("", 0);
-                fortitude_append_to(key, new_prefix_as_string);
-                break;
+        case T_NIL:
+        case T_FALSE:
+            break;
 
-            default:
-                rb_raise(rb_eArgError, "You can only use a String as a prefix (this is a native (C) method)");
-                break;
-        }
+        case T_TRUE:
+            rb_str_cat2(rb_output, " ");
 
-        rb_str_cat2(new_prefix_as_string, "-");
-        method_append_as_attributes(value, rb_output, new_prefix_as_string);
-    } else {
-        rb_str_cat2(rb_output, " ");
+            switch (TYPE(prefix)) {
+                case T_STRING:
+                    rb_str_append(rb_output, prefix);
+                    break;
 
-        switch (TYPE(prefix)) {
-            case T_STRING:
-                rb_str_append(rb_output, prefix);
-                break;
+                case T_NIL:
+                    break;
 
-            case T_NIL:
-                break;
+                default:
+                    rb_raise(rb_eArgError, "You can only use a String as a prefix (this is a native (C) method)");
+                    break;
+            }
 
-            default:
-                rb_raise(rb_eArgError, "You can only use a String as a prefix (this is a native (C) method)");
-                break;
-        }
+            fortitude_append_to(key, rb_output);
+            if (TYPE(allows_bare_attributes) == T_TRUE) {
+                /* ok */
+            } else {
+                rb_str_cat2(rb_output, "=\"");
+                fortitude_append_to(key, rb_output);
+                rb_str_cat2(rb_output, "\"");
+            }
+            break;
 
-        fortitude_append_to(key, rb_output);
-        rb_str_cat2(rb_output, "=\"");
-        fortitude_append_to(value, rb_output);
-        rb_str_cat2(rb_output, "\"");
+        default:
+            rb_str_cat2(rb_output, " ");
+
+            switch (TYPE(prefix)) {
+                case T_STRING:
+                    rb_str_append(rb_output, prefix);
+                    break;
+
+                case T_NIL:
+                    break;
+
+                default:
+                    rb_raise(rb_eArgError, "You can only use a String as a prefix (this is a native (C) method)");
+                    break;
+            }
+
+            fortitude_append_to(key, rb_output);
+            rb_str_cat2(rb_output, "=\"");
+            fortitude_append_to(value, rb_output);
+            rb_str_cat2(rb_output, "\"");
+            break;
     }
 
     return 0;
 }
 
 
-VALUE method_append_as_attributes(VALUE self, VALUE rb_output, VALUE prefix) {
-    struct fortitude_prefix_and_output prefix_and_output;
+VALUE method_append_as_attributes(VALUE self, VALUE rb_output, VALUE prefix, VALUE allows_bare_attributes) {
+    struct fortitude_append_key_and_value_data key_and_value_data;
 
     if (TYPE(rb_output) != T_STRING) {
         rb_raise(rb_eArgError, "You can only append to a String (this is a native (C) method)");
     }
 
-    prefix_and_output.prefix = prefix;
-    prefix_and_output.rb_output = rb_output;
+    key_and_value_data.prefix = prefix;
+    key_and_value_data.rb_output = rb_output;
+    key_and_value_data.allows_bare_attributes = allows_bare_attributes;
 
-    rb_hash_foreach(self, fortitude_append_key_and_value, (VALUE) &prefix_and_output);
+    rb_hash_foreach(self, fortitude_append_key_and_value, (VALUE) &key_and_value_data);
     return Qnil;
 }
 

data/lib/fortitude/doctypes/html4.rb

@@ -13,6 +13,10 @@ module Fortitude
         false
       end
 
+      def allows_bare_attributes?
+        true
+      end
+
       def close_void_tags_must_be
         false
       end

data/lib/fortitude/doctypes/html5.rb

@@ -16,6 +16,10 @@ module Fortitude
         false
       end
 
+      def allows_bare_attributes?
+        true
+      end
+
       def close_void_tags_must_be
         nil
       end

data/lib/fortitude/doctypes/unknown_doctype.rb

@@ -15,6 +15,10 @@ module Fortitude
       def needs_cdata_in_javascript_tag?
         false
       end
+
+      def allows_bare_attributes?
+        true
+      end
     end
   end
 end

data/lib/fortitude/doctypes/xhtml10.rb

@@ -12,6 +12,10 @@ module Fortitude
         true
       end
 
+      def allows_bare_attributes?
+        false
+      end
+
       def close_void_tags_must_be
         true
       end

data/lib/fortitude/doctypes/xhtml11.rb

@@ -16,6 +16,10 @@ module Fortitude
         true
       end
 
+      def allows_bare_attributes?
+        false
+      end
+
       def close_void_tags_must_be
         true
       end

data/lib/fortitude/erector.rb

@@ -23,6 +23,7 @@ module Fortitude
 
       def is_erector_widget_class?(widget_class)
         return false unless is_erector_available?
+        return false unless widget_class.kind_of?(::Class)
         return true if widget_class == ::Erector::Widget
         return false if widget_class == ::Object
         return is_erector_widget_class?(widget_class.superclass)