formtastic_tristate_radio 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6cb90abb9a912c583ace9c1ce3c7fabdf27e3b0b
-  data.tar.gz: fd220427f9e5d0f573c3533d186c85c47dffd581
+SHA256:
+  metadata.gz: b26a9dab6e7233cd6a694dc88f59d08f6d47263c900abfc07416679a87f7c974
+  data.tar.gz: 0a399b71d713ce0f4488f1f7461694d824d43c8f0f42db848daf4c0ad2caa0db
 SHA512:
-  metadata.gz: 47c7eb5acfd279ce25b9b61216951004aa76c472260d01053ffc91925c2ea078c2428287593e746e62239b984a90b3f3f6f2a299ae2f928024b5702c4e19202f
-  data.tar.gz: 0f76c972c65fd6d2e1e78b69e7d5b1868345d0a04a3755a7b39719fc9fffc16e7b0fa5776861202d2638ecfa267a5ee1431493576b5d6467fbba2096d95fb0a1
+  metadata.gz: '0339d723213d63e7355ca4c50f120f6b08b22d406ba042ad47a89414708d4e07a1748dfa6d530190d2ca45ffd5dff0402779d53a225d9af80449c86b90d85a88'
+  data.tar.gz: b36093c5c3207e2375adb7c80769f890ac3b433c178128add4fa0d24ebd68aff11c5421b783213ff4d3e25d0f3603bf3b49ab8f794475f958e6aa909c879a088

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [0.2.5] - 2021-11-10
+
+- Corrects an error introduced in 0.2.4
+- Moves error-related code into a new module
+- Type-checks the `unset_value` passed into configuration
+
+## [0.2.4] - 2021-11-09
+
+- Add translations into most popular languages (although the problem with loading them seems to persist)
+
 ## [0.2.2] - 2021-11-05
 
 - Make the gem configurable

data/README.md

@@ -190,8 +190,8 @@ ActiveModel::Type::Boolean.new.cast(:nil)   #=> nil
 - [ ] Remove `require_relative "../app/models/active_record/base"` from main file
 - [x] Make the gem configurable
 - [x] Pull the key used for “unset” choice value into configuration
+- [x] Add translations into most popular languages
 - [ ] Load translations from gem
-- [ ] Add translations into most popular languages
 - [ ] Rgister `:tristate_radio` for Boolean columns with `null`
 - [ ] Decouple `ActiveModel::Type::Boolean` thing from Formtastic things, maybe into a separate gem
 - [ ] Decouple from Rails

data/app/inputs/tristate_radio_input.rb

@@ -52,11 +52,10 @@ class TristateRadioInput < Formtastic::Inputs::RadioInput
   #
   # @return [String] Label of the radio that stands for the unknown choice
   #
-  # @raise [StandardError] if the translation could not be found
-  # @see missing_i18n_error_msg
+  # @raise [FormtasticTristateRadio::I18n::Error] if the translation could not be found
   #
   def label_text_for_unset
-    options.fetch(:null, Formtastic::I18n.t(UNSET_KEY)).presence or fail FormtasticTristateRadio::I18n::Error.new(locale, UNSET_KEY)
+    options.fetch(:null, Formtastic::I18n.t(UNSET_KEY)).presence or fail FormtasticTristateRadio::I18n::Error.new(I18n.locale, UNSET_KEY)
   end
 
 

data/formtastic_tristate_radio.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.description      = <<~HEREDOC
                             #{spec.summary}. This gem:
                             1. Provides a custom Formtastic input type `:tristate_radio` which renders 3 radios (“Yes”, “No”, “Unset”) instead of a checkbox (only where you put it).
-                            2. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`. See “[How it works](#how-it-works)” ☟ section for technical details on this.
+                            2. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`
                             3. Encourages you to add translations for ActiveAdmin “status tag” so that `nil` be correctly translated as “Unset” instead of “False”.
                             Does not change controls, you need to turn it on via `as: :tristate_radio` option.
                           HEREDOC

data/lib/formtastic_tristate_radio/configuration.rb

@@ -14,12 +14,30 @@ module FormtasticTristateRadio
     yield(config)
   end
 
+  # Configuration block pattern
+  #
+  # @see https://thoughtbot.com/blog/mygem-configure-block
+  # @see https://brandonhilkert.com/blog/ruby-gem-configuration-patterns/
+  #
   class Configuration
-    attr_accessor :unset_key
 
     def initialize
       @unset_key = :null
     end
+
+    # @!attribute [r] unset_key
+    #   @return [Symbol, String] the value of <var>@unset_key</var>
+    #
+    attr_reader :unset_key
+
+    # @return [Symbol, String, Integer] value that was passed into the method
+    #
+    # @raise [TypeError] because no other types seem to make sence here
+    #
+    def unset_key=(value)
+      fail TypeError, "`unset_key` must be a Symbol, String or Integer" unless [Symbol, String, Integer].include? value.class
+      @unset_key = value
+    end
   end
 
 end

data/lib/formtastic_tristate_radio/engine.rb

@@ -3,7 +3,7 @@
 module FormtasticTristateRadio
 
   # This is standard Rails way to autoload gem’s contents dynamically as an “engine”
-  # https://guides.rubyonrails.org/engines.html
+  # @see https://guides.rubyonrails.org/engines.html Rails guide on engines
   #
   class Engine < ::Rails::Engine
   end

data/lib/formtastic_tristate_radio/i18n/error.rb

@@ -27,7 +27,7 @@ module FormtasticTristateRadio
         #
         # @return [String] error message with YAML examples for the “unset” label translation lookup error
         #
-        # @see URL https://github.com/ruby-i18n/i18n/blob/master/lib/i18n/exceptions.rb#L63 Original I18n method
+        # @see https://github.com/ruby-i18n/i18n/blob/master/lib/i18n/exceptions.rb#L63 Original I18n method
         #
         def message
           msg = []

data/lib/formtastic_tristate_radio/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FormtasticTristateRadio
-  VERSION = "0.2.4"
+  VERSION = "0.2.5"
 end

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: formtastic_tristate_radio
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Sergey Pedan
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
 date: 2021-11-09 00:00:00.000000000 Z
@@ -87,7 +87,7 @@ dependencies:
 description: |
   Have 3-state radiobuttons instead of a 2-state checkbox for your Boolean columns which can store NULL. This gem:
   1. Provides a custom Formtastic input type `:tristate_radio` which renders 3 radios (“Yes”, “No”, “Unset”) instead of a checkbox (only where you put it).
-  2. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`. See “[How it works](#how-it-works)” ☟ section for technical details on this.
+  2. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`
   3. Encourages you to add translations for ActiveAdmin “status tag” so that `nil` be correctly translated as “Unset” instead of “False”.
   Does not change controls, you need to turn it on via `as: :tristate_radio` option.
 email:
@@ -110,6 +110,7 @@ files:
 - config/locales/active_admin.yml
 - config/locales/formtastic.yml
 - config/routes.rb
+- formtastic_tristate_radio-0.2.4.gem
 - formtastic_tristate_radio.gemspec
 - lib/formtastic_tristate_radio.rb
 - lib/formtastic_tristate_radio/configuration.rb
@@ -124,7 +125,7 @@ metadata:
   documentation_uri: https://www.rubydoc.info/gems/formtastic_tristate_radio
   homepage_uri: https://github.com/sergeypedan/formtastic-tristate-radio
   source_code_uri: https://github.com/sergeypedan/formtastic-tristate-radio
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -144,9 +145,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2.3
-signing_key: 
+rubygems_version: 3.2.15
+signing_key:
 specification_version: 4
 summary: Have 3-state radiobuttons instead of a 2-state checkbox for your Boolean
   columns which can store NULL