formtastic_tristate_radio 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 8fdf4d000b01b98679b7b2e4eb9bbb8ac43e2bdec9dfe79aba6e07ed580f0cbf
-  data.tar.gz: 7734d39327b809b599b058362e091df2e6153749ff6cfad5a7cb7ac91756e1a2
+SHA1:
+  metadata.gz: 6cb90abb9a912c583ace9c1ce3c7fabdf27e3b0b
+  data.tar.gz: fd220427f9e5d0f573c3533d186c85c47dffd581
 SHA512:
-  metadata.gz: e67a6dfe2440683e483d9d2bb677b66a87d335625a1ca7622888e641b3b0c36d8602ef502708d2098e78b4d3f15985ca59b6105d17f661adb4e72ea5661f07a1
-  data.tar.gz: 9fcd6fe99ddfba81237d17305abcc6e1de6febcc05765c442c265bdb5293adaea88bd9364affac0c374929a4ebc1113cba8c98ad7eb82dd11440cde462fa7606
+  metadata.gz: 47c7eb5acfd279ce25b9b61216951004aa76c472260d01053ffc91925c2ea078c2428287593e746e62239b984a90b3f3f6f2a299ae2f928024b5702c4e19202f
+  data.tar.gz: 0f76c972c65fd6d2e1e78b69e7d5b1868345d0a04a3755a7b39719fc9fffc16e7b0fa5776861202d2638ecfa267a5ee1431493576b5d6467fbba2096d95fb0a1

data/app/inputs/tristate_radio_input.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
-require "formtastic"
-
 # It may also be appropriate to put this file in `app/inputs`
 class TristateRadioInput < Formtastic::Inputs::RadioInput
 
-  # No equals `:null`.
+  # Now equals `:null`.
   # Should equal one of `ActiveModel::Type::Boolean::NULL_VALUES`
   #
   # Mind ActiveAdmin [status resolving logic](https://github.com/activeadmin/activeadmin/blob/master/lib/active_admin/views/components/status_tag.rb#L51):
@@ -14,37 +12,6 @@ class TristateRadioInput < Formtastic::Inputs::RadioInput
   #
   UNSET_KEY = FormtasticTristateRadio.config.unset_key
 
-  I18N_EXAMPLE_ACTIVEADMIN = <<~YAML.chomp
-    ru:
-      active_admin:
-        status_tag:
-          :yes: Да
-          :no: Нет
-          :#{UNSET_KEY}: Неизвестно
-  YAML
-
-  I18N_EXAMPLE_FORMTASTIC = <<~YAML.chomp
-    ru:
-      formtastic:
-        :yes: Да
-        :no: Нет
-        :#{UNSET_KEY}: Неизвестно
-  YAML
-
-
-  # @note In you have ActiveAdmin installed, it will give you YAML example for ActiveAdmin as well, otherwise only for Formtastic
-  #
-  # @return [String] error message with YAML examples for the “unset” label translation lookup error
-  #
-  def self.missing_i18n_error_msg
-    msg = []
-    msg << "Add translations for the “unset” radio label"
-    msg << ["For radiobutton labels in forms:", I18N_EXAMPLE_FORMTASTIC].join("\n")
-    msg << "Note: “yes”, “no” and some other reserved words are converted into Boolean values in YAML, so you need to quote or symbolize them."
-    msg << ["For ActiveAdmin status tags in index & view tables:", I18N_EXAMPLE_ACTIVEADMIN].join("\n") if !!defined?(ActiveAdmin)
-    msg.join("\n\n")
-  end
-
 
   # @see https://github.com/formtastic/formtastic/blob/35dc806964403cb2bb0a6074b951ceef906c8581/lib/formtastic/inputs/base/choices.rb#L59 Original Formtastic method
   #
@@ -89,8 +56,7 @@ class TristateRadioInput < Formtastic::Inputs::RadioInput
   # @see missing_i18n_error_msg
   #
   def label_text_for_unset
-    options.fetch(:null, Formtastic::I18n.t(UNSET_KEY)).presence or \
-      fail FormtasticTristateRadio::MissingTranslationError.new(self.class.missing_i18n_error_msg)
+    options.fetch(:null, Formtastic::I18n.t(UNSET_KEY)).presence or fail FormtasticTristateRadio::I18n::Error.new(locale, UNSET_KEY)
   end
 
 

data/formtastic_tristate_radio.gemspec

@@ -16,21 +16,11 @@ Gem::Specification.new do |spec|
 
   spec.summary          =  "Have 3-state radiobuttons instead of a 2-state checkbox for your Boolean columns which can store NULL"
   spec.description      = <<~HEREDOC
-                            #{spec.summary}.
-
-                            What the gem does?
-
+                            #{spec.summary}. This gem:
                             1. Provides a custom Formtastic input type `:tristate_radio` which renders 3 radios (“Yes”, “No”, “Unset”) instead of a checkbox (only where you put it).
-                            1. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`. See “[How it works](#how-it-works)” ☟ section for technical details on this.
-                            1. Encourages you to add translations for ActiveAdmin “status tag” so that `nil` be correctly translated as “Unset” instead of “False”.
-
+                            2. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`. See “[How it works](#how-it-works)” ☟ section for technical details on this.
+                            3. Encourages you to add translations for ActiveAdmin “status tag” so that `nil` be correctly translated as “Unset” instead of “False”.
                             Does not change controls, you need to turn it on via `as: :tristate_radio` option.
-
-                            By defenition Boolean values have 2 states: True & False.
-
-                            However, if you store a Boolean value in a database column with no `NOT NULL` restriction, it aquires a 3<sup>d</sup> possible state: `null`.
-
-                            Some may consider this practice questionable — I don’t think so. In real life you always have a case when the answer to your question may be only “yes” or “no”, but you don’t know the answer yet. Using a string type column, storing there `"yes"`, `"no"` and `"unset"` + using a state machine + validations — feels overkill to me.
                           HEREDOC
 
   spec.homepage         =  "https://github.com/sergeypedan/formtastic-tristate-radio"

data/lib/formtastic_tristate_radio/i18n/error.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module FormtasticTristateRadio
+  module I18n
+
+    EXAMPLE_ACTIVEADMIN = <<~YAML.chomp
+      ru:
+        active_admin:
+          status_tag:
+            :yes: Да
+            :no: Нет
+            :#{FormtasticTristateRadio.config.unset_key}: Неизвестно
+    YAML
+
+    EXAMPLE_FORMTASTIC = <<~YAML.chomp
+      ru:
+        formtastic:
+          :yes: Да
+          :no: Нет
+          :#{FormtasticTristateRadio.config.unset_key}: Неизвестно
+    YAML
+
+    class Error < ::I18n::MissingTranslationData
+      module Base
+
+        # @note In you have ActiveAdmin installed, it will give you YAML example for ActiveAdmin as well, otherwise only for Formtastic
+        #
+        # @return [String] error message with YAML examples for the “unset” label translation lookup error
+        #
+        # @see URL https://github.com/ruby-i18n/i18n/blob/master/lib/i18n/exceptions.rb#L63 Original I18n method
+        #
+        def message
+          msg = []
+          msg << "Add translations for the “unset” radio label"
+          msg << ["For radiobutton labels in forms:", EXAMPLE_FORMTASTIC].join("\n")
+          msg << "Note: “yes”, “no” and some other reserved words are converted into Boolean values in YAML, so you need to quote or symbolize them."
+          msg << ["For ActiveAdmin status tags in index & view tables:", EXAMPLE_ACTIVEADMIN].join("\n") if !!defined?(ActiveAdmin)
+          [super, msg.join("\n\n")].join("\n\n")
+        end
+      end
+
+      include Base
+    end
+
+  end
+end

data/lib/formtastic_tristate_radio/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FormtasticTristateRadio
-  VERSION = '0.2.3'
+  VERSION = "0.2.4"
 end

data/lib/formtastic_tristate_radio.rb

@@ -1,9 +1,7 @@
 require_relative "formtastic_tristate_radio/version"
-require_relative "formtastic_tristate_radio/missing_translation_error"
 require_relative "formtastic_tristate_radio/configuration"
+require_relative "formtastic_tristate_radio/i18n/error"
 require_relative "formtastic_tristate_radio/engine"
-
 require_relative "../app/models/active_record/base"
 
-module FormtasticTristateRadio
-end
+module FormtasticTristateRadio; end

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: formtastic_tristate_radio
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Sergey Pedan
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
 date: 2021-11-09 00:00:00.000000000 Z
@@ -85,21 +85,11 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1'
 description: |
-  Have 3-state radiobuttons instead of a 2-state checkbox for your Boolean columns which can store NULL.
-
-  What the gem does?
-
+  Have 3-state radiobuttons instead of a 2-state checkbox for your Boolean columns which can store NULL. This gem:
   1. Provides a custom Formtastic input type `:tristate_radio` which renders 3 radios (“Yes”, “No”, “Unset”) instead of a checkbox (only where you put it).
-  1. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`. See “[How it works](#how-it-works)” ☟ section for technical details on this.
-  1. Encourages you to add translations for ActiveAdmin “status tag” so that `nil` be correctly translated as “Unset” instead of “False”.
-
+  2. Teaches Rails recognize `"null"` and `"nil"` param values as `nil`. See “[How it works](#how-it-works)” ☟ section for technical details on this.
+  3. Encourages you to add translations for ActiveAdmin “status tag” so that `nil` be correctly translated as “Unset” instead of “False”.
   Does not change controls, you need to turn it on via `as: :tristate_radio` option.
-
-  By defenition Boolean values have 2 states: True & False.
-
-  However, if you store a Boolean value in a database column with no `NOT NULL` restriction, it aquires a 3<sup>d</sup> possible state: `null`.
-
-  Some may consider this practice questionable — I don’t think so. In real life you always have a case when the answer to your question may be only “yes” or “no”, but you don’t know the answer yet. Using a string type column, storing there `"yes"`, `"no"` and `"unset"` + using a state machine + validations — feels overkill to me.
 email:
 - sergey.pedan@gmail.com
 executables: []
@@ -124,7 +114,7 @@ files:
 - lib/formtastic_tristate_radio.rb
 - lib/formtastic_tristate_radio/configuration.rb
 - lib/formtastic_tristate_radio/engine.rb
-- lib/formtastic_tristate_radio/missing_translation_error.rb
+- lib/formtastic_tristate_radio/i18n/error.rb
 - lib/formtastic_tristate_radio/version.rb
 homepage: https://github.com/sergeypedan/formtastic-tristate-radio
 licenses:
@@ -134,7 +124,7 @@ metadata:
   documentation_uri: https://www.rubydoc.info/gems/formtastic_tristate_radio
   homepage_uri: https://github.com/sergeypedan/formtastic-tristate-radio
   source_code_uri: https://github.com/sergeypedan/formtastic-tristate-radio
-post_install_message:
+post_install_message: 
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -154,8 +144,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
-signing_key:
+rubyforge_project: 
+rubygems_version: 2.5.2.3
+signing_key: 
 specification_version: 4
 summary: Have 3-state radiobuttons instead of a 2-state checkbox for your Boolean
   columns which can store NULL

data/lib/formtastic_tristate_radio/missing_translation_error.rb

@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-module FormtasticTristateRadio
-  class MissingTranslationError < I18n::MissingTranslationData
-  end
-end