formtastic 3.1.5 → 4.0.0.rc1

data/spec/inputs/time_select_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'time select input' do
+RSpec.describe 'time select input' do
 
   include FormtasticSpecHelper
 
@@ -24,42 +24,42 @@ describe 'time select input' do
       end
 
       it 'should not have hidden inputs for day, month and year' do
-        output_buffer.should_not have_tag('input#post_publish_at_1i')
-        output_buffer.should_not have_tag('input#post_publish_at_2i')
-        output_buffer.should_not have_tag('input#post_publish_at_3i')
+        expect(output_buffer).not_to have_tag('input#post_publish_at_1i')
+        expect(output_buffer).not_to have_tag('input#post_publish_at_2i')
+        expect(output_buffer).not_to have_tag('input#post_publish_at_3i')
       end
 
       it 'should have an input for hour and minute' do
-        output_buffer.should have_tag('select#post_publish_at_4i')
-        output_buffer.should have_tag('select#post_publish_at_5i')
+        expect(output_buffer).to have_tag('select#post_publish_at_4i')
+        expect(output_buffer).to have_tag('select#post_publish_at_5i')
       end
 
     end
     
     describe "with :ignore_date => false" do
       before do
-        @new_post.stub(:publish_at).and_return(Time.parse('2010-11-07'))
+        allow(@new_post).to receive(:publish_at).and_return(Time.parse('2010-11-07'))
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:publish_at, :as => :time_select, :ignore_date => false))
         end)
       end
 
       it 'should have a hidden input for day, month and year' do
-        output_buffer.should have_tag('input#post_publish_at_1i')
-        output_buffer.should have_tag('input#post_publish_at_2i')
-        output_buffer.should have_tag('input#post_publish_at_3i')
-        output_buffer.should have_tag('input#post_publish_at_1i[@value="2010"]')
-        output_buffer.should have_tag('input#post_publish_at_2i[@value="11"]')
-        output_buffer.should have_tag('input#post_publish_at_3i[@value="7"]')
+        expect(output_buffer).to have_tag('input#post_publish_at_1i')
+        expect(output_buffer).to have_tag('input#post_publish_at_2i')
+        expect(output_buffer).to have_tag('input#post_publish_at_3i')
+        expect(output_buffer).to have_tag('input#post_publish_at_1i[@value="2010"]')
+        expect(output_buffer).to have_tag('input#post_publish_at_2i[@value="11"]')
+        expect(output_buffer).to have_tag('input#post_publish_at_3i[@value="7"]')
       end
 
       it 'should have an select for hour and minute' do
-        output_buffer.should have_tag('select#post_publish_at_4i')
-        output_buffer.should have_tag('select#post_publish_at_5i')
+        expect(output_buffer).to have_tag('select#post_publish_at_4i')
+        expect(output_buffer).to have_tag('select#post_publish_at_5i')
       end
 
       it 'should associate the legend label with the hour select' do
-        output_buffer.should have_tag('form li.time_select fieldset legend.label label[@for="post_publish_at_4i"]')
+        expect(output_buffer).to have_tag('form li.time_select fieldset legend.label label[@for="post_publish_at_4i"]')
       end
 
     end
@@ -80,26 +80,26 @@ describe 'time select input' do
       it_should_apply_error_logic_for_input_type(:time_select)
 
       it 'should have a legend and label with the label text inside the fieldset' do
-        output_buffer.should have_tag('form li.time_select fieldset legend.label label', /Publish at/)
+        expect(output_buffer).to have_tag('form li.time_select fieldset legend.label label', :text => /Publish at/)
       end
 
       it 'should associate the legend label with the first select' do
-        output_buffer.should have_tag('form li.time_select fieldset legend.label label[@for="post_publish_at_4i"]')
+        expect(output_buffer).to have_tag('form li.time_select fieldset legend.label label[@for="post_publish_at_4i"]')
       end
 
       it 'should have an ordered list of two items inside the fieldset' do
-        output_buffer.should have_tag('form li.time_select fieldset ol.fragments-group')
-        output_buffer.should have_tag('form li.time_select fieldset ol li.fragment', :count => 2)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol.fragments-group')
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li.fragment', :count => 2)
       end
 
       it 'should have five labels for hour and minute' do
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', :count => 2)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', /hour/i)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', /minute/i)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :count => 2)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => /hour/i)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => /minute/i)
       end
 
       it 'should have two selects for hour and minute' do
-        output_buffer.should have_tag('form li.time_select fieldset ol li', :count => 2)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li', :count => 2)
       end
     end
 
@@ -111,20 +111,20 @@ describe 'time select input' do
       end
 
       it 'should have five labels for hour and minute' do
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', :count => 3)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', /hour/i)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', /minute/i)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', /second/i)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :count => 3)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => /hour/i)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => /minute/i)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => /second/i)
       end
 
       it 'should have three selects for hour, minute and seconds' do
-        output_buffer.should have_tag('form li.time_select fieldset ol li', :count => 3)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li', :count => 3)
       end
 
       it 'should generate a sanitized label and matching ids for attribute' do
         4.upto(6) do |i|
-          output_buffer.should have_tag("form li fieldset ol li label[@for='post_publish_at_#{i}i']")
-          output_buffer.should have_tag("form li fieldset ol li #post_publish_at_#{i}i")
+          expect(output_buffer).to have_tag("form li fieldset ol li label[@for='post_publish_at_#{i}i']")
+          expect(output_buffer).to have_tag("form li fieldset ol li #post_publish_at_#{i}i")
         end
       end
     end
@@ -138,9 +138,9 @@ describe 'time select input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:created_at, :as => :time_select, :include_seconds => true, :labels => { field => "another #{field} label" }))
         end)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', :count => fields.length)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :count => fields.length)
         fields.each do |f|
-          output_buffer.should have_tag('form li.time_select fieldset ol li label', f == field ? /another #{f} label/i : /#{f}/i)
+          expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => f == field ? /another #{f} label/i : /#{f}/i)
         end
       end
 
@@ -149,9 +149,9 @@ describe 'time select input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:created_at, :as => :time_select, :include_seconds => true, :labels => { field => "" }))
         end)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', :count => fields.length-1)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :count => fields.length-1)
         fields.each do |f|
-          output_buffer.should have_tag('form li.time_select fieldset ol li label', /#{f}/i) unless field == f
+          expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => /#{f}/i) unless field == f
         end
       end
       
@@ -160,9 +160,9 @@ describe 'time select input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:created_at, :as => :time_select, :include_seconds => true, :labels => { field => false }))
         end)
-        output_buffer.should have_tag('form li.time_select fieldset ol li label', :count => fields.length-1)
+        expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :count => fields.length-1)
         fields.each do |f|
-          output_buffer.should have_tag('form li.time_select fieldset ol li label', /#{f}/i) unless field == f
+          expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :text => /#{f}/i) unless field == f
         end
       end
 
@@ -171,7 +171,7 @@ describe 'time select input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:created_at, :as => :time_select, :include_seconds => true, :labels => { field => false }))
         end)
-        output_buffer.should_not include(">")
+        expect(output_buffer).not_to include(">")
       end
       
     end
@@ -181,7 +181,20 @@ describe 'time select input' do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.input(:created_at, :as => :time_select, :include_seconds => true, :labels => false))
       end)
-      output_buffer.should have_tag('form li.time_select fieldset ol li label', :count => 0)
+      expect(output_buffer).to have_tag('form li.time_select fieldset ol li label', :count => 0)
+    end
+  end
+
+  describe ":selected option for setting a value" do
+    it "should set the selected value for the form" do
+      concat(
+        semantic_form_for(@new_post) do |f|
+          concat(f.input(:created_at, :as => :datetime_select, :selected => DateTime.new(2018, 10, 4, 12, 00)))
+        end
+      )
+
+      expect(output_buffer).to have_tag "option[value='12'][selected='selected']"
+      expect(output_buffer).to have_tag "option[value='00'][selected='selected']"
     end
   end
 
@@ -193,9 +206,9 @@ describe 'time select input' do
     end
 
     it 'should have a tag matching the namespace' do
-      output_buffer.should have_tag('#form2_post_publish_at_input')
-      output_buffer.should have_tag('#form2_post_publish_at_4i')
-      output_buffer.should have_tag('#form2_post_publish_at_5i')
+      expect(output_buffer).to have_tag('#form2_post_publish_at_input')
+      expect(output_buffer).to have_tag('#form2_post_publish_at_4i')
+      expect(output_buffer).to have_tag('#form2_post_publish_at_5i')
     end
   end
   
@@ -205,7 +218,7 @@ describe 'time select input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :time_select, :required => true))
         end)
-        output_buffer.should have_tag("select[@required]", :count => 2)
+        expect(output_buffer).to have_tag("select[@required]", :count => 2)
       end
     end
   end
@@ -221,23 +234,23 @@ describe 'time select input' do
     end
 
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_created_at_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_created_at_input")
     end
 
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_created_at_1i")
-      output_buffer.should have_tag("input#post_author_attributes_3_created_at_2i")
-      output_buffer.should have_tag("input#post_author_attributes_3_created_at_3i")
-      output_buffer.should have_tag("select#post_author_attributes_3_created_at_4i")
-      output_buffer.should have_tag("select#post_author_attributes_3_created_at_5i")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_created_at_1i")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_created_at_2i")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_created_at_3i")
+      expect(output_buffer).to have_tag("select#post_author_attributes_3_created_at_4i")
+      expect(output_buffer).to have_tag("select#post_author_attributes_3_created_at_5i")
     end
 
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][created_at(1i)]']")
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][created_at(2i)]']")
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][created_at(3i)]']")
-      output_buffer.should have_tag("select[@name='post[author_attributes][3][created_at(4i)]']")
-      output_buffer.should have_tag("select[@name='post[author_attributes][3][created_at(5i)]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][created_at(1i)]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][created_at(2i)]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][created_at(3i)]']")
+      expect(output_buffer).to have_tag("select[@name='post[author_attributes][3][created_at(4i)]']")
+      expect(output_buffer).to have_tag("select[@name='post[author_attributes][3][created_at(5i)]']")
     end
 
   end

data/spec/inputs/time_zone_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'time_zone input' do
+RSpec.describe 'time_zone input' do
 
   include FormtasticSpecHelper
 
@@ -20,22 +20,22 @@ describe 'time_zone input' do
   it_should_apply_error_logic_for_input_type(:time_zone)
 
   it 'should generate a label for the input' do
-    output_buffer.should have_tag('form li label')
-    output_buffer.should have_tag('form li label[@for="post_time_zone"]')
-    output_buffer.should have_tag('form li label', /Time zone/)
+    expect(output_buffer).to have_tag('form li label')
+    expect(output_buffer).to have_tag('form li label[@for="post_time_zone"]')
+    expect(output_buffer).to have_tag('form li label', :text => /Time zone/)
   end
 
   it "should generate a select" do
-    output_buffer.should have_tag("form li select")
-    output_buffer.should have_tag("form li select#post_time_zone")
-    output_buffer.should have_tag("form li select[@name=\"post[time_zone]\"]")
+    expect(output_buffer).to have_tag("form li select")
+    expect(output_buffer).to have_tag("form li select#post_time_zone")
+    expect(output_buffer).to have_tag("form li select[@name=\"post[time_zone]\"]")
   end
 
   it 'should use input_html to style inputs' do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:time_zone, :input_html => { :class => 'myclass' }))
     end)
-    output_buffer.should have_tag("form li select.myclass")
+    expect(output_buffer).to have_tag("form li select.myclass")
   end
 
   describe "when namespace is provided" do
@@ -69,37 +69,37 @@ describe 'time_zone input' do
     end
 
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
 
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("select#post_author_attributes_3_name")
+      expect(output_buffer).to have_tag("select#post_author_attributes_3_name")
     end
 
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("select[@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("select[@name='post[author_attributes][3][name]']")
     end
 
   end
 
 
   describe 'when no object is given' do
-    before(:each) do
+    before(:example) do
       concat(semantic_form_for(:project, :url => 'http://test.host/') do |builder|
         concat(builder.input(:time_zone, :as => :time_zone))
       end)
     end
 
     it 'should generate labels' do
-      output_buffer.should have_tag('form li label')
-      output_buffer.should have_tag('form li label[@for="project_time_zone"]')
-      output_buffer.should have_tag('form li label', /Time zone/)
+      expect(output_buffer).to have_tag('form li label')
+      expect(output_buffer).to have_tag('form li label[@for="project_time_zone"]')
+      expect(output_buffer).to have_tag('form li label', :text => /Time zone/)
     end
 
     it 'should generate select inputs' do
-      output_buffer.should have_tag("form li select")
-      output_buffer.should have_tag("form li select#project_time_zone")
-      output_buffer.should have_tag("form li select[@name=\"project[time_zone]\"]")
+      expect(output_buffer).to have_tag("form li select")
+      expect(output_buffer).to have_tag("form li select#project_time_zone")
+      expect(output_buffer).to have_tag("form li select[@name=\"project[time_zone]\"]")
     end
   end
 
@@ -109,7 +109,7 @@ describe 'time_zone input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :time_zone, :required => true))
         end)
-        output_buffer.should have_tag("select[@required]")
+        expect(output_buffer).to have_tag("select[@required]")
       end
     end
   end

data/spec/inputs/url_input_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'url input' do
+RSpec.describe 'url input' do
 
   include FormtasticSpecHelper
 
@@ -56,15 +56,15 @@ describe 'url input' do
     end
     
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
     end
     
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer).to have_tag("input#post_author_attributes_3_name")
     end
     
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][name]']")
+      expect(output_buffer).to have_tag("input[@name='post[author_attributes][3][name]']")
     end
     
   end
@@ -76,7 +76,7 @@ describe 'url input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :url, :required => true))
         end)
-        output_buffer.should have_tag("input[@required]")
+        expect(output_buffer).to have_tag("input[@required]")
       end
     end
   end

data/spec/inputs/with_options_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'string input' do
+RSpec.describe 'string input' do
 
   include FormtasticSpecHelper
 
@@ -21,23 +21,23 @@ describe 'string input' do
     end
 
     it "should have extra class on title" do
-      output_buffer.should have_tag("form li#post_title_input.extra")
+      expect(output_buffer).to have_tag("form li#post_title_input.extra")
     end
     it "should have title as string" do
-      output_buffer.should have_tag("form li#post_title_input.string")
+      expect(output_buffer).to have_tag("form li#post_title_input.string")
     end
     it "should not have title as radio" do
-      output_buffer.should_not have_tag("form li#post_title_input.radio")
+      expect(output_buffer).not_to have_tag("form li#post_title_input.radio")
     end
 
     it "should have extra class on author" do
-      output_buffer.should have_tag("form li#post_author_input.extra")
+      expect(output_buffer).to have_tag("form li#post_author_input.extra")
     end
     it "should not have author as string" do
-      output_buffer.should_not have_tag("form li#post_author_input.string")
+      expect(output_buffer).not_to have_tag("form li#post_author_input.string")
     end
     it "should have author as radio" do
-      output_buffer.should have_tag("form li#post_author_input.radio")
+      expect(output_buffer).to have_tag("form li#post_author_input.radio")
     end
   end
 end

data/spec/localizer_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 require 'spec_helper'
 
-describe 'Formtastic::Localizer' do
+RSpec.describe 'Formtastic::Localizer' do
   describe "Cache" do
     before do
       @cache = Formtastic::Localizer::Cache.new
@@ -11,27 +11,27 @@ describe 'Formtastic::Localizer' do
     end
     
     it "should get value" do
-      @cache.get(@key).should == 'value'
-      @cache.get(@undefined_key).should be_nil
+      expect(@cache.get(@key)).to eq('value')
+      expect(@cache.get(@undefined_key)).to be_nil
     end
     
     it "should check if key exists?" do
-      @cache.has_key?(@key).should be_truthy
-      @cache.has_key?(@undefined_key).should be_falsey
+      expect(@cache.has_key?(@key)).to be_truthy
+      expect(@cache.has_key?(@undefined_key)).to be_falsey
     end
     
     it "should set a key" do
       @cache.set(['model', 'name2'], 'value2')
-      @cache.get(['model', 'name2']).should == 'value2'
+      expect(@cache.get(['model', 'name2'])).to eq('value2')
     end
     
     it "should return hash" do
-      @cache.cache.should be_an_instance_of(Hash)
+      expect(@cache.cache).to be_an_instance_of(Hash)
     end
     
     it "should clear the cache" do
       @cache.clear!
-      @cache.get(@key).should be_nil
+      expect(@cache.get(@key)).to be_nil
     end
   end
   
@@ -53,11 +53,11 @@ describe 'Formtastic::Localizer' do
     end
     
     it "should be defined" do
-      lambda { Formtastic::Localizer }.should_not raise_error
+      expect { Formtastic::Localizer }.not_to raise_error
     end
     
     it "should have a cache" do
-      Formtastic::Localizer.cache.should be_an_instance_of(Formtastic::Localizer::Cache)
+      expect(Formtastic::Localizer.cache).to be_an_instance_of(Formtastic::Localizer::Cache)
     end
     
     describe "localize" do
@@ -75,19 +75,19 @@ describe 'Formtastic::Localizer' do
       end
 
       it "should translate key with i18n" do
-        @localizer.localize(:name, :name, :label).should == 'POST.NAME'
+        expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')
       end
       
       describe "with caching" do
         it "should not update translation when stored translations change" do
           with_config :i18n_cache_lookups, true do
-            @localizer.localize(:name, :name, :label).should == 'POST.NAME'
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')
             store_post_translations('POST.NEW_NAME')
             
-            @localizer.localize(:name, :name, :label).should == 'POST.NAME'       
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')       
             
             Formtastic::Localizer.cache.clear!
-            @localizer.localize(:name, :name, :label).should == 'POST.NEW_NAME'                  
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NEW_NAME')                  
           end
         end        
       end
@@ -95,9 +95,9 @@ describe 'Formtastic::Localizer' do
       describe "without caching" do
         it "should update translation when stored translations change" do
           with_config :i18n_cache_lookups, false do
-            @localizer.localize(:name, :name, :label).should == 'POST.NAME'
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')
             store_post_translations('POST.NEW_NAME')
-            @localizer.localize(:name, :name, :label).should == 'POST.NEW_NAME'            
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NEW_NAME')            
           end
         end
       end
@@ -120,7 +120,7 @@ describe 'Formtastic::Localizer' do
         end
 
         it "should translate custom key with i18n" do
-          @localizer.localize(:name, :name, :label).should == 'MESSAGE.NAME'
+          expect(@localizer.localize(:name, :name, :label)).to eq('MESSAGE.NAME')
         end
       end 
     end