formtastic 3.1.3 → 3.1.4

data/spec/inputs/check_boxes_input_spec.rb

@@ -5,6 +5,11 @@ describe 'check_boxes input' do
 
   include FormtasticSpecHelper
 
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
   describe 'for a has_many association' do
     before do
       @output_buffer = ''
@@ -56,15 +61,15 @@ describe 'check_boxes input' do
     end
 
     describe "each choice" do
-      
+
       it 'should not give the choice label the .label class' do
         output_buffer.should_not have_tag('li.choice label.label')
       end
-      
+
       it 'should not be marked as required' do
         output_buffer.should_not have_tag('li.choice input[@required]')
       end
-      
+
       it 'should contain a label for the radio input with a nested input and label text' do
         ::Post.all.each do |post|
           output_buffer.should have_tag('form li fieldset ol li label', /#{post.to_label}/)
@@ -77,7 +82,7 @@ describe 'check_boxes input' do
           output_buffer.should have_tag("form li fieldset ol li.post_#{post.id} label")
         end
       end
-      
+
       it 'should have a checkbox input but no hidden field for each post' do
         ::Post.all.each do |post|
           output_buffer.should have_tag("form li fieldset ol li label input#author_post_ids_#{post.id}")
@@ -290,11 +295,11 @@ describe 'check_boxes input' do
       it "should not output the legend" do
         output_buffer.should_not have_tag("legend.label")
       end
-      
+
       it "should not cause escaped HTML" do
         output_buffer.should_not include(">")
       end
-      
+
     end
 
     describe "when :required option is true" do
@@ -309,7 +314,23 @@ describe 'check_boxes input' do
         output_buffer.should have_tag("legend.label label abbr")
       end
     end
+  end
+
+  describe 'for a enum column' do
+    before do
+      @new_post.stub(:status) { 'inactive' }
+      statuses = ActiveSupport::HashWithIndifferentAccess.new("active"=>0, "inactive"=>1)
+      @new_post.class.stub(:statuses) { statuses }
+      @new_post.stub(:defined_enums) { { "status" => statuses } }
+    end
 
+    it 'should have a select inside the wrapper' do
+      expect {
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:status, :as => :check_boxes))
+        end)
+      }.to raise_error(Formtastic::UnsupportedEnumCollection)
+    end
   end
 
   describe 'for a has_and_belongs_to_many association' do
@@ -337,6 +358,31 @@ describe 'check_boxes input' do
 
   end
 
+  describe ':collection for a has_and_belongs_to_many association' do
+
+    before do
+      @output_buffer = ''
+      mock_everything
+
+      concat(semantic_form_for(@freds_post) do |builder|
+        concat(builder.input(:authors, as: :check_boxes, collection: Author.all))
+      end)
+    end
+
+    it 'should render checkboxes' do
+      # I'm aware these two lines test the same thing
+      output_buffer.should have_tag('input[type="checkbox"]', :count => 2)
+      output_buffer.should have_tag('input[type="checkbox"]', :count => ::Author.all.size)
+    end
+
+    it 'should only select checkboxes that are present in the association' do
+      # I'm aware these two lines test the same thing
+      output_buffer.should have_tag('input[checked="checked"]', :count => 1)
+      output_buffer.should have_tag('input[checked="checked"]', :count => @freds_post.authors.size)
+    end
+
+  end
+
   describe 'for an association when a :collection is provided' do
     describe 'it should use the specified :member_value option' do
       before do
@@ -350,7 +396,7 @@ describe 'check_boxes input' do
         item.stub(:custom_value).and_return('custom_value')
         item.should_receive(:custom_value).exactly(3).times
         @new_post.author.should_receive(:custom_value).exactly(1).times
-        
+
         with_deprecation_silenced do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:author, :as => :check_boxes, :member_value => :custom_value, :collection => [item, item, item]))
@@ -360,35 +406,35 @@ describe 'check_boxes input' do
       end
     end
   end
-  
+
   describe 'when :collection is provided as an array of arrays' do
     before do
       @output_buffer = ''
       mock_everything
       @fred.stub(:genres) { ['fiction', 'biography'] }
-      
+
       concat(semantic_form_for(@fred) do |builder|
         concat(builder.input(:genres, :as => :check_boxes, :collection => [['Fiction', 'fiction'], ['Non-fiction', 'non_fiction'], ['Biography', 'biography']]))
       end)
     end
-    
+
     it 'should check the correct checkboxes' do
       output_buffer.should have_tag("form li fieldset ol li label input[@value='fiction'][@checked='checked']")
       output_buffer.should have_tag("form li fieldset ol li label input[@value='biography'][@checked='checked']")
     end
   end
-  
+
   describe 'when :collection is a set' do
     before do
       @output_buffer = ''
       mock_everything
       @fred.stub(:roles) { Set.new([:reviewer, :admin]) }
-      
+
       concat(semantic_form_for(@fred) do |builder|
         concat(builder.input(:roles, :as => :check_boxes, :collection => [['User', :user], ['Reviewer', :reviewer], ['Administrator', :admin]]))
       end)
     end
-    
+
     it 'should check the correct checkboxes' do
       output_buffer.should have_tag("form li fieldset ol li label input[@value='user']")
       output_buffer.should have_tag("form li fieldset ol li label input[@value='admin'][@checked='checked']")
@@ -406,7 +452,7 @@ describe 'check_boxes input' do
         concat(builder.input(:posts, :as => :check_boxes))
       end)
     end
-    
+
     it "should have a label for #context2_author_post_ids_19" do
       output_buffer.should have_tag("form li label[@for='context2_author_post_ids_19']")
     end
@@ -414,7 +460,7 @@ describe 'check_boxes input' do
     it_should_have_input_with_id('context2_author_post_ids_19')
     it_should_have_input_wrapper_with_id("context2_author_posts_input")
   end
-  
+
   describe "when index is provided" do
 
     before do
@@ -427,11 +473,11 @@ describe 'check_boxes input' do
         end)
       end)
     end
-    
+
     it 'should index the id of the wrapper' do
       output_buffer.should have_tag("li#author_post_3_authors_input")
     end
-    
+
     it 'should index the id of the input tag' do
       output_buffer.should have_tag("input#author_post_3_author_ids_42")
     end
@@ -439,9 +485,9 @@ describe 'check_boxes input' do
     it 'should index the name of the checkbox input' do
       output_buffer.should have_tag("input[@type='checkbox'][@name='author[post][3][author_ids][]']")
     end
-    
+
   end
-  
+
 
   describe "when collection is an array" do
     before do
@@ -495,6 +541,6 @@ describe 'check_boxes input' do
       end
     end
   end
-  
+
 end
 

data/spec/inputs/country_input_spec.rb

@@ -17,7 +17,7 @@ describe 'country input' do
         semantic_form_for(@new_post) do |builder|
           concat(builder.input(:country, :as => :country))
         end
-      }.should raise_error
+      }.should raise_error(Formtastic::Inputs::CountryInput::CountrySelectPluginMissing)
     end
 
   end
@@ -56,7 +56,7 @@ describe 'country input' do
       priority_countries = ["Foo", "Bah"]
       semantic_form_for(@new_post) do |builder|
         builder.stub(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
-        builder.should_receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+        builder.should_receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false, :readonly => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
 
         concat(builder.input(:country, :as => :country, :priority_countries => priority_countries))
       end
@@ -69,7 +69,7 @@ describe 'country input' do
 
       semantic_form_for(@new_post) do |builder|
         builder.stub(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
-        builder.should_receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+        builder.should_receive(:country_select).with(:country, priority_countries, {}, {:id => "post_country", :required => false, :autofocus => false, :readonly => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
 
         concat(builder.input(:country, :as => :country))
       end
@@ -85,7 +85,7 @@ describe 'country input' do
 
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
         builder.stub(:country_select).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
-        builder.should_receive(:country_select).with(:country, [], {}, {:id => "context2_post_country", :required => false, :autofocus => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
+        builder.should_receive(:country_select).with(:country, [], {}, {:id => "context2_post_country", :required => false, :autofocus => false, :readonly => false}).and_return(Formtastic::Util.html_safe("<select><option>...</option></select>"))
         concat(builder.input(:country, :priority_countries => []))
       end)
     end

data/spec/inputs/radio_input_spec.rb

@@ -152,6 +152,34 @@ describe 'radio input' do
     end
   end
 
+  describe 'for a enum column' do
+    before do
+      @new_post.stub(:status) { 'inactive' }
+      statuses = ActiveSupport::HashWithIndifferentAccess.new("active"=>0, "inactive"=>1)
+      @new_post.class.stub(:statuses) { statuses }
+      @new_post.stub(:defined_enums) { { "status" => statuses } }
+    end
+
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.input(:status, :as => :radio))
+      end)
+    end
+
+    it 'should have a radio input for each defined enum status' do
+      output_buffer.should have_tag("form li input[@name='post[status]'][@type='radio']", :count => @new_post.class.statuses.count)
+      @new_post.class.statuses.each do |label, value|
+        output_buffer.should have_tag("form li input[@value='#{label}']")
+        output_buffer.should have_tag("form li label", /#{label.humanize}/)
+      end
+    end
+
+    it 'should have one radio input with a "checked" attribute' do
+      output_buffer.should have_tag("form li input[@name='post[status]'][@checked]", :count => 1)
+    end
+  end
+
+
   describe "with i18n of the legend label" do
 
     before do

data/spec/inputs/readonly_spec.rb

@@ -0,0 +1,50 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'readonly option' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
+  describe "placeholder text" do
+    [:email, :number, :password, :phone, :search, :string, :url, :text, :date_picker, :time_picker, :datetime_picker].each do |type|
+
+      describe "for #{type} inputs" do
+
+        describe "when readonly is found in input_html" do
+          it "sets readonly attribute" do
+            concat(semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:title, :as => type, input_html: {readonly: true}))
+            end)
+              output_buffer.should have_tag((type == :text ? 'textarea' : 'input') + '[@readonly]')
+          end
+        end
+
+        describe "when readonly not found in input_html" do
+          describe "when column is not readonly attribute" do
+            it "doesn't set readonly attribute" do
+              concat(semantic_form_for(@new_post) do |builder|
+                concat(builder.input(:title, :as => type))
+              end)
+                output_buffer.should_not have_tag((type == :text ? 'textarea' : 'input') + '[@readonly]')
+            end
+          end
+          describe "when column is readonly attribute" do
+            it "sets readonly attribute" do
+              input_class = "Formtastic::Inputs::#{type.to_s.camelize}Input".constantize
+              expect_any_instance_of(input_class).to receive(:readonly_attribute?).at_least(1).and_return(true)
+              concat(semantic_form_for(@new_post) do |builder|
+                concat(builder.input(:title, :as => type))
+              end)
+                output_buffer.should have_tag((type == :text ? 'textarea' : 'input') + '[@readonly]')
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/inputs/select_input_spec.rb

@@ -151,6 +151,77 @@ describe 'select input' do
     end
   end
 
+  describe 'for a enum column' do
+    before do
+      @new_post.stub(:status) { 'inactive' }
+      statuses = ActiveSupport::HashWithIndifferentAccess.new("active"=>0, "inactive"=>1)
+      @new_post.class.stub(:statuses) { statuses }
+      @new_post.stub(:defined_enums) { { "status" => statuses } }
+    end
+
+    context 'single choice' do
+      before do
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:status, :as => :select))
+        end)
+      end
+
+      it_should_have_input_wrapper_with_class("select")
+      it_should_have_input_wrapper_with_class(:input)
+      it_should_have_input_wrapper_with_id("post_status_input")
+      it_should_have_label_with_text(/Status/)
+      it_should_have_label_for('post_status')
+      it_should_apply_error_logic_for_input_type(:select)
+
+      it 'should have a select inside the wrapper' do
+        output_buffer.should have_tag('form li select')
+        output_buffer.should have_tag('form li select#post_status')
+      end
+
+      it 'should have a valid name' do
+        output_buffer.should have_tag("form li select[@name='post[status]']")
+        output_buffer.should_not have_tag("form li select[@name='post[status][]']")
+      end
+
+      it 'should not create a multi-select' do
+        output_buffer.should_not have_tag('form li select[@multiple]')
+      end
+      
+      it 'should not add a hidden input' do
+        output_buffer.should_not have_tag('form li input[@type="hidden"]')
+      end
+
+      it 'should create a select without size' do
+        output_buffer.should_not have_tag('form li select[@size]')
+      end
+
+      it 'should have a blank option' do
+        output_buffer.should have_tag("form li select option[@value='']")
+      end
+
+      it 'should have a select option for each defined enum status' do
+        output_buffer.should have_tag("form li select[@name='post[status]'] option", :count => @new_post.class.statuses.count + 1)
+        @new_post.class.statuses.each do |label, value|
+          output_buffer.should have_tag("form li select option[@value='#{label}']", /#{label.humanize}/)
+        end
+      end
+
+      it 'should have one option with a "selected" attribute (TODO)' do
+        output_buffer.should have_tag("form li select[@name='post[status]'] option[@selected]", :count => 1)
+      end
+    end
+
+    context 'multiple choice' do
+      it 'raises an error' do
+        expect {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.input(:status, :as => :select, :multiple => true))
+          end)
+        }.to raise_error Formtastic::UnsupportedEnumCollection
+      end
+    end
+  end
+
   describe 'for a belongs_to association' do
     before do
       concat(semantic_form_for(@new_post) do |builder|
@@ -240,17 +311,6 @@ describe 'select input' do
         concat(builder.input(:author, :as => :select))
       end
     end
-
-    it "should call author.(scoped|where) with association conditions" do
-      if Formtastic::Util.rails3?
-        ::Author.should_receive(:scoped).with(:conditions => {:active => true})
-      else
-        ::Author.should_receive(:where).with({:active => true})
-      end
-      semantic_form_for(@new_post) do |builder|
-        concat(builder.input(:author, :as => :select))
-      end
-    end
   end
 
   describe 'for a has_many association' do

data/spec/inputs/time_zone_input_spec.rb

@@ -54,7 +54,7 @@ describe 'time_zone input' do
     it_should_have_label_for("context2_post_time_zone")
 
   end
-  
+
   describe "when index is provided" do
 
     before do
@@ -67,21 +67,21 @@ describe 'time_zone input' do
         end)
       end)
     end
-    
+
     it 'should index the id of the wrapper' do
       output_buffer.should have_tag("li#post_author_attributes_3_name_input")
     end
-    
+
     it 'should index the id of the select tag' do
       output_buffer.should have_tag("select#post_author_attributes_3_name")
     end
-    
+
     it 'should index the name of the select tag' do
       output_buffer.should have_tag("select[@name='post[author_attributes][3][name]']")
     end
-    
+
   end
-  
+
 
   describe 'when no object is given' do
     before(:each) do
@@ -102,10 +102,10 @@ describe 'time_zone input' do
       output_buffer.should have_tag("form li select[@name=\"project[time_zone]\"]")
     end
   end
-  
+
   context "when required" do
     it "should add the required attribute to the input's html options" do
-      with_config :use_required_attribute, true do 
+      with_config :use_required_attribute, true do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :time_zone, :required => true))
         end)
@@ -113,5 +113,31 @@ describe 'time_zone input' do
       end
     end
   end
-  
+
+  describe "when priority time zone is provided" do
+    let(:time_zones) { [ActiveSupport::TimeZone['Alaska'], ActiveSupport::TimeZone['Hawaii']] }
+    let(:input_html_options) do
+      { id: "post_title", required: false, autofocus: false, readonly: false }
+    end
+
+    context "by priority_zone option" do
+      it "passes right time_zones" do
+        expect_any_instance_of(Formtastic::FormBuilder).to receive(:time_zone_select).with(:title, time_zones, {}, input_html_options)
+        semantic_form_for(@new_post) do |builder|
+          builder.input(:title, as: :time_zone, priority_zones: time_zones)
+        end
+      end
+    end
+
+    context "by configuration" do
+      it "passes right time_zones" do
+        expect_any_instance_of(Formtastic::FormBuilder).to receive(:time_zone_select).with(:title, time_zones, {}, input_html_options)
+        with_config :priority_time_zones, time_zones do
+          semantic_form_for(@new_post) do |builder|
+            builder.input(:title, as: :time_zone)
+          end
+        end
+      end
+    end
+  end
 end