formtastic 2.0.2 → 2.1.0.beta1

data/spec/actions/input_action_spec.rb

@@ -0,0 +1,59 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'InputAction', 'when submitting' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+    
+    concat(semantic_form_for(@new_post) do |builder|
+      concat(builder.action(:submit, :as => :input))
+    end)
+  end
+  
+  it 'should render a submit type of input' do
+    output_buffer.should have_tag('li.action.input_action input[@type="submit"]')
+  end
+
+end
+
+describe 'InputAction', 'when resetting' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+    
+    concat(semantic_form_for(@new_post) do |builder|
+      concat(builder.action(:reset, :as => :input))
+    end)
+  end
+  
+  it 'should render a reset type of input' do
+    output_buffer.should have_tag('li.action.input_action input[@type="reset"]')
+  end
+  
+end
+
+describe 'InputAction', 'when cancelling' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  it 'should raise an error' do
+    lambda { 
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :input))
+      end)
+    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+  end
+  
+end

data/spec/actions/link_action_spec.rb

@@ -0,0 +1,92 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'LinkAction', 'when cancelling' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  context 'without a :url' do
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :link))
+      end)
+    end
+    
+    it 'should render a submit type of input' do
+      output_buffer.should have_tag('li.action.link_action a[@href="javascript:history.back()"]')
+    end
+    
+  end
+  
+  context 'with a :url as String' do
+    
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :link, :url => "http://foo.bah/baz"))
+      end)
+    end
+    
+    it 'should render a submit type of input' do
+      output_buffer.should have_tag('li.action.link_action a[@href="http://foo.bah/baz"]')
+    end
+    
+  end
+
+  context 'with a :url as Hash' do
+    
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :link, :url => { :action => "foo" }))
+      end)
+    end
+    
+    it 'should render a submit type of input' do
+      output_buffer.should have_tag('li.action.link_action a[@href="/mock/path"]')
+    end
+    
+  end
+
+end
+
+describe 'LinkAction', 'when submitting' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  it 'should raise an error' do
+    lambda { 
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:submit, :as => :link))
+      end)
+    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+  end
+  
+end
+
+describe 'LinkAction', 'when submitting' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  it 'should raise an error' do
+    lambda { 
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:reset, :as => :link))
+      end)
+    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+  end
+  
+end

data/spec/builder/semantic_fields_for_spec.rb

@@ -98,6 +98,20 @@ describe 'Formtastic::FormBuilder#fields_for' do
       end)
       output_buffer.should have_tag('form fieldset.inputs #context2_post_author_1_login_input')
     end
+    
+    it 'should render errors on the nested inputs' do
+      @errors = mock('errors')
+      @errors.stub!(:[]).with(:login).and_return(['oh noes'])
+      @bob.stub!(:errors).and_return(@errors)
+      
+      concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
+        concat(builder.semantic_fields_for(@bob) do |nested_builder|
+          concat(nested_builder.inputs(:login))
+        end)
+      end)
+      output_buffer.should =~ /oh noes/
+    end
+    
   end
   
   context "when I rendered my own hidden id input" do 

data/spec/generators/formtastic/form/form_generator_spec.rb

@@ -0,0 +1,118 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/formtastic/form/form_generator'
+
+describe Formtastic::FormGenerator do
+
+  include FormtasticSpecHelper
+
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before do
+    @output_buffer = ''
+    prepare_destination
+    mock_everything
+    ::Post.stub!(:reflect_on_all_associations).with(:belongs_to).and_return([
+      mock('reflection', :name => :author, :options => {}, :klass => ::Author, :macro => :belongs_to),
+      mock('reflection', :name => :reviewer, :options => {:class_name => 'Author'}, :klass => ::Author, :macro => :belongs_to),
+      mock('reflection', :name => :main_post, :options => {}, :klass => ::Post, :macro => :belongs_to),
+      mock('reflection', :name => :attachment, :options => {:polymorphic => true}, :macro => :belongs_to),
+    ])
+  end
+
+  describe 'without model' do
+    it 'should raise Thor::RequiredArgumentMissingError' do
+      lambda { run_generator }.should raise_error(Thor::RequiredArgumentMissingError)
+    end
+  end
+
+  describe 'with existing model' do
+    it 'should not raise an exception' do
+      lambda { run_generator %w(Post) }.should_not raise_error(Thor::RequiredArgumentMissingError)
+    end
+  end
+
+  describe 'with attributes' do
+    before { run_generator %w(Post title:string author:references) }
+
+    describe 'render only the specified attributes' do
+      subject { file('app/views/posts/_form.html.erb') }
+      it { should exist }
+      it { should contain "<%= f.input :title %>" }
+      it { should contain "<%= f.input :author %>" }
+      it { should_not contain "<%= f.input :main_post %>" }
+    end
+  end
+
+  describe 'without attributes' do
+    before { run_generator %w(Post) }
+
+    subject { file('app/views/posts/_form.html.erb') }
+
+    describe 'content_columns' do
+      it { should contain "<%= f.input :title %>" }
+      it { should contain "<%= f.input :body %>" }
+      it { should_not contain "<%= f.input :created_at %>" }
+      it { should_not contain "<%= f.input :updated_at %>" }
+    end
+
+    describe 'reflection_on_association' do
+      it { should contain "<%= f.input :author %>" }
+      it { should contain "<%= f.input :reviewer %>" }
+      it { should contain "<%= f.input :main_post %>" }
+      it { should_not contain "<%= f.input :attachment %>" }
+    end
+  end
+
+  describe 'with template engine option' do
+    describe 'erb' do
+      before { run_generator %w(Post --template-engine erb) }
+
+      describe 'app/views/posts/_form.html.erb' do
+        subject { file('app/views/posts/_form.html.erb') }
+        it { should exist }
+        it { should contain "<%= semantic_form_for @post do |f| %>" }
+      end
+    end
+
+    describe 'haml' do
+      before { run_generator %w(Post --template-engine haml) }
+
+      describe 'app/views/posts/_form.html.haml' do
+        subject { file('app/views/posts/_form.html.haml') }
+        it { should exist }
+        it { should contain "= semantic_form_for @post do |f|" }
+      end
+    end
+
+    describe 'slim' do
+      before { run_generator %w(Post --template-engine slim) }
+
+      describe 'app/views/posts/_form.html.slim' do
+        subject { file('app/views/posts/_form.html.slim') }
+        it { should exist }
+        it { should contain "= semantic_form_for @post do |f|" }
+      end
+    end
+  end
+
+  describe 'with copy option' do
+    before { run_generator %w(Post --copy) }
+
+    describe 'app/views/posts/_form.html.erb' do
+      subject { file('app/views/posts/_form.html.erb') }
+      it { should_not exist }
+    end
+  end
+
+  describe 'with controller option' do
+    before { run_generator %w(Post --controller admin/posts) }
+
+    describe 'app/views/admin/posts/_form.html.erb' do
+      subject { file('app/views/admin/posts/_form.html.erb') }
+      it { should exist }
+    end
+  end
+end

data/spec/generators/formtastic/install/install_generator_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/formtastic/install/install_generator'
+
+describe Formtastic::InstallGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  describe 'no arguments' do
+    before { run_generator  }
+
+    describe 'config/initializers/formtastic.rb' do
+      subject { file('config/initializers/formtastic.rb') }
+      it { should exist }
+      it { should contain "# Please note: If you're subclassing Formtastic::FormBuilder" }
+    end
+
+    describe 'lib/templates/erb/scaffold/_form.html.erb' do
+      subject { file('lib/templates/erb/scaffold/_form.html.erb') }
+      it { should exist }
+      it { should contain "<%%= semantic_form_for @<%= singular_name %> do |f| %>" }
+    end
+  end
+
+  describe 'haml' do
+    before { run_generator %w(--template-engine haml) }
+
+    describe 'lib/templates/erb/scaffold/_form.html.haml' do
+      subject { file('lib/templates/haml/scaffold/_form.html.haml') }
+      it { should exist }
+      it { should contain "= semantic_form_for @<%= singular_name %> do |f|" }
+    end
+  end
+
+  describe 'slim' do
+    before { run_generator %w(--template-engine slim) }
+
+    describe 'lib/templates/erb/scaffold/_form.html.slim' do
+      subject { file('lib/templates/slim/scaffold/_form.html.slim') }
+      it { should exist }
+      it { should contain "= semantic_form_for @<%= singular_name %> do |f|" }
+    end
+  end
+end

data/spec/helpers/action_helper_spec.rb

@@ -0,0 +1,365 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'Formtastic::FormBuilder#action' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
+  after do
+    ::I18n.backend.reload!
+  end
+
+  describe 'arguments and options' do
+
+    it 'should require the first argument (the action method)' do
+      lambda {
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.action()) # no args passed in at all
+        end)
+      }.should raise_error(ArgumentError)
+    end
+
+    describe ':as option' do
+    
+      describe 'when not provided' do
+    
+        it 'should default to a commit for commit' do
+          concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
+            concat(builder.action(:submit))
+          end)
+          output_buffer.should have_tag('form li.action.input_action', :count => 1)
+        end
+    
+        it 'should default to a button for reset' do
+          concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
+            concat(builder.action(:reset))
+          end)
+          output_buffer.should have_tag('form li.action.input_action', :count => 1)
+        end
+
+        it 'should default to a link for cancel' do
+          concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
+            concat(builder.action(:cancel))
+          end)
+          output_buffer.should have_tag('form li.action.link_action', :count => 1)
+        end
+      end
+    
+      it 'should call the corresponding action class with .to_html' do
+        [:input, :button, :link].each do |action_style|
+          semantic_form_for(:project, :url => "http://test.host") do |builder|
+            action_instance = mock('Action instance')
+            action_class = "#{action_style.to_s}_action".classify
+            action_constant = "Formtastic::Actions::#{action_class}".constantize
+    
+            action_constant.should_receive(:new).and_return(action_instance)
+            action_instance.should_receive(:to_html).and_return("some HTML")
+    
+            concat(builder.action(:submit, :as => action_style))
+          end
+        end
+      end
+    
+    end
+    
+    #describe ':label option' do
+    #
+    #  describe 'when provided' do
+    #    it 'should be passed down to the label tag' do
+    #      concat(semantic_form_for(@new_post) do |builder|
+    #        concat(builder.input(:title, :label => "Kustom"))
+    #      end)
+    #      output_buffer.should have_tag("form li label", /Kustom/)
+    #    end
+    #
+    #    it 'should not generate a label if false' do
+    #      concat(semantic_form_for(@new_post) do |builder|
+    #        concat(builder.input(:title, :label => false))
+    #      end)
+    #      output_buffer.should_not have_tag("form li label")
+    #    end
+    #
+    #    it 'should be dupped if frozen' do
+    #      concat(semantic_form_for(@new_post) do |builder|
+    #        concat(builder.input(:title, :label => "Kustom".freeze))
+    #      end)
+    #      output_buffer.should have_tag("form li label", /Kustom/)
+    #    end
+    #  end
+    #
+    #  describe 'when not provided' do
+    #    describe 'when localized label is provided' do
+    #      describe 'and object is given' do
+    #        describe 'and label_str_method not :humanize' do
+    #          it 'should render a label with localized text and not apply the label_str_method' do
+    #            with_config :label_str_method, :reverse do
+    #              @localized_label_text = 'Localized title'
+    #              @new_post.stub!(:meta_description)
+    #              ::I18n.backend.store_translations :en,
+    #                :formtastic => {
+    #                  :labels => {
+    #                    :meta_description => @localized_label_text
+    #                  }
+    #                }
+    #
+    #              concat(semantic_form_for(@new_post) do |builder|
+    #                concat(builder.input(:meta_description))
+    #              end)
+    #              output_buffer.should have_tag('form li label', /Localized title/)
+    #            end
+    #          end
+    #        end
+    #      end
+    #    end
+    #
+    #    describe 'when localized label is NOT provided' do
+    #      describe 'and object is not given' do
+    #        it 'should default the humanized method name, passing it down to the label tag' do
+    #          ::I18n.backend.store_translations :en, :formtastic => {}
+    #          with_config :label_str_method, :humanize do
+    #            concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
+    #              concat(builder.input(:meta_description))
+    #            end)
+    #            output_buffer.should have_tag("form li label", /#{'meta_description'.humanize}/)
+    #          end
+    #        end
+    #      end
+    #
+    #      describe 'and object is given' do
+    #        it 'should delegate the label logic to class human attribute name and pass it down to the label tag' do
+    #          @new_post.stub!(:meta_description) # a two word method name
+    #          @new_post.class.should_receive(:human_attribute_name).with('meta_description').and_return('meta_description'.humanize)
+    #
+    #          concat(semantic_form_for(@new_post) do |builder|
+    #            concat(builder.input(:meta_description))
+    #          end)
+    #          output_buffer.should have_tag("form li label", /#{'meta_description'.humanize}/)
+    #        end
+    #      end
+    #
+    #      describe 'and object is given with label_str_method set to :capitalize' do
+    #        it 'should capitalize method name, passing it down to the label tag' do
+    #          with_config :label_str_method, :capitalize do
+    #            @new_post.stub!(:meta_description)
+    #
+    #            concat(semantic_form_for(@new_post) do |builder|
+    #              concat(builder.input(:meta_description))
+    #            end)
+    #            output_buffer.should have_tag("form li label", /#{'meta_description'.capitalize}/)
+    #          end
+    #        end
+    #      end
+    #    end
+    #
+    #    describe 'when localized label is provided' do
+    #      before do
+    #        @localized_label_text = 'Localized title'
+    #        @default_localized_label_text = 'Default localized title'
+    #        ::I18n.backend.store_translations :en,
+    #          :formtastic => {
+    #              :labels => {
+    #                :title => @default_localized_label_text,
+    #                :published => @default_localized_label_text,
+    #                :post => {
+    #                  :title => @localized_label_text,
+    #                  :published => @default_localized_label_text
+    #                 }
+    #               }
+    #            }
+    #      end
+    #
+    #      it 'should render a label with localized label (I18n)' do
+    #        with_config :i18n_lookups_by_default, false do
+    #          concat(semantic_form_for(@new_post) do |builder|
+    #            concat(builder.input(:title, :label => true))
+    #            concat(builder.input(:published, :as => :boolean, :label => true))
+    #          end)
+    #          output_buffer.should have_tag('form li label', Regexp.new('^' + @localized_label_text))
+    #        end
+    #      end
+    #
+    #      it 'should render a hint paragraph containing an optional localized label (I18n) if first is not set' do
+    #        with_config :i18n_lookups_by_default, false do
+    #          ::I18n.backend.store_translations :en,
+    #            :formtastic => {
+    #                :labels => {
+    #                  :post => {
+    #                    :title => nil,
+    #                    :published => nil
+    #                   }
+    #                 }
+    #              }
+    #          concat(semantic_form_for(@new_post) do |builder|
+    #            concat(builder.input(:title, :label => true))
+    #            concat(builder.input(:published, :as => :boolean, :label => true))
+    #          end)
+    #          output_buffer.should have_tag('form li label', Regexp.new('^' + @default_localized_label_text))
+    #        end
+    #      end
+    #    end
+    #  end
+    #
+    #end
+    #
+    describe ':wrapper_html option' do
+    
+      describe 'when provided' do
+        it 'should be passed down to the li tag' do
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:submit, :wrapper_html => {:id => :another_id}))
+          end)
+          output_buffer.should have_tag("form li#another_id")
+        end
+    
+        it 'should append given classes to li default classes' do
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:submit, :wrapper_html => {:class => :another_class}))
+          end)
+          output_buffer.should have_tag("form li.action")
+          output_buffer.should have_tag("form li.input_action")
+          output_buffer.should have_tag("form li.another_class")
+        end
+    
+        it 'should allow classes to be an array' do
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:submit, :wrapper_html => {:class => [ :my_class, :another_class ]}))
+          end)
+          output_buffer.should have_tag("form li.action")
+          output_buffer.should have_tag("form li.input_action")
+          output_buffer.should have_tag("form li.my_class")
+          output_buffer.should have_tag("form li.another_class")
+        end
+      end
+    
+      describe 'when not provided' do
+        it 'should use default id and class' do
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:submit))
+          end)
+          output_buffer.should have_tag("form li#post_submit_action")
+          output_buffer.should have_tag("form li.action")
+          output_buffer.should have_tag("form li.input_action")
+        end
+      end
+    
+    end
+    
+  end
+
+  describe 'instantiating an action class' do
+  
+    context 'when a class does not exist' do
+      it "should raise an error" do
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            builder.action(:submit, :as => :non_existant)
+          end)
+        }.should raise_error(Formtastic::UnknownActionError)
+      end
+    end
+  
+    context 'when a customized top-level class does not exist' do
+  
+      it 'should instantiate the Formtastic action' do
+        action = mock('action', :to_html => 'some HTML')
+        Formtastic::Actions::ButtonAction.should_receive(:new).and_return(action)
+        concat(semantic_form_for(@new_post) do |builder|
+          builder.action(:commit, :as => :button)
+        end)
+      end
+  
+    end
+  
+    describe 'when a top-level (custom) action class exists' do
+      it "should instantiate the top-level action instead of the Formtastic one" do
+        class ::ButtonAction < Formtastic::Actions::ButtonAction
+        end
+  
+        action = mock('action', :to_html => 'some HTML')
+        Formtastic::Actions::ButtonAction.should_not_receive(:new).and_return(action)
+        ::ButtonAction.should_receive(:new).and_return(action)
+  
+        concat(semantic_form_for(@new_post) do |builder|
+          builder.action(:commit, :as => :button)
+        end)
+      end
+    end
+  
+    describe 'when instantiated multiple times with the same action type' do
+  
+      it "should be cached (not calling the internal methods)" do
+        # TODO this is really tied to the underlying implementation
+        concat(semantic_form_for(@new_post) do |builder|
+          builder.should_receive(:custom_action_class_name).with(:button).once.and_return(::Formtastic::Actions::ButtonAction)
+          builder.action(:submit, :as => :button)
+          builder.action(:submit, :as => :button)
+        end)
+      end
+  
+    end
+    
+    describe 'support for :as on each action' do
+      
+      it "should raise an error when the action does not support the :as" do
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:submit, :as => :link))
+          end)
+        }.should raise_error(Formtastic::UnsupportedMethodForAction)
+        
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:cancel, :as => :input))
+          end)
+        }.should raise_error(Formtastic::UnsupportedMethodForAction)
+        
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:cancel, :as => :button))
+          end)
+        }.should raise_error(Formtastic::UnsupportedMethodForAction)
+      end
+      
+      it "should not raise an error when the action does not support the :as" do
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:cancel, :as => :link))
+          end)
+        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
+        
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:submit, :as => :input))
+          end)
+        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
+
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:submit, :as => :button))
+          end)
+        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
+        
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:reset, :as => :input))
+          end)
+        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
+        
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            concat(builder.action(:reset, :as => :button))
+          end)
+        }.should_not raise_error(Formtastic::UnsupportedMethodForAction)
+      end
+      
+    end
+    
+  end
+
+end
+