formtastic 2.0.0.rc3 → 2.0.0.rc4

data/spec/helpers/reflection_helper_spec.rb

@@ -0,0 +1,32 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'Formtastic::Helpers::Reflection' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
+  class ReflectionTester
+    include Formtastic::Helpers::Reflection
+    def initialize(model_object)
+      @object = model_object
+    end
+  end
+
+  context 'with an ActiveRecord object' do
+    it "should return association details on an ActiveRecord association" do
+      @reflection_tester = ReflectionTester.new(@new_post)
+      @reflection_tester.reflection_for(:sub_posts).should_not be_nil
+    end
+    it "should return association details on a MongoMapper association" do
+      @reflection_tester = ReflectionTester.new(@new_mm_post)
+      @reflection_tester.reflection_for(:sub_posts).should_not be_nil
+    end
+  end
+  
+  
+end

data/spec/inputs/check_boxes_input_spec.rb

@@ -61,6 +61,10 @@ describe 'check_boxes input' do
         output_buffer.should_not have_tag('li.choice label.label')
       end
       
+      it 'should not be marked as required' do
+        output_buffer.should_not have_tag('li.choice input[@required]')
+      end
+      
       it 'should contain a label for the radio input with a nested input and label text' do
         ::Post.all.each do |post|
           output_buffer.should have_tag('form li fieldset ol li label', /#{post.to_label}/)
@@ -74,12 +78,6 @@ describe 'check_boxes input' do
         end
       end
       
-      it "should add the required attribute to the input's html options" do
-        ::Post.all.each do |post|
-          output_buffer.should have_tag("form li fieldset ol li.post_#{post.id} input[@required]")
-        end
-      end
-
       it 'should have a checkbox input but no hidden field for each post' do
         ::Post.all.each do |post|
           output_buffer.should have_tag("form li fieldset ol li label input#author_post_ids_#{post.id}")
@@ -358,6 +356,23 @@ describe 'check_boxes input' do
       end
     end
   end
+  
+  describe 'when :collection is provided as an array of arrays' do
+    before do
+      @output_buffer = ''
+      mock_everything
+      @fred.stub(:genres) { ['fiction', 'biography'] }
+      
+      concat(semantic_form_for(@fred) do |builder|
+        concat(builder.input(:genres, :as => :check_boxes, :collection => [['Fiction', 'fiction'], ['Non-fiction', 'non_fiction'], ['Biography', 'biography']]))
+      end)
+    end
+    
+    it 'should check the correct checkboxes' do
+      output_buffer.should have_tag("form li fieldset ol li label input[@value='fiction'][@checked='checked']")
+      output_buffer.should have_tag("form li fieldset ol li label input[@value='biography'][@checked='checked']")
+    end
+  end
 
   describe "when namespace is provided" do
 

data/spec/inputs/date_input_spec.rb

@@ -95,6 +95,26 @@ describe 'date input' do
           output_buffer.should have_tag('form li.date fieldset ol li label', /#{f}/i) unless field == f
         end
       end
+      
+      it "should not display the label for the #{field} field when :labels[:#{field}] is false" do
+        output_buffer.replace ''
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:created_at, :as => :date, :labels => { field => false }))
+        end)
+        output_buffer.should have_tag('form li.date fieldset ol li label', :count => fields.length-1)
+        fields.each do |f|
+          output_buffer.should have_tag('form li.date fieldset ol li label', /#{f}/i) unless field == f
+        end
+      end
+      
+      it "should not render unsafe HTML when :labels[:#{field}] is false" do 
+        output_buffer.replace ''
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:created_at, :as => :time, :include_seconds => true, :labels => { field => false }))
+        end)
+        output_buffer.should_not include(">")
+      end
+      
     end
   end
   

data/spec/inputs/datetime_input_spec.rb

@@ -89,17 +89,36 @@ describe 'datetime input' do
           output_buffer.should have_tag('form li.datetime fieldset ol li label', f == field ? /another #{f} label/i : /#{f}/i)
         end
       end
-  
-      #it "should not display the label for the #{field} field when :labels[:#{field}] is blank" do
-      #  output_buffer.replace ''
-      #  concat(semantic_form_for(@new_post) do |builder|
-      #    concat(builder.input(:created_at, :as => :datetime, :labels => { field => "" }))
-      #  end)
-      #  output_buffer.should have_tag('form li.datetime fieldset ol li label', :count => fields.length-1)
-      #  fields.each do |f|
-      #    output_buffer.should have_tag('form li.datetime fieldset ol li label', /#{f}/i) unless field == f
-      #  end
-      #end
+      
+      it "should not display the label for the #{field} field when :labels[:#{field}] is blank" do
+        output_buffer.replace ''
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:created_at, :as => :datetime, :labels => { field => "" }))
+        end)
+        output_buffer.should have_tag('form li.datetime fieldset ol li label', :count => fields.length-1)
+        fields.each do |f|
+          output_buffer.should have_tag('form li.datetime fieldset ol li label', /#{f}/i) unless field == f
+        end
+      end
+      
+      it "should not display the label for the #{field} field when :labels[:#{field}] is false" do
+        output_buffer.replace ''
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:created_at, :as => :datetime, :labels => { field => false }))
+        end)
+        output_buffer.should have_tag('form li.datetime fieldset ol li label', :count => fields.length-1)
+        fields.each do |f|
+          output_buffer.should have_tag('form li.datetime fieldset ol li label', /#{f}/i) unless field == f
+        end
+      end
+      
+      it "should not render unsafe HTML when :labels[:#{field}] is false" do 
+        output_buffer.replace ''
+        concat(semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:created_at, :as => :time, :include_seconds => true, :labels => { field => false }))
+        end)
+        output_buffer.should_not include(">")
+      end
     end
   end
   

data/spec/inputs/label_spec.rb

@@ -73,6 +73,14 @@ describe 'Formtastic::FormBuilder#label' do
       output_buffer.should_not have_tag('label')
       output_buffer.should_not include(">")
     end
+    
+    it 'should return nil if label is false for timeish fragments' do
+      concat(semantic_form_for(@new_post) do |builder|
+        builder.input(:title, :as => :time, :label => false)
+      end)
+      output_buffer.should_not have_tag('li.time > label')
+      output_buffer.should_not include(">")
+    end
 
     it 'should html escape the label string by default' do
       concat(semantic_form_for(@new_post) do |builder|

data/spec/inputs/number_input_spec.rb

@@ -153,6 +153,84 @@ describe 'number input' do
     
   end
   
+  describe "when validations require a minimum value (:greater_than) that takes a proc" do
+    before do
+      @new_post.class.stub!(:validators_on).with(:title).and_return([
+        active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :greater_than=> Proc.new {|post| 2}})
+      ])
+    end
+    
+    it "should allow :input_html to override :min" do
+      concat(semantic_form_for(@new_post) do |builder|
+        builder.input(:title, :as => :number, :input_html => { :min => 5 })
+      end)
+      output_buffer.should have_tag('input[@min="5"]')
+    end
+    
+    it "should allow :input_html to override :min through :in" do
+      concat(semantic_form_for(@new_post) do |builder|
+        builder.input(:title, :as => :number, :input_html => { :in => 5..102 })
+      end)
+      output_buffer.should have_tag('input[@min="5"]')
+    end
+    
+    it "should allow options to override :min" do
+      concat(semantic_form_for(@new_post) do |builder|
+        builder.input(:title, :as => :number, :min => 5)
+      end)
+      output_buffer.should have_tag('input[@min="5"]')
+    end
+    
+    it "should allow options to override :min through :in" do
+      concat(semantic_form_for(@new_post) do |builder|
+        builder.input(:title, :as => :number, :in => 5..102)
+      end)
+      output_buffer.should have_tag('input[@min="5"]')
+    end
+    
+    describe "and the column is an integer" do
+      before do
+        @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :integer))
+      end
+      
+      it "should add a min attribute to the input one greater than the validation" do
+        concat(semantic_form_for(@new_post) do |builder|
+          builder.input(:title, :as => :number)
+        end)
+        output_buffer.should have_tag('input[@min="3"]')
+      end
+    end
+    
+    describe "and the column is a float" do
+      before do
+        @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :float))
+      end
+      
+      it "should raise an error" do
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            builder.input(:title, :as => :number)
+          end)
+        }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMinimumAttributeError)
+      end
+    end
+    
+    describe "and the column is a big decimal" do
+      before do
+        @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :decimal))
+      end
+      
+      it "should raise an error" do
+        lambda {
+          concat(semantic_form_for(@new_post) do |builder|
+            builder.input(:title, :as => :number)
+          end)
+        }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMinimumAttributeError)
+      end
+    end
+    
+  end
+  
   describe "when validations require a minimum value (:greater_than_or_equal_to)" do
     before do
       @new_post.class.stub!(:validators_on).with(:title).and_return([
@@ -217,8 +295,74 @@ describe 'number input' do
       end
     end
   end
+  
+  describe "when validations require a minimum value (:greater_than_or_equal_to) that takes a Proc" do
+     before do
+       @new_post.class.stub!(:validators_on).with(:title).and_return([
+         active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :greater_than_or_equal_to=> Proc.new { |post| 2}})
+       ])
+     end
+
+     it "should allow :input_html to override :min" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :input_html => { :min => 5 })
+       end)
+       output_buffer.should have_tag('input[@min="5"]')
+     end
+
+     it "should allow options to override :min" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :min => 5)
+       end)
+       output_buffer.should have_tag('input[@min="5"]')
+     end
+
+     it "should allow :input_html to override :min with :in" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :input_html => { :in => 5..102 })
+       end)
+       output_buffer.should have_tag('input[@min="5"]')
+     end
+
+     it "should allow options to override :min  with :in" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :in => 5..102)
+       end)
+       output_buffer.should have_tag('input[@min="5"]')
+     end
+
+
+     [:integer, :decimal, :float].each do |column_type|
+       describe "and the column is a #{column_type}" do
+         before do
+           @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => column_type))
+         end
+
+         it "should add a max attribute to the input equal to the validation" do
+           concat(semantic_form_for(@new_post) do |builder|
+             builder.input(:title, :as => :number)
+           end)
+           output_buffer.should have_tag('input[@min="2"]')
+         end
+       end
+     end
+
+     describe "and there is no column" do
+       before do
+         @new_post.stub!(:column_for_attribute).with(:title).and_return(nil)
+       end
+
+       it "should add a max attribute to the input equal to the validation" do
+         concat(semantic_form_for(@new_post) do |builder|
+           builder.input(:title, :as => :number)
+         end)
+         output_buffer.should have_tag('input[@min="2"]')
+       end
+     end
+   end
 
   describe "when validations require a maximum value (:less_than)" do
+    
    before do
      @new_post.class.stub!(:validators_on).with(:title).and_return([
        active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :less_than=>20})
@@ -293,9 +437,97 @@ describe 'number input' do
        }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMaximumAttributeError)
      end
    end
+   describe "and the validator takes a proc" do
+     before do
+       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :decimal))
+     end
+   end
+  end
+  
+  describe "when validations require a maximum value (:less_than) that takes a Proc" do
+    
+   before do
+     @new_post.class.stub!(:validators_on).with(:title).and_return([
+       active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :less_than=> Proc.new {|post| 20 }})
+     ])
+   end
+   
+   it "should allow :input_html to override :max" do
+     concat(semantic_form_for(@new_post) do |builder|
+       builder.input(:title, :as => :number, :input_html => { :max => 102 })
+     end)
+     output_buffer.should have_tag('input[@max="102"]')
+   end
+   
+   it "should allow option to override :max" do
+     concat(semantic_form_for(@new_post) do |builder|
+       builder.input(:title, :as => :number, :max => 102)
+     end)
+     output_buffer.should have_tag('input[@max="102"]')
+   end
+   
+   it "should allow :input_html to override :max with :in" do
+      concat(semantic_form_for(@new_post) do |builder|
+        builder.input(:title, :as => :number, :input_html => { :in => 1..102 })
+      end)
+      output_buffer.should have_tag('input[@max="102"]')
+    end
+
+    it "should allow option to override :max with :in" do
+      concat(semantic_form_for(@new_post) do |builder|
+        builder.input(:title, :as => :number, :in => 1..102)
+      end)
+      output_buffer.should have_tag('input[@max="102"]')
+    end
+   
+   describe "and the column is an integer" do
+     before do
+       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :integer))
+     end
+     
+     it "should add a max attribute to the input one greater than the validation" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number)
+       end)
+       output_buffer.should have_tag('input[@max="19"]')
+     end
+   end
+   
+   describe "and the column is a float" do
+     before do
+       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :float))
+     end
+     
+     it "should raise an error" do
+       lambda {
+         concat(semantic_form_for(@new_post) do |builder|
+           builder.input(:title, :as => :number)
+         end)
+       }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMaximumAttributeError)
+     end
+   end
    
+   describe "and the column is a big decimal" do
+     before do
+       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :decimal))
+     end
+     
+     it "should raise an error" do
+       lambda {
+         concat(semantic_form_for(@new_post) do |builder|
+           builder.input(:title, :as => :number)
+         end)
+       }.should raise_error(Formtastic::Inputs::Base::Validations::IndeterminableMaximumAttributeError)
+     end
+   end
+   describe "and the validator takes a proc" do
+     before do
+       @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :decimal))
+     end
+   end
   end
   
+  
   describe "when validations require a maximum value (:less_than_or_equal_to)" do
     before do
       @new_post.class.stub!(:validators_on).with(:title).and_return([
@@ -359,6 +591,70 @@ describe 'number input' do
       end
     end
   end
+ 
+  describe "when validations require a maximum value (:less_than_or_equal_to) that takes a proc" do
+     before do
+       @new_post.class.stub!(:validators_on).with(:title).and_return([
+         active_model_numericality_validator([:title], {:only_integer=>false, :allow_nil=>false, :less_than_or_equal_to=> Proc.new { |post| 20 }})
+       ])
+     end
+
+     it "should allow :input_html to override :max" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :input_html => { :max => 102 })
+       end)
+       output_buffer.should have_tag('input[@max="102"]')
+     end
+
+     it "should allow options to override :max" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :max => 102)
+       end)
+       output_buffer.should have_tag('input[@max="102"]')
+     end
+
+     it "should allow :input_html to override :max with :in" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :input_html => { :in => 1..102 })
+       end)
+       output_buffer.should have_tag('input[@max="102"]')
+     end
+
+     it "should allow options to override :max with :in" do
+       concat(semantic_form_for(@new_post) do |builder|
+         builder.input(:title, :as => :number, :in => 1..102)
+       end)
+       output_buffer.should have_tag('input[@max="102"]')
+     end
+
+     [:integer, :decimal, :float].each do |column_type|
+       describe "and the column is a #{column_type}" do
+         before do
+           @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => column_type))
+         end
+
+         it "should add a max attribute to the input equal to the validation" do
+           concat(semantic_form_for(@new_post) do |builder|
+             builder.input(:title, :as => :number)
+           end)
+           output_buffer.should have_tag('input[@max="20"]')
+         end
+       end
+     end
+
+     describe "and there is no column" do
+       before do
+         @new_post.stub!(:column_for_attribute).with(:title).and_return(nil)
+       end
+
+       it "should add a max attribute to the input equal to the validation" do
+         concat(semantic_form_for(@new_post) do |builder|
+           builder.input(:title, :as => :number)
+         end)
+         output_buffer.should have_tag('input[@max="20"]')
+       end
+     end
+   end
   
   describe "when validations require conflicting minimum values (:greater_than, :greater_than_or_equal_to)" do
     before do
@@ -460,11 +756,11 @@ describe 'number input' do
       ])
     end
     
-    it "should default step to 1" do
+    it "should default step to 'any'" do
       concat(semantic_form_for(@new_post) do |builder|
         builder.input(:title, :as => :number)
       end)
-      output_buffer.should have_tag('input[@step="1"]')
+      output_buffer.should have_tag('input[@step="any"]')
     end
     
     it "should let input_html set :step" do