formtastic 1.2.4 → 3.1.5

data/spec/actions/input_action_spec.rb

@@ -0,0 +1,59 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'InputAction', 'when submitting' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+    
+    concat(semantic_form_for(@new_post) do |builder|
+      concat(builder.action(:submit, :as => :input))
+    end)
+  end
+  
+  it 'should render a submit type of input' do
+    output_buffer.should have_tag('li.action.input_action input[@type="submit"]')
+  end
+
+end
+
+describe 'InputAction', 'when resetting' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+    
+    concat(semantic_form_for(@new_post) do |builder|
+      concat(builder.action(:reset, :as => :input))
+    end)
+  end
+  
+  it 'should render a reset type of input' do
+    output_buffer.should have_tag('li.action.input_action input[@type="reset"]')
+  end
+  
+end
+
+describe 'InputAction', 'when cancelling' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  it 'should raise an error' do
+    lambda { 
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :input))
+      end)
+    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+  end
+  
+end

data/spec/actions/link_action_spec.rb

@@ -0,0 +1,92 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'LinkAction', 'when cancelling' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  context 'without a :url' do
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :link))
+      end)
+    end
+    
+    it 'should render a submit type of input' do
+      output_buffer.should have_tag('li.action.link_action a[@href="javascript:history.back()"]')
+    end
+    
+  end
+  
+  context 'with a :url as String' do
+    
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :link, :url => "http://foo.bah/baz"))
+      end)
+    end
+    
+    it 'should render a submit type of input' do
+      output_buffer.should have_tag('li.action.link_action a[@href="http://foo.bah/baz"]')
+    end
+    
+  end
+
+  context 'with a :url as Hash' do
+    
+    before do
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:cancel, :as => :link, :url => { :action => "foo" }))
+      end)
+    end
+    
+    it 'should render a submit type of input' do
+      output_buffer.should have_tag('li.action.link_action a[@href="/mock/path"]')
+    end
+    
+  end
+
+end
+
+describe 'LinkAction', 'when submitting' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  it 'should raise an error' do
+    lambda { 
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:submit, :as => :link))
+      end)
+    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+  end
+  
+end
+
+describe 'LinkAction', 'when submitting' do
+
+  include FormtasticSpecHelper
+  
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+  
+  it 'should raise an error' do
+    lambda { 
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.action(:reset, :as => :link))
+      end)
+    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+  end
+  
+end

data/spec/builder/custom_builder_spec.rb

@@ -0,0 +1,116 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'Formtastic::Helpers::FormHelper.builder' do
+
+  include FormtasticSpecHelper
+
+  class MyCustomFormBuilder < Formtastic::FormBuilder
+  end
+  
+  # TODO should be a separate spec for custom inputs
+  class Formtastic::Inputs::AwesomeInput
+    include Formtastic::Inputs::Base
+    def to_html
+      "Awesome!"
+    end
+  end
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
+  it 'is the Formtastic::FormBuilder by default' do
+    Formtastic::Helpers::FormHelper.builder.should == Formtastic::FormBuilder
+  end
+
+  it 'can be configured to use your own custom form builder' do
+    # Set it to a custom builder class
+    Formtastic::Helpers::FormHelper.builder = MyCustomFormBuilder
+    Formtastic::Helpers::FormHelper.builder.should == MyCustomFormBuilder
+
+    # Reset it to the default
+    Formtastic::Helpers::FormHelper.builder = Formtastic::FormBuilder
+    Formtastic::Helpers::FormHelper.builder.should == Formtastic::FormBuilder
+  end
+
+  it 'should allow custom settings per form builder subclass' do
+    with_config(:all_fields_required_by_default, true) do
+      MyCustomFormBuilder.all_fields_required_by_default = false
+
+      MyCustomFormBuilder.all_fields_required_by_default.should be_falsey
+      Formtastic::FormBuilder.all_fields_required_by_default.should be_truthy
+    end
+  end
+
+  describe "when using a custom builder" do
+
+    before do
+      @new_post.stub(:title)
+      Formtastic::Helpers::FormHelper.builder = MyCustomFormBuilder
+    end
+
+    after do
+      Formtastic::Helpers::FormHelper.builder = Formtastic::FormBuilder
+    end
+
+    describe "semantic_form_for" do
+
+      it "should yield an instance of the custom builder" do
+        semantic_form_for(@new_post) do |builder|
+          builder.class.should.kind_of?(MyCustomFormBuilder)
+        end
+      end
+      
+      # TODO should be a separate spec for custom inputs
+      it "should allow me to call my custom input" do
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:title, :as => :awesome))
+        end
+      end
+
+      # See: https://github.com/justinfrench/formtastic/issues/657
+      it "should not conflict with navigasmic" do
+        self.class.any_instance.stub(:builder).and_return('navigasmic')
+        
+        lambda { semantic_form_for(@new_post) { |f| } }.should_not raise_error
+      end
+
+    end
+
+    describe "fields_for" do
+
+      it "should yield an instance of the parent form builder" do
+        @new_post.stub(:comment).and_return([@fred])
+        @new_post.stub(:comment_attributes=)
+        semantic_form_for(@new_post, :builder => MyCustomFormBuilder) do |builder|
+          builder.class.should.kind_of?(MyCustomFormBuilder)
+          
+          builder.fields_for(:comment) do |nested_builder|
+            nested_builder.class.should.kind_of?(MyCustomFormBuilder)
+          end
+        end
+      end
+
+    end
+
+  end
+
+  describe "when using a builder passed to form options" do
+
+    describe "fields_for" do
+
+      it "should yield an instance of the parent form builder" do
+        @new_post.stub(:author_attributes=)
+        semantic_form_for(@new_post, :builder => MyCustomFormBuilder) do |builder|
+          builder.fields_for(:author) do |nested_builder|
+            nested_builder.class.should.kind_of?(MyCustomFormBuilder)
+          end
+        end
+      end
+
+    end
+
+  end
+end

data/spec/builder/error_proc_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'Rails field_error_proc' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+  end
+
+  it "should not be overridden globally for all form builders" do
+    current_field_error_proc = ::ActionView::Base.field_error_proc
+
+    semantic_form_for(@new_post) do |builder|
+      ::ActionView::Base.field_error_proc.should_not == current_field_error_proc
+    end
+
+    ::ActionView::Base.field_error_proc.should == current_field_error_proc
+
+    form_for(@new_post) do |builder|
+      ::ActionView::Base.field_error_proc.should == current_field_error_proc
+    end
+  end
+
+end

data/spec/builder/semantic_fields_for_spec.rb

@@ -0,0 +1,142 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe 'Formtastic::FormBuilder#fields_for' do
+
+  include FormtasticSpecHelper
+
+  before do
+    @output_buffer = ''
+    mock_everything
+    @new_post.stub(:author).and_return(::Author.new)
+  end
+
+  context 'outside a form_for block' do
+    it 'yields an instance of FormHelper.builder' do
+      semantic_fields_for(@new_post) do |nested_builder|
+        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+      end
+      semantic_fields_for(@new_post.author) do |nested_builder|
+        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+      end
+      semantic_fields_for(:author, @new_post.author) do |nested_builder|
+        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+      end
+      semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
+        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+      end
+    end
+    
+    it 'should respond to input' do
+      semantic_fields_for(@new_post) do |nested_builder|
+        nested_builder.respond_to?(:input).should be_truthy
+      end
+      semantic_fields_for(@new_post.author) do |nested_builder|
+        nested_builder.respond_to?(:input).should be_truthy
+      end
+      semantic_fields_for(:author, @new_post.author) do |nested_builder|
+        nested_builder.respond_to?(:input).should be_truthy
+      end
+      semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
+        nested_builder.respond_to?(:input).should be_truthy
+      end
+    end
+  end
+  
+  context 'within a form_for block' do
+    it 'yields an instance of FormHelper.builder' do
+      semantic_form_for(@new_post) do |builder|
+        builder.semantic_fields_for(:author) do |nested_builder|
+          nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        end
+      end
+    end
+    
+    it 'yields an instance of FormHelper.builder with hash-like model' do
+      semantic_form_for(:user) do |builder|
+        builder.semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
+          nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        end
+      end
+    end
+    
+    it 'nests the object name' do
+      semantic_form_for(@new_post) do |builder|
+        builder.semantic_fields_for(@bob) do |nested_builder|
+          nested_builder.object_name.should == 'post[author]'
+        end
+      end
+    end
+    
+    it 'supports passing collection as second parameter' do
+      semantic_form_for(@new_post) do |builder|
+        builder.semantic_fields_for(:author, [@fred,@bob]) do |nested_builder|
+          nested_builder.object_name.should =~ /post\[author_attributes\]\[\d+\]/
+        end
+      end
+    end
+    
+    it 'should sanitize html id for li tag' do
+      @bob.stub(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
+      concat(semantic_form_for(@new_post) do |builder|
+        concat(builder.semantic_fields_for(@bob, :index => 1) do |nested_builder|
+          concat(nested_builder.inputs(:login))
+        end)
+      end)
+      output_buffer.should have_tag('form fieldset.inputs #post_author_1_login_input')
+      # Not valid selector, so using good ol' regex
+      output_buffer.should_not =~ /id="post\[author\]_1_login_input"/
+      # <=> output_buffer.should_not have_tag('form fieldset.inputs #post[author]_1_login_input')
+    end
+    
+    it 'should use namespace provided in nested fields' do
+      @bob.stub(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
+      concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
+        concat(builder.semantic_fields_for(@bob, :index => 1) do |nested_builder|
+          concat(nested_builder.inputs(:login))
+        end)
+      end)
+      output_buffer.should have_tag('form fieldset.inputs #context2_post_author_1_login_input')
+    end
+    
+    it 'should render errors on the nested inputs' do
+      @errors = double('errors')
+      @errors.stub(:[]).with(errors_matcher(:login)).and_return(['oh noes'])      
+      @bob.stub(:errors).and_return(@errors)
+      
+      concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
+        concat(builder.semantic_fields_for(@bob) do |nested_builder|
+          concat(nested_builder.inputs(:login))
+        end)
+      end)
+      output_buffer.should =~ /oh noes/
+    end
+    
+  end
+  
+  context "when I rendered my own hidden id input" do 
+    
+    before do
+      output_buffer.replace ''
+      
+      @fred.posts.size.should == 1
+      @fred.posts.first.stub(:persisted?).and_return(true)
+      @fred.stub(:posts_attributes=)
+      concat(semantic_form_for(@fred) do |builder|
+        concat(builder.semantic_fields_for(:posts) do |nested_builder|
+          concat(nested_builder.input(:id, :as => :hidden))
+          concat(nested_builder.input(:title))
+        end)
+      end)
+    end
+  
+    it "should only render one hidden input (my one)" do
+      output_buffer.should have_tag 'input#author_posts_attributes_0_id', :count => 1
+    end
+    
+    it "should render the hidden input inside an li.hidden" do
+      output_buffer.should have_tag 'li.hidden input#author_posts_attributes_0_id'
+    end
+  end
+
+end

data/spec/fast_spec_helper.rb

@@ -0,0 +1,12 @@
+# encoding: utf-8
+$LOAD_PATH << 'lib/formtastic'
+require 'active_support/all'
+require 'localized_string'
+require 'inputs'
+require 'helpers'
+
+class MyInput
+  include Formtastic::Inputs::Base
+end
+
+I18n.enforce_available_locales = false if I18n.respond_to?(:enforce_available_locales)