formtastic 1.0.1 → 1.1.0.beta

data/spec/inputs/boolean_input_spec.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe 'boolean input' do
   
@@ -9,16 +9,17 @@ describe 'boolean input' do
     @output_buffer = ''
     mock_everything
     
-    semantic_form_for(@new_post) do |builder|
+    @form = semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean))
     end
   end
-    
+   
   it_should_have_input_wrapper_with_class("boolean")
   it_should_have_input_wrapper_with_id("post_allow_comments_input")
   it_should_apply_error_logic_for_input_type(:boolean)
 
   it 'should generate a label containing the input' do
+    output_buffer.concat(@form) if Formtastic::Util.rails3?
     output_buffer.should have_tag('form li label', :count => 1)
     output_buffer.should have_tag('form li label[@for="post_allow_comments"]')
     output_buffer.should have_tag('form li label', /Allow comments/)
@@ -26,6 +27,7 @@ describe 'boolean input' do
   end
 
   it 'should generate a checkbox input' do
+    output_buffer.concat(@form) if Formtastic::Util.rails3?
     output_buffer.should have_tag('form li label input')
     output_buffer.should have_tag('form li label input#post_allow_comments')
     output_buffer.should have_tag('form li label input[@type="checkbox"]')
@@ -34,19 +36,22 @@ describe 'boolean input' do
   end
 
   it 'should allow checked and unchecked values to be sent' do
-    semantic_form_for(@new_post) do |builder|
+    form = semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'checked', :unchecked_value => 'unchecked'))
     end
 
+    output_buffer.concat(form) if Formtastic::Util.rails3?
     output_buffer.should have_tag('form li label input[@type="checkbox"][@value="checked"]:not([@unchecked_value][@checked_value])')
     output_buffer.should have_tag('form li label input[@type="hidden"][@value="unchecked"]')
   end
 
   it 'should generate a label and a checkbox even if no object is given' do
-    semantic_form_for(:project, :url => 'http://test.host') do |builder|
+    form = semantic_form_for(:project, :url => 'http://test.host') do |builder|
       concat(builder.input(:allow_comments, :as => :boolean))
     end
 
+    output_buffer.concat(form) if Formtastic::Util.rails3?
+
     output_buffer.should have_tag('form li label[@for="project_allow_comments"]')
     output_buffer.should have_tag('form li label', /Allow comments/)
     output_buffer.should have_tag('form li label input[@type="checkbox"]')
@@ -66,13 +71,14 @@ describe 'boolean input' do
         @new_post.stub!(:allow_comments).and_return(true)
 
         with_deprecation_silenced do
-          semantic_form_for(@new_post) do |builder|
+          @form = semantic_form_for(@new_post) do |builder|
             concat(builder.input(:allow_comments, :as => :boolean, :selected => false))
           end
         end
       end
 
       it 'should not be selected' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         output_buffer.should_not have_tag("form li label input[@type='checkbox'][@checked='checked']")
       end
     end
@@ -82,13 +88,14 @@ describe 'boolean input' do
         @new_post.stub!(:allow_comments).and_return(false)
         
         with_deprecation_silenced do
-          semantic_form_for(@new_post) do |builder|
+          @form = semantic_form_for(@new_post) do |builder|
             concat(builder.input(:allow_comments, :as => :boolean, :selected => true))
           end
         end
       end
 
       it 'should be selected' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         output_buffer.should have_tag("form li label input[@type='checkbox'][@checked='checked']")
       end
     end

data/spec/inputs/check_boxes_input_spec.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe 'check_boxes input' do
   
@@ -10,7 +10,7 @@ describe 'check_boxes input' do
       @output_buffer = ''
       mock_everything
       
-      semantic_form_for(@fred) do |builder|
+      @form = semantic_form_for(@fred) do |builder|
         concat(builder.input(:posts, :as => :check_boxes, :value_as_class => true))
       end
     end
@@ -23,31 +23,37 @@ describe 'check_boxes input' do
     it_should_use_the_collection_when_provided(:check_boxes, 'input[@type="checkbox"]')
     
     it 'should generate a legend containing a label with text for the input' do
+      output_buffer.concat(@form) if Formtastic::Util.rails3?
       output_buffer.should have_tag('form li fieldset legend.label label')
       output_buffer.should have_tag('form li fieldset legend.label label', /Posts/)
     end
     
     it 'should not link the label within the legend to any input' do
+      output_buffer.concat(@form) if Formtastic::Util.rails3?
       output_buffer.should_not have_tag('form li fieldset legend label[@for^="author_post_ids_"]')
     end
     
 
     it 'should generate an ordered list with a list item for each choice' do
+      output_buffer.concat(@form) if Formtastic::Util.rails3?
       output_buffer.should have_tag('form li fieldset ol')
-      output_buffer.should have_tag('form li fieldset ol li', :count => ::Post.find(:all).size)
+      output_buffer.should have_tag('form li fieldset ol li input[@type=checkbox]', :count => ::Post.find(:all).size)
     end
 
     it 'should have one option with a "checked" attribute' do
+      output_buffer.concat(@form) if Formtastic::Util.rails3?
       output_buffer.should have_tag('form li input[@checked]', :count => 1)
     end
 
-    it 'should generate hidden inputs with default value blank' do
-      output_buffer.should have_tag("form li fieldset ol li label input[@type='hidden'][@value='']", :count => ::Post.find(:all).size)
+    it 'should not generate hidden inputs with default value blank' do
+      output_buffer.concat(@form) if Formtastic::Util.rails3?
+      output_buffer.should_not have_tag("form li fieldset ol li label input[@type='hidden'][@value='']", :count => ::Post.find(:all).size)
     end
 
     describe "each choice" do
 
       it 'should contain a label for the radio input with a nested input and label text' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         ::Post.find(:all).each do |post|
           output_buffer.should have_tag('form li fieldset ol li label', /#{post.to_label}/)
           output_buffer.should have_tag("form li fieldset ol li label[@for='author_post_ids_#{post.id}']")
@@ -55,20 +61,53 @@ describe 'check_boxes input' do
       end
 
       it 'should use values as li.class when value_as_class is true' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         ::Post.find(:all).each do |post|
           output_buffer.should have_tag("form li fieldset ol li.post_#{post.id} label")
         end
       end
 
-      it 'should have a checkbox input for each post' do
+      it 'should have a checkbox input but no hidden field for each post' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
+        ::Post.find(:all).each do |post|
+          output_buffer.should have_tag("form li fieldset ol li label input#author_post_ids_#{post.id}")
+          output_buffer.should have_tag("form li fieldset ol li label input[@name='author[post_ids][]']", :count => 1)
+        end
+      end
+
+      it 'should have a hidden field with an empty array value for the collection to allow clearing of all checkboxes' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
+        output_buffer.should have_tag("form li fieldset > input[@type=hidden][@name='author[post_ids][]'][@value='']", :count => 1)
+      end
+
+      it 'the hidden field with an empty array value should be followed by the ol' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
+        output_buffer.should have_tag("form li fieldset > input[@type=hidden][@name='author[post_ids][]'][@value=''] + ol", :count => 1)
+      end
+
+      it 'should not have a hidden field with an empty string value for the collection' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
+        output_buffer.should_not have_tag("form li fieldset > input[@type=hidden][@name='author[post_ids]'][@value='']", :count => 1)
+      end
+
+      it 'should have a checkbox and a hidden field for each post with :hidden_field => true' do
+        output_buffer.replace ''
+
+        form = semantic_form_for(@fred) do |builder|
+          concat(builder.input(:posts, :as => :check_boxes, :hidden_fields => true, :value_as_class => true))
+        end
+        output_buffer.concat(form) if Formtastic::Util.rails3?
+
         ::Post.find(:all).each do |post|
           output_buffer.should have_tag("form li fieldset ol li label input#author_post_ids_#{post.id}")
           output_buffer.should have_tag("form li fieldset ol li label input[@name='author[post_ids][]']", :count => 2)
         end
+
       end
 
       it "should mark input as checked if it's the the existing choice" do
         ::Post.find(:all).include?(@fred.posts.first).should be_true
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked']")
       end
     end
@@ -76,20 +115,23 @@ describe 'check_boxes input' do
     describe 'and no object is given' do
       before(:each) do
         output_buffer.replace ''
-        semantic_form_for(:project, :url => 'http://test.host') do |builder|
+        @form = semantic_form_for(:project, :url => 'http://test.host') do |builder|
           concat(builder.input(:author_id, :as => :check_boxes, :collection => ::Author.find(:all)))
         end
       end
 
       it 'should generate a fieldset with legend' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         output_buffer.should have_tag('form li fieldset legend', /Author/)
       end
 
       it 'shold generate an li tag for each item in the collection' do
-        output_buffer.should have_tag('form li fieldset ol li', :count => ::Author.find(:all).size)
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
+        output_buffer.should have_tag('form li fieldset ol li input[@type=checkbox]', :count => ::Author.find(:all).size)
       end
 
       it 'should generate labels for each item' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         ::Author.find(:all).each do |author|
           output_buffer.should have_tag('form li fieldset ol li label', /#{author.to_label}/)
           output_buffer.should have_tag("form li fieldset ol li label[@for='project_author_id_#{author.id}']")
@@ -97,6 +139,7 @@ describe 'check_boxes input' do
       end
 
       it 'should generate inputs for each item' do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         ::Author.find(:all).each do |author|
           output_buffer.should have_tag("form li fieldset ol li label input#project_author_id_#{author.id}")
           output_buffer.should have_tag("form li fieldset ol li label input[@type='checkbox']")
@@ -106,16 +149,44 @@ describe 'check_boxes input' do
       end
 
       it 'should html escape the label string' do
-        output_buffer.replace ''
-        semantic_form_for(:project, :url => 'http://test.host') do |builder|
+        form = semantic_form_for(:project, :url => 'http://test.host') do |builder|
           concat(builder.input(:author_id, :as => :check_boxes, :collection => [["<b>Item 1</b>", 1], ["<b>Item 2</b>", 2]]))
         end
+        output_buffer.concat(form) if Formtastic::Util.rails3?
         output_buffer.should have_tag('form li fieldset ol li label') do |label|
           label.body.should match /&lt;b&gt;Item [12]&lt;\/b&gt;$/
         end
       end
     end
 
+    describe 'when :hidden_fields is set to false' do
+      before do
+        @output_buffer = ''
+        mock_everything
+
+        form = semantic_form_for(@fred) do |builder|
+          concat(builder.input(:posts, :as => :check_boxes, :value_as_class => true, :hidden_fields => false))
+        end
+        output_buffer.concat(form) if Formtastic::Util.rails3?        
+      end
+
+      it 'should have a checkbox input for each post' do
+        ::Post.find(:all).each do |post|
+          output_buffer.should have_tag("form li fieldset ol li label input#author_post_ids_#{post.id}")
+          output_buffer.should have_tag("form li fieldset ol li label input[@name='author[post_ids][]']", :count => ::Post.find(:all).length)
+        end
+      end
+
+      it "should mark input as checked if it's the the existing choice" do
+        ::Post.find(:all).include?(@fred.posts.first).should be_true
+        output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked']")
+      end
+
+      it 'should not generate empty hidden inputs' do
+        output_buffer.should_not have_tag("form li fieldset ol li label input[@type='hidden'][@value='']", :count => ::Post.find(:all).length)
+      end
+    end
+
     describe 'when :selected is set' do
       before do
         @output_buffer = ''
@@ -126,13 +197,14 @@ describe 'check_boxes input' do
           @new_post.stub!(:author_ids).and_return(nil)
 
           with_deprecation_silenced do
-            semantic_form_for(@new_post) do |builder|
+            @form = semantic_form_for(@new_post) do |builder|
               concat(builder.input(:authors, :as => :check_boxes, :selected => nil))
             end
           end
         end
 
         it 'should not have any selected item(s)' do
+          output_buffer.concat(@form) if Formtastic::Util.rails3?
           output_buffer.should_not have_tag("form li fieldset ol li label input[@checked='checked']")
         end
       end
@@ -142,13 +214,14 @@ describe 'check_boxes input' do
           @new_post.stub!(:author_ids).and_return(nil)
 
           with_deprecation_silenced do
-            semantic_form_for(@new_post) do |builder|
+            @form = semantic_form_for(@new_post) do |builder|
               concat(builder.input(:authors, :as => :check_boxes, :selected => @fred.id))
             end
           end
         end
 
         it "should have one item selected; the specified one" do
+          output_buffer.concat(@form) if Formtastic::Util.rails3?
           output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked']", :count => 1)
           output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@fred.id}']", /fred/i)
           output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked'][@value='#{@fred.id}']")
@@ -160,13 +233,14 @@ describe 'check_boxes input' do
           @new_post.stub!(:author_ids).and_return(nil)
           
           with_deprecation_silenced do
-            semantic_form_for(@new_post) do |builder|
+            @form = semantic_form_for(@new_post) do |builder|
               concat(builder.input(:authors, :as => :check_boxes, :selected => [@bob.id, @fred.id]))
             end
           end
         end
 
         it "should have multiple items selected; the specified ones" do
+          output_buffer.concat(@form) if Formtastic::Util.rails3?
           output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked']", :count => 2)
           output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@bob.id}']", /bob/i)
           output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked'][@value='#{@bob.id}']")
@@ -196,12 +270,13 @@ describe 'check_boxes input' do
         before do
           @new_post.stub!(:author_ids).and_return(nil)
 
-          semantic_form_for(@new_post) do |builder|
+          @form = semantic_form_for(@new_post) do |builder|
             concat(builder.input(:authors, :as => :check_boxes, :disabled => nil))
           end
         end
 
         it 'should not have any disabled item(s)' do
+          output_buffer.concat(@form) if Formtastic::Util.rails3?
           output_buffer.should_not have_tag("form li fieldset ol li label input[@disabled='disabled']")
         end
       end
@@ -210,12 +285,13 @@ describe 'check_boxes input' do
         before do
           @new_post.stub!(:author_ids).and_return(nil)
 
-          semantic_form_for(@new_post) do |builder|
+          @form = semantic_form_for(@new_post) do |builder|
             concat(builder.input(:authors, :as => :check_boxes, :disabled => @fred.id))
           end
         end
 
         it "should have one item disabled; the specified one" do
+          output_buffer.concat(@form) if Formtastic::Util.rails3?
           output_buffer.should have_tag("form li fieldset ol li label input[@disabled='disabled']", :count => 1)
           output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@fred.id}']", /fred/i)
           output_buffer.should have_tag("form li fieldset ol li label input[@disabled='disabled'][@value='#{@fred.id}']")
@@ -226,12 +302,13 @@ describe 'check_boxes input' do
         before do
           @new_post.stub!(:author_ids).and_return(nil)
 
-          semantic_form_for(@new_post) do |builder|
+          @form = semantic_form_for(@new_post) do |builder|
             concat(builder.input(:authors, :as => :check_boxes, :disabled => [@bob.id, @fred.id]))
           end
         end
 
         it "should have multiple items disabled; the specified ones" do
+          output_buffer.concat(@form) if Formtastic::Util.rails3?
           output_buffer.should have_tag("form li fieldset ol li label input[@disabled='disabled']", :count => 2)
           output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@bob.id}']", /bob/i)
           output_buffer.should have_tag("form li fieldset ol li label input[@disabled='disabled'][@value='#{@bob.id}']")
@@ -249,7 +326,7 @@ describe 'check_boxes input' do
         Formtastic::SemanticFormBuilder.i18n_lookups_by_default = true
 
         @new_post.stub!(:author_ids).and_return(nil)
-        semantic_form_for(@new_post) do |builder|
+        @form = semantic_form_for(@new_post) do |builder|
           concat(builder.input(:authors, :as => :check_boxes))
         end
       end
@@ -260,6 +337,7 @@ describe 'check_boxes input' do
       end
 
       it "should do foo" do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         output_buffer.should have_tag("legend.label label", /Translated/)
       end
 
@@ -268,12 +346,13 @@ describe 'check_boxes input' do
     describe "when :label option is set" do
       before do
         @new_post.stub!(:author_ids).and_return(nil)
-        semantic_form_for(@new_post) do |builder|
+        @form = semantic_form_for(@new_post) do |builder|
           concat(builder.input(:authors, :as => :check_boxes, :label => 'The authors'))
         end
       end
 
       it "should output the correct label title" do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         output_buffer.should have_tag("legend.label label", /The authors/)
       end
     end
@@ -282,15 +361,66 @@ describe 'check_boxes input' do
       before do
         @output_buffer = ''
         @new_post.stub!(:author_ids).and_return(nil)
-        semantic_form_for(@new_post) do |builder|
-          concat(builder.input(:authors, :as => :check_boxes, :label => false, :morton => true))
+        @form = semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:authors, :as => :check_boxes, :label => false))
         end
       end
 
       it "should not output the legend" do
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
         output_buffer.should_not have_tag("legend.label")
       end
     end
   end
+
+  describe 'for a has_and_belongs_to_many association' do
+    
+    before do
+      @output_buffer = ''
+      mock_everything
+      
+      @form = semantic_form_for(@freds_post) do |builder|
+        concat(builder.input(:authors, :as => :check_boxes))
+      end
+      output_buffer.concat(@form) if Formtastic::Util.rails3?
+    end
+    
+    it 'should render checkboxes' do
+      # I'm aware these two lines test the same thing
+      output_buffer.should have_tag('input[type="checkbox"]', :count => 2)
+      output_buffer.should have_tag('input[type="checkbox"]', :count => ::Author.find(:all).size)
+    end
+    
+    it 'should only select checkboxes that are present in the association' do
+      # I'm aware these two lines test the same thing
+      output_buffer.should have_tag('input[checked="checked"]', :count => 1)
+      output_buffer.should have_tag('input[checked="checked"]', :count => @freds_post.authors.size)
+    end
+    
+  end
+
+  describe 'for an association when a :collection is provided' do
+    describe 'it should use the specified :value_method option' do
+      before do
+        @output_buffer = ''
+        mock_everything
+      end
+
+      it 'to set the right input value' do
+        item = mock('item')
+        item.should_not_receive(:id)
+        item.stub!(:custom_value).and_return('custom_value')
+        item.should_receive(:custom_value).exactly(3).times
+        @new_post.author.should_receive(:custom_value)
+        @form = semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:author, :as => :check_boxes, :value_method => :custom_value, :collection => [item, item, item]))
+        end
+
+        output_buffer.concat(@form) if Formtastic::Util.rails3?
+        output_buffer.should have_tag('input[@type=checkbox][@value="custom_value"]', :count => 3)
+      end
+    end
+  end
+
 end