formtastic 0.9.4 → 0.9.5

data/lib/formtastic/i18n.rb

@@ -9,7 +9,12 @@ module Formtastic
         :create         => 'Create {{model}}',
         :update         => 'Update {{model}}'
       }.freeze
-    
+    SCOPES = [
+        '{{model}}.{{action}}.{{attribute}}',
+        '{{model}}.{{attribute}}',
+        '{{attribute}}'
+      ]
+      
     class << self
       
       def translate(*args)

data/spec/custom_macros.rb

@@ -75,6 +75,7 @@ module CustomMacros
     def it_should_use_default_text_field_size_when_method_has_no_database_column(as)
       it 'should use default_text_field_size when method has no database column' do
         @new_post.stub!(:column_for_attribute).and_return(nil) # Return a nil column
+        
         semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => as))
         end
@@ -222,7 +223,108 @@ module CustomMacros
         end
       end
     end
-    
+
+    def it_should_select_existing_datetime_else_current(*datetime_parts)
+      describe "default value" do
+        before do
+          @new_post.should_receive(:publish_at=).any_number_of_times
+        end
+
+        describe "when attribute value is present" do
+          before do
+            @output_buffer = ''
+            publish_at_value = 1.year.ago + 2.month + 3.day + 4.hours + 5.minutes # No comment =)
+            @new_post.stub!(:publish_at).and_return(publish_at_value)
+
+            semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:publish_at, :as => :datetime))
+            end
+          end
+
+          it "should select the present value by default" do
+            # puts output_buffer
+            output_buffer.should have_tag("form li select#post_publish_at_1i option[@selected='selected'][@value='#{@new_post.publish_at.year}']") if datetime_parts.include?(:year)
+            output_buffer.should have_tag("form li select#post_publish_at_2i option[@selected='selected'][@value='#{@new_post.publish_at.month}']") if datetime_parts.include?(:month)
+            output_buffer.should have_tag("form li select#post_publish_at_3i option[@selected='selected'][@value='#{@new_post.publish_at.day}']") if datetime_parts.include?(:day)
+            output_buffer.should have_tag("form li select#post_publish_at_4i option[@selected='selected'][@value='#{@new_post.publish_at.strftime("%H")}']") if datetime_parts.include?(:hour)
+            output_buffer.should have_tag("form li select#post_publish_at_5i option[@selected='selected'][@value='#{@new_post.publish_at.strftime("%M")}']") if datetime_parts.include?(:minute)
+            #output_buffer.should have_tag("form li select#post_publish_at_6i option[@selected='selected'][@value='#{@new_post.publish_at.sec}']") if datetime_parts.include?(:second)
+          end
+        end
+
+        describe "when no attribute value is present" do
+          before do
+            @output_buffer = ''
+            @new_post.stub!(:publish_at).and_return(nil)
+            @current_time = ::Time.now
+
+            semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:publish_at, :as => :datetime))
+            end
+          end
+
+          it "should select the current day/time by default" do
+            # puts output_buffer
+            output_buffer.should have_tag("form li select#post_publish_at_1i option[@selected='selected'][@value='#{@current_time.year}']") if datetime_parts.include?(:year)
+            output_buffer.should have_tag("form li select#post_publish_at_2i option[@selected='selected'][@value='#{@current_time.month}']") if datetime_parts.include?(:month)
+            output_buffer.should have_tag("form li select#post_publish_at_3i option[@selected='selected'][@value='#{@current_time.day}']") if datetime_parts.include?(:day)
+            output_buffer.should have_tag("form li select#post_publish_at_4i option[@selected='selected'][@value='#{@current_time.strftime("%H")}']") if datetime_parts.include?(:hour)
+            output_buffer.should have_tag("form li select#post_publish_at_5i option[@selected='selected'][@value='#{@current_time.strftime("%M")}']") if datetime_parts.include?(:minute)
+            #output_buffer.should have_tag("form li select#post_publish_at_6i option[@selected='selected'][@value='#{@custom_default_time.sec}']") if datetime_parts.include?(:second)
+          end
+
+          # TODO: Scenario when current time is not a possible choice (because of specified date/time ranges)?
+        end
+      end
+    end
+
+    def it_should_select_explicit_default_value_if_set(*datetime_parts)
+      describe 'when :selected is set' do
+        before do
+          @output_buffer = ''
+        end
+
+        # Note: Not possible to override default selected value for time_zone input
+        # without overriding Rails core helper. This Rails helper works "a bit different". =/
+        #
+        describe "no selected items" do
+          before do
+            @default_time = 2.days.ago
+            @new_post.stub!(:publish_at).and_return(@default_time)
+
+            semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:publish_at, :as => :time_zone, :selected => nil))
+            end
+          end
+
+          it 'should not have any selected item(s)' do
+            output_buffer.should_not have_tag("form li select#post_publish_at_1i option[@selected='selected']")
+          end
+        end
+
+        describe "single selected item" do
+          before do
+            @custom_default_time = 5.days.ago
+            @new_post.stub!(:publish_at).and_return(2.days.ago)
+
+            semantic_form_for(@new_post) do |builder|
+              concat(builder.input(:publish_at, :as => :datetime, :selected => @custom_default_time))
+            end
+          end
+
+          it "should select the specified value" do
+            output_buffer.should have_tag("form li select#post_publish_at_1i option[@selected='selected'][@value='#{@custom_default_time.year}']") if datetime_parts.include?(:year)
+            output_buffer.should have_tag("form li select#post_publish_at_2i option[@selected='selected'][@value='#{@custom_default_time.month}']") if datetime_parts.include?(:month)
+            output_buffer.should have_tag("form li select#post_publish_at_3i option[@selected='selected'][@value='#{@custom_default_time.day}']") if datetime_parts.include?(:day)
+            output_buffer.should have_tag("form li select#post_publish_at_4i option[@selected='selected'][@value='#{@custom_default_time.strftime("%H")}']") if datetime_parts.include?(:hour)
+            output_buffer.should have_tag("form li select#post_publish_at_5i option[@selected='selected'][@value='#{@custom_default_time.strftime("%M")}']") if datetime_parts.include?(:minute)
+            #output_buffer.should have_tag("form li select#post_publish_at_6i option[@selected='selected'][@value='#{@custom_default_time.sec}']") if datetime_parts.include?(:second)
+          end
+        end
+
+      end
+    end
+
     def it_should_use_the_collection_when_provided(as, countable)
       describe 'when the :collection option is provided' do
 
@@ -456,6 +558,4 @@ module CustomMacros
     end
 
   end
-  
-  
 end

data/spec/form_helper_spec.rb

@@ -79,7 +79,17 @@ describe 'SemanticFormHelper' do
         builder.object_name.to_s.should == "post" # TODO: is this forced .to_s a bad assumption somewhere?
       end
     end
-
+    
+    describe "with :builder option" do
+      it "yields an instance of the given builder" do
+        class MyAwesomeCustomBuilder < ::Formtastic::SemanticFormBuilder
+        end
+        semantic_form_for(:post, ::Post.new, :url => '/hello', :builder => MyAwesomeCustomBuilder) do |builder|
+          builder.class.should == MyAwesomeCustomBuilder
+        end
+      end
+    end
+    
   end
 
   describe '#semantic_fields_for' do

data/spec/i18n_spec.rb

@@ -80,4 +80,52 @@ describe 'Formtastic::I18n' do
     
   end
   
+  describe "I18n string lookups" do
+    
+    include FormtasticSpecHelper
+    
+    before do
+      @output_buffer = ''
+      mock_everything
+      
+      ::I18n.backend.store_translations :en, :formtastic => {
+          :labels => {
+              :title    => "Hello world!",
+              :post     => {:title => "Hello post!"},
+              :project  => {:title => "Hello project!"}
+            }
+        }
+      ::Formtastic::SemanticFormBuilder.i18n_lookups_by_default = true
+      
+      @new_post.stub!(:title)
+      @new_post.stub!(:column_for_attribute).with(:title).and_return(mock('column', :type => :string, :limit => 255))
+    end
+    
+    after do
+      ::I18n.backend.store_translations :en, :formtastic => nil
+      ::Formtastic::SemanticFormBuilder.i18n_lookups_by_default = false
+    end
+    
+    it "lookup scopes should be defined" do
+      lambda { ::Formtastic::I18n::SCOPES }.should_not raise_error(::NameError)
+    end
+    
+    it "should be able to translate with namespaced object" do
+      semantic_form_for(@new_post) do |builder|
+        concat(builder.input(:title))
+      end
+      output_buffer.should have_tag("form label", /Hello post!/)
+    end
+    
+    it "should be able to translate without form-object" do
+      semantic_form_for(:project, :url => 'http://test.host') do |builder|
+        concat(builder.input(:title))
+      end
+      output_buffer.should have_tag("form label", /Hello project!/)
+    end
+    
+    # TODO: Add spec for namespaced models?
+    
+  end
+  
 end

data/spec/input_spec.rb

@@ -400,9 +400,8 @@ describe 'SemanticFormBuilder#input' do
 
       describe 'when not provided' do
         describe 'when localized label is NOT provided' do
-          describe 'and object is not given' do
+          describe 'and label_str_method is not provided' do
             it 'should default the humanized method name, passing it down to the label tag' do
-              ::Formtastic::SemanticFormBuilder.label_str_method = :humanize
 
               semantic_form_for(:project, :url => 'http://test.host') do |builder|
                 concat(builder.input(:meta_description))
@@ -412,16 +411,17 @@ describe 'SemanticFormBuilder#input' do
             end
           end
 
-          describe 'and object is given' do
-            it 'should delegate the label logic to class human attribute name and pass it down to the label tag' do
-              @new_post.stub!(:meta_description) # a two word method name
-              @new_post.class.should_receive(:human_attribute_name).with('meta_description').and_return('meta_description'.humanize)
+          describe 'and label_str_method is :capitalize' do
+            it 'should capitalize method name, passing it down to the label tag' do
+              old_value = ::Formtastic::SemanticFormBuilder.label_str_method
+              ::Formtastic::SemanticFormBuilder.label_str_method = :capitalize
 
-              semantic_form_for(@new_post) do |builder|
+              semantic_form_for(:project, :url => 'http://test.host') do |builder|
                 concat(builder.input(:meta_description))
               end
 
-              output_buffer.should have_tag("form li label", /#{'meta_description'.humanize}/)
+              output_buffer.should have_tag("form li label", /#{'meta_description'.capitalize}/)
+              ::Formtastic::SemanticFormBuilder.label_str_method = old_value
             end
           end
         end

data/spec/inputs/boolean_input_spec.rb

@@ -56,5 +56,38 @@ describe 'boolean input' do
     output_buffer.should have_tag('form li label input[@name="project[allow_comments]"]')
   end
 
-end
+  describe 'when :selected is set' do
+    before do
+      @output_buffer = ''
+    end
+
+    describe "not selected" do
+      before do
+        @new_post.stub!(:allow_comments).and_return(true)
+
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:allow_comments, :as => :boolean, :selected => false))
+        end
+      end
+
+      it 'should not be selected' do
+        output_buffer.should_not have_tag("form li label input[@type='checkbox'][@checked='checked']")
+      end
+    end
 
+    describe "selected" do
+      before do
+        @new_post.stub!(:allow_comments).and_return(false)
+
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:allow_comments, :as => :boolean, :selected => true))
+        end
+      end
+
+      it 'should be selected' do
+        output_buffer.should have_tag("form li label input[@type='checkbox'][@checked='checked']")
+      end
+    end
+  end
+
+end

data/spec/inputs/check_boxes_input_spec.rb

@@ -51,7 +51,7 @@ describe 'check_boxes input' do
 
       it 'should use values as li.class when value_as_class is true' do
         ::Post.find(:all).each do |post|
-          output_buffer.should have_tag("form li fieldset ol li.#{post.id} label")
+          output_buffer.should have_tag("form li fieldset ol li.post_#{post.id} label")
         end
       end
 
@@ -100,6 +100,62 @@ describe 'check_boxes input' do
         end
       end
     end
+
+    describe 'when :selected is set' do
+      before do
+        @output_buffer = ''
+      end
+
+      describe "no selected items" do
+        before do
+          @new_post.stub!(:author_ids).and_return(nil)
+
+          semantic_form_for(@new_post) do |builder|
+            concat(builder.input(:authors, :as => :check_boxes, :selected => nil))
+          end
+        end
+
+        it 'should not have any selected item(s)' do
+          output_buffer.should_not have_tag("form li fieldset ol li label input[@checked='checked']")
+        end
+      end
+
+      describe "single selected item" do
+        before do
+          @new_post.stub!(:author_ids).and_return(nil)
+
+          semantic_form_for(@new_post) do |builder|
+            concat(builder.input(:authors, :as => :check_boxes, :selected => @fred.id))
+          end
+        end
+
+        it "should have one item selected; the specified one" do
+          output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked']", :count => 1)
+          output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@fred.id}']", /fred/i)
+          output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked'][@value='#{@fred.id}']")
+        end
+      end
+
+      describe "multiple selected items" do
+        before do
+          @new_post.stub!(:author_ids).and_return(nil)
+
+          semantic_form_for(@new_post) do |builder|
+            concat(builder.input(:authors, :as => :check_boxes, :selected => [@bob.id, @fred.id]))
+          end
+        end
+
+        it "should have multiple items selected; the specified ones" do
+          output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked']", :count => 2)
+          output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@bob.id}']", /bob/i)
+          output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked'][@value='#{@bob.id}']")
+          output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@fred.id}']", /fred/i)
+          output_buffer.should have_tag("form li fieldset ol li label input[@checked='checked'][@value='#{@fred.id}']")
+        end
+      end
+
+    end
+
   end
 
 end

data/spec/inputs/date_input_spec.rb

@@ -39,5 +39,7 @@ describe 'date input' do
     output_buffer.should have_tag('form li.date fieldset ol li select', :count => 3)
   end
 
-end
+  it_should_select_existing_datetime_else_current(:year, :month, :day)
+  it_should_select_explicit_default_value_if_set(:year, :month, :day)
 
+end

data/spec/inputs/datetime_input_spec.rb

@@ -9,6 +9,11 @@ describe 'datetime input' do
     @output_buffer = ''
     mock_everything
     
+    @new_post.should_receive(:publish_at=).any_number_of_times
+    @new_post.should_receive(:created_at=).any_number_of_times
+    @bob.should_receive(:created_at=).any_number_of_times
+    @new_post.should_receive(:title=).any_number_of_times # Macro stuff forces this.
+    
     semantic_form_for(@new_post) do |builder|
       concat(builder.input(:publish_at, :as => :datetime))
     end
@@ -54,15 +59,10 @@ describe 'datetime input' do
     end
   end
 
-  describe 'when :discard_input => true is set' do
-    it 'should use default hidden value equals to 1 when attribute returns nil' do
-      semantic_form_for(@new_post) do |builder|
-        concat(builder.input(:publish_at, :as => :datetime, :discard_day => true))
-      end
-
-      output_buffer.should have_tag("form li input[@type='hidden'][@value='1']")
-    end
+  it_should_select_existing_datetime_else_current(:year, :month, :day, :hour, :minute, :second)
+  it_should_select_explicit_default_value_if_set(:year, :month, :day, :hour, :minute, :second)
 
+  describe 'when :discard_input => true is set' do
     it 'should use default attribute value when it is not nil' do
       @new_post.stub!(:publish_at).and_return(Date.new(2007,12,27))
       semantic_form_for(@new_post) do |builder|

data/spec/inputs/radio_input_spec.rb

@@ -49,7 +49,7 @@ describe 'radio input' do
 
       it 'should use values as li.class when value_as_class is true' do
         ::Author.find(:all).each do |author|
-          output_buffer.should have_tag("form li fieldset ol li.#{author.id} label")
+          output_buffer.should have_tag("form li fieldset ol li.author_#{author.id} label")
         end
       end
 
@@ -109,5 +109,41 @@ describe 'radio input' do
     end
   end
 
-end
+  describe 'when :selected is set' do
+    before do
+      @output_buffer = ''
+    end
+
+    describe "no selected items" do
+      before do
+        @new_post.stub!(:author_ids).and_return(nil)
+
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:authors, :as => :radio, :selected => nil))
+        end
+      end
+
+      it 'should not have any selected item(s)' do
+        output_buffer.should_not have_tag("form li fieldset ol li label input[@checked='checked']")
+      end
+    end
 
+    describe "single selected item" do
+      before do
+        @new_post.stub!(:author_ids).and_return(nil)
+  
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:authors, :as => :radio, :selected => @fred.id))
+        end
+      end
+
+      it "should have one item selected; the specified one" do
+        output_buffer.should have_tag("form li fieldset ol li label input[@type='radio'][@checked='checked']", :count => 1)
+        output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_ids_#{@fred.id}']", /fred/i)
+        output_buffer.should have_tag("form li fieldset ol li label input[@type='radio'][@checked='checked'][@value='#{@fred.id}']")
+      end
+    end
+
+  end
+
+end