formtastic 0.9.2 → 0.9.3

data/spec/custom_macros.rb

@@ -157,7 +157,7 @@ module CustomMacros
         end
 
         it 'should render a paragraph for the errors' do
-          Formtastic::SemanticFormBuilder.inline_errors = :sentence
+          ::Formtastic::SemanticFormBuilder.inline_errors = :sentence
           semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => type))
           end
@@ -165,7 +165,7 @@ module CustomMacros
         end
 
         it 'should not display an error list' do
-          Formtastic::SemanticFormBuilder.inline_errors = :list
+          ::Formtastic::SemanticFormBuilder.inline_errors = :list
           semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => type))
           end
@@ -399,7 +399,7 @@ module CustomMacros
         end
 
         describe 'when the :label_method option is not provided' do
-          Formtastic::SemanticFormBuilder.collection_label_methods.each do |label_method|
+          ::Formtastic::SemanticFormBuilder.collection_label_methods.each do |label_method|
 
             describe "when the collection objects respond to #{label_method}" do
               before do

data/spec/errors_spec.rb

@@ -19,14 +19,14 @@ describe 'SemanticFormBuilder#errors_on' do
     end
     
     it 'should render a paragraph with the errors joined into a sentence when inline_errors config is :sentence' do
-      Formtastic::SemanticFormBuilder.inline_errors = :sentence
+      ::Formtastic::SemanticFormBuilder.inline_errors = :sentence
       semantic_form_for(@new_post) do |builder|
         builder.errors_on(:title).should have_tag('p.inline-errors', @title_errors.to_sentence)
       end
     end
     
     it 'should render an unordered list with the class errors when inline_errors config is :list' do
-      Formtastic::SemanticFormBuilder.inline_errors = :list
+      ::Formtastic::SemanticFormBuilder.inline_errors = :list
       semantic_form_for(@new_post) do |builder|
         builder.errors_on(:title).should have_tag('ul.errors')
         @title_errors.each do |error|
@@ -36,14 +36,14 @@ describe 'SemanticFormBuilder#errors_on' do
     end
 
     it 'should render a paragraph with the first error when inline_errors config is :first' do
-      Formtastic::SemanticFormBuilder.inline_errors = :first
+      ::Formtastic::SemanticFormBuilder.inline_errors = :first
       semantic_form_for(@new_post) do |builder|
         builder.errors_on(:title).should have_tag('p.inline-errors', @title_errors.first)
       end
     end
     
     it 'should return nil when inline_errors config is :none' do
-      Formtastic::SemanticFormBuilder.inline_errors = :none
+      ::Formtastic::SemanticFormBuilder.inline_errors = :none
       semantic_form_for(@new_post) do |builder|
         builder.errors_on(:title).should be_nil
       end
@@ -58,7 +58,7 @@ describe 'SemanticFormBuilder#errors_on' do
     
     it 'should return nil when inline_errors config is :sentence, :list or :none' do
       [:sentence, :list, :none].each do |config|
-        Formtastic::SemanticFormBuilder.inline_errors = config
+        ::Formtastic::SemanticFormBuilder.inline_errors = config
         semantic_form_for(@new_post) do |builder|
           builder.errors_on(:title).should be_nil
         end
@@ -73,7 +73,7 @@ describe 'SemanticFormBuilder#errors_on' do
     
     it 'should return nil when inline_errors config is :sentence, :list or :none' do
       [:sentence, :list, :none].each do |config|
-        Formtastic::SemanticFormBuilder.inline_errors = config
+        ::Formtastic::SemanticFormBuilder.inline_errors = config
         semantic_form_for(@new_post) do |builder|
           builder.errors_on(:title).should be_nil
         end

data/spec/form_helper_spec.rb

@@ -14,7 +14,7 @@ describe 'SemanticFormHelper' do
 
     it 'yields an instance of SemanticFormBuilder' do
       semantic_form_for(:post, ::Post.new, :url => '/hello') do |builder|
-        builder.class.should == Formtastic::SemanticFormBuilder
+        builder.class.should == ::Formtastic::SemanticFormBuilder
       end
     end
 
@@ -85,7 +85,7 @@ describe 'SemanticFormHelper' do
   describe '#semantic_fields_for' do
     it 'yields an instance of SemanticFormBuilder' do
       semantic_fields_for(:post, ::Post.new, :url => '/hello') do |builder|
-        builder.class.should == Formtastic::SemanticFormBuilder
+        builder.class.should == ::Formtastic::SemanticFormBuilder
       end
     end
   end
@@ -93,7 +93,7 @@ describe 'SemanticFormHelper' do
   describe '#semantic_form_remote_for' do
     it 'yields an instance of SemanticFormBuilder' do
       semantic_form_remote_for(:post, ::Post.new, :url => '/hello') do |builder|
-        builder.class.should == Formtastic::SemanticFormBuilder
+        builder.class.should == ::Formtastic::SemanticFormBuilder
       end
     end
   end
@@ -101,7 +101,7 @@ describe 'SemanticFormHelper' do
   describe '#semantic_form_for_remote' do
     it 'yields an instance of SemanticFormBuilder' do
       semantic_remote_form_for(:post, ::Post.new, :url => '/hello') do |builder|
-        builder.class.should == Formtastic::SemanticFormBuilder
+        builder.class.should == ::Formtastic::SemanticFormBuilder
       end
     end
   end

data/spec/i18n_spec.rb

@@ -0,0 +1,83 @@
+# coding: utf-8
+require File.join(File.dirname(__FILE__), *%w[spec_helper])
+
+describe 'Formtastic::I18n' do
+  
+  FORMTASTIC_KEYS = [:required, :yes, :no, :create, :update].freeze
+  
+  it "should be defined" do
+    lambda { ::Formtastic::I18n }.should_not raise_error(::NameError)
+  end
+  
+  describe "default translations" do
+    it "should be defined" do
+      lambda { ::Formtastic::I18n::DEFAULT_VALUES }.should_not raise_error(::NameError)
+      ::Formtastic::I18n::DEFAULT_VALUES.is_a?(::Hash).should == true
+    end
+    
+    it "should exists for the core I18n lookup keys" do
+      (::Formtastic::I18n::DEFAULT_VALUES.keys & FORMTASTIC_KEYS).size.should == FORMTASTIC_KEYS.size
+    end
+  end
+  
+  describe "when I18n locales are available" do
+    
+    before do
+      @formtastic_strings = {
+          :required       => 'Default Required',
+          :yes            => 'Default Yes',
+          :no             => 'Default No',
+          :create         => 'Default Create {{model}}',
+          :update         => 'Default Update {{model}}',
+          :custom_scope   => {
+              :duck           => 'Duck',
+              :duck_pond      => '{{ducks}} ducks in a pond'
+            }
+        }
+      ::I18n.backend.store_translations :en, :formtastic => @formtastic_strings
+    end
+    
+    it "should translate core strings correctly" do
+      ::Formtastic::I18n.t(:required).should  == "Default Required"
+      ::Formtastic::I18n.t(:yes).should       == "Default Yes"
+      ::Formtastic::I18n.t(:no).should        == "Default No"
+      ::Formtastic::I18n.t(:create, :model => 'Post').should == "Default Create Post"
+      ::Formtastic::I18n.t(:update, :model => 'Post').should == "Default Update Post"
+    end
+    
+    it "should all belong to scope 'formtastic'" do
+      ::Formtastic::I18n.t(:duck, :scope => [:custom_scope]).should == 'Duck'
+    end
+    
+    it "should override default I18n lookup args if these are specified" do
+      ::Formtastic::I18n.t(:duck_pond, :scope => [:custom_scope], :ducks => 15).should == '15 ducks in a pond'
+    end
+    
+    it "should be possible to override default values" do
+      ::I18n.backend.store_translations :en, {:formtastic => {:required => nil}}
+      ::Formtastic::I18n.t(:required, :default => 'Nothing found!').should == 'Nothing found!'
+    end
+    
+  end
+  
+  describe "when no I18n locales are available" do
+    
+    before do
+      ::I18n.backend.store_translations :en, :formtastic => {
+          :required => nil,
+          :yes => nil,
+          :no => nil,
+          :create => nil,
+          :update => nil
+        }
+    end
+    
+    it "should use default strings" do
+      (::Formtastic::I18n::DEFAULT_VALUES.keys).each do |key|
+        ::Formtastic::I18n.t(key, :model => '{{model}}').should == ::Formtastic::I18n::DEFAULT_VALUES[key]
+      end
+    end
+    
+  end
+  
+end

data/spec/input_spec.rb

@@ -12,7 +12,7 @@ describe 'SemanticFormBuilder#input' do
 
   describe 'with inline order customization' do
     it 'should allow input, hints, errors as order' do
-      Formtastic::SemanticFormBuilder.inline_order = [:input, :hints, :errors]
+      ::Formtastic::SemanticFormBuilder.inline_order = [:input, :hints, :errors]
 
       semantic_form_for(@new_post) do |builder|
         builder.should_receive(:inline_input_for).once.ordered
@@ -23,7 +23,7 @@ describe 'SemanticFormBuilder#input' do
     end
 
     it 'should allow hints, input, errors as order' do
-      Formtastic::SemanticFormBuilder.inline_order = [:hints, :input, :errors]
+      ::Formtastic::SemanticFormBuilder.inline_order = [:hints, :input, :errors]
 
       semantic_form_for(@new_post) do |builder|
         builder.should_receive(:inline_hints_for).once.ordered
@@ -49,12 +49,13 @@ describe 'SemanticFormBuilder#input' do
       describe 'when true' do
 
         before do
-          @string = Formtastic::SemanticFormBuilder.required_string = " required yo!" # ensure there's something in the string
+          @old_string = ::Formtastic::SemanticFormBuilder.required_string
+          @new_string = ::Formtastic::SemanticFormBuilder.required_string = " required yo!" # ensure there's something in the string
           @new_post.class.should_not_receive(:reflect_on_all_validations)
         end
 
         after do
-          Formtastic::SemanticFormBuilder.required_string = %{<abbr title="required">*</abbr>}
+          ::Formtastic::SemanticFormBuilder.required_string = @old_string
         end
 
         it 'should set a "required" class' do
@@ -69,7 +70,7 @@ describe 'SemanticFormBuilder#input' do
           semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :required => true))
           end
-          output_buffer.should have_tag('form li.required label', /#{@string}$/)
+          output_buffer.should have_tag('form li.required label', /#{@new_string}$/)
         end
 
       end
@@ -77,12 +78,12 @@ describe 'SemanticFormBuilder#input' do
       describe 'when false' do
 
         before do
-          @string = Formtastic::SemanticFormBuilder.optional_string = " optional yo!" # ensure there's something in the string
+          @string = ::Formtastic::SemanticFormBuilder.optional_string = " optional yo!" # ensure there's something in the string
           @new_post.class.should_not_receive(:reflect_on_all_validations)
         end
 
         after do
-          Formtastic::SemanticFormBuilder.optional_string = ''
+          ::Formtastic::SemanticFormBuilder.optional_string = ''
         end
 
         it 'should set an "optional" class' do
@@ -107,8 +108,8 @@ describe 'SemanticFormBuilder#input' do
         describe 'and an object was not given' do
 
           it 'should use the default value' do
-            Formtastic::SemanticFormBuilder.all_fields_required_by_default.should == true
-            Formtastic::SemanticFormBuilder.all_fields_required_by_default = false
+            ::Formtastic::SemanticFormBuilder.all_fields_required_by_default.should == true
+            ::Formtastic::SemanticFormBuilder.all_fields_required_by_default = false
 
             semantic_form_for(:project, :url => 'http://test.host/') do |builder|
               concat(builder.input(:title))
@@ -116,7 +117,7 @@ describe 'SemanticFormBuilder#input' do
             output_buffer.should_not have_tag('form li.required')
             output_buffer.should have_tag('form li.optional')
 
-            Formtastic::SemanticFormBuilder.all_fields_required_by_default = true
+            ::Formtastic::SemanticFormBuilder.all_fields_required_by_default = true
           end
 
         end
@@ -225,8 +226,8 @@ describe 'SemanticFormBuilder#input' do
           describe 'and the validation reflection plugin is not available' do
 
             it 'should use the default value' do
-              Formtastic::SemanticFormBuilder.all_fields_required_by_default.should == true
-              Formtastic::SemanticFormBuilder.all_fields_required_by_default = false
+              ::Formtastic::SemanticFormBuilder.all_fields_required_by_default.should == true
+              ::Formtastic::SemanticFormBuilder.all_fields_required_by_default = false
 
               semantic_form_for(@new_post) do |builder|
                 concat(builder.input(:title))
@@ -234,7 +235,7 @@ describe 'SemanticFormBuilder#input' do
               output_buffer.should_not have_tag('form li.required')
               output_buffer.should have_tag('form li.optional')
 
-              Formtastic::SemanticFormBuilder.all_fields_required_by_default = true
+              ::Formtastic::SemanticFormBuilder.all_fields_required_by_default = true
             end
 
           end
@@ -330,12 +331,12 @@ describe 'SemanticFormBuilder#input' do
         end
 
         describe 'defaulting to file column' do
-          Formtastic::SemanticFormBuilder.file_methods.each do |method|
+          ::Formtastic::SemanticFormBuilder.file_methods.each do |method|
             it "should default to :file for attributes that respond to ##{method}" do
               @new_post.stub!(:column_for_attribute).and_return(nil)
               column = mock('column')
 
-              Formtastic::SemanticFormBuilder.file_methods.each do |test|
+              ::Formtastic::SemanticFormBuilder.file_methods.each do |test|
                 column.stub!(:respond_to?).with(test).and_return(method == test)
               end
 
@@ -401,25 +402,25 @@ describe 'SemanticFormBuilder#input' do
         describe 'when localized label is NOT provided' do
           describe 'and object is not given' do
             it 'should default the humanized method name, passing it down to the label tag' do
-              Formtastic::SemanticFormBuilder.label_str_method = :humanize
-          
+              ::Formtastic::SemanticFormBuilder.label_str_method = :humanize
+
               semantic_form_for(:project, :url => 'http://test.host') do |builder|
                 concat(builder.input(:meta_description))
               end
-          
+
               output_buffer.should have_tag("form li label", /#{'meta_description'.humanize}/)
             end
           end
-          
+
           describe 'and object is given' do
             it 'should delegate the label logic to class human attribute name and pass it down to the label tag' do
               @new_post.stub!(:meta_description) # a two word method name
               @new_post.class.should_receive(:human_attribute_name).with('meta_description').and_return('meta_description'.humanize)
-          
+
               semantic_form_for(@new_post) do |builder|
                 concat(builder.input(:meta_description))
               end
-          
+
               output_buffer.should have_tag("form li label", /#{'meta_description'.humanize}/)
             end
           end

data/spec/inputs/check_boxes_input_spec.rb

@@ -22,9 +22,9 @@ describe 'check_boxes input' do
     it_should_call_find_on_association_class_when_no_collection_is_provided(:check_boxes)
     it_should_use_the_collection_when_provided(:check_boxes, 'input[@type="checkbox"]')
     
-    it 'should generate a legend containing label text for the input' do
-      output_buffer.should have_tag('form li fieldset legend')
-      output_buffer.should have_tag('form li fieldset legend', /Posts/)
+    it 'should generate a legend - classified as a label - containing label text for the input' do
+      output_buffer.should have_tag('form li fieldset legend.label')
+      output_buffer.should have_tag('form li fieldset legend.label', /Posts/)
     end
 
     it 'should generate an ordered list with a list item for each choice' do

data/spec/inputs/country_input_spec.rb

@@ -62,7 +62,7 @@ describe 'country input' do
     end
       
     it "should default to the @@priority_countries config when absent" do 
-      priority_countries = Formtastic::SemanticFormBuilder.priority_countries
+      priority_countries = ::Formtastic::SemanticFormBuilder.priority_countries
       priority_countries.should_not be_empty
       priority_countries.should_not be_nil
       

data/spec/inputs/date_input_spec.rb

@@ -19,8 +19,8 @@ describe 'date input' do
   it_should_have_a_nested_fieldset
   it_should_apply_error_logic_for_input_type(:date)
   
-  it 'should have a legend containing the label text inside the fieldset' do
-    output_buffer.should have_tag('form li.date fieldset legend', /Publish at/)
+  it 'should have a legend - classified as a label - containing the label text inside the fieldset' do
+    output_buffer.should have_tag('form li.date fieldset legend.label', /Publish at/)
   end
 
   it 'should have an ordered list of three items inside the fieldset' do

data/spec/inputs/datetime_input_spec.rb

@@ -84,7 +84,7 @@ describe 'datetime input' do
     end
 
     it 'should be specified with :order option' do
-      I18n.backend.store_translations 'en', :date => { :order => [:month, :year, :day] }
+      ::I18n.backend.store_translations 'en', :date => { :order => [:month, :year, :day] }
       semantic_form_for(@new_post) do |builder|
         self.should_receive(:select_month).once.ordered.and_return('')
         self.should_receive(:select_year).once.ordered.and_return('')
@@ -105,7 +105,7 @@ describe 'datetime input' do
 
   describe 'when the locale changes the label text' do
     before do
-      I18n.backend.store_translations 'en', :datetime => {:prompts => {
+      ::I18n.backend.store_translations 'en', :datetime => {:prompts => {
         :year => 'The Year', :month => 'The Month', :day => 'The Day',
         :hour => 'The Hour', :minute => 'The Minute'
       }}
@@ -115,7 +115,7 @@ describe 'datetime input' do
     end
 
     after do
-      I18n.backend.store_translations 'en', :formtastic => {
+      ::I18n.backend.store_translations 'en', :formtastic => {
         :year => nil, :month => nil, :day => nil,
         :hour => nil, :minute => nil
       }
@@ -138,8 +138,8 @@ describe 'datetime input' do
       end
     end
 
-    it 'should have fieldset with legend' do
-      output_buffer.should have_tag('form li.datetime fieldset legend', /Publish at/)
+    it 'should have fieldset with legend - classified as a label' do
+      output_buffer.should have_tag('form li.datetime fieldset legend.label', /Publish at/)
     end
 
     it 'should have labels for each input' do

data/spec/inputs/hidden_input_spec.rb

@@ -11,6 +11,8 @@ describe 'hidden input' do
     
     semantic_form_for(@new_post) do |builder|
       concat(builder.input(:secret, :as => :hidden))
+      concat(builder.input(:author_id, :as => :hidden, :value => 99))
+      concat(builder.input(:published, :as => :hidden, :input_html => {:value => true}))
     end
   end
 
@@ -20,8 +22,17 @@ describe 'hidden input' do
 
   it "should generate a input field" do
     output_buffer.should have_tag("form li input#post_secret")
-    output_buffer.should have_tag("form li input[@type=\"hidden\"]")
-    output_buffer.should have_tag("form li input[@name=\"post[secret]\"]")
+    output_buffer.should have_tag("form li input#post_secret[@type=\"hidden\"]")
+    output_buffer.should have_tag("form li input#post_secret[@name=\"post[secret]\"]")
+  end
+  
+  it "should pass any explicitly specified value - using :value" do
+    output_buffer.should have_tag("form li input#post_author_id[@type=\"hidden\"][@value=\"99\"]")
+  end
+  
+  # Handle Formtastic :input_html options for consistency.
+  it "should pass any explicitly specified value - using :input_html options" do
+    output_buffer.should have_tag("form li input#post_published[@type=\"hidden\"][@value=\"true\"]")
   end
   
   it "should not render inline errors" do

data/spec/inputs/radio_input_spec.rb

@@ -24,9 +24,9 @@ describe 'radio input' do
     it_should_use_the_collection_when_provided(:radio, 'input')
     
     
-    it 'should generate a legend containing label text for the input' do
-      output_buffer.should have_tag('form li fieldset legend')
-      output_buffer.should have_tag('form li fieldset legend', /Author/)
+    it 'should generate a legend - classified as a label - containing label text for the input' do
+      output_buffer.should have_tag('form li fieldset legend.label')
+      output_buffer.should have_tag('form li fieldset legend.label', /Author/)
     end
 
     it 'should generate an ordered list with a list item for each choice' do

data/spec/inputs/select_input_spec.rb

@@ -2,14 +2,51 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe 'select input' do
-  
+
   include FormtasticSpecHelper
-  
+
   before do
     @output_buffer = ''
     mock_everything
   end
-  
+
+  describe 'explicit values' do
+    describe 'using an array of values' do
+      before do
+        @array_with_values = ["Title A", "Title B", "Title C"]
+        @array_with_keys_and_values = [["Title D", 1], ["Title E", 2], ["Title F", 3]]
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:title, :as => :select, :collection => @array_with_values))
+          concat(builder.input(:title, :as => :select, :collection => @array_with_keys_and_values))
+        end
+      end
+
+      it 'should have a option for each key and/or value' do
+        @array_with_values.each do |v|
+          output_buffer.should have_tag("form li select option[@value='#{v}']", /^#{v}$/)
+        end
+        @array_with_keys_and_values.each do |v|
+          output_buffer.should have_tag("form li select option[@value='#{v.second}']", /^#{v.first}$/)
+        end
+      end
+    end
+
+    describe 'using a range' do
+      before do
+        @range_with_values = 1..5
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:title, :as => :select, :collection => @range_with_values))
+        end
+      end
+
+      it 'should have an option for each value' do
+        @range_with_values.each do |v|
+          output_buffer.should have_tag("form li select option[@value='#{v}']", /^#{v}$/)
+        end
+      end
+    end
+  end
+
   describe 'for a belongs_to association' do
     before do
       semantic_form_for(@new_post) do |builder|
@@ -259,5 +296,47 @@ describe 'select input' do
     
   end
 
-end
+  describe 'boolean select' do
+    describe 'default formtastic locale' do
+      before do
+        # Note: Works, but something like Formtastic.root.join(...) would probably be "safer".
+        ::I18n.load_path = [File.join(File.dirname(__FILE__), *%w[.. .. lib locale en.yml])]
+        ::I18n.backend.send(:init_translations)
+
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:published, :as => :select))
+        end
+      end
+
+      after do
+        ::I18n.backend.store_translations :en, {}
+      end
 
+      it 'should render a select with at least options: true/false' do
+        output_buffer.should have_tag("form li select option[@value='true']", /^Yes$/)
+        output_buffer.should have_tag("form li select option[@value='false']", /^No$/)
+      end
+    end
+    
+    describe 'custom locale' do
+      before do
+        @boolean_select_labels = {:yes => 'Yep', :no => 'Nope'}
+        ::I18n.backend.store_translations :en, :formtastic => @boolean_select_labels
+
+        semantic_form_for(@new_post) do |builder|
+          concat(builder.input(:published, :as => :select))
+        end
+      end
+
+      after do
+        ::I18n.backend.store_translations :en, {}
+      end
+
+      it 'should render a select with at least options: true/false' do
+        output_buffer.should have_tag("form li select option[@value='true']", /#{@boolean_select_labels[:yes]}/)
+        output_buffer.should have_tag("form li select option[@value='false']", /#{@boolean_select_labels[:no]}/)
+      end
+    end
+  end
+
+end

data/spec/inputs/time_input_spec.rb

@@ -19,8 +19,8 @@ describe 'time input' do
   it_should_have_a_nested_fieldset
   it_should_apply_error_logic_for_input_type(:time)
 
-  it 'should have a legend containing the label text inside the fieldset' do
-    output_buffer.should have_tag('form li.time fieldset legend', /Publish at/)
+  it 'should have a legend - classified as a label - containing the label text inside the fieldset' do
+    output_buffer.should have_tag('form li.time fieldset legend.label', /Publish at/)
   end
 
   it 'should have an ordered list of two items inside the fieldset' do