forminate 0.1.0 → 0.2.0

data/spec/{lib/forminate → forminate}/client_side_validations.rb

@@ -71,7 +71,7 @@ module Forminate
     # validation hash.
     def association_validators
       associations.reduce({}) do |assoc_validators, (name, object)|
-        if should_validate_assoc?(name) && object.respond_to?(:_validators)
+        if validate_assoc?(name) && object.respond_to?(:_validators)
           object._validators.each do |attr, validators|
             new_validators = validators.reduce([]) do |new_validators, validator|
               new_validator = validator.dup

data/spec/{lib/forminate → forminate}/client_side_validations_spec.rb

@@ -14,13 +14,13 @@ describe Forminate::ClientSideValidations do
       attribute :tax
 
       attributes_for :dummy_user
-      attributes_for :dummy_book, :validate => false
-      attributes_for :dummy_credit_card, :validate => :require_credit_card?
+      attributes_for :dummy_book, validate: false
+      attributes_for :dummy_credit_card, validate: :require_credit_card?
 
       validates_numericality_of :total
 
       def self.name
-        "Cart"
+        'Cart'
       end
 
       def calculate_total
@@ -33,11 +33,11 @@ describe Forminate::ClientSideValidations do
     end
   end
 
-  describe "#client_side_validation_hash" do
-    it "constructs a hash of validations and messages for use with the client_side_validations gem" do
+  describe '#client_side_validation_hash' do
+    it 'constructs a hash of validations and messages for use with the client_side_validations gem' do
       expected_hash = {
         total: {
-          numericality: [{ messages: { numericality: "is not a number" } }]
+          numericality: [{ messages: { numericality: 'is not a number' } }]
         },
         dummy_user_email: {
           presence: [{ message: "can't be blank" }]
@@ -46,7 +46,7 @@ describe Forminate::ClientSideValidations do
       expect(model.client_side_validation_hash).to eq(expected_hash)
       expected_hash = {
         total: {
-          numericality: [{ messages: { numericality: "is not a number" } }]
+          numericality: [{ messages: { numericality: 'is not a number' } }]
         },
         dummy_user_email: {
           presence: [{ message: "can't be blank" }]
@@ -55,13 +55,13 @@ describe Forminate::ClientSideValidations do
           presence: [{ message: "can't be blank" }],
           length: [{
             messages: {
-              minimum: "is too short (minimum is 12 characters)",
-              maximum: "is too long (maximum is 19 characters)"
+              minimum: 'is too short (minimum is 12 characters)',
+              maximum: 'is too long (maximum is 19 characters)'
             },
             minimum: 12,
             maximum: 19
           }]
-        },
+        }
       }
       model.dummy_book_price = 12.95
       expect(model.client_side_validation_hash).to eq(expected_hash)

data/spec/forminate_spec.rb

@@ -0,0 +1,250 @@
+require 'spec_helper'
+
+describe Forminate do
+  subject(:model) { model_class.new }
+
+  let :model_class do
+    Class.new do
+      include Forminate
+
+      attribute :total
+      attribute :tax
+
+      attributes_for :dummy_user
+      attributes_for :dummy_book, validate: false
+      attributes_for :dummy_credit_card, validate: :require_credit_card?
+
+      validates_numericality_of :total
+
+      def self.name
+        'Cart'
+      end
+
+      def calculate_total
+        self.total = dummy_book.price || 0.0
+      end
+
+      def require_credit_card?
+        dummy_book.price && dummy_book.price > 0.0
+      end
+    end
+  end
+
+  describe '.attributes_for' do
+    it 'adds a reader method for each attribute of the associated model' do
+      expect(model.respond_to?(:dummy_user_first_name)).to be_true
+    end
+
+    it 'adds reader and writer methods for each attribute of the associated model' do
+      model.dummy_user_first_name = 'Mo'
+      expect(model.dummy_user_first_name).to eq('Mo')
+    end
+
+    it 'adds reader methods for each associated model' do
+      expect(model.dummy_user).to be_an_instance_of(DummyUser)
+    end
+
+    it 'adds the association to the list of association names' do
+      expect(model_class.association_names).to include(:dummy_user)
+    end
+
+    describe ':validate option' do
+      context 'true or false' do
+        it 'validates associated object based value given' do
+          model.calculate_total
+          expect(model.valid?).to be_false
+          model.dummy_user_email = 'bob@example.com'
+          expect(model.valid?).to be_true
+        end
+      end
+
+      context 'method name (as a symbol) that evaluates to true or false' do
+        it 'validates associated objects based on result of method call' do
+          model.calculate_total
+          model.dummy_user_email = 'bob@example.com'
+          expect(model.valid?).to be_true
+          model.dummy_book_price = 12.95
+          expect(model.valid?).to be_false
+          model.dummy_credit_card_number = 4242424242424242
+          expect(model.valid?).to be_true
+        end
+      end
+
+      context 'invalid value' do
+        let(:bad_model_class) do
+          Class.new do
+            include Forminate
+            attributes_for :dummy_book, validate: [:say, :what?]
+          end
+        end
+
+        it 'raises an NotImplemented error' do
+          expect { bad_model_class.new.valid? }
+            .to raise_error(NotImplementedError)
+        end
+      end
+    end
+  end
+
+  describe '.attribute_names' do
+    it 'includes the names of its own attributes and the attributes of associated models' do
+      expected_attributes = %w(
+        total
+        tax
+        dummy_user_id
+        dummy_user_first_name
+        dummy_user_last_name
+        dummy_user_email
+        dummy_book_title
+        dummy_book_price
+        dummy_credit_card_number
+        dummy_credit_card_expiration
+        dummy_credit_card_cvv
+      )
+      expect(model_class.attribute_names).to eq(expected_attributes)
+    end
+  end
+
+  describe '.association_names' do
+    it 'includes the names of associated models' do
+      expect(model_class.association_names)
+        .to eq([:dummy_user, :dummy_book, :dummy_credit_card])
+    end
+  end
+
+  describe '.association_validations' do
+    it 'includes the names and conditions of association validations' do
+      expect(model_class.association_validations)
+        .to eq(
+          dummy_user: true,
+          dummy_book: false,
+          dummy_credit_card: :require_credit_card?
+        )
+    end
+  end
+
+  describe '#initialize' do
+    it 'builds associated objects and creates reader methods' do
+      expect(model.dummy_user).to be_an_instance_of(DummyUser)
+    end
+
+    it 'creates writer methods for associated objects' do
+      new_dummy_user = DummyUser.new(first_name: 'Mo')
+      expect(model.dummy_user).to_not be(new_dummy_user)
+      model.dummy_user = new_dummy_user
+      expect(model.dummy_user).to be(new_dummy_user)
+    end
+
+    it 'sets association attributes based on an options hash' do
+      new_model = model_class.new(
+        dummy_user_first_name: 'Mo',
+        dummy_user_last_name: 'Lawson',
+        dummy_book_title: 'The Hobbit'
+      )
+      expect(new_model.dummy_user_first_name).to eq('Mo')
+      expect(new_model.dummy_user_last_name).to eq('Lawson')
+    end
+
+    context 'primary key of an associated AR model is present' do
+      it 'populates the matching model with values from the database' do
+        user = DummyUser.create(
+          first_name: 'Mo',
+          last_name: 'Lawson',
+          email: 'mo@example.com'
+        )
+        new_model = model_class.new(dummy_user_id: user.id)
+        expect(new_model.dummy_user_first_name).to eq('Mo')
+      end
+    end
+
+    it 'sets attributes based on an options hash' do
+      new_model = model_class.new(total: 21.49)
+      expect(new_model.total).to eq(21.49)
+    end
+  end
+
+  describe '#association_names' do
+    it 'delegates to self.association_names' do
+      expect(model.association_names).to eq(model_class.association_names)
+    end
+  end
+
+  describe '#associations' do
+    it 'returns a hash of association names and associated objects' do
+      expect(model.associations[:dummy_user]).to be_an_instance_of(DummyUser)
+    end
+  end
+
+  describe '#save' do
+    context 'object is valid' do
+      it 'saves associations and returns self' do
+        model.dummy_user_email = 'bob@example.com'
+        model.calculate_total
+        DummyUser.any_instance.should_receive(:save)
+        expect(model.save).to eq(model)
+      end
+    end
+
+    context 'object is not valid' do
+      it 'does not save associations and returns false' do
+        DummyUser.any_instance.should_not_receive(:save)
+        expect(model.save).to be_false
+      end
+    end
+  end
+
+  context 'setting an attribute using the attribute name' do
+    it 'reflects the change on the associated object' do
+      model.dummy_user_first_name = 'Mo'
+      expect(model.dummy_user.first_name).to eq('Mo')
+    end
+  end
+
+  context "setting an attribute using the association's attribute" do
+    it 'reflects the change on the attribute name' do
+      model.dummy_user.last_name = 'Lawson'
+      expect(model.dummy_user_last_name).to eq('Lawson')
+    end
+  end
+
+  describe '#method_missing' do
+    context 'associated object responds to method' do
+      it 'returns the value from the association' do
+        new_model = model_class.new(dummy_user_temporary_note: 'Only stopping by')
+        expect(new_model.dummy_user_temporary_note).to eq('Only stopping by')
+      end
+    end
+
+    context 'associated object does not respond to method' do
+      it 'raises a NoMethodError' do
+        expect { model.dummy_user_bogus_method }.to raise_error(NoMethodError)
+      end
+    end
+  end
+
+  describe '#respond_to_missing?' do
+    context 'associated object responds to method' do
+      it 'returns true' do
+        expect(model.respond_to?(:dummy_user_temporary_note)).to be_true
+      end
+    end
+
+    context 'associated object does not respond to method' do
+      it 'returns false' do
+        expect(model.respond_to?(:dummy_user_bogus_method)).to be_false
+      end
+    end
+  end
+
+  it 'delegates to attr_accessors of associated objects' do
+    model.dummy_user_temporary_note = 'Only stopping by'
+    expect(model.dummy_user.temporary_note).to eq('Only stopping by')
+    expect(model.dummy_user_temporary_note).to eq('Only stopping by')
+  end
+
+  it 'inherits the validations of its associated objects' do
+    model.valid?
+    expect(model.errors.full_messages)
+      .to eq(["Dummy user email can't be blank", 'Total is not a number'])
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,23 @@
+require 'codeclimate-test-reporter'
+CodeClimate::TestReporter.start
+
 require 'bundler/setup'
 require 'forminate'
 
+require 'active_record'
+ActiveRecord::Base.establish_connection(
+  adapter: 'sqlite3',
+  database: ':memory:'
+)
+ActiveRecord::Schema.define do
+  suppress_messages do
+    create_table :dummy_users do |t|
+      t.string :first_name
+      t.string :last_name
+      t.string :email
+    end
+  end
+end
+
 # Requires supporting files in spec/support/
 Dir["#{File.dirname(__FILE__)}/support/*.rb"].each { |file| require file }

data/spec/support/dummy_book.rb

@@ -1,5 +1,3 @@
-require 'active_attr'
-
 class DummyBook
   include ActiveAttr::Model
 

data/spec/support/dummy_credit_card.rb

@@ -1,5 +1,3 @@
-require 'active_attr'
-
 class DummyCreditCard
   include ActiveAttr::Model
 

data/spec/support/dummy_user.rb

@@ -1,17 +1,5 @@
-require 'active_attr'
-
-class DummyUser
-  include ActiveAttr::Model
-
-  attribute :first_name
-  attribute :last_name
-  attribute :email
-
-  attr_accessor :full_name
-
+class DummyUser < ActiveRecord::Base
   validates_presence_of :email
 
-  def save
-    # fake a persisted model
-  end
+  attr_accessor :temporary_note
 end

metadata

@@ -1,125 +1,157 @@
 --- !ruby/object:Gem::Specification
 name: forminate
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Mo Lawson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-06 00:00:00.000000000 Z
+date: 2014-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.2
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '4.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.2
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '4.1'
 - !ruby/object:Gem::Dependency
   name: client_side_validations
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.11'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Form objects for Rails applications
 email:
-- moklawson@gmail.com
+- mo@molawson.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - forminate.gemspec
 - lib/forminate.rb
+- lib/forminate/association_builder.rb
+- lib/forminate/association_definition.rb
 - lib/forminate/client_side_validations.rb
 - lib/forminate/version.rb
-- spec/lib/forminate/client_side_validations.rb
-- spec/lib/forminate/client_side_validations_spec.rb
-- spec/lib/forminate_spec.rb
+- spec/forminate/association_builder_spec.rb
+- spec/forminate/association_definition_spec.rb
+- spec/forminate/client_side_validations.rb
+- spec/forminate/client_side_validations_spec.rb
+- spec/forminate_spec.rb
 - spec/spec_helper.rb
 - spec/support/dummy_book.rb
 - spec/support/dummy_credit_card.rb
@@ -134,24 +166,26 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Create form objects from multiple Active Record and/or ActiveAttr models.
 test_files:
-- spec/lib/forminate/client_side_validations.rb
-- spec/lib/forminate/client_side_validations_spec.rb
-- spec/lib/forminate_spec.rb
+- spec/forminate/association_builder_spec.rb
+- spec/forminate/association_definition_spec.rb
+- spec/forminate/client_side_validations.rb
+- spec/forminate/client_side_validations_spec.rb
+- spec/forminate_spec.rb
 - spec/spec_helper.rb
 - spec/support/dummy_book.rb
 - spec/support/dummy_credit_card.rb