format_parser 0.22.0 → 0.22.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13d1f2a3748d62b027f80b1d6c46f8d087ddfc9cbeadeb62b330fa397797b847
-  data.tar.gz: eea08816482a939538aa1400ba6ca29af864f33ac12d960cbad8806d0e13a9c8
+  metadata.gz: 05470fef0edec68c427b9680cf94a88a8f3286e2279b2daf13e87679324eb061
+  data.tar.gz: f65ed1d390e4e70bd34a3b01b5d54d39e4076d18ebf15fc20196c2746c86122f
 SHA512:
-  metadata.gz: d21c310453155285236e3469ad9980df4d408b00b989fa5a9ed330f39c0c4f5a65ebfb84a79d7f9d7c9761c9dbf27958b8b44a5e8176f79cbf340b011279a0c0
-  data.tar.gz: 0e8949ac9c1ac6624f27539fe33f52c28c7e5b9c2cce83d9c752372653e35c0231d9a087cff88c9ea87585eaa7dcd8d6878a1345b5b914554d4a5691f11dce60
+  metadata.gz: e6e9e2d1fbfe6e813d1e0d9d2c102ce3f031fd37395cc75807ca7b527b1a2fc4a9a3c41baaf9e2cdaa601063cded92ef446ce913f2210f3d82e063126873d54d
+  data.tar.gz: 86e166b2ac754fe5d7e42e471bcaa70cd54ae0aa22da3e0f85a6223213c2bd5a284f2b53416d03656dc291898837636678dbfba2e32b179a562ea7c8b05ef0bf

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.22.1
+* Fix Zip parser to not raise error for invalid zip files, with an invalid central directory
+
 ## 0.22.0
 * Adds option `stringify_keys: true` to #as_json methods (fix #151)
 

data/CONTRIBUTING.md

@@ -234,4 +234,9 @@ This provision also applies to the test files you include with the changed code
 
 ## Changelog
 
-When creating a new release you must add an entry in the `CHANGELOG.md`.
+When creating a new release you must add an entry in the `CHANGELOG.md`.
+
+## Testing locally
+
+It's possible to run `exe/format_parser_inspect FILE_NAME` or `exe/format_parser_inspect FILE_URI`
+to test the new code without the necessity of installing the gem.

data/lib/format_parser/version.rb

@@ -1,3 +1,3 @@
 module FormatParser
-  VERSION = '0.22.0'
+  VERSION = '0.22.1'
 end

data/lib/parsers/zip_parser/file_reader.rb

@@ -18,6 +18,7 @@ class FormatParser::ZIPParser::FileReader
       'Could not find the EOCD signature in the buffer - maybe a malformed ZIP file'
     end
   end
+  InvalidCentralDirectory = Class.new(Error)
 
   C_UINT32LE = 'V'
   C_UINT16LE = 'v'
@@ -175,6 +176,8 @@ class FormatParser::ZIPParser::FileReader
     # BUT! in format_parser we avoid unbounded reads, as a matter of fact they are forbidden.
     # So we will again limit ouselves to cdir_size, and we will take cushion of 1 KB.
     central_directory_str = io.read(cdir_size + 1024)
+    raise InvalidCentralDirectory if central_directory_str.nil?
+
     central_directory_io = StringIO.new(central_directory_str)
     log do
       format(

data/spec/parsers/zip_parser_spec.rb

@@ -103,4 +103,11 @@ describe FormatParser::ZIPParser do
     expect(first_entry.filename).to eq('Li��nia Extreme//')
     expect(first_entry.type).to eq(:directory)
   end
+
+  it 'is able to handle files with invalid central directory position' do
+    invalid_zip_path = fixtures_dir + '/ZIP/invalid_central_directory.zip'
+
+    expect { subject.call(File.open(invalid_zip_path, 'rb')) }
+      .to_not raise_error
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: format_parser
 version: !ruby/object:Gem::Version
-  version: 0.22.0
+  version: 0.22.1
 platform: ruby
 authors:
 - Noah Berman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-15 00:00:00.000000000 Z
+date: 2020-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ks
@@ -293,7 +293,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A library for efficient parsing of file metadata