format_parser 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aac884390c22699e4c3508ef5ecd363d2f1d2b5a
-  data.tar.gz: da10c68c25b0ba46929282a1bcd918e9bf4513b1
+  metadata.gz: 606211b4e5b24b26244fdc1a869e9e3c3a1960ea
+  data.tar.gz: c8da075299f9373ababeaffe28454c94329adf2b
 SHA512:
-  metadata.gz: 74efa5fe85532815e9475e711af8cfc6a2a4478c1832479ec073f7fdecdf4ed2997a61d2c5e068fe6013cd8fb9fbea7c16eaf1bc109485dde7d469b4cec62342
-  data.tar.gz: 2a8da42f8d4f49dff0b7c76393d5c9385ef109ada91d539235d5afbef98689e5f99ca4a5b9a99843c109d2665ea1c4843192d3cf9c25d4ccb3117c98c25fb455
+  metadata.gz: ff3f7310ba2ff1b414b03b066bbddc42ee80fd448e51dfccb11d2bfe4a9d088d4b92b4e4c9cfcbf39173a9d69c627125b112cc4e7902d66080b113751f9a3b2e
+  data.tar.gz: 2e6146596b92f490641d41d48e71d51486900edcd7aa25a060345e7ee7c6d6272220a7a019d047b67296d9e9f7a062b3af431817b624b8c1c11891c422eaf14c

data/.rubocop.yml

@@ -0,0 +1,2 @@
+inherit_gem:
+  wetransfer_style: ruby/default.yml

data/.travis.yml

@@ -8,4 +8,5 @@ matrix:
   allow_failures:
     - rvm: jruby-9.0
 script:
+  - bundle exec rubocop
   - bundle exec rspec

data/README.md

@@ -1,5 +1,6 @@
 # format_parser
 
+
 is a Ruby library for prying open video, image, document, and audio files.
 It includes a number of parser modules that try to recover metadata useful for post-processing and layout while reading the absolute
 minimum amount of data possible.
@@ -7,35 +8,37 @@ minimum amount of data possible.
 `format_parser` is inspired by [imagesize,](https://rubygems.org/gem/imagesize) [fastimage](https://github.com/sdsykes/fastimage)
 and [dimensions,](https://github.com/sstephenson/dimensions) borrowing from them where appropriate.
 
+[![Gem Version](https://badge.fury.io/rb/format_parser.svg)](https://badge.fury.io/rb/format_parser) [![Build Status](https://travis-ci.org/WeTransfer/format_parser.svg?branch=master)](https://travis-ci.org/WeTransfer/format_parser)
+
 ## Currently supported filetypes:
 
 `TIFF, PSD, PNG, MP3, JPEG, GIF, DPX, AIFF, WAV, FDX, MOV, MP4`
 
-...with more on the way!
+...with [more](https://github.com/WeTransfer/format_parser/issues?q=is%3Aissue+is%3Aopen+label%3Aformats) on the way!
 
 ## Basic usage
 
-Pass an IO object that responds to `read` and `seek` to `FormatParser` and an array of matches will be returned.
+Pass an IO object that responds to `read` and `seek` to `FormatParser` and the first confirmed match will be returned.
 
 ```ruby
-matches = FormatParser.parse(File.open("myimage.jpg", "rb"))
-matches.first.nature        #=> :image
-matches.first.format        #=> :jpg
-matches.first.width_px      #=> 320
-matches.first.height_px     #=> 240
-matches.first.orientation   #=> :top_left
+match = FormatParser.parse(File.open("myimage.jpg", "rb"))
+match.nature        #=> :image
+match.format        #=> :jpg
+match.width_px      #=> 320
+match.height_px     #=> 240
+match.orientation   #=> :top_left
 ```
 
-If you would rather receive only one result, call the gem as follows:
+If you would rather receive all potential results from the gem, call the gem as follows:
 
 ```ruby
-FormatParser.parse(File.open("myimage.jpg", "rb"), returns: :one)
+FormatParser.parse(File.open("myimage.jpg", "rb"), results: :all)
 ```
 
 You can also optimize the metadata extraction by providing hints to the gem:
 
 ```ruby
-FormatParser.parse(File.open("myimage", "rb"), natures: [:video, :image], formats: [:jpg, :png, :mp4])
+FormatParser.parse(File.open("myimage", "rb"), natures: [:video, :image], formats: [:jpg, :png, :mp4], results: :all)
 ```
 
 ## Creating your own parsers

data/format_parser.gemspec

@@ -1,42 +1,42 @@
-# coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'format_parser/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "format_parser"
+  spec.name          = 'format_parser'
   spec.version       = FormatParser::VERSION
   spec.authors       = ['Noah Berman', 'Julik Tarkhanov']
   spec.email         = ['noah@noahberman.org', 'me@julik.nl']
   spec.licenses      = ['MIT']
-  spec.summary       = "A library for efficient parsing of file metadata"
+  spec.summary       = 'A library for efficient parsing of file metadata'
   spec.description   = "A Ruby library for prying open files you can convert to a previewable format, such as video, image and audio files. It includes
   a number of parser modules that try to recover metadata useful for post-processing and layout while reading the absolute
   minimum amount of data possible."
-  spec.homepage      = "https://github.com/WeTransfer/format_parser"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/WeTransfer/format_parser'
+  spec.license       = 'MIT'
   # Alert people to a change in the gem's interface, will remove in a subsequent version
   spec.post_install_message = %q{
     -----------------------------------------------------------------------------
-    | ATTENTION: format_parser v0.2.0 introduces changes to the gem's interface.|
+    | ALERT: format_parser **v0.3.0** introduces changes to the gem's interface.|
     | See https://github.com/WeTransfer/format_parser#basic-usage               |
     | for up-to-date usage instructions. Thank you for using format_parser! :)  |
     -----------------------------------------------------------------------------
   }
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = "https://rubygems.org"
+    spec.metadata['allowed_push_host'] = 'https://rubygems.org'
   else
-    raise "RubyGems 2.0 or newer is required to protect against public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.'
   end
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     # Make sure large fixture files are not packaged with the gem every time
     f.match(%r{^spec/fixtures/})
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   spec.add_dependency 'ks', '~> 0.0.1'
   spec.add_dependency 'exifr', '~> 1.0'
@@ -47,4 +47,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov', '~> 0.15'
   spec.add_development_dependency 'pry', '~> 0.11'
   spec.add_development_dependency 'yard', '~> 0.9'
+  spec.add_development_dependency 'wetransfer_style', '0.4.0'
 end

data/lib/care.rb

@@ -7,8 +7,9 @@ class Care
   DEFAULT_PAGE_SIZE = 16 * 1024
 
   class IOWrapper
-    def initialize(io, cache=Cache.new(DEFAULT_PAGE_SIZE))
-      @io, @cache = io, cache
+    def initialize(io, cache = Cache.new(DEFAULT_PAGE_SIZE))
+      @io = io
+      @cache = cache
       @pos = 0
     end
 
@@ -26,8 +27,9 @@ class Care
 
     def read(n_bytes)
       return '' if n_bytes == 0 # As hardcoded for all Ruby IO objects
+      raise ArgumentError, "negative length #{n_bytes} given" if n_bytes < 0 # also as per Ruby IO objects
       read = @cache.byteslice(@io, @pos, n_bytes)
-      return nil unless read && !read.empty?
+      return unless read && !read.empty?
       @pos += read.bytesize
       read
     end
@@ -40,10 +42,6 @@ class Care
       clear
       @io.close if @io.respond_to?(:close)
     end
-
-    def size
-      @io.size
-    end
   end
 
   # Stores cached pages of data from the given IO as strings.
@@ -51,7 +49,7 @@ class Care
   class Cache
     def initialize(page_size = DEFAULT_PAGE_SIZE)
       @page_size = page_size.to_i
-      raise ArgumentError, "The page size must be a positive Integer" unless @page_size > 0
+      raise ArgumentError, 'The page size must be a positive Integer' unless @page_size > 0
       @pages = {}
       @lowest_known_empty_page = nil
     end
@@ -72,7 +70,7 @@ class Care
       first_page = at / @page_size
       last_page = (at + n_bytes) / @page_size
 
-      relevant_pages = (first_page..last_page).map{|i| hydrate_page(io, i) }
+      relevant_pages = (first_page..last_page).map { |i| hydrate_page(io, i) }
 
       # Create one string combining all the pages which are relevant for
       # us - it is much easier to address that string instead of piecing
@@ -96,11 +94,7 @@ class Care
 
       # Returning an empty string from read() is very confusing for the caller,
       # and no builtins do this - if we are at EOF we should return nil
-      if slice && !slice.empty?
-        slice
-      else
-        nil
-      end
+      slice if slice && !slice.empty?
     end
 
     def clear
@@ -110,9 +104,7 @@ class Care
     def hydrate_page(io, page_i)
       # Avoid trying to read the page if we know there is no content to fill it
       # in the underlying IO
-      if @lowest_known_empty_page && page_i >= @lowest_known_empty_page
-        return nil
-      end
+      return if @lowest_known_empty_page && page_i >= @lowest_known_empty_page
 
       @pages[page_i] ||= read_page(io, page_i)
     end

data/lib/format_parser.rb

@@ -1,5 +1,3 @@
-require 'thread'
-
 module FormatParser
   require_relative 'image'
   require_relative 'audio'
@@ -28,7 +26,7 @@ module FormatParser
     end
   end
 
-  def self.parse_http(url)
+  def self.parse_http(url, **kwargs)
     remote_io = RemoteIO.new(url)
     cached_io = Care::IOWrapper.new(remote_io)
 
@@ -36,25 +34,27 @@ module FormatParser
     # by all parsers anyway. Additionally, when using RemoteIO we need
     # to explicitly obtain the size of the resource, which is only available
     # after having performed at least one successful GET - at least on S3
-    cached_io.read(1); cached_io.seek(0)
+    cached_io.read(1)
+    cached_io.seek(0)
 
-    parse(cached_io)
+    parse(cached_io, **kwargs)
   end
 
-  def self.parse(io, natures: @natures.to_a, formats: @formats.to_a, returns: :all)
+  # Return all by default
+  def self.parse(io, natures: @natures.to_a, formats: @formats.to_a, results: :first)
     # If the cache is preconfigured do not apply an extra layer. It is going
     # to be preconfigured when using parse_http.
     io = Care::IOWrapper.new(io) unless io.is_a?(Care::IOWrapper)
 
     # How many results has the user asked for? Used to determinate whether an array
     # is returned or not.
-    amount = case returns
+    amount = case results
              when :all
                @parsers.count
-             when :one
+             when :first
                1
              else
-               throw ArgumentError.new(":returns does not match any supported mode (:all, :one)")
+               throw ArgumentError.new(':results does not match any supported mode (:all, :first)')
              end
 
     # Always instantiate parsers fresh for each input, since they might
@@ -64,7 +64,7 @@ module FormatParser
       # We need to rewind for each parser, anew
       io.seek(0)
       # Limit how many operations the parser can perform
-      limited_io = ReadLimiter.new(io, max_bytes: 512*1024, max_reads: 64*1024, max_seeks: 64*1024)
+      limited_io = ReadLimiter.new(io, max_bytes: 512 * 1024, max_reads: 64 * 1024, max_seeks: 64 * 1024)
       begin
         parser.call(limited_io)
       rescue IOUtils::InvalidRead
@@ -82,14 +82,12 @@ module FormatParser
     results.to_a
   end
 
-  private
-
   def self.parsers_for(natures, formats)
     # returns lazy enumerator for only computing the minimum amount of work (see :returns keyword argument)
     @parsers.map(&:new).select do |parser|
       # Do a given parser contain any nature and/or format asked by the user?
       (natures & parser.natures).size > 0 && (formats & parser.formats).size > 0
-      end.lazy
+    end.lazy
   end
 
   Dir.glob(__dir__ + '/parsers/*.rb').sort.each do |parser_file|

data/lib/format_parser/version.rb

@@ -1,3 +1,3 @@
 module FormatParser
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/lib/io_constraint.rb

@@ -19,15 +19,15 @@ class FormatParser::IOConstraint
   def initialize(io)
     @io = io
   end
-  
+
   def read(n_bytes)
     @io.read(n_bytes)
   end
-  
+
   def seek(absolute_offset)
     @io.seek(absolute_offset)
   end
-  
+
   def size
     @io.size
   end

data/lib/io_utils.rb

@@ -3,12 +3,10 @@ module FormatParser::IOUtils
   end
 
   def safe_read(io, n)
-    if n.nil?
-      raise ArgumentError, "Unbounded reads are not supported"
-    end
+    raise ArgumentError, 'Unbounded reads are not supported' if n.nil?
     buf = io.read(n)
 
-    if !buf
+    unless buf
       raise InvalidRead, "We wanted to read #{n} bytes from the IO, but the IO is at EOF"
     end
     if buf.bytesize != n
@@ -19,15 +17,11 @@ module FormatParser::IOUtils
   end
 
   def safe_skip(io, n)
-    if n.nil?
-      raise ArgumentError, "Unbounded skips are not supported"
-    end
+    raise ArgumentError, 'Unbounded skips are not supported' if n.nil?
 
     return if n == 0
 
-    if n < 0
-      raise InvalidRead, "Negative skips are not supported"
-    end
+    raise InvalidRead, 'Negative skips are not supported' if n < 0
 
     if io.respond_to?(:pos)
       io.seek(io.pos + n)

data/lib/parsers/aiff_parser.rb

@@ -25,11 +25,11 @@ class FormatParser::AIFFParser
   def call(io)
     io = FormatParser::IOConstraint.new(io)
     form_chunk_type, chunk_size = safe_read(io, 8).unpack('a4N')
-    return unless form_chunk_type == "FORM" && chunk_size > 4
+    return unless form_chunk_type == 'FORM' && chunk_size > 4
 
     fmt_chunk_type = safe_read(io, 4)
-    
-    return unless fmt_chunk_type == "AIFF"
+
+    return unless fmt_chunk_type == 'AIFF'
 
     # There might be COMT chunks, for example in Logic exports
     loop do
@@ -49,16 +49,15 @@ class FormatParser::AIFFParser
         safe_skip(io, chunk_size)
         next
       else # This most likely not an AIFF
-        return nil
+        return
       end
     end
   end
 
   def unpack_comm_chunk(io)
     # Parse the COMM chunk
-    channels, sample_frames, sample_size, sample_rate_extended = safe_read(io, 2 + 4 + 2 + 10).unpack('nNna10')
+    channels, sample_frames, _sample_size, sample_rate_extended = safe_read(io, 2 + 4 + 2 + 10).unpack('nNna10')
     sample_rate = unpack_extended_float(sample_rate_extended)
-    bytes_per_sample = (sample_size - 1) / 8 + 1
 
     return unless sample_frames > 0
 
@@ -71,18 +70,18 @@ class FormatParser::AIFFParser
       num_audio_channels: channels,
       audio_sample_rate_hz: sample_rate.to_i,
       media_duration_frames: sample_frames,
-      media_duration_seconds: duration_in_seconds,
+      media_duration_seconds: duration_in_seconds
     )
   end
- 
+
   def unpack_extended_float(ten_bytes_string)
     extended = ten_bytes_string.unpack('B80')[0]
 
     sign = extended[0, 1]
     exponent = extended[1, 15].to_i(2) - ((1 << 14) - 1)
     fraction = extended[16, 64].to_i(2)
-  
-    ((sign == '1') ? -1.0 : 1.0) * (fraction.to_f / ((1 << 63) - 1)) * (2 ** exponent)
+
+    (sign == '1' ? -1.0 : 1.0) * (fraction.to_f / ((1 << 63) - 1)) * (2**exponent)
   end
 
   FormatParser.register_parser_constructor self

data/lib/parsers/dpx_parser.rb

@@ -6,7 +6,7 @@ class FormatParser::DPXParser
   formats :dpx
 
   FILE_INFO = [
-#    :x4,   # magic bytes SDPX, we read them anyway so not in the pattern
+    #    :x4,   # magic bytes SDPX, we read them anyway so not in the pattern
     :x4,   # u32  :image_offset,   :desc => 'Offset to image data in bytes', :req => true
     :x8,   # char :version, 8,     :desc => 'Version of header format', :req => true
     :x4,   # u32  :file_size,      :desc => "Total image size in bytes", :req => true
@@ -20,48 +20,48 @@ class FormatParser::DPXParser
     :x200, # char :project, 200,   :desc => 'Project name'
     :x200, # char :copyright, 200, :desc => 'Copyright'
     :x4,   # u32  :encrypt_key,   :desc => 'Encryption key'
-    :x104,  # blanking :reserve, 104
+    :x104, # blanking :reserve, 104
   ].join
 
   FILM_INFO = [
-    :x2, # char :id, 2,          :desc => 'Film mfg. ID code (2 digits from film edge code)'
-    :x2, # char :type, 2,        :desc => 'Film type (2 digits from film edge code)'
-    :x2, # char :offset, 2,      :desc => 'Offset in perfs (2 digits from film edge code)'
-    :x6, # char :prefix, 6,      :desc => 'Prefix (6 digits from film edge code'
-    :x4, # char :count, 4,       :desc => 'Count (4 digits from film edge code)'
-    :x32,# char :format, 32,     :desc => 'Format (e.g. Academy)'
-    :x4, # u32 :frame_position,  :desc => 'Frame position in sequence'
-    :x4, # u32 :sequence_extent, :desc => 'Sequence length'
-    :x4, # u32 :held_count,      :desc => 'For how many frames the frame is held'
-    :x4, # r32 :frame_rate,      :desc => 'Frame rate'
-    :x4, # r32 :shutter_angle,   :desc => 'Shutter angle'
-    :x4, # char :frame_id, 32,   :desc => 'Frame identification (keyframe)'
-    :x4, # char :slate, 100,     :desc => 'Slate information'
-    :x4, # blanking :reserve, 56
+    :x2,  # char :id, 2,          :desc => 'Film mfg. ID code (2 digits from film edge code)'
+    :x2,  # char :type, 2,        :desc => 'Film type (2 digits from film edge code)'
+    :x2,  # char :offset, 2,      :desc => 'Offset in perfs (2 digits from film edge code)'
+    :x6,  # char :prefix, 6,      :desc => 'Prefix (6 digits from film edge code'
+    :x4,  # char :count, 4,       :desc => 'Count (4 digits from film edge code)'
+    :x32, # char :format, 32,     :desc => 'Format (e.g. Academy)'
+    :x4,  # u32 :frame_position,  :desc => 'Frame position in sequence'
+    :x4,  # u32 :sequence_extent, :desc => 'Sequence length'
+    :x4,  # u32 :held_count,      :desc => 'For how many frames the frame is held'
+    :x4,  # r32 :frame_rate,      :desc => 'Frame rate'
+    :x4,  # r32 :shutter_angle,   :desc => 'Shutter angle'
+    :x4,  # char :frame_id, 32,   :desc => 'Frame identification (keyframe)'
+    :x4,  # char :slate, 100,     :desc => 'Slate information'
+    :x4,  # blanking :reserve, 56
   ].join
 
   IMAGE_ELEMENT = [
-    :x4, # u32 :data_sign, :desc => 'Data sign (0=unsigned, 1=signed). Core is unsigned', :req => true
+    :x4,  # u32 :data_sign, :desc => 'Data sign (0=unsigned, 1=signed). Core is unsigned', :req => true
     #
-    :x4, # u32 :low_data,      :desc => 'Reference low data code value'
-    :x4, # r32 :low_quantity,  :desc => 'Reference low quantity represented'
-    :x4, # u32 :high_data,     :desc => 'Reference high data code value (1023 for 10bit per channel)'
-    :x4, # r32 :high_quantity, :desc => 'Reference high quantity represented'
+    :x4,  # u32 :low_data,      :desc => 'Reference low data code value'
+    :x4,  # r32 :low_quantity,  :desc => 'Reference low quantity represented'
+    :x4,  # u32 :high_data,     :desc => 'Reference high data code value (1023 for 10bit per channel)'
+    :x4,  # r32 :high_quantity, :desc => 'Reference high quantity represented'
     #
-    :x1, # u8 :descriptor,   :desc => 'Descriptor for this image element (ie Video or Film), by enum', :req => true
+    :x1,  # u8 :descriptor,   :desc => 'Descriptor for this image element (ie Video or Film), by enum', :req => true
     # TODO - colirimetry information might be handy to recover,
     # as well as "bit size per element" (how many bits _per component_ we have) -
     # this will be different for, say, 8-bit DPX files versus 10-bit etc.
-    :x1, # u8 :transfer,     :desc => 'Transfer function (ie Linear), by enum', :req => true
-    :x1, # u8 :colorimetric, :desc => 'Colorimetric (ie YcbCr), by enum', :req => true
-    :x1, # u8 :bit_size,     :desc => 'Bit size for element (ie 10)', :req => true
+    :x1,  # u8 :transfer,     :desc => 'Transfer function (ie Linear), by enum', :req => true
+    :x1,  # u8 :colorimetric, :desc => 'Colorimetric (ie YcbCr), by enum', :req => true
+    :x1,  # u8 :bit_size,     :desc => 'Bit size for element (ie 10)', :req => true
     #
-    :x2, # u16 :packing,     :desc => 'Packing (0=Packed into 32-bit words, 1=Filled to 32-bit words))', :req => true
-    :x2, # u16 :encoding,    :desc => "Encoding (0=None, 1=RLE)", :req => true
-    :x4, # u32 :data_offset, :desc => 'Offset to data for this image element', :req => true
-    :x4, # u32 :end_of_line_padding, :desc => "End-of-line padding for this image element"
-    :x4, # u32 :end_of_image_padding, :desc => "End-of-line padding for this image element"
-    :x32,# char :description, 32
+    :x2,  # u16 :packing,     :desc => 'Packing (0=Packed into 32-bit words, 1=Filled to 32-bit words))', :req => true
+    :x2,  # u16 :encoding,    :desc => "Encoding (0=None, 1=RLE)", :req => true
+    :x4,  # u32 :data_offset, :desc => 'Offset to data for this image element', :req => true
+    :x4,  # u32 :end_of_line_padding, :desc => "End-of-line padding for this image element"
+    :x4,  # u32 :end_of_image_padding, :desc => "End-of-line padding for this image element"
+    :x32, # char :description, 32
   ].join
 
   IMAGE_INFO = [
@@ -93,7 +93,7 @@ class FormatParser::DPXParser
     :x4,
     :x4,
 
-    # TODO - the aspect ratio might be handy to recover since it
+    # TODO: - the aspect ratio might be handy to recover since it
     # will be used in DPX files in, say, anamorphic (non-square pixels)
     :x4,   #  array :aspect_ratio , :u32, 2, :desc => "Aspect (H:V)"
     :x4,
@@ -107,16 +107,16 @@ class FormatParser::DPXParser
     ORIENTATION_INFO,
   ].join
 
-  DPX_INFO_LE = DPX_INFO.tr("n", "v").tr("N", "V")
+  DPX_INFO_LE = DPX_INFO.tr('n', 'v').tr('N', 'V')
 
   SIZEOF = ->(pattern) {
     bytes_per_element = {
-      "v" => 2, # 16bit uints
-      "n" => 2,
-      "V" => 4, # 32bit uints
-      "N" => 4,
-      "C" => 1,
-      "x" => 1,
+      'v' => 2, # 16bit uints
+      'n' => 2,
+      'V' => 4, # 32bit uints
+      'N' => 4,
+      'C' => 1,
+      'x' => 1,
     }
     pattern.scan(/[^\d]\d+/).map do |pattern|
       unpack_code = pattern[0]
@@ -133,15 +133,15 @@ class FormatParser::DPXParser
     io = FormatParser::IOConstraint.new(io)
     magic = io.read(4)
 
-    return nil unless [BE_MAGIC, LE_MAGIC].include?(magic)
+    return unless [BE_MAGIC, LE_MAGIC].include?(magic)
 
     unpack_pattern = DPX_INFO
     unpack_pattern = DPX_INFO_LE if magic == LE_MAGIC
-    num_elements, pixels_per_line, num_lines, *_ = safe_read(io, HEADER_SIZE).unpack(unpack_pattern)
+    _num_elements, pixels_per_line, num_lines, *_ = safe_read(io, HEADER_SIZE).unpack(unpack_pattern)
     FormatParser::Image.new(
       format: :dpx,
       width_px: pixels_per_line,
-      height_px: num_lines,
+      height_px: num_lines
     )
   end