form_props 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cff106aa823f714feedeca5bcb60009c1e699fd3e5caf04213aff7b5453bebf1
-  data.tar.gz: dec35c8f4b7eaf8233b1dc5ba018b08d2d71275a9e5251e82c18c68190e8b10f
+  metadata.gz: e3200a705c61ab6b0ebae4316cb80874b53ee0be1297e1230632e8b4568d7054
+  data.tar.gz: e0f83bff9ce077fee68002cedc1a0906d4139aff509fe514c73a4e085c82a386
 SHA512:
-  metadata.gz: 3bfdfa243ba6534c73b837472bd1e9718b19ca0c99ecc7cc177389a6d4474c4042a634f5ac2a0f68e32484b6895e024b433266d7c670cda6199dfa0a82929154
-  data.tar.gz: 5afc0d65c6d09a6bbfde9c31dc9fc489499cfa69f489cd45626ebf4342da1bd1e8524ec4fab46af87d6778cef9fd445a2b45585d7462143298a113fc13efcb94
+  metadata.gz: 6054204836874c8cebb5fa3f9cfd6f84fb3cb5c96f27ac9945683dc5e2aac73fe4be3a652dd64d3cfab33bfc70703fb2283fcf553d1908eaba46a0b4c10a8c7c
+  data.tar.gz: d586f6ebb862c1e75fe55056cdf7138dc72db2a0e3f2c847563524d2889d44b5afb16dc4135681b7524e80c4d2081ae08719fdd46951e3a14631fa73fa84a504

data/README.md

@@ -1,10 +1,9 @@
 # Form Props
 
-![Build Status](https://github.com/github/docs/actions/workflows/build.yml/badge.svg?branch=main)
+![Build Status](https://github.com/thoughtbot/form_props/actions/workflows/build.yml/badge.svg?branch=main)
 
-FormProps is a Rails form builder that outputs HTML attributes instead of tags.
-Now you can enjoy the conviences of Rails helpers in other view libraries like
-React, and React Native.
+FormProps is a Rails form builder that outputs HTML props instead of tags. Now
+you can enjoy the power and convenience of Rails helpers in React!
 
 By separting attributes from tags, FormProps can offer greater flexbility than normal
 Rails form builders; allowing designers to stay longer in HTML land and more easily
@@ -26,7 +25,7 @@ gem "form_props"
 and `bundle install`
 
 ## Usage
-`form_props` is designed to be used in a [PropsTemplate] template (it can work with 
+`form_props` is designed to be used in a [PropsTemplate] template (it can work with
 [jbuilder](#jbuilder)). For example in your `new.json.props`:
 
 ```ruby
@@ -46,7 +45,7 @@ would output
     props: {
       id: "create-post",
       action: "/posts/123",
-      accept-charset: "UTF-8",
+      acceptCharset: "UTF-8",
       method: "post"
     },
     extras: {
@@ -54,19 +53,19 @@ would output
         name: "_method",
         type: "hidden",
         defaultValue: "patch",
-        autocomplete: "off"
+        autoComplete: "off"
       },
       utf8: {
         name: "utf8",
         type: "hidden",
         defaultValue: "\u0026#x2713;",
-        autocomplete: "off"
+        autoComplete: "off"
       }
       csrf: {
         name: "utf8",
         type: "authenticity_token",
         defaultValue: "SomeTOken!23$",
-        autocomplete: "off"
+        autoComplete: "off"
       }
     },
     inputs: {
@@ -84,12 +83,11 @@ import React from 'react'
 
 export default ({props, inputs, extras}) => {
   <form {...props}>
-    {Object.values(extras).map((hiddenProps) => (<input {...hiddenProps} type="hidden"/>))}
+    {Object.values(extras).map((hiddenProps) => (<input {...hiddenProps} key={hiddenProps.name}/>))}
 
-    <input {...inputs.title} type="text"/>
+    <input {...inputs.title} />
     <label for={inputs.title.id}>Your Name</label>
-
-    <input {...inputs.submit} type="submit"/>
+    <button {...inputs.submit}>{inputs.submit.text}</button>
   </form>
 }
 ```
@@ -649,7 +647,7 @@ available.
 
 ## jbuilder
 
-form_props can work with jbuilder, but needs an extra call in the beginning of 
+form_props can work with jbuilder, but needs an extra call in the beginning of
 your template to `FormProps.set` to inject `json`. For example.
 
 ```ruby

data/lib/form_props/action_view_extensions/form_helper.rb

@@ -40,6 +40,7 @@ module FormProps
         end
 
         html_options = html_options_for_form_with(url, model, **options)
+        html_options["acceptCharset"] ||= html_options.delete("accept-charset")
 
         json.extras do
           extra_props_for_form(json, html_options)
@@ -62,7 +63,7 @@ module FormProps
             json.name request_forgery_protection_token.to_s
             json.type "hidden"
             json.default_value token
-            json.autocomplete "off"
+            json.auto_complete "off"
           end
         end
       end
@@ -72,7 +73,7 @@ module FormProps
           json.name "_method"
           json.type "hidden"
           json.default_value method.to_s
-          json.autocomplete "off"
+          json.auto_complete "off"
         end
       end
 
@@ -81,7 +82,7 @@ module FormProps
           json.name "utf8"
           json.type "hidden"
           json.default_value "✓"
-          json.autocomplete "off"
+          json.auto_complete "off"
         end
       end
 

data/lib/form_props/form_builder.rb

@@ -132,7 +132,7 @@ module FormProps
     def submit(value = nil, options = {})
       value, options = nil, value if value.is_a?(Hash)
       value ||= submit_default_value
-      options = {name: "commit", value: value}.update(options)
+      options = {name: "commit", text: value}.update(options)
 
       Inputs::Submit.new(@template, options).render
     end
@@ -140,6 +140,7 @@ module FormProps
     def fields_for_with_nested_attributes(association_name, association, options, block)
       name = "#{object_name}[#{association_name}_attributes]"
       association = convert_to_model(association)
+      json = @template.instance_variable_get(:@__json)
 
       if association.respond_to?(:persisted?)
         association = [association] if @object.public_send(association_name).respond_to?(:to_ary)
@@ -150,8 +151,8 @@ module FormProps
       if association.respond_to?(:to_ary)
         explicit_child_index = options[:child_index]
 
-        @template.json.set!("#{association_name}_attributes") do
-          @template.json.array! association do |child|
+        json.set!("#{association_name}_attributes") do
+          json.array! association do |child|
             if explicit_child_index
               options[:child_index] = explicit_child_index.call if explicit_child_index.respond_to?(:call)
             else
@@ -162,7 +163,7 @@ module FormProps
           end
         end
       elsif association
-        @template.json.set!("#{association_name}_attributes") do
+        json.set!("#{association_name}_attributes") do
           fields_for_nested_model(name, association, options, block)
         end
       end

data/lib/form_props/inputs/hidden_field.rb

@@ -4,7 +4,7 @@ module FormProps
   module Inputs
     class HiddenField < TextField
       def render
-        @options[:autocomplete] = "off"
+        @options[:auto_complete] = "off"
         super
       end
 

data/lib/form_props/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FormProps
-  VERSION = "0.0.2"
+  VERSION = "0.0.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: form_props
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Johny Ho
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-13 00:00:00.000000000 Z
+date: 2023-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -106,7 +106,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="