forking_test_runner 1.17.0 → 1.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d794c30f5c802d8bc7ac54e9f904df97920f75731f9df22f141e74a09bcf138
-  data.tar.gz: 5b80cdb62e641794f436babb17619c0ad680f93ed50878c38066b1e4d5104655
+  metadata.gz: a248306cb1a71ac76fe62cff26f468f3aa8ae39f701f6c2d6ab8ed43bc2c0491
+  data.tar.gz: a4683438d4fa23251d609568fec91e147c77325548d6d0c616e5034c6bc26efe
 SHA512:
-  metadata.gz: ecc5203c6a7c9249c83008b799fa773b7f53c40ceed7a88cb7e4bf49316d08a40b8535ee9e926521e230ef2d8cfa9b8c7317bdd473b6aff70188109f10ada905
-  data.tar.gz: 7f6832e31114fb564aa6af927dd091f1caf8c7cb09b87410db06d6a9f63779e38630f75fb21a8dd3b54eb5f65137aa347c5948b4c0157ef399effab44a0ee8ed
+  metadata.gz: a63845433bc9bef04de653f116dc20377ad1c16d7014e81f2bc16b32e02b68f6bab9b46cb9de0ea6740d86c74021381c5f457deb6fc6c212e3555f6b095948c2
+  data.tar.gz: b80c1bcb90d560d74af870dff0b44bffee28bc1a60c0a1ee0607d96361c4b00e8fb210d96734482495aabc003fe1a7ef01464e6f1838730dfed317add6871188

data/lib/forking_test_runner/cli.rb

@@ -18,7 +18,7 @@ module ForkingTestRunner
         String
       ],
       [:runtime_log, "--runtime-log FILE", "File to store runtime log in or runtime.log", String],
-      [:parallel, "--parallel NUM", "Number of parallel groups to run at once", Integer],
+      [:parallel, "--parallel [NUM]", "Number of parallel groups to run at once", Integer],
       [:group, "--group NUM[,NUM]", "What group this is (use with --groups / starts at 1)", String],
       [:groups, "--groups NUM", "How many groups there are in total (use with --group)", Integer],
       [:version, "--version", "Show version"],
@@ -28,9 +28,13 @@ module ForkingTestRunner
     class << self
       def parse_options(argv)
         options = OPTIONS.each_with_object({}) do |(setting, flag, _, type), all|
-          all[setting] = delete_argv(flag.split(' ', 2)[0], argv, type: type)
+          optional = flag.include?("[")
+          all[setting] = delete_argv(flag.split(' ', 2)[0], argv, type: type, optional: optional)
         end
 
+        # default parallel to processor count
+        options[:parallel] = Parallel.processor_count if options[:parallel] == true
+
         # show version
         if options.fetch(:version)
           puts VERSION
@@ -76,12 +80,19 @@ module ForkingTestRunner
       # so minitest / rspec can read their own options (--seed / -v ...)
       #  - keep our options clear / unambiguous to avoid overriding
       #  - read all serial non-flag arguments as tests and leave only unknown options behind
-      def delete_argv(name, argv, type: nil)
+      def delete_argv(name, argv, type: nil, optional: false)
         if type # value needed
           value =
             if (index = argv.index(name)) # user used `--foo bar` style ?
               argv.delete_at(index)
-              argv.delete_at(index) || raise(ArgumentError, "Missing argument for #{name}")
+              next_arg = argv[index]
+              if next_arg && !next_arg.start_with?("-")
+                argv.delete_at(index)
+              elsif optional
+                return true
+              else
+                raise(ArgumentError, "Missing argument for #{name}")
+              end
             else # user used `--foo=bar` style ?
               prefix = "#{name}="
               return unless (index = argv.index { |arg| arg.start_with?(prefix) })

data/lib/forking_test_runner/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ForkingTestRunner
-  VERSION = "1.17.0"
+  VERSION = "1.18.0"
 end

data/lib/forking_test_runner.rb

@@ -66,8 +66,8 @@ module ForkingTestRunner
         puts "\nResults:"
         puts(
           results
-                    .sort_by { |_, _, _, r, _| r ? 0 : 1 } # failures should be last so they are easy to find
-                    .map { |f, _, _, r, _| "#{f}: #{r ? "OK" : "Fail"}" }
+            .sort_by { |_, _, _, r, _| r ? 0 : 1 } # failures should be last so they are easy to find
+            .map { |f, _, _, r, _| "#{f}: #{r ? "OK" : "Fail"}" }
         )
         puts
       end
@@ -82,7 +82,7 @@ module ForkingTestRunner
         puts "Time: #{diff.round(2)} diff to expected"
       end
 
-      if mode = @options.fetch(:record_runtime)
+      if (mode = @options.fetch(:record_runtime))
         # store runtime log
         log = runtime_log || 'runtime.log'
         record_test_runtime(mode, results, log)
@@ -162,7 +162,7 @@ module ForkingTestRunner
       when 'simple'
         File.write(log, data)
       when 'amend'
-        if id = ENV["BUILDKITE_JOB_ID"]
+        if (id = ENV["BUILDKITE_JOB_ID"])
           slug = "#{ENV.fetch("BUILDKITE_ORG_SLUG")}-#{ENV.fetch("BUILDKITE_PIPELINE_SLUG")}"
         else
           slug = ENV.fetch("TRAVIS_REPO_SLUG").sub("/", "-")
@@ -278,10 +278,11 @@ module ForkingTestRunner
       wpipe.close
 
       buffer = +""
+      tee = !@options.fetch(:quiet) && !@options.fetch(:parallel)
 
-      while ch = rpipe.read(1)
+      while (ch = rpipe.read(tee ? 1 : 4096))
         buffer << ch
-        $stdout.write(ch) if !@options.fetch(:quiet) && !@options.fetch(:parallel) # tee
+        $stdout.write(ch) if tee
       end
 
       Process.wait(child)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forking_test_runner
 version: !ruby/object:Gem::Version
-  version: 1.17.0
+  version: 1.18.0
 platform: ruby
 authors:
 - Michael Grosser
@@ -200,7 +200,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="