forget-me-not 0.3.2.1 → 0.3.2.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTExZjc2Zjk2OWUzNWJjODVmOWU1MTM2MWUzMzJkNjk0YTIyYTNiMQ==
+    MWQ5ODI0Njg4OGM5NmEyN2Y1YWE0Njg3Njc5ODEyMTYyNjJkMjg4Yg==
   data.tar.gz: !binary |-
-    ZTEwNTAwMDA3OWE1NTM3NWMwYzM4MTIwZTEwZTU4ZWQwY2FlZjljMA==
+    OGZkMGZjMWExMWFjNDQyZjM5NjhjMzFiZmM4MzhiMDY3MjY0Njc1NQ==
 SHA512:
   metadata.gz: !binary |-
-    MjE4NjNmOGMyNTI0MmFjZWYzYjJjNzczYjFlZTc4YzM0ZGQyNjI4MjI4NzJk
-    ZWZlMjdlOTk4MzMyMTgwZGY0M2RkODcwYjZlZGI2MjRmZjNiM2E2OGYyMDli
-    ZTNlZmMwYmYwYTI2ZTgyYzkzYjZjOGIwOGVlNzMxZGZlZWQ1Zjc=
+    Y2Q2ODU1N2QzZGZjZWIxOGQ1YWQ0N2ZiYTVhNGVmMDllODNiZmU5ZjNkOTM4
+    ZGU4YTI1ZjhiNTdiYzBmNDk2NDNkYzE4MzA0ZDFiOGQ5MWEwNTE3NzY4NDRi
+    YWEwYmVjMzhlZGJmMmFhNTJjOGQ4ODFhYjRlZDFmNDM1MmE2MjE=
   data.tar.gz: !binary |-
-    N2RjYzY2YWY3YWRlZGU2MmE1MDRmZTA5MjBjY2NmYWY3NDA1Mjg5MWU0MGM3
-    NzkwYWQ5MjkwMGM4NDE5ODkyZWFhYmVlYjI1MzFiOTllNWYxZTI4NzcyYmZk
-    YzhiNDdlM2RkYzQ4ZTY1NDI2OGQwNDJhYmI4ZTI4YjUxMGFmOTc=
+    ODFkMTlkZjZlZGZiYmExNzAyYWE5MGY3MDMwOWI5YWIxMjYxZWJkNTQ1YjA0
+    M2EyNzg3NDAzOGQ0OGY3ZWNmNzc1ODEzZTc2MTJiNTM4MzBkNDc0YTE5YTQy
+    MDZjNWY4ZjQ4N2E3Y2FmMjNhODcyYzc0YmYzZDUxZTk0MDM2YTc=

data/lib/forget-me-not/cacheable.rb

@@ -119,7 +119,14 @@ module ForgetMeNot
     def self.warm(*args)
       begin
         Cacheable.cache_options_threaded = {force: true}
-        Cacheable.cachers_and_descendants.each { |cacher| cacher.cache_warm(*args) }
+
+        Cacheable.cachers_and_descendants.each do |cacher|
+          begin
+            cacher.cache_warm(*args)
+          rescue StandardError => e
+            logger.error "Exception encountered when warming #{cacher.name}: #{e.inspect}.  \n\t#{e.backtrace.join("\n\t")}"
+          end
+        end
       ensure
         Cacheable.cache_options_threaded = nil
       end

data/lib/forget-me-not/version.rb

@@ -1,3 +1,3 @@
 module ForgetMeNot
-  VERSION = '0.3.2.1'
+  VERSION = '0.3.2.2'
 end

data/spec/cacheable_spec.rb

@@ -63,6 +63,34 @@ module ForgetMeNot
 
   end
 
+  class TestClassException1
+    include Cacheable
+
+
+    class << self
+      attr_accessor :cache_warm_called
+      def cache_warm(*args)
+        self.cache_warm_called = true
+        raise "We're not going to take it"
+      end
+    end
+  end
+
+  class TestClassException2
+    include Cacheable
+
+    class << self
+      attr_accessor :cache_warm_called
+
+      def cache_warm(*args)
+        self.cache_warm_called = true
+        raise "We're not going to take it"
+      end
+    end
+
+  end
+
+
   describe Cacheable do
     before do
       Cacheable.log_cache_activity = true
@@ -104,7 +132,7 @@ module ForgetMeNot
       it 'should raise an error if called with a block on initial caching' do
         foo = TestClass.new
         expect do
-          foo.method1 {'a block'}
+          foo.method1 { 'a block' }
         end.to raise_error 'Cannot pass blocks to cached methods'
       end
 
@@ -112,7 +140,7 @@ module ForgetMeNot
         foo = TestClass.new
         foo.method1
         expect do
-          foo.method1 {'a block'}
+          foo.method1 { 'a block' }
         end.to raise_error 'Cannot pass blocks to cached methods'
       end
 
@@ -249,6 +277,16 @@ module ForgetMeNot
         expect(TestClass.count(:method4)).to eq 0
         expect(TestClass.count(:method5)).to eq 0
       end
+
+      it 'Cache warming should keep going when encountering exceptions' do
+        TestClassException1.cache_warm_called = false
+        TestClassException2.cache_warm_called = false
+
+        Cacheable.warm('foo')
+
+        expect(TestClassException1.cache_warm_called).to be_true
+        expect(TestClassException2.cache_warm_called).to be_true
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forget-me-not
 version: !ruby/object:Gem::Version
-  version: 0.3.2.1
+  version: 0.3.2.2
 platform: ruby
 authors:
 - Koan Health