forge_ops_tracker 0.15.0 → 0.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c05c6f94c7c080f7c148cc315097b8e177d34dec772d580e21cf89a7120f1b3
-  data.tar.gz: d486796b0f26b752872118cfaad2c9c184671bc596bd6c32a04cfb6a754dc171
+  metadata.gz: 81c08199bfeae97d20295b7c04a46dc3b9dd9be519d4790404b88e2ca514fbe1
+  data.tar.gz: dad1efa10164cebcbce9452c1f903812157143e871162076f09298ebf41a6ea7
 SHA512:
-  metadata.gz: e99dddf991705420ceb4d69f21ad8d5e39885f5f2f782e0747976aa2c8cb2463a4d8f56652f23f6944c40d38bc89e95475e61ecaf2079b0f106ca401d4e25d06
-  data.tar.gz: 1e5e0e69a95ddecb9411a024dcbf1817b688312131bbffc7359cb917f86d416e7d2811b1215feeb355b4ff4df3b1a2757bafe747ddc425e057e3248bb3572287
+  metadata.gz: 2a32b34300ee005cd09be7f188275091ec9ba8cf4ef2e65044176a7e6d1427feef170cbc44dbd9f7a25dcf0073b2afb6186db3db2069a5737bfdcb274e62cc7f
+  data.tar.gz: 4431641c5e95f757dd82e7af0015de824804610ee4ebf252cbe3a4db13ca5f5aa1cac5fda274a94833be652a9d6c5e25ab4406570d4790b165cf242f8490ff66

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.15.1 (2026-10-01)
+
+- Errors reported just before a process exits are now sent before it ends. Delivery runs on a
+  background thread, and a short-lived process (a rake task, a cron script, `rails runner`,
+  including the test command on a project's setup page) could exit before that thread sent them,
+  so they never arrived. On a normal exit the queue now sends what's left, waiting at most 5
+  seconds, and only in a process that reported something.
+
 ## 0.15.0 (2026-09-29)
 
 - SQL masking now also catches strings with a backslash-escaped quote (`'o\'brien'`,

data/lib/forge_ops_tracker/delivery_queue.rb

@@ -8,6 +8,11 @@ module ForgeOpsTracker
   # in each forked Puma/Passenger worker process rather than being carried
   # across a fork, which would leave it dead in the child.
   class DeliveryQueue
+    # The most a normal process exit waits for queued events to go out (see #drain): long enough for
+    # one delivery at the default open_timeout + read_timeout, short enough that an unreachable
+    # ForgeOps never holds up a deploy or a cron run for long.
+    DRAIN_TIMEOUT = 5
+
     # deliver_with names the Client method each payload goes through: :deliver (error events) by
     # default, :deliver_change for ForgeOpsTracker.record_change's own queue.
     def initialize(configuration, client: Client.new(configuration), deliver_with: :deliver)
@@ -17,6 +22,28 @@ module ForgeOpsTracker
       @queue = SizedQueue.new(configuration.queue_size)
       @mutex = Mutex.new
       @thread = nil
+      @in_flight = 0
+      @drain_registered = false
+    end
+
+    # Sends whatever is still queued, and lets a delivery already under way finish, before the
+    # process exits, within DRAIN_TIMEOUT. Without it a short-lived process (a rake task, a cron
+    # script, `rails runner`) lost every error it reported in its last moments: the worker thread
+    # dies with the process before it gets to them. Delivers here on the exiting thread rather than
+    # waiting on the worker, which in a forked child is a parent's thread that no longer runs.
+    def drain(timeout: DRAIN_TIMEOUT)
+      deadline = monotonic_now + timeout
+      while monotonic_now < deadline
+        payload = begin
+          @queue.pop(true)
+        rescue ThreadError
+          break
+        end
+        client.public_send(@deliver_with, payload)
+      end
+      sleep 0.01 while @in_flight.positive? && monotonic_now < deadline
+    rescue StandardError => e
+      log { "drain failed: #{e.class}: #{e.message}" }
     end
 
     # Enqueues a payload, dropping it silently (never blocking the caller)
@@ -35,6 +62,7 @@ module ForgeOpsTracker
       attr_reader :configuration, :client
 
       def ensure_worker_started
+        register_drain
         return if @thread&.alive?
 
         @mutex.synchronize do
@@ -47,12 +75,35 @@ module ForgeOpsTracker
 
       def run
         loop do
-          client.public_send(@deliver_with, @queue.pop)
+          payload = @queue.pop
+          @in_flight += 1
+          begin
+            client.public_send(@deliver_with, payload)
+          ensure
+            @in_flight -= 1
+          end
         rescue StandardError => e
           log { "delivery thread error: #{e.class}: #{e.message}" }
         end
       end
 
+      # Registered on the first push, not at load, so a process that never reports anything never
+      # waits on exit at all.
+      def register_drain
+        return if @drain_registered
+
+        @mutex.synchronize do
+          return if @drain_registered
+
+          @drain_registered = true
+          at_exit { drain }
+        end
+      end
+
+      def monotonic_now
+        Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      end
+
       def log
         configuration.logger&.debug { "[ForgeOpsTracker] #{yield}" }
       end

data/lib/forge_ops_tracker/version.rb

@@ -1,3 +1,3 @@
 module ForgeOpsTracker
-  VERSION = "0.15.0"
+  VERSION = "0.15.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forge_ops_tracker
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.15.1
 platform: ruby
 authors:
 - ForgeOps