forest_liana 9.20.0 → 9.20.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c37d0a61be7a37b80bab933cf4892cef1aceb25a5f8351d56c66dbd4d07e6c4d
-  data.tar.gz: d857a4ebb09833f6c99afb44d4daf2e06b396689331c6e28359fe78117e78727
+  metadata.gz: de38bb4323a6676a9185bee03e2ba490c9b9bc2be0fcb41e213849ef9755c9f2
+  data.tar.gz: 54e8bd60a653ecdf126480f2530b15cf52c024d9b69acd3152fd7ffa86f52c0e
 SHA512:
-  metadata.gz: d8e83baf30e64e0c1a0fed567e62c7f1ed8b1763924a813967090616cf703e103b5f53609b0579d811bd286fd107aef17fa50ec14d92dac67ed8cc77cfc51b12
-  data.tar.gz: d2c6655ba0c37f0a917018e32ac3afdc0bbcbc3de9ebb82bce59cf2e4043a53145c7897184322a1c372ea9e51c223cc03c59714d312b728b7466044bd8a575a1
+  metadata.gz: c319db67ae5621fd89a52d86e02022b73c4a2872763ec1cc48ef5a43c0f9b47b0ae3fa4927c1d180b60d0af83dfaa6085e788f8e66b91c3213c804a9e5fc56b6
+  data.tar.gz: 2d59d2fb65f0b2c05e189e11d25d20dcf9980fe9dc23d4c1f14c96050a7ef67bc7e162731b0fe5f6c0a717557ba9b8b12d98d4481197abc21a69b9d2a1c5b900

data/app/controllers/forest_liana/actions_controller.rb

@@ -58,7 +58,7 @@ module ForestLiana
       begin
         # action.hooks[:change] is a hashmap here
         # to do the validation, only the hook names are require
-        change_hooks_name = action.hooks[:change].nil? ? nil : action.hooks[:change].keys
+        change_hooks_name = action.hooks && action.hooks[:change] ? action.hooks[:change].keys : nil
         ForestLiana::SmartActionFieldValidator.validate_smart_action_fields(result[:fields], action.name, change_hooks_name)
       rescue ForestLiana::Errors::SmartActionInvalidFieldError => invalid_field_error
         FOREST_LOGGER.warn invalid_field_error.message
@@ -107,10 +107,15 @@ module ForestLiana
         # Get the smart action hook load context
         context = get_smart_action_load_ctx(action.fields)
 
-        # Call the user-defined load hook.
-        result = action.hooks[:load].(context)
+        if action.hooks && action.hooks[:load].present?
+          # Call the user-defined load hook.
+          result = action.hooks[:load].(context)
 
-        handle_result(result, action)
+          handle_result(result, action)
+        else
+          # No load hook declared: answer the static form (Node agent parity) instead of a 404.
+          handle_result(context[:fields], action)
+        end
       end
     end
 

data/app/services/forest_liana/schema_adapter.rb

@@ -266,6 +266,9 @@ module ForestLiana
             }
 
             collection.fields = collection.fields.reject do |field|
+              # NOTICE: A primary key column must survive; a type column is never one.
+              next false if field[:is_primary_key]
+
               field[:field] == association.foreign_key || field[:field] == association.foreign_type
             end
           # NOTICE: Delete the association if the targeted model is excluded.
@@ -274,7 +277,8 @@ module ForestLiana
               x[:field] == association.foreign_key
             end
 
-            collection.fields.delete(field) if field
+            # NOTICE: A primary key column must survive, even as an excluded association's FK.
+            collection.fields.delete(field) if field && !field[:is_primary_key]
           # NOTICE: The foreign key exists, so it's a belongsTo relationship.
           elsif (field = column_association(collection, association)) &&
             [:has_one, :belongs_to].include?(association.macro)

data/config/routes/actions.rb

@@ -1,9 +1,8 @@
 ForestLiana.apimap.each do |collection|
   if !collection.actions.empty?
     collection.actions.each do |action|
-      if action.hooks && action.hooks[:load].present?
-        post action.endpoint.sub('forest', '') + '/hooks/load' => 'actions#load', action_name: ActiveSupport::Inflector.parameterize(action.name)
-      end
+      # Unconditional: clients probe /hooks/load even when no load hook is declared.
+      post action.endpoint.sub('forest', '') + '/hooks/load' => 'actions#load', action_name: ActiveSupport::Inflector.parameterize(action.name)
       if action.hooks && action.hooks[:change].present?
         post action.endpoint.sub('forest', '') + '/hooks/change' => 'actions#change', action_name: ActiveSupport::Inflector.parameterize(action.name)
       end

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "9.20.0"
+  VERSION = "9.20.2"
 end

data/spec/dummy/lib/forest_liana/collections/island.rb

@@ -28,6 +28,19 @@ class Forest::Island
 
   action 'test'
 
+  action 'static_form_action',
+    fields: [{
+      field: 'static_field',
+      type: 'String',
+      default_value: nil,
+      enums: nil,
+      is_required: false,
+      is_read_only: false,
+      reference: nil,
+      description: nil,
+      widget: nil
+    }]
+
   action 'my_action',
     fields: [foo],
     hooks: {

data/spec/requests/actions_controller_spec.rb

@@ -130,6 +130,25 @@ describe 'Requesting Actions routes', :type => :request  do
         expect(response.status).to eq(422)
       end
 
+      it 'should respond 200 with the static form when the action has no load hook' do
+        post '/forest/actions/static_form_action/hooks/load', params: JSON.dump(params), headers: headers
+        action = island.actions.select { |action| action.name == 'static_form_action' }.first
+        static_field = action.fields.select { |field| field[:field] == 'static_field' }.first
+        expect(response.status).to eq(200)
+        expect(JSON.parse(response.body)).to eq({'fields' => [static_field.merge({:value => nil}).transform_keys { |key| key.to_s.camelize(:lower) }.stringify_keys]})
+
+        first_body = response.body
+        post '/forest/actions/static_form_action/hooks/load', params: JSON.dump(params), headers: headers
+        expect(response.status).to eq(200)
+        expect(response.body).to eq(first_body)
+      end
+
+      it 'should respond 200 with empty fields when the action has no form at all' do
+        post '/forest/actions/test/hooks/load', params: JSON.dump(params), headers: headers
+        expect(response.status).to eq(200)
+        expect(JSON.parse(response.body)).to eq({'fields' => []})
+      end
+
       it 'should respond 500 with bad hook result type' do
         post '/forest/actions/fail_action/hooks/load', params: JSON.dump(params), headers: headers
         expect(response.status).to eq(500)

data/spec/requests/workflow_executions_spec.rb

@@ -1,4 +1,7 @@
 require 'rails_helper'
+require 'zlib'
+require 'stringio'
+require 'socket'
 
 describe 'Workflow executor proxy', type: :request do
   let(:run_id) { 'run_abc123' }
@@ -207,6 +210,53 @@ describe 'Workflow executor proxy', type: :request do
     end
   end
 
+  # Real local server + real HTTParty (no stub) to exercise actual gzip decompression.
+  describe 'when the executor gzip-compresses the response (nginx in front)' do
+    let(:gz_body) do
+      io = StringIO.new
+      writer = Zlib::GzipWriter.new(io)
+      writer.write({ 'id' => run_id, 'state' => 'pending' }.to_json)
+      writer.close
+      io.string
+    end
+
+    around do |example|
+      server = TCPServer.new('127.0.0.1', 0)
+      port = server.addr[1]
+      thread = Thread.new do
+        client = server.accept
+        client.readpartial(4096)
+        client.write(
+          "HTTP/1.1 200 OK\r\nContent-Type: application/json\r\n" \
+          "Content-Encoding: gzip\r\nContent-Length: #{gz_body.bytesize}\r\n" \
+          "Connection: close\r\n\r\n"
+        )
+        client.write(gz_body)
+        client.close
+      rescue IOError, Errno::ECONNRESET, Errno::EPIPE
+        nil
+      end
+
+      original = ForestLiana.workflow_executor_url
+      ForestLiana.workflow_executor_url = "http://127.0.0.1:#{port}"
+      example.run
+    ensure
+      ForestLiana.workflow_executor_url = original
+      thread&.kill
+      server&.close
+    end
+
+    before { allow(HTTParty).to receive(:get).and_call_original }
+
+    it 'decompresses the body and drops the stale content-encoding' do
+      get "/forest/_internal/executor/runs/#{run_id}", headers: auth_headers
+
+      expect(response.status).to eq(200)
+      expect(JSON.parse(response.body)).to eq('id' => run_id, 'state' => 'pending')
+      expect(response.headers['content-encoding']).to be_nil
+    end
+  end
+
   describe 'when ForestLiana.workflow_executor_url is blank' do
     around do |example|
       original = ForestLiana.workflow_executor_url

data/test/services/forest_liana/schema_adapter_test.rb

@@ -86,6 +86,62 @@ module ForestLiana
       ForestLiana.apimap << original if original
     end
 
+    test 'a primary key column that is also the foreign key of an excluded association is kept' do
+      excluded_models = ForestLiana.excluded_models
+      name = ForestLiana.name_for(BelongsToField)
+      original = ForestLiana.apimap.find { |c| c.name.to_s == name }
+      ForestLiana.apimap.delete(original) if original
+      ForestLiana.excluded_models = [ForestLiana.name_for(HasOneField)]
+      BelongsToField.define_singleton_method(:primary_key) { 'has_one_field_id' }
+
+      schema = SchemaAdapter.new(BelongsToField).perform
+      field = schema.fields.find { |f| f[:field] == 'has_one_field_id' }
+
+      refute_nil field, 'the primary key column must not be deleted'
+      assert_equal true, field[:is_primary_key]
+    ensure
+      BelongsToField.singleton_class.send(:remove_method, :primary_key)
+      ForestLiana.excluded_models = excluded_models
+      rebuilt = ForestLiana.apimap.find { |c| c.name.to_s == name }
+      ForestLiana.apimap.delete(rebuilt) if rebuilt
+      ForestLiana.apimap << original if original
+    end
+
+    test 'an ordinary foreign key of an excluded association is still deleted' do
+      excluded_models = ForestLiana.excluded_models
+      name = ForestLiana.name_for(BelongsToField)
+      original = ForestLiana.apimap.find { |c| c.name.to_s == name }
+      ForestLiana.apimap.delete(original) if original
+      ForestLiana.excluded_models = [ForestLiana.name_for(HasOneField)]
+
+      schema = SchemaAdapter.new(BelongsToField).perform
+
+      assert_nil schema.fields.find { |f| f[:field] == 'has_one_field_id' }
+    ensure
+      ForestLiana.excluded_models = excluded_models
+      rebuilt = ForestLiana.apimap.find { |c| c.name.to_s == name }
+      ForestLiana.apimap.delete(rebuilt) if rebuilt
+      ForestLiana.apimap << original if original
+    end
+
+    test 'a primary key column that is also a polymorphic foreign key is kept' do
+      name = ForestLiana.name_for(PolymorphicField)
+      original = ForestLiana.apimap.find { |c| c.name.to_s == name }
+      ForestLiana.apimap.delete(original) if original
+      PolymorphicField.define_singleton_method(:primary_key) { 'has_one_field_id' }
+
+      schema = SchemaAdapter.new(PolymorphicField).perform
+      field = schema.fields.find { |f| f[:field] == 'has_one_field_id' }
+
+      refute_nil field, 'the primary key column must not be rejected'
+      assert_equal true, field[:is_primary_key]
+    ensure
+      PolymorphicField.singleton_class.send(:remove_method, :primary_key)
+      rebuilt = ForestLiana.apimap.find { |c| c.name.to_s == name }
+      ForestLiana.apimap.delete(rebuilt) if rebuilt
+      ForestLiana.apimap << original if original
+    end
+
     test 'belongsTo relationship' do
       schema = SchemaAdapter.new(BelongsToField).perform
       fields = schema.fields.select do |field|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 9.20.0
+  version: 9.20.2
 platform: ruby
 authors:
 - Sandro Munda
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-26 00:00:00.000000000 Z
+date: 2026-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails